openggsn.git branch neels/refactor updated. 0.91-80-gb72c2dc

gitosis at gitosis at
Mon Oct 19 12:10:10 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenGGSN project".

The branch, neels/refactor has been updated
  discards  fec3b14781797eb3d356b04566f473a94fec550f (commit)
  discards  d7768c81ae99a0b7324562739aed0579537adc47 (commit)
  discards  746179370c89589ce9a4e959740a8f551a27d935 (commit)
  discards  5e0586df38fce1bb6edb734c1e4d1f4d9242a1f6 (commit)
  discards  b8aae6dd3e0a0039953eb9c37f9bc720feca82e1 (commit)
  discards  7d62a4eaa315d689e3c1268f75c42d552f68ac81 (commit)
  discards  c2058e0c648ff0c224da65bd1863da0b5dae542d (commit)
       via  b72c2dc592bdaa2be86ea5b5f00a51599687c32e (commit)
       via  b84545e30e327b429b7910dc4675b9e3e80df704 (commit)
       via  ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd (commit)
       via  85c25ac91c5fe6e87e1c417ea3543149a92d4145 (commit)
       via  9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5 (commit)
       via  878e188be73e49e96b2fe78604e7daa86cedf6ff (commit)
       via  e845cb950544af8f0d00f5a2bed2072d795a2a7e (commit)
       via  b18e811e24464d9b50f21674246806c3b7c25030 (commit)
       via  9b09738891770367f9878a1a4d1b83bc23217383 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (fec3b14781797eb3d356b04566f473a94fec550f)
             N -- N -- N (b72c2dc592bdaa2be86ea5b5f00a51599687c32e)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit b72c2dc592bdaa2be86ea5b5f00a51599687c32e
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:26:39 2015 +0200

    sgsnemu: improve an error message

commit b84545e30e327b429b7910dc4675b9e3e80df704
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:24:51 2015 +0200

    cosmetic: gtpie_gettv0(): flow readability

commit ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:07:40 2015 +0200

    gtpie_gettlv(): fix return value on specific error.
    Make gtpie_gettlv() return an error if gtpie_getie() returned an error.
    Previously, openggsn would fail to complain about certain missing elements.
    Technically, a missing IE could be detectable from the *length value, but the
    code in gtp.c relies on the return value to detect missing elements, which did
    not work prior to this commit. For example:
    if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,
    		 &pdp->eua.v, sizeof(pdp->eua.v))) {
    	GTP_LOGPKG(LOGL_ERROR, peer, pack,
    		    len, "Missing mandatory information field\n");
    	return gtp_create_pdp_resp(gsn, version, pdp,
    If an EUA were missing in this code path, openggsn would fail to issue an error
    message. Since pdp and hence pdp->eua.l is initialized as all-zero, it would
    probably not do much harm besides failing to issue an error.
    I haven't checked all callers though.

commit 85c25ac91c5fe6e87e1c417ea3543149a92d4145
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 12 14:26:49 2015 +0200

    comments: add/replace.
    Sponsored-by: On-Waves ehi

commit 9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Oct 11 23:44:00 2015 +0200

    comments: fix spelling/punctuation.
    Fix spelling/punctuation and one numbering in comments.
    Remove an opening brace from a comment to not mix up cindent in vim.
    Sponsored-by: On-Waves ehi

commit 878e188be73e49e96b2fe78604e7daa86cedf6ff
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:46:09 2015 +0200

    rename gtp_dublicate (static func).
    Fix spelling dublicate -> duplicate in comments and in (apparently only
    statically used) gtp_dublicate().
    Sponsored-by: On-Waves ehi


Summary of changes:
 gtp/gtpie.c       | 20 ++++++++++----------
 sgsnemu/sgsnemu.c |  7 +++----
 2 files changed, 13 insertions(+), 14 deletions(-)

The OpenGGSN project

More information about the osmocom-commitlog mailing list