This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards fcf22de1dbcf265d6a9ce6af555eefe270434f66 (commit)
discards 67c2ddd0b5abca58a190b00cf53cb97c3b170237 (commit)
discards e91785f031c8ca3118b2ccd8538db557c6369e09 (commit)
discards 255964b7fbe15f4f59772a7d7aab23ea25a4b051 (commit)
discards f4da0c2d6639ec50c53534e99d07e837f56d0ffb (commit)
discards c9ddc0b9e79de2d5ef297c3b53fe77411f10c4e3 (commit)
discards 1732f1e3abd2ec0fc230d837f1212320696c605e (commit)
discards d8327dd1cdda4d906de2af84b831ff7f7b4453db (commit)
discards b1596da3ca7e5121ca4798f2165bfe1d46dd6c9c (commit)
discards 1e28ebef266bd361f51f6f1c17436ae223dbd695 (commit)
discards d1502a4c76d1c3992a532447638dea58b147797b (commit)
discards d384e27b2e465e154f2e886e3cec6c2cd80e2642 (commit)
discards 9d4bd22a40165ff7b1b52804a10c41ecdee02fdb (commit)
discards eb7c17e39c87873eca2d0f497116c91952d0b450 (commit)
discards 3e48b2a9cf0172b29019fc3e5dbcd9ec04808985 (commit)
discards a2fecd7257d71840cd9679ee72c706ccbfda4287 (commit)
discards fe5c92d6ecc0869570c3cd8adb063eac123cfc7f (commit)
discards 8aab2b5612bff0b8c60a9e350716cd6f67d626c1 (commit)
discards 7c68023be49f8f986c05a0532d0206c085fbcc7d (commit)
discards a7b4e202bd93f5a42979e981033fb18558cefc5e (commit)
discards 733d3190c04c6bbdc828daadf2ca729db30e7801 (commit)
discards 0be28a65d00931ba6aef8ce0ea84e391c65bbf2a (commit)
discards 6f92fd3e83ee32ae7732547887751a7244f58926 (commit)
discards cd81f9a2abbbf1b45f35512fd6351064d0e9980b (commit)
discards 885127a7e5f1e2cbbfe1474e773300ce774c127c (commit)
via c0a60234bdf933aee14ce147efc2851c8e0ff0b0 (commit)
via 7eb51548af9343982e61312a36ad97ba2255ebe0 (commit)
via 03975d637be22241b4a41933908129e9c9ac80cc (commit)
via 27b982ce1a1f748ead692fc4d239b2e5c8f326f7 (commit)
via 0b7ce8bf1f344ab0d339dda707a2feec6b4bf486 (commit)
via b4289f7e645149143a76406f0004cf6567d2dd50 (commit)
via 65a3946bd76dedc092b605c4dbf92a63983c266c (commit)
via 7508cbc0ee0e935466c75a09a21999638a23330c (commit)
via 4a88fa2ab5c1f5721c4f72ecbf2d6ac36590be0e (commit)
via da979ef8bbacaf1641cbf40e841a05f1e5421cba (commit)
via 173c36b20b3163817d519aa21428448f5b16618d (commit)
via 4defa42cf51330c087f506587f4171c3c75dc53f (commit)
via e36599fecd68ffabd3b5d7e68aa34d48d829f93b (commit)
via dff8c375f07b49e6cdf36352fa0d2c0a69c3faaf (commit)
via fc78950790586b66c6f87b92603039b8703ab6a7 (commit)
via 54bb59814699042da2c294da8eddd012c52598f8 (commit)
via 6357d8e218408bdd2b4df861fae88e8bdeea244e (commit)
via 9e16284e3307f0689ff1b41554da1820f1584355 (commit)
via e82037a0873be819a65550c7948182dd3685f375 (commit)
via 4d7dd42d9714e9c4a6aaf7ac010453f93f80cd71 (commit)
via 91d1bb23fa35d175969382a573c7470e38c86041 (commit)
via fa0fd33199eeba9e69c165aa5ff6f718fefab5a0 (commit)
via 2586ba4045fa84fc0daf6ac444a757adeb033d5c (commit)
via 3643ee36f32ca326881d78fc55a30cd6bfabb261 (commit)
via 1d19d62d810d284a883f42814a5c389652bb2950 (commit)
via 5e95a411946ba3c520f048c07f8fdc3dff26d564 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (fcf22de1dbcf265d6a9ce6af555eefe270434f66)
\
N -- N -- N (c0a60234bdf933aee14ce147efc2851c8e0ff0b0)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=c0a60234bdf933aee14ce147efc2851c8e0ff0b0
commit c0a60234bdf933aee14ce147efc2851c8e0ff0b0
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 00:07:02 2015 +0100
gtphub: add two stubs
http://cgit.osmocom.org/openbsc/commit/?id=7eb51548af9343982e61312a36ad97ba2255ebe0
commit 7eb51548af9343982e61312a36ad97ba2255ebe0
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 23:50:45 2015 +0100
gtphub: vty: add missing SGSN-proxy output.
http://cgit.osmocom.org/openbsc/commit/?id=03975d637be22241b4a41933908129e9c9ac80cc
commit 03975d637be22241b4a41933908129e9c9ac80cc
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 23:49:48 2015 +0100
gtphub: refactor: use side_idx everywhere.
This is a mostly cosmetic change. Instead of separate buffer handling
functions, reduce some code duplication by using a side_idx just like the
plane_idx, with arrays.
http://cgit.osmocom.org/openbsc/commit/?id=27b982ce1a1f748ead692fc4d239b2e5c8f326f7
commit 27b982ce1a1f748ead692fc4d239b2e5c8f326f7
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 19:14:58 2015 +0100
found_libgtp_and_libcares
http://cgit.osmocom.org/openbsc/commit/?id=0b7ce8bf1f344ab0d339dda707a2feec6b4bf486
commit 0b7ce8bf1f344ab0d339dda707a2feec6b4bf486
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 01:22:13 2015 +0100
gtphub: make sure mapped TEIs aren't occupied.
discussion pending.
http://cgit.osmocom.org/openbsc/commit/?id=b4289f7e645149143a76406f0004cf6567d2dd50
commit b4289f7e645149143a76406f0004cf6567d2dd50
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 01:20:53 2015 +0100
gtphub: use a single TEI pool across planes.
There's no need to keep two separate number pools when both can be fed
from the same pool. User and Ctrl plane TEIs can technically overlap without
colliding, but it doesn't hurt if they don't overlap, either.
http://cgit.osmocom.org/openbsc/commit/?id=65a3946bd76dedc092b605c4dbf92a63983c266c
commit 65a3946bd76dedc092b605c4dbf92a63983c266c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 00:05:56 2015 +0100
gtphub: cosmetic: for_each_side,_plane macros.
Simplify looping over sides and planes. I'm tired of typing the same for
loops all the time.
http://cgit.osmocom.org/openbsc/commit/?id=7508cbc0ee0e935466c75a09a21999638a23330c
commit 7508cbc0ee0e935466c75a09a21999638a23330c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Nov 26 22:19:22 2015 +0100
gtphub: implement restart counter properly.
Force passing a restart counter, by adding such arg to gtphub_start() (test
suite is not affected by this).
In gtphub_main.c, add -r,--restart-file <path> and next_restart_count() to
maintain the counter file. While at it, tweak the cmdline help to unify the
formatting (mostly commas and a missing line break).
Send gtphub's own restart counter. So far, the sender's restart counter was
copied through, which would break as soon as more than one GSN would talk to
the same peer with differing restart counters.
Also fix the in-mem restart counter data type (one octet, not two).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=4a88fa2ab5c1f5721c4f72ecbf2d6ac36590be0e
commit 4a88fa2ab5c1f5721c4f72ecbf2d6ac36590be0e
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
http://cgit.osmocom.org/openbsc/commit/?id=da979ef8bbacaf1641cbf40e841a05f1e5421cba
commit da979ef8bbacaf1641cbf40e841a05f1e5421cba
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN, to index tunnel
endpoint structs, and so on.
Track the originating side in the gtp_packet_desc.
Add header_tei_rx: set_tei() overwrites header_tei, but the originally received
header TEI is still needed to match a Create PDP Context Response up with its
Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok, and including the IP addresses.
Add regression test for refreshing tunnel expiry upon use.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=173c36b20b3163817d519aa21428448f5b16618d
commit 173c36b20b3163817d519aa21428448f5b16618d
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 25 16:45:59 2015 +0100
gtphub: cosmetic/prepare: rename expiry queues.
The expiry queues are already used for resolved GGSN addresses, and will
soon enlist tunnel structs. Hence the naming should be more general.
http://cgit.osmocom.org/openbsc/commit/?id=4defa42cf51330c087f506587f4171c3c75dc53f
commit 4defa42cf51330c087f506587f4171c3c75dc53f
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:32:23 2015 +0100
gtphub: add assertion to ensure expiry ordering.
Make 100% sure the user adds expiring_items in chronological order by asserting
that a newly added expiry is >= the last expiry in the queue. Add llist_last()
to facilitate.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e36599fecd68ffabd3b5d7e68aa34d48d829f93b
commit e36599fecd68ffabd3b5d7e68aa34d48d829f93b
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:30:38 2015 +0100
gtphub: cosmetic/prepare: add nr_map_refresh().
http://cgit.osmocom.org/openbsc/commit/?id=dff8c375f07b49e6cdf36352fa0d2c0a69c3faaf
commit dff8c375f07b49e6cdf36352fa0d2c0a69c3faaf
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:27:13 2015 +0100
gtphub: move timestamp into packet struct.
Instead of passing the current time around in function arguments ('now'),
rather store the current time once upon decoding a GTP packet in the
gtp_packet_desc passed around anyway ('p->timestamp').
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=fc78950790586b66c6f87b92603039b8703ab6a7
commit fc78950790586b66c6f87b92603039b8703ab6a7
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:23:44 2015 +0100
gtphub: cosmetic: fix an argument name.
http://cgit.osmocom.org/openbsc/commit/?id=54bb59814699042da2c294da8eddd012c52598f8
commit 54bb59814699042da2c294da8eddd012c52598f8
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 03:16:19 2015 +0100
gtphub: first vty show commands.
Start adding VTY commands to show rate counters / statistics / cache dumps.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=6357d8e218408bdd2b4df861fae88e8bdeea244e
commit 6357d8e218408bdd2b4df861fae88e8bdeea244e
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 01:28:40 2015 +0100
gtphub: add first rate counters
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=9e16284e3307f0689ff1b41554da1820f1584355
commit 9e16284e3307f0689ff1b41554da1820f1584355
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 01:27:22 2015 +0100
gtphub: cosmetic: clarify bind pointer naming.
Some gtphub_bind pointers point to an array of binds, some point directly at
instances. Make the distinction between the two more obvious by adding an
'_arr' suffix to the array ones.
Partly in preparation for upcoming rate counters.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e82037a0873be819a65550c7948182dd3685f375
commit e82037a0873be819a65550c7948182dd3685f375
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 00:08:28 2015 +0100
gtphub: add explicit cleanup handles.
Clean up functionality is added for the test suite only, to be able to clean
out all allocations and test against memory leaks.
So far, it was sufficient to expire everything to free a gtphub. In preparation
for the upcoming rate counters, which will need to be freed explicitly, add
gtphub functions to clean up everything.
As added bonus, also close the sockets explicitly -- not really needed upon
program exit, neither by the test suite, but *if* we have a cleanup function,
it should clean up everything properly.
Closing the sockets is however kept separate, for the test suite.
gtphub_start() and gtphub_stop() are for normal use (published in gtphub.h),
and gtphub_init() and gtphub_free() are for the test suite, without sockets.
(gtphub_stop() will probably never be called by anyone, but its existence
completes the picture.)
In gtphub_test.c, have a function to clean up the testing gtphub struct. First,
expire everything by timeout, assert emptiness, then call the cleanup function.
Call from each test in the end.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=4d7dd42d9714e9c4a6aaf7ac010453f93f80cd71
commit 4d7dd42d9714e9c4a6aaf7ac010453f93f80cd71
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 00:04:41 2015 +0100
gtphub: ensure cleanup of peer addresses.
Upon calling gtphub_peer_del(), all addresses and ports should already have
expired (by force). Make sure the code heeds that with a so far missing
assertion.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=91d1bb23fa35d175969382a573c7470e38c86041
commit 91d1bb23fa35d175969382a573c7470e38c86041
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 18:11:32 2015 +0100
gtphub: ares vty and init
From sgsn_vty.c, copy the cfg_grx_ggsn_cmd to add an ares server to the static
sgsn_instance.
This is sort of preliminary. As described in comments, the sgsn_ares functions
should actually be separated from the static sgsn structure. gtphub keeps such
an sgsn structure just for the sgsn_ares functions.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=fa0fd33199eeba9e69c165aa5ff6f718fefab5a0
commit fa0fd33199eeba9e69c165aa5ff6f718fefab5a0
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 18:11:09 2015 +0100
gtphub: review some logging.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=2586ba4045fa84fc0daf6ac444a757adeb033d5c
commit 2586ba4045fa84fc0daf6ac444a757adeb033d5c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 17:53:00 2015 +0100
gtphub: cosmetic: rename a file.
gtphub_ext.c's initial purpose was to wrap a specific function. The file
then turned into everything related to DNS, which fits pretty well. Rename
to gtphub_ares.c.
Tweak the header comment to reflect the new file name.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=3643ee36f32ca326881d78fc55a30cd6bfabb261
commit 3643ee36f32ca326881d78fc55a30cd6bfabb261
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 17 14:30:37 2015 +0100
gtphub: nr_map: add min,max and wrap.
Implement min/max bounds for nr_pool, adjust nr_pool_init() and current tests,
and create unit tests for nr_map wrapping.
Sequence numbers range from 0 to 65535, while TEIs range from 1 to 0xffffffff.
Both cause problems when the nr_pool surpasses the range: seq exit their valid
range, causing unmappings to fail, and a TEI would be mapped as zero (invalid).
Add a comment about TEI wrapping, and lose the comment about random TEIs (not
really important).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=1d19d62d810d284a883f42814a5c389652bb2950
commit 1d19d62d810d284a883f42814a5c389652bb2950
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 17 14:24:46 2015 +0100
gtphub: fix number map range for TEIs.
Use unsigned int for nr_map, just large enough to fit the TEI space.
Adjust log output formats and casts accordingly.
Fixes: TEIs are uint32_t, but the nr_map so far used int. This would cause TEIs
from 0x80000000 on to be handled and printed as a negative value.
Sponsored-by: On-Waves ehi
-----------------------------------------------------------------------
Summary of changes:
openbsc/osmoappdesc.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)