osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-439-g1db67e0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Thu May 28 12:12:20 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  c299cee15cabb2a8c2ad7eb54da182f2b73d3f16 (commit)
  discards  aa9c1199e40d19c2f65dfcb6d3239483b2dbc2bf (commit)
  discards  1c96d98d9c392f60e457d3dac310e5826489c50e (commit)
  discards  d4b882dd013c6a2069995a7cb89eecde283d92e1 (commit)
  discards  1c674ff4826c18741acf685c0073236e2f431fb6 (commit)
  discards  0ef422fe0307183b6281aca77074827cb61f2024 (commit)
  discards  24ebf9022f7d76b00771b32c9557a50106329ba3 (commit)
  discards  69381940f40a2d42f75e060e79d63feed54ff609 (commit)
       via  1db67e0a35a479ef20b871c459ea3f3e0155b620 (commit)
       via  9200ce60196a289968144582f1acfac25e17eed5 (commit)
       via  ddfc0d57632c5f57aeb123f6506d3923fcec69dc (commit)
       via  d3eac2867a84d009fa3c1c7d8da9502f8468fbca (commit)
       via  1c68abaffab6b7f8472d54b7881c3618d72e00d9 (commit)
       via  71e55118f52002af433077251a5a7fee2017b40b (commit)
       via  7b9f825ae8f8a39c072413820a1a0557f420499d (commit)
       via  b0e5eaf59adbefc44e01850a6784c9da0c3abbf9 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (c299cee15cabb2a8c2ad7eb54da182f2b73d3f16)
            \
             N -- N -- N (1db67e0a35a479ef20b871c459ea3f3e0155b620)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=1db67e0a35a479ef20b871c459ea3f3e0155b620

commit 1db67e0a35a479ef20b871c459ea3f3e0155b620
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 18:02:51 2015 +0200

    tbf: Remove TimingAdvance storage
    
    Currently the TA storage stores up to 30 TLLI->TA mappings, if more
    entries are created the oldest one is dropped. In theory this can
    lead to missing TA information if many MS are present.
    
    This commit removes the TimingAdvance class completely, since the TA
    value is now stored in the GprsMs objects.
    
    Note that the GprsMs objects are currently not kept after the TBFs
    have detached from them, so the TA values are now kept for a shorter
    time than before.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=9200ce60196a289968144582f1acfac25e17eed5

commit 9200ce60196a289968144582f1acfac25e17eed5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 17:48:04 2015 +0200

    tbf: Store the timing advance (TA) value in the GprsMs object
    
    The TA value rather relates to an MS and not to a single TBF. So all
    TBFs share the same TA value. Currently the TA value is stored per
    TBF and eventually copied from an old TBF to a new one. It is in
    general only passed with an RACH request when the TLLI and thus the
    MS is not yet known.
    
    This commit adds a TA member to the GprsMs class and uses that one
    when the TBF is associated to an MS object. Since the TBF is not
    always associated with an MS object (after RACH or when it has been
    replaced by another TBF), the TA value is still stored in each TBF
    and that value is used as long as no MS object is being associated.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=ddfc0d57632c5f57aeb123f6506d3923fcec69dc

commit ddfc0d57632c5f57aeb123f6506d3923fcec69dc
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed May 27 13:03:15 2015 +0200

    tbf/test: Add tests for single and two phase access
    
    These tests cover the message exchange from receiving from the first
    RACH request to the first data block when establishing an uplink TBF.
    
    This will be used to check, whether TA and other values are passed to
    an MS object correctly.
    
    In addition, the RX RACH log message in rcv_rach is extended to
    contain the single block fn.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=d3eac2867a84d009fa3c1c7d8da9502f8468fbca

commit d3eac2867a84d009fa3c1c7d8da9502f8468fbca
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:47:55 2015 +0200

    tbf: Remove TBF chaining (m_new_tbf and m_old_tbf)
    
    Currently a new TBF is chained to an existing older one, either of
    the other direction (active or releasing) or of the same direction
    (releasing). This does not work properly work if and uplink and a
    downlink TBF are being established at the same time while an old TBF
    is being released. In that case, one of them is thrown away and the
    pending procedure is cancelled.
    
    The chaining is no longer necessary since the GprsMs objects have
    been introduced which keep track of the active TBFs.
    
    This commit removes the TBF members m_new_tbf and m_old_tbf and the
    related methods and code paths.
    
    Note that a new TBF can replace an older TBF entry of the same
    direction within an MS object when it is associated with an MS (e.g.
    by TLLI or because it is assigned via another, already associated
    TBF). In that case, the old TBF is no longer associated with an MS
    object.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=1c68abaffab6b7f8472d54b7881c3618d72e00d9

commit 1c68abaffab6b7f8472d54b7881c3618d72e00d9
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:40:08 2015 +0200

    tbf/test: Attach TLLI and MS objects to TBFs
    
    Currently the DL TBF's TLLI are not set. This will have to change in
    the future, when the m_new_tbf chaining is replaced by the usage of MS
    object to group TBFs.
    
    This commit just calls update_ms() on newly created TBFs. This
    changes many of the lines written to stderr due to the TLLI change,
    but doesn't change other aspects or messages beside creating and
    destroying MS objects.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=71e55118f52002af433077251a5a7fee2017b40b

commit 71e55118f52002af433077251a5a7fee2017b40b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:10:15 2015 +0200

    tbf: Remove IMSI handling from trigger_dl_ass
    
    Currently the BTS::trigger_dl_ass() method assigns the IMSI to the MS
    object. This should be (and is already) done earlier where the MS
    object is retrieved/created.
    
    This commit removes the corresponding code along with the 'imsi'
    parameter from trigger_dl_ass.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=7b9f825ae8f8a39c072413820a1a0557f420499d

commit 7b9f825ae8f8a39c072413820a1a0557f420499d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:53 2015 +0200

    ms: Use the IMSI to retrieve the MS object
    
    This commit extends get_ms() to really compare the IMSI if it has
    been given. Matching by TLLI has a higher precedence than matching by
    IMSI.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=b0e5eaf59adbefc44e01850a6784c9da0c3abbf9

commit b0e5eaf59adbefc44e01850a6784c9da0c3abbf9
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:16 2015 +0200

    tbf: Move IMSI to MS object
    
    Currently the IMSI is stored in the TBFs. Since it directly refers to
    an MS, it should rather be stored in an MS object.
    
    This patch move the m_imsi field from gprs_rlcmac_tbf to GprsMs,
    changes gprs_rlcmac_tbf::imsi() to get the IMSI from the associated
    MS object, and adds getter and setter to GprsMs. Before changing the
    IMSI of the associated MS object, assign_imsi() checks if there is
    already another MS object with the same IMSI and eventually resets
    the IMSI of that one. So using update_ms() and assign_imsi() ensures
    that there are not two MS object entries is the storage with the
    same TLLI or the same IMSI.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 src/gprs_ms.cpp         |  2 +-
 src/gprs_ms_storage.cpp | 33 ++++++++++++++++++------------
 src/tbf.cpp             | 32 +++++++++++++++++++++++++++++
 src/tbf.h               |  1 +
 src/tbf_dl.cpp          |  9 +++++----
 tests/tbf/TbfTest.cpp   | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 tests/tbf/TbfTest.err   | 45 +++++++++++++++++++++++++++++++++++++++++
 tests/tbf/TbfTest.ok    |  2 ++
 8 files changed, 160 insertions(+), 18 deletions(-)


hooks/post-receive
-- 
UNNAMED PROJECT



More information about the osmocom-commitlog mailing list