osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-425-gec1ad5b

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue May 19 13:05:08 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  37ff7a43bbaa202f0907b6dd4787ca2064ee2102 (commit)
  discards  2c1cf0df10a5a261807d0e32e2e85bc6c9a176cd (commit)
  discards  87b77832a57dca618ce90f7dd63458e70a7e1ef2 (commit)
  discards  307acb4b07cfcf19f09b9b01ac00649b35b2460d (commit)
  discards  a0c3917b70a93dcee0c0f2d6da3310a24d7aad43 (commit)
  discards  b40250da4eac953cb02cae2d29416c567a809678 (commit)
  discards  f538d8e606b323586df3f90ab029e7c83c82ce11 (commit)
  discards  fdc8ff769314d142300456c0dc93a93729df5694 (commit)
  discards  dcd16b639e675774a6078a2cfd13578f076fefb7 (commit)
  discards  d52ac303205492ca453c8930b0eb369a296f8088 (commit)
       via  ec1ad5b8474a9a62724f2c6168d2cdc51d21364d (commit)
       via  2e6c43bb2ac719c5a42ca5207f3d3ee831c5ed59 (commit)
       via  072ac71c072f7d67a1a259d54daded95820dbaf4 (commit)
       via  141390fcc3b55a5a0a5b08b5ee60b5ac9a9ec24e (commit)
       via  e934a4510e6b3a12807ebe9d7ef6bc5d2a16123e (commit)
       via  963800da8a4b8bcda919e9c9da516f1633bedc9d (commit)
       via  f2c47b68af934781d8a065a626a0c1333d26a244 (commit)
       via  dd0f95ce829a69eb447c43ca8c7dd17314df3134 (commit)
       via  068e6c898a5500d87ec44d6a7ca0637f20ea830d (commit)
       via  08f0cb07ec6802aaae0dd2cdab0c7194e543af81 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (37ff7a43bbaa202f0907b6dd4787ca2064ee2102)
            \
             N -- N -- N (ec1ad5b8474a9a62724f2c6168d2cdc51d21364d)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=ec1ad5b8474a9a62724f2c6168d2cdc51d21364d

commit ec1ad5b8474a9a62724f2c6168d2cdc51d21364d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon May 18 15:21:36 2015 +0200

    tbf: Just pass the MS object in reuse_tbf
    
    Currently the MS will be searched based on the TLLI in resue_tbf().
    Since the MS object is already known in the TBF when the TLLI is set,
    it can just be passed to the new TBF.
    
    This commit removes the call to update_ms() and just adds
    new_tbf->set_ms(ms()) which will also work as expected if ms() == NULL.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=2e6c43bb2ac719c5a42ca5207f3d3ee831c5ed59

commit 2e6c43bb2ac719c5a42ca5207f3d3ee831c5ed59
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon May 18 14:35:11 2015 +0200

    tbf: Explicitly pass the direction to update_ms()
    
    The type of the TBF update_ms() is being called on does not always
    reflect whether the TLLI has been signaled by the MS or the SGSN.
    
    This commit adds an additional parameter to tell the method, in which
    direction the TLLI has been passed.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=072ac71c072f7d67a1a259d54daded95820dbaf4

commit 072ac71c072f7d67a1a259d54daded95820dbaf4
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon May 18 11:56:50 2015 +0200

    tbf: Get the TLLI from the MS object
    
    Since the synchronisation of the TBF's concerning the TLLIs has been
    removed in 'Support new and old TLLI's', gprs_rlcmac_tbf::tlli() can
    return the old TLLI which is probably different to ms()->tlli() in
    that case. This can lead to a wrong TLLI being used in BSSGP messages.
    
    This commit modifies the TBF's tlli() method to get the current TLLI
    from the MS object.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=141390fcc3b55a5a0a5b08b5ee60b5ac9a9ec24e

commit 141390fcc3b55a5a0a5b08b5ee60b5ac9a9ec24e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 15 15:50:43 2015 +0200

    ms: Support new and old TLLIs
    
    According to the specification (GSM 04.08/24.008, 4.7.1.5) after a
    new P-TMSI has been assigned, the old P-TMSI must be kept basically
    until it has been used by both sides. Since the TLLI will be derived
    from the P-TMSI, the old TLLI must also be kept until the new TLLI
    has been used by both MS and SGSN.
    
    This commit modifies the TLLI handling of GprsMs accordingly.
    set_tlli() is only used with TLLIs derived from MS messages,
    confirm_tlli() is used with TLLIs derived from messages received from
    the SGSN.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=e934a4510e6b3a12807ebe9d7ef6bc5d2a16123e

commit e934a4510e6b3a12807ebe9d7ef6bc5d2a16123e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed May 13 13:33:12 2015 +0200

    ms: Integrate the MS storage
    
    Use the MS storage to find a MS object for a given TLLI instead of
    searching the TBF lists. The TBFs are then taken from the MS object,
    if one has been found. If all TBF might be temporarily detached from
    the MS object, a GprsMs::Guard is added to prevent the deletion of
    the object, in case another TBF gets attached later on in the scope.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=963800da8a4b8bcda919e9c9da516f1633bedc9d

commit 963800da8a4b8bcda919e9c9da516f1633bedc9d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue May 12 17:54:33 2015 +0200

    ms: Add MS storage class
    
    Currently the MS objects are contained in the TBF objects only. To
    allow for an extended life time after the TBF objects have been freed
    and to find them based on TLLI, a container for the MS objects is
    needed.
    
    This commit adds the container class and also adds the corresponding
    m_list member to GprsMs. Further integration into the PCU code is not
    yet done.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=f2c47b68af934781d8a065a626a0c1333d26a244

commit f2c47b68af934781d8a065a626a0c1333d26a244
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon May 11 14:13:47 2015 +0200

    llist: Add a C++ wrapper for linux_list
    
    This commit adds the LListHead class which is a wrapper around the
    linuxlist. It adds an additional member to refer to the container,
    since the container_of macro doesn't work properly with C++ classes.
    All functions and macros from linuxlist.h are support except for the
    entry macros (e.g. llist_entry, llist_for_each_entry, ...). To access
    the container (entry), an entry() method is provided instead:
    
      llist_for_each(pos, &elems) {
          pos->entry()->do_something();
      }
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=dd0f95ce829a69eb447c43ca8c7dd17314df3134

commit dd0f95ce829a69eb447c43ca8c7dd17314df3134
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon May 11 10:32:40 2015 +0200

    tbf/test: Optionally show talloc report
    
    To show the talloc report more easily, this commit adds a call to
    talloc_report_full if the TALLOC_REPORT_FULL environment variable is
    set (the value is ignored). Since the stderr output is checked by the
    test suite, this feature is not enabled by default.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=068e6c898a5500d87ec44d6a7ca0637f20ea830d

commit 068e6c898a5500d87ec44d6a7ca0637f20ea830d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 8 12:13:08 2015 +0200

    tbf: Add MS object management to TBF code
    
    This commit adds MS object creation and cleanup to the TBF related
    code. MS objects are created when a TBF that has been "anonymous" so
    far gets associated with a TLLI. When a TBF is replaced by another,
    the old TBF is detached and the new one is attached to the MS. When
    all TBFs have been detached, the MS object gets deleted.
    
    The TBF related code should not call attach_tbf/detach_tbf directly
    but use set_ms instead to make sure, that the references are updated
    properly. GprsMs::detach_tbf also calls set_ms(NULL) on the detached
    TBF object.
    
    The MS object is not really used yet, the focus is still on object
    creation, TBF association, and cleanup.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=08f0cb07ec6802aaae0dd2cdab0c7194e543af81

commit 08f0cb07ec6802aaae0dd2cdab0c7194e543af81
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed May 6 18:30:48 2015 +0200

    ms: Add GprsMs class to hold per-MS information
    
    Currently only TBF objects are used to handle the data flow between
    the MS and the SGSN. MS specific data (e.g. pending LLC frames, TLLI)
    is copied between successive TBFs. If all TBFs (uplink and downlink)
    are idle for some time, all information about the MS is discarded in
    the PCU. This makes the implementation of some features more
    difficult, e.g. proper TLLI and timing advance handling,
    connection based CS selection, and proper management of multiple TBF.
    
    This commit adds the GprsMs class that is intended to hold
    information directly related to the MS and to keep references to the
    active TBFs.
    
    The class is not yet integrated with the other PCU code. A GprsMs
    object container and MS specific fields (TA, CS) will be added in
    later commits.
    
    Note that calling detach_tbf() can possibly delete the MS object
    depending on the callback implementation.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 src/Makefile.am                      |  2 +-
 src/{LinuxList.h => cxx_linuxlist.h} | 30 +++++++++++++++++++++++-------
 src/gprs_ms.cpp                      |  2 ++
 src/gprs_ms.h                        |  6 +++---
 src/gprs_ms_storage.h                |  2 +-
 tests/llist/LListTest.cpp            |  2 +-
 tests/ms/MsTest.cpp                  |  1 -
 7 files changed, 31 insertions(+), 14 deletions(-)
 rename src/{LinuxList.h => cxx_linuxlist.h} (84%)


hooks/post-receive
-- 
UNNAMED PROJECT



More information about the osmocom-commitlog mailing list