osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-468-g5522d4a

gitosis at osmocom.org gitosis at osmocom.org
Thu Jun 11 11:15:28 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  dd1567812895ed5092d77db653be91c17cd7f5c3 (commit)
  discards  547b8d09c439d4e73156ed414392cf8205cf2307 (commit)
  discards  8ea626b89a82266d4cd5299a71f82638da11fc1c (commit)
       via  5522d4a5ef71157c7429d687cbc96a3f29f74ea0 (commit)
       via  4507a1f2aad235aff7cb56925a498d0175710f7d (commit)
       via  058c0274f87a0cc0ade2e4b22ad3e2820031cff6 (commit)
       via  0808f6860111ef54e80a2865029760e063c29755 (commit)
       via  25db7c6116d11a91697e439fcbc21eb824beace4 (commit)
       via  7bf9f49728a306976b1974a52a9039807b0a2979 (commit)
       via  0ae431380015a5c6a944a9edd1620e56b0b65445 (commit)
       via  d0aee85b29a17e6ef3fb1454a798e10ced0d0266 (commit)
       via  09fdf6622a3774849bc90b9c4fedf76fdc76ac03 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (dd1567812895ed5092d77db653be91c17cd7f5c3)
             N -- N -- N (5522d4a5ef71157c7429d687cbc96a3f29f74ea0)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 5522d4a5ef71157c7429d687cbc96a3f29f74ea0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 9 09:44:36 2015 +0200

    ms: Add UL CS selection based on L1 link quality
    Currently the UL CS values are set to the corresponding DL CS value,
    eventually limited by a maximum value. This approach does not reflect
    the general situation of the RF link between ME and BTS, which is
    rather asymmetric e.g. due to a lower degree of TX efficiency of the
    built-in antenna. This means, that UL and DL CS control should be
    decoupled for better results.
    This commit adds automatic UL CS selection based on the link quality
    measurement parameter. Each coding scheme is mapped to a link quality
    range. If the link quality value leaves that range, the current UL CS
    value is increased/decreased accordingly. This value will be copied
    sent to the MS.
    The following VTY command will be added to the config-pcu node:
    -  cs link-quality-ranges cs1 <0-20> cs2 <0-20> <0-20>
              cs3 <0-20> <0-20> cs4 <0-20>
    which sets the ranges for the four coding schemes. For instance the
    example below reflects the current default values:
      cs link-quality-ranges cs1 5 cs2 4 8 cs3 7 12 cs4 10
    set the following ranges, where the overlapping is used to configure
    a hysteresis:
      CS1: -inf ..  5
      CS2:    4 ..  8
      CS3:    7 .. 12
      CS4:   10 .. inf
    Sponsored-by: On-Waves ehf


commit 4507a1f2aad235aff7cb56925a498d0175710f7d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jun 8 11:26:38 2015 +0200

    ms: Store the L1 measurement values in the MS objects
    This commits adds the GprsMs::update_l1_meas() and GprsMs::l1_meas()
    methods to store and access the measurement values. The internal
    state is updated depending on which values are actually set.
    In addition, these values are shown in the output of the 'show ms
    imsi|tlli' command.
    Sponsored-by: On-Waves ehf


commit 058c0274f87a0cc0ade2e4b22ad3e2820031cff6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jun 8 11:05:45 2015 +0200

    l1: Pass all L1 measurements upwards (TODO)
    Currently only the RSSI value is passed to the upper layers. Other
    values like TA and BER which are needed for TA update respectively CS
    selection are not propagated.
    This commit introduces and passes a struct that contains a set of
    measurement values.
     - the struct is currently defined in pcu_l1_if.h. Consider to put
       it into a separate file.
    Sponsored-by: On-Waves ehf


commit 0808f6860111ef54e80a2865029760e063c29755
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 13:02:29 2015 +0200

    ms: Fix timer start condition (Coverity)
    Currently the timer can be started even if m_ul_tbf is attached.
    Replace m_dl_tbf by m_ul_tbf to only start the timer if _both_ TBF
    are detached.
    Fixes: Coverity CID 1304683
    Sponsored-by: On-Waves ehf


commit 25db7c6116d11a91697e439fcbc21eb824beace4
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 12:59:01 2015 +0200

    ms: Add missing initialiser for m_delay (Coverity)
    Set m_delay to 0 in the constructor to disable the timer feature by
    Fixes: Coverity CID 1304682
    Sponsored-by: On-Waves ehf


commit 7bf9f49728a306976b1974a52a9039807b0a2979
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 12:45:47 2015 +0200

    tbf: Check for NULL in name() (Coverity)
    The gprs_rlcmac_tbf::name() method is generally used to generate log
    messages. To avoid the need for an explicit NULL check for the tbf
    and to get a consistent text if it is NULL, this commit adds a
    NULL check to the method itself so that it can be called with this ==
    Fixes: Coverity CID 1304680, 1304681
    Sponsored-by: On-Waves ehf


commit 0ae431380015a5c6a944a9edd1620e56b0b65445
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 12:03:18 2015 +0200

    bssgp: Calculate the avg_delay_ms in 32bit only (Coverity)
    Currently the delay_sum is stored in 64 to avoid overflow errors.
    But only the result of tv_sec * 1000 is casted to 64 bit, resulting
    in an overflow if the accumulated queue delay reached 25 days (which
    will not happen in practice, unless there are >200k LLC messages with
    a max of 10s delay each in the queue). If that were the case, the
    only impact would be a wrong number in a log message and in the BSSGP
    FLOW CONTROL message.
    This commit changes the calculations so that they are done in 32 bit
    only, rather than to do the calculation in 64 bit properly.
    Fixes: Coverity CID 1298705
    Sponsored-by: On-Waves ehf


commit d0aee85b29a17e6ef3fb1454a798e10ced0d0266
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 11:47:06 2015 +0200

    llc: Fix LLC UI frame detection (Coverity)
    Currently the wrong nibble is masked out, so the conditional
    expression always yields true.
    Therefore gprs_llc::is_user_data_frame() always returns true. As a
    consequence, the low watermark feature of
    gprs_rlcmac_dl_tbf::llc_dequeue() is not being used in fact.
    This commit fixes the mask value.
    Fixes: Coverity CID 1292834, 1292835
    Sponsored-by: On-Waves ehf


commit 09fdf6622a3774849bc90b9c4fedf76fdc76ac03
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 11 11:35:58 2015 +0200

    bssgp: Handle btcx == NULL in gprs_bssgp_pcu_rx_sign (Coverity)
    Currently it is assumed, that btcx is non-NULL. The btcx is only used
    to obtain the BVCI in some log messages.
    This commit changes that by using -1 as shown BVCI value.
    Fixes: Coverity CID 1040961
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/gprs_bssgp_pcu.cpp | 8 +++++---
 src/gprs_ms.cpp        | 5 +++--
 src/llc.cpp            | 4 ++--
 src/tbf.cpp            | 3 +++
 4 files changed, 13 insertions(+), 7 deletions(-)


More information about the osmocom-commitlog mailing list