osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-459-g37e896d

gitosis at osmocom.org gitosis at osmocom.org
Mon Jun 8 07:42:00 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  d3350c8cd2aa6a32a65fd0ea1691db16e662592e (commit)
  discards  5bf5b0da30700bb881295794ad6ea1edf0d854d3 (commit)
  discards  a92f9825845313cee04ee805a6abf1bd30a4ae47 (commit)
  discards  693d4f787d70dba6b2ce4becdfd219c2cacd6a06 (commit)
  discards  504d1e34c061e236a377fb4040d70bf6a00d1416 (commit)
  discards  c93d457de7ca952b46b97dcad686a3880a5c2be0 (commit)
  discards  53efddb64fdc2c2526313bea005d8ca6cab73a4d (commit)
  discards  87e9169fc5c576e4815a18d57831a0773cfc22dc (commit)
  discards  092f3c60b5e5cadbc044ede4617d074208649c3d (commit)
  discards  3b343d0cb1734ba42befc6b44d590be1ee86cb96 (commit)
  discards  b6ab897d0e1e7c43b1a15118d7508b03e7f4d18c (commit)
  discards  a29c640f28d9f1a065671b91d1ab1ff320b73e71 (commit)
  discards  0a21c4016109d81dd45797a576d7c035660273e6 (commit)
  discards  eb69865cbb9a6190a1adc0cc586e93b2fa26437c (commit)
  discards  bb4e151c3c2e6e3a859c004b32890637ea95a3d1 (commit)
  discards  cd5f42e588805e6bc5b5cf6d4c64cb426656c562 (commit)
       via  37e896dff112fda77c29de770a0d8b3fe8800a5a (commit)
       via  b33e675e5a9f80be81ffef87ba3a9ed05d6945c5 (commit)
       via  8158ea7288f57d7bc66d8ccd1c278999fd656076 (commit)
       via  144a1d0516187d09f80c8b9125c6e51b4988503f (commit)
       via  8322d08071d740b033941271d584a52d25565a94 (commit)
       via  a17fccbcf47bff8f0cca7f3f02d55d63cf5b4d01 (commit)
       via  1751c62c980f8d6ed965e08fcb9ad1af485d8854 (commit)
       via  f47f68a9d8e4421398e2369e4b18de8c52a9d396 (commit)
       via  62e96a3535714088a5dabe3cb4a8523165b19877 (commit)
       via  a700dd9e11d31805cfe8dd07fc27ac96425cbf0c (commit)
       via  17214bb06de4a1d8b626dab0f695017b0c74b358 (commit)
       via  befc760f8677d794e5a0dbc1f02f8ac85b649aa0 (commit)
       via  489a2b35d87610fb077a51de696555a54e5fb247 (commit)
       via  10ed79553a8e7241b69c4155325c29105c7a606d (commit)
       via  1d0a52a3497ada98bb4013ba907a00b4ab9a1ccd (commit)
       via  6dbe822062d54a6c765c6fa7e2c6b79a5dff29b1 (commit)
       via  b3f713bd7be2af9bf7c3168099d35df089020164 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (d3350c8cd2aa6a32a65fd0ea1691db16e662592e)
             N -- N -- N (37e896dff112fda77c29de770a0d8b3fe8800a5a)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 37e896dff112fda77c29de770a0d8b3fe8800a5a
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 5 16:33:33 2015 +0200

    vty: Add command to show detailed MS info
    This commit extends the "show ms" command to display an extended set
    of information for a single MS.
    The following VTY commands are added:
    - show ms tlli TLLI
    - show ms imsi IMSI
    Sponsored-by: On-Waves ehf


commit b33e675e5a9f80be81ffef87ba3a9ed05d6945c5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 19:04:30 2015 +0200

    ms: Add support for maximum CS values
    Currently the CS values can be increased to CS4 even when the "cs"
    configuration command has been used with a lower value. The "cs"
    command just sets the initial coding scheme, so other means are
    needed to limit the selection. One approach is to use the CS flags
    passed in SI, but these are currently ignored.
    To make it possible to limit the CS selection by configuring the PCU,
    this commit adds the following VTY commands to config-pcu:
    - cs max <1-4>             Limit DL and UL CS to the given value
    - cs max <1-4> <1-4>       Limit DL and UL CS separately (DL first)
    - no cs max                Don't limit
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 8158ea7288f57d7bc66d8ccd1c278999fd656076
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 17:46:33 2015 +0200

    ms: Add blocking period for CS upgrade
    Currently the CS level is immediately increased if the error rate
    drops below the lower threshold. Since the measurement values are not
    damped, this behaviour leads to a quick return to higher CS values
    even under bad radio conditions. Since with GPRS RLC/MAC blocks
    cannot be resent with another coding scheme, increasing the CS value
    should be done carefully.
    This commit adds a blocking period that only allows higher CS values
    if all error rate measurements were below the LOW threshold for a
    certain amount of time (currently fixed to 1s).
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 144a1d0516187d09f80c8b9125c6e51b4988503f
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 16:51:44 2015 +0200

    tbf: Ignore lost+recv == 1
    Currently the CS level gets changed quickly if single RLC/MAC blocks
    are sent (e.g. LLC dummy commands), since the rate is either 0% or
    This commit ignores measurements which are based on a single block
    Sponsored-by: On-Waves ehf


commit 8322d08071d740b033941271d584a52d25565a94
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 15:12:10 2015 +0200

    tbf: Add adaptive coding scheme configuration
    This commit adds the following VTY commands to config-pcu:
    - cs threshold <0-100> <0-100>    Enables adaptive CS selection
    - no cs threshold                 Disables it
    The "cs threshold LOW HIGH" command sets the water marks
    (cs_adj_lower_limit and cs_adj_upper_limit) used to
    decide about switching coding schemes.
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit a17fccbcf47bff8f0cca7f3f02d55d63cf5b4d01
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 16:52:23 2015 +0200

    tbf: Add debugging output to analyse_errors()
    To help with the debugging, optimisation, and understanding of this
    method, this commit adds an info string containing a flag character per
    RLC/MAC data block in the current window.
    Note that the blocks are shown in reversed order (highest BSN first)
    in comparison to other logging output.
    Sponsored-by: On-Waves ehf


commit 1751c62c980f8d6ed965e08fcb9ad1af485d8854
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 12:12:32 2015 +0200

    tbf: Add adaptive DL CS adjustment
    To cope with transmission failures due to bad radio conditions, a
    different coding scheme with more redundance can be used.
    This commit adds an implemenation that is based on the Ack/Nack
    ratio per PACKET DOWNLINK ACK/NACK message received from the MS.
    Basically the CS level is decreased, if the block error rate goes
    above cs_adj_upper_limit (default 33%), and it is increased, if the
    rate drops below cs_adj_lower_limit (default 10%). Only blocks that
    have been encoded with the current CS are taken into account.
    Note that this approach doesn't measure the MS->BTS conditions and
    that the measurement values reported by the MS are not taken into
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit f47f68a9d8e4421398e2369e4b18de8c52a9d396
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 10:23:24 2015 +0200

    vty: Add 'show ms all' command
    This command lists the entries of the ms_store by a line per MS.
    Beside TLLI and IMSI, some measurement and state information is
    A ms_list() getter method is added to GprsMsStorage to obtain a list
    of the MsGprs objects.
    The following VTY command is added to the 'enable' node:
     - show ms all
    Sponsored-by: On-Waves ehf


commit 62e96a3535714088a5dabe3cb4a8523165b19877
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 09:42:14 2015 +0200

    vty: Add a file for C++ functions
    Currently the pcu_vty.c doesn't compile with C++. Thus C++ object
    cannot be access directly there.
    This commit adds a helper C++ file that exports all functions with C
    calling conventions and naming to work around that limitation until
    the transition of pcu_vty.c is completed.
    Sponsored-by: On-Waves ehf


commit a700dd9e11d31805cfe8dd07fc27ac96425cbf0c
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 16:00:41 2015 +0200

    tbf: Move the current CS field to GprsMs
    Currently the current CS value is stored in the cs field of
    gprs_rlcmac_tbf and initialised when it is used the first time.
    This commit adds separate fields for UL and DL CS values to the
    GprsMs class and provides corresponding getter methods for GprsMs and
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit 17214bb06de4a1d8b626dab0f695017b0c74b358
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 14:06:12 2015 +0200

    ms: Add back pointer to BTS
    Since more functionality will be moved to the GprsMs class, a pointer
    to the current BTS object is added to allow access to configuration
    data and other methods.
    Sponsored-by: On-Waves ehf


commit befc760f8677d794e5a0dbc1f02f8ac85b649aa0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 12:33:30 2015 +0200

    tbf: Store MS class in GprsMs objects
    The ms_class value is a property of the MS and thus belongs to the
    GprsMs class. Nevertheless the MS object is created after the TLLI
    gets known, so the value still has to be stored in the TBF initially.
    This commit add the ms_class value to the GprsMs class and introduces
    TBF accessor functions which either access that object or, if that is
    not available, the value stored locally.
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 489a2b35d87610fb077a51de696555a54e5fb247
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 28 19:07:01 2015 +0200

    tbf: Move the LLC queue to GprsMs
    Currently the enqueued DL LLC messages which have not yet passed to
    RLC/MAC encoding are eventually copied from one TBF to the next one
    (see gprs_rlcmac_dl_tbf::reuse_tbf). Since the enqueued LLC messages
    are related to a specific MS, they should be stored at that layer.
    This commit moves the gprs_llc_queue object to GprsMs and changes the
    TBF's accessor methods accordingly. The LLC copying code is removed
    from gprs_rlcmac_dl_tbf::reuse_tbf().
    Sponsored-by: On-Waves ehf


commit 10ed79553a8e7241b69c4155325c29105c7a606d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 11:37:22 2015 +0200

    tbf: Make the ms() getter method const
    Currently this method cannot be used in other const methods.
    This commit adds the missing const keyword.
    Sponsored-by: On-Waves ehf


commit 1d0a52a3497ada98bb4013ba907a00b4ab9a1ccd
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 11:28:07 2015 +0200

    llc: Add missing declarations to llc.h
    Currently llc.h relies on the structs BTS, timeval, and msgb being
    declared before the file is included.
    This commit adds forward declaration for these structs, because they
    will only be used for pointer types.
    Sponsored-by: On-Waves ehf


commit 6dbe822062d54a6c765c6fa7e2c6b79a5dff29b1
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 29 10:37:09 2015 +0200

    llc: Separate LLC queue handling from gprs_llc
    Currently the gprs_llc class handles both LLC queueing and the
    partition into smaller pieces for RLC/MAC encapsulation. This hinders
    the separation of TBF and MS related data, since LLC queueing belongs
    to the MS related code while the RLC/MAC encoding/decoding belongs to
    the TBF layer.
    This commits takes the LLC queueing related methods and members and
    puts them into a new class gprs_llc_queue. It puts the queueing
    object into gprs_rlcmac_tbf and adds accessor functions. The
    implementation in tbf.cpp and tbf_dl.cpp is adapted accordingly.
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit b3f713bd7be2af9bf7c3168099d35df089020164
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jun 8 09:30:31 2015 +0200

    l1: Fix warning by logging acc_delay
    The acc_delay value is computed but not used, resulting in a warning.
    This commit adds a logging message it case the function is executed
    to make the warning disappear. It also adds a CPP warning to remind
    of the incomplete implementation.
      sysmo_l1_if.c:226:10: error: variable ‘acc_delay’ set but not used
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/sysmo_l1_if.c | 6 ++++++
 src/tbf_dl.cpp    | 1 -
 2 files changed, 6 insertions(+), 1 deletion(-)


More information about the osmocom-commitlog mailing list