osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-458-gd3350c8

gitosis at osmocom.org gitosis at osmocom.org
Fri Jun 5 15:17:11 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  6f9d51e2782ce349aac10278620fa8f47c091ac8 (commit)
  discards  2db9809ce5a0f4aa096eb79dbb986c193a034736 (commit)
  discards  656b510286fc71f5cac8e38738f8d10272644ea9 (commit)
  discards  988b991ce30b5d8cfd3274e6eb09e1c1db092343 (commit)
  discards  74c47e3f4817f84f6cf511a8e83253d3179a0ac7 (commit)
  discards  2676163e8140181b17152429ce28b029061d63e7 (commit)
  discards  0324579575fcd15189fc5681f4aa94e3962119a5 (commit)
  discards  77cd8ef12907c3ad8f3e244d609feb4824eb0a37 (commit)
  discards  ff181e90e9e26fa53ba5fff74848701f91ac0236 (commit)
  discards  8c15e1561e456930ece94b2844adc06311e14f9f (commit)
  discards  98fc1c481feebe4b2fae8d70c87e130f5cccc4d8 (commit)
  discards  1a217dcf8848954a401c7119fe9da5764f03b7aa (commit)
  discards  5b66f22cd47e8a20ac2137cb9d37f0f93a564b90 (commit)
  discards  b3ddb7e71000fe071c30c567352389f61f5fe838 (commit)
  discards  79741cb0f8c6fc9d56cfbfc3b204c1a2cbb3a316 (commit)
  discards  4fd4ccbb315621b2ceceb2ca3ee5a07fc88937de (commit)
  discards  9bb8963feffa73deb17c1efff0b824eb000fba2c (commit)
  discards  17ee6bb1a0a164fc82dbf36dc5c46e75246d5435 (commit)
  discards  dce39aa8a7139890f9fa74bce9795d78f3d09572 (commit)
       via  d3350c8cd2aa6a32a65fd0ea1691db16e662592e (commit)
       via  5bf5b0da30700bb881295794ad6ea1edf0d854d3 (commit)
       via  a92f9825845313cee04ee805a6abf1bd30a4ae47 (commit)
       via  693d4f787d70dba6b2ce4becdfd219c2cacd6a06 (commit)
       via  504d1e34c061e236a377fb4040d70bf6a00d1416 (commit)
       via  c93d457de7ca952b46b97dcad686a3880a5c2be0 (commit)
       via  53efddb64fdc2c2526313bea005d8ca6cab73a4d (commit)
       via  87e9169fc5c576e4815a18d57831a0773cfc22dc (commit)
       via  092f3c60b5e5cadbc044ede4617d074208649c3d (commit)
       via  3b343d0cb1734ba42befc6b44d590be1ee86cb96 (commit)
       via  b6ab897d0e1e7c43b1a15118d7508b03e7f4d18c (commit)
       via  a29c640f28d9f1a065671b91d1ab1ff320b73e71 (commit)
       via  0a21c4016109d81dd45797a576d7c035660273e6 (commit)
       via  eb69865cbb9a6190a1adc0cc586e93b2fa26437c (commit)
       via  bb4e151c3c2e6e3a859c004b32890637ea95a3d1 (commit)
       via  cd5f42e588805e6bc5b5cf6d4c64cb426656c562 (commit)
       via  3c91cb881d6a5126673e88d8421a207efec6a42d (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (6f9d51e2782ce349aac10278620fa8f47c091ac8)
             N -- N -- N (d3350c8cd2aa6a32a65fd0ea1691db16e662592e)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit d3350c8cd2aa6a32a65fd0ea1691db16e662592e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 5 16:33:33 2015 +0200

    vty: Add command to show detailed MS info
    This commit extends the "show ms" command to display an extended set
    of information for a single MS.
    The following VTY commands are added:
    - show ms tlli TLLI
    - show ms imsi IMSI
    Sponsored-by: On-Waves ehf


commit 5bf5b0da30700bb881295794ad6ea1edf0d854d3
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 19:04:30 2015 +0200

    ms: Add support for maximum CS values
    Currently the CS values can be increased to CS4 even when the "cs"
    configuration command has been used with a lower value. The "cs"
    command just sets the initial coding scheme, so other means are
    needed to limit the selection. One approach is to use the CS flags
    passed in SI, but these are currently ignored.
    To make it possible to limit the CS selection by configuring the PCU,
    this commit adds the following VTY commands to config-pcu:
    - cs max <1-4>             Limit DL and UL CS to the given value
    - cs max <1-4> <1-4>       Limit DL and UL CS separately (DL first)
    - no cs max                Don't limit
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit a92f9825845313cee04ee805a6abf1bd30a4ae47
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 17:46:33 2015 +0200

    ms: Add blocking period for CS upgrade
    Currently the CS level is immediately increased if the error rate
    drops below the lower threshold. Since the measurement values are not
    damped, this behaviour leads to a quick return to higher CS values
    even under bad radio conditions. Since with GPRS RLC/MAC blocks
    cannot be resent with another coding scheme, increasing the CS value
    should be done carefully.
    This commit adds a blocking period that only allows higher CS values
    if all error rate measurements were below the LOW threshold for a
    certain amount of time (currently fixed to 1s).
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 693d4f787d70dba6b2ce4becdfd219c2cacd6a06
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 16:51:44 2015 +0200

    tbf: Ignore lost+recv == 1
    Currently the CS level gets changed quickly if single RLC/MAC blocks
    are sent (e.g. LLC dummy commands), since the rate is either 0% or
    This commit ignores measurements which are based on a single block
    Sponsored-by: On-Waves ehf


commit 504d1e34c061e236a377fb4040d70bf6a00d1416
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 15:12:10 2015 +0200

    tbf: Add adaptive coding scheme configuration
    This commit adds the following VTY commands to config-pcu:
    - cs threshold <0-100> <0-100>    Enables adaptive CS selection
    - no cs threshold                 Disables it
    The "cs threshold LOW HIGH" command sets the water marks
    (cs_adj_lower_limit and cs_adj_upper_limit) used to
    decide about switching coding schemes.
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit c93d457de7ca952b46b97dcad686a3880a5c2be0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 16:52:23 2015 +0200

    tbf: Add debugging output to analyse_errors()
    To help with the debugging, optimisation, and understanding of this
    method, this commit adds an info string containing a flag character per
    RLC/MAC data block in the current window.
    Note that the blocks are shown in reversed order (highest BSN first)
    in comparison to other logging output.
    Sponsored-by: On-Waves ehf


commit 53efddb64fdc2c2526313bea005d8ca6cab73a4d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 12:12:32 2015 +0200

    tbf: Add adaptive DL CS adjustment
    To cope with transmission failures due to bad radio conditions, a
    different coding scheme with more redundance can be used.
    This commit adds an implemenation that is based on the Ack/Nack
    ratio per PACKET DOWNLINK ACK/NACK message received from the MS.
    Basically the CS level is decreased, if the block error rate goes
    above cs_adj_upper_limit (default 33%), and it is increased, if the
    rate drops below cs_adj_lower_limit (default 10%). Only blocks that
    have been encoded with the current CS are taken into account.
    Note that this approach doesn't measure the MS->BTS conditions and
    that the measurement values reported by the MS are not taken into
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit 87e9169fc5c576e4815a18d57831a0773cfc22dc
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 10:23:24 2015 +0200

    vty: Add 'show ms all' command
    This command lists the entries of the ms_store by a line per MS.
    Beside TLLI and IMSI, some measurement and state information is
    A ms_list() getter method is added to GprsMsStorage to obtain a list
    of the MsGprs objects.
    The following VTY command is added to the 'enable' node:
     - show ms all
    Sponsored-by: On-Waves ehf


commit 092f3c60b5e5cadbc044ede4617d074208649c3d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 09:42:14 2015 +0200

    vty: Add a file for C++ functions
    Currently the pcu_vty.c doesn't compile with C++. Thus C++ object
    cannot be access directly there.
    This commit adds a helper C++ file that exports all functions with C
    calling conventions and naming to work around that limitation until
    the transition of pcu_vty.c is completed.
    Sponsored-by: On-Waves ehf


commit 3b343d0cb1734ba42befc6b44d590be1ee86cb96
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 16:00:41 2015 +0200

    tbf: Move the current CS field to GprsMs
    Currently the current CS value is stored in the cs field of
    gprs_rlcmac_tbf and initialised when it is used the first time.
    This commit adds separate fields for UL and DL CS values to the
    GprsMs class and provides corresponding getter methods for GprsMs and
    Ticket: #1739
    Sponsored-by: On-Waves ehf


commit b6ab897d0e1e7c43b1a15118d7508b03e7f4d18c
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 14:06:12 2015 +0200

    ms: Add back pointer to BTS
    Since more functionality will be moved to the GprsMs class, a pointer
    to the current BTS object is added to allow access to configuration
    data and other methods.
    Sponsored-by: On-Waves ehf


commit a29c640f28d9f1a065671b91d1ab1ff320b73e71
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 12:33:30 2015 +0200

    tbf: Store MS class in GprsMs objects
    The ms_class value is a property of the MS and thus belongs to the
    GprsMs class. Nevertheless the MS object is created after the TLLI
    gets known, so the value still has to be stored in the TBF initially.
    This commit add the ms_class value to the GprsMs class and introduces
    TBF accessor functions which either access that object or, if that is
    not available, the value stored locally.
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 0a21c4016109d81dd45797a576d7c035660273e6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 28 19:07:01 2015 +0200

    tbf: Move the LLC queue to GprsMs
    Currently the enqueued DL LLC messages which have not yet passed to
    RLC/MAC encoding are eventually copied from one TBF to the next one
    (see gprs_rlcmac_dl_tbf::reuse_tbf). Since the enqueued LLC messages
    are related to a specific MS, they should be stored at that layer.
    This commit moves the gprs_llc_queue object to GprsMs and changes the
    TBF's accessor methods accordingly. The LLC copying code is removed
    from gprs_rlcmac_dl_tbf::reuse_tbf().
    Sponsored-by: On-Waves ehf


commit eb69865cbb9a6190a1adc0cc586e93b2fa26437c
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 11:37:22 2015 +0200

    tbf: Make the ms() getter method const
    Currently this method cannot be used in other const methods.
    This commit adds the missing const keyword.
    Sponsored-by: On-Waves ehf


commit bb4e151c3c2e6e3a859c004b32890637ea95a3d1
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jun 2 11:28:07 2015 +0200

    llc: Add missing declarations to llc.h
    Currently llc.h relies on the structs BTS, timeval, and msgb being
    declared before the file is included.
    This commit adds forward declaration for these structs, because they
    will only be used for pointer types.
    Sponsored-by: On-Waves ehf


commit cd5f42e588805e6bc5b5cf6d4c64cb426656c562
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 29 10:37:09 2015 +0200

    llc: Separate LLC queue handling from gprs_llc
    Currently the gprs_llc class handles both LLC queueing and the
    partition into smaller pieces for RLC/MAC encapsulation. This hinders
    the separation of TBF and MS related data, since LLC queueing belongs
    to the MS related code while the RLC/MAC encoding/decoding belongs to
    the TBF layer.
    This commits takes the LLC queueing related methods and members and
    puts them into a new class gprs_llc_queue. It puts the queueing
    object into gprs_rlcmac_tbf and adds accessor functions. The
    implementation in tbf.cpp and tbf_dl.cpp is adapted accordingly.
    Ticket: #1674
    Sponsored-by: On-Waves ehf


commit 3c91cb881d6a5126673e88d8421a207efec6a42d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jun 4 10:05:48 2015 +0200

    pcu: Set ms_idle_sec to 60s
    Since the timing advance storage has been removed, the TA values are
    lost, when the last TBF of a single MS is freed. The TA storage has
    at least saved the last 30 TA values. So now in more cases a wrong TA
    value can be transmitted to an MS. Note that this also could have
    happened before the removal of the storage, especially if more than
    30 MS were in use.
    This commit changes the default value of ms_idle_sec to 60s which is
    higher than default value for T3314 (44s, see TS 24.008, 11.2.2),
    after which the SGSN will have to start paging anyway. In that case,
    a RACH request will be triggered, that will trigger an update of the
    TA value in the PCU.
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/gprs_ms.cpp           |  3 +--
 src/pcu_vty.c             | 26 ++++++++++++++++++++++++
 src/pcu_vty_functions.cpp | 51 +++++++++++++++++++++++++++++++++++++++++++++++
 src/pcu_vty_functions.h   |  4 ++++
 src/tbf_dl.cpp            |  6 ++++--
 5 files changed, 86 insertions(+), 4 deletions(-)


More information about the osmocom-commitlog mailing list