openbsc.git branch master updated. 0.13.0-884-gd919343

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue Jan 20 15:15:03 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  d91934357fe28e5362da600e61fd6473f33ff62b (commit)
       via  15cc8c812553e60422ce1917ba8e4230d7eab0b4 (commit)
       via  d6267d12d8bd945f219b3d2f7bf04060fe2d83bd (commit)
       via  2585620857a3a6c17b17a65a3d9a863824b8e401 (commit)
       via  6be9ffa3b811311043194d04ae06e05d216c57bb (commit)
       via  d8a65536ecc6eae026898822b58f520f5ee25ac7 (commit)
       via  87c7ffccea5fb8a579ade220e6e4754f857e4ecc (commit)
       via  4dedb27d7e7829099bf0873ecd6af3b9b9e570b5 (commit)
       via  9999fd9026fbb3f4a7d07a455698230d209dbcb6 (commit)
       via  f81cacc6814dde73f203d125b0065d1451a98317 (commit)
      from  743dec4c0c80383556efac60f03d307287ecf024 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=d91934357fe28e5362da600e61fd6473f33ff62b

commit d91934357fe28e5362da600e61fd6473f33ff62b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 19 14:11:46 2015 +0100

    sgsn: Restructure the 'update-subscriber' command
    
    This patch drops the following commands:
    
     - update-subscriber imsi IMSI insert authorized <0-1>
     - update-subscriber imsi IMSI commit
    
    since they are already covered by the 'update-location-result'
    sub-command, except that this command doesn't create an new entry if
    none is found with the given IMSI.
    
    It adds the following command:
    
     - update-subscriber imsi IMSI create
    
    which can be used to create a new entry.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=15cc8c812553e60422ce1917ba8e4230d7eab0b4

commit 15cc8c812553e60422ce1917ba8e4230d7eab0b4
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 19 14:29:43 2015 +0100

    sgsn: Fix vty_out newlines
    
    Currently '\n' is used to end lines in the VTY output string
    constants instead of inserting VTY_NEWLINE. This leads to incorrect
    line starts in error messages.
    
    This patch fixes that accordingly.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=d6267d12d8bd945f219b3d2f7bf04060fe2d83bd

commit d6267d12d8bd945f219b3d2f7bf04060fe2d83bd
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 19 11:10:04 2015 +0100

    sgsn: Add SGSN_ERROR_CAUSE_NONE and use it instead of 0
    
    Currently an error_cause of 0 is being used to indicate normal
    operation. Albeit this is not a defined GMM cause, the value is not
    explicitly reserved.
    
    This commit adds the macro SGSN_ERROR_CAUSE_NONE and uses it for
    initialisation (instead of relying on talloc_zero) and comparisons.
    The value is set to -1 to be on the safe side. The VTY code is
    updated to set the error_cause when using the
    'update-subscriber imsi IMSI update-location-result CAUSE' command.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=2585620857a3a6c17b17a65a3d9a863824b8e401

commit 2585620857a3a6c17b17a65a3d9a863824b8e401
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 19 09:13:05 2015 +0100

    sgsn: Fix access to subscr in sgsn_auth_update (Coverity)
    
    Currently the access to subscr->sgsn_data->error_cause is not
    protected against subscr == NULL like it is done in other code paths
    of sgsn_auth_update.
    
    This commit adds a conditional to avoid a NULL-dereference.
    
    Fixes: Coverity CID 1264589
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=6be9ffa3b811311043194d04ae06e05d216c57bb

commit 6be9ffa3b811311043194d04ae06e05d216c57bb
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 19 08:57:07 2015 +0100

    sgsn/test: Make assert_substr safer (Coverity)
    
    Currently, if assert_subscr were called with subscr == NULL, the
    later call to subscr_put might fail, as Coverity has complained. In
    addition, the call to subscr_put would free the subscr object if it
    were in the cache with a refcount of 0 at the time assert_substr was
    called.
    
    This patch adds a check for the subscr being non-NULL and reorders
    the checks, so that the subscr_put comes last.
    
    Fixes: Coverity CID 1264590
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=d8a65536ecc6eae026898822b58f520f5ee25ac7

commit d8a65536ecc6eae026898822b58f520f5ee25ac7
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 18:51:31 2015 +0100

    sgsn: Fix P-TMSI generator's distance of equal values
    
    Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then
    sets to upper 2 MSB. Therefore there is no lower limit of the
    distance between 2 identical P-TMSI.
    
    This patch changes the implementation to discard any random value
    above 2^30 and to generate a new random number in that case until a
    fitting number is found (or a repetition limit is reached). This way,
    all number below 2^30 within the PRNG's period are used.
    
    Ticket: OW#1362
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=87c7ffccea5fb8a579ade220e6e4754f857e4ecc

commit 87c7ffccea5fb8a579ade220e6e4754f857e4ecc
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 8 15:29:01 2015 +0100

    gprs: Support the full cancellation procedure
    
    Currently no GSUP LocationCancellationResult message is sent back to
    the peer (HLR), if the procedure succeeded at the SGSN's side.
    
    This patch adds the missing message and put the whole request
    handling of this procedure into a separate function.
    
    Ticket: OW#1338
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=4dedb27d7e7829099bf0873ecd6af3b9b9e570b5

commit 4dedb27d7e7829099bf0873ecd6af3b9b9e570b5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 17:50:16 2015 +0100

    gprs: Don't create a subscr entry on InsertSubscriberData
    
    Currently gprs_subscr_rx_gsup_message creates a subscriber entry if
    such an entry doesn't exist for the IMSI within an
    InsertSubscriberData GSUP message. This behaviour is not compliant to
    GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is
    defined, that an error ("Unidentified subscriber") shall be returned.
    
    This patch removes the case distinction, so that an existing
    subscriber entry is required for all incoming GSUP messages.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=9999fd9026fbb3f4a7d07a455698230d209dbcb6

commit 9999fd9026fbb3f4a7d07a455698230d209dbcb6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 17:08:30 2015 +0100

    gprs: Add replies for all GSUP requests
    
    Currently, an incoming GSUP request message isn't answered at all if
    it is not handled due to an error or missing implementation.
    
    This patch adds GSUP error replies for these requests (and only for
    requests). It also adds tests for these cases.
    
    Note that several of these tests check for
    GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when
    the features are implemented.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=f81cacc6814dde73f203d125b0065d1451a98317

commit f81cacc6814dde73f203d125b0065d1451a98317
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 8 16:23:25 2015 +0100

    gprs: Block other GSUP procedures during PURGE_MS
    
    GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be
    started until the PURGE_MS procedure has been completed.
    
    This patch implements this by adding corresponding state and checks
    to gprs_subscr_purge, gprs_subscr_location_update, and
    gprs_subscr_update_auth_info. If an Update Location or a Send Auth
    Info Req procedure is not started because of blocking, the retry
    mechanism is aborted to shorten the blocking time. The outstanding
    Purge MS procedure itself is not aborted.
    
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 openbsc/include/openbsc/gprs_gsup_messages.h |   4 +
 openbsc/include/openbsc/gprs_sgsn.h          |  17 ++-
 openbsc/src/gprs/gprs_gmm.c                  |   4 +-
 openbsc/src/gprs/gprs_sgsn.c                 |  28 ++++-
 openbsc/src/gprs/gprs_subscriber.c           | 151 +++++++++++++++++++++----
 openbsc/src/gprs/sgsn_auth.c                 |   4 +-
 openbsc/src/gprs/sgsn_vty.c                  |  87 +++++++--------
 openbsc/tests/sgsn/sgsn_test.c               | 160 ++++++++++++++++++++++++++-
 openbsc/tests/sgsn/sgsn_test.ok              |   1 +
 openbsc/tests/vty_test_runner.py             |  10 +-
 10 files changed, 386 insertions(+), 80 deletions(-)


hooks/post-receive
-- 
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)



More information about the osmocom-commitlog mailing list