From gitosis at osmocom.org Thu Jan 1 11:32:57 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 11:32:57 GMT Subject: openbsc.git branch master updated. 0.13.0-809-g7b1d25a Message-ID: <201501011132.t01BWvWB086161@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90 (commit) via 7b129e76cebee739dc959d70d7c8c257e83c76b1 (commit) via c3e66ff5c36e47ca849b4f522d0f845437077076 (commit) via c3f0cb38cf626c349aa2fcf6c7aa6459ac22c476 (commit) from 979ac860954459ea8707815abeda96274e3de27b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90 commit 7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90 Author: Harald Welte Date: Thu Jan 1 12:32:03 2015 +0100 Fix most compiler warnings with gcc-4.9.2 http://cgit.osmocom.org/openbsc/commit/?id=7b129e76cebee739dc959d70d7c8c257e83c76b1 commit 7b129e76cebee739dc959d70d7c8c257e83c76b1 Author: Harald Welte Date: Thu Jan 1 12:20:21 2015 +0100 rtp_proxy: Remove dead code commit 65be6de155407142ddab44faf8aee5f8d5ebf628 removed the RTP timesetamp mangling and thus the only caller to tv_difference(), which can now be removed, too. http://cgit.osmocom.org/openbsc/commit/?id=c3e66ff5c36e47ca849b4f522d0f845437077076 commit c3e66ff5c36e47ca849b4f522d0f845437077076 Author: Harald Welte Date: Thu Jan 1 12:14:43 2015 +0100 chan_alloc: Fix missing break statement Fixes: Coverity CID 1261354 http://cgit.osmocom.org/openbsc/commit/?id=c3f0cb38cf626c349aa2fcf6c7aa6459ac22c476 commit c3f0cb38cf626c349aa2fcf6c7aa6459ac22c476 Author: Harald Welte Date: Thu Jan 1 12:13:42 2015 +0100 chan_alloc.c: Don't remove SDCCH/8 without CBCH In commit 30f1f376383df3ae8d85e96542bf14d174c25d89 we wanted to add support for SDCCH/8+CBCH, not replace the existing SDCCH/8 with the new CBCH-enabled configuration. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/Makefile.am | 2 +- openbsc/include/openbsc/smpp.h | 4 ++++ openbsc/src/libbsc/bsc_api.c | 5 +++-- openbsc/src/libbsc/chan_alloc.c | 2 ++ openbsc/src/libmgcp/mgcp_protocol.c | 2 +- openbsc/src/libtrau/rtp_proxy.c | 15 --------------- openbsc/src/osmo-nitb/bsc_hack.c | 1 + openbsc/src/utils/smpp_mirror.c | 6 ++++-- openbsc/tests/abis/abis_test.c | 16 ++++++++-------- openbsc/tests/gbproxy/gbproxy_test.c | 16 ++++++++-------- 10 files changed, 32 insertions(+), 37 deletions(-) create mode 100644 openbsc/include/openbsc/smpp.h hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 1 11:41:55 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 11:41:55 GMT Subject: openbsc.git branch master updated. 0.13.0-810-g5468f76 Message-ID: <201501011141.t01Bftmd086957@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 5468f768618c5d225e99f3ecf00c0ad068b1500b (commit) from 7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=5468f768618c5d225e99f3ecf00c0ad068b1500b commit 5468f768618c5d225e99f3ecf00c0ad068b1500b Author: Harald Welte Date: Thu Jan 1 12:41:17 2015 +0100 convert away from deprecated gsm_7bit_{encode,decode}() functions which removes yet another bunch of compiler warnings. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libmsc/gsm_04_08.c | 4 ++-- openbsc/src/libmsc/gsm_04_11.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 1 11:58:07 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 11:58:07 GMT Subject: openbsc.git branch master updated. 0.13.0-812-g7ff77ec Message-ID: <201501011158.t01Bw76D088488@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 7ff77ec713c6569715077344563ff9ab1719619c (commit) via f86852ce0bc7d4c854d6f6825f74ab30be64b5c5 (commit) from 5468f768618c5d225e99f3ecf00c0ad068b1500b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7ff77ec713c6569715077344563ff9ab1719619c commit 7ff77ec713c6569715077344563ff9ab1719619c Author: Holger Hans Peter Freyther Date: Wed Dec 29 23:06:22 2010 +0100 smscb: Prepare to fill in the info for CBCH in SI4 Pass the number of bytes the rest octet for si4 should fill. http://cgit.osmocom.org/openbsc/commit/?id=f86852ce0bc7d4c854d6f6825f74ab30be64b5c5 commit f86852ce0bc7d4c854d6f6825f74ab30be64b5c5 Author: Harald Welte Date: Thu Jan 1 12:46:26 2015 +0100 chan_alloc: remove ts_alloc() and ts_free() The idea of ts_alloc()/ts_free() dates back to the very early days of OpenBSC, where we didn't yet have a fixed PCHAN type assigned for every lchan in a BTS. However, ever since, PCHAN types (channel combinations) are configured by OML in a certain way, and we only allocate LCHANs inside PCHANs of a matching type. There should be no PCHANs with type GSM_PCHAN_NONE, unless those that you don't want to use for administraive reasons or the like. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/chan_alloc.h | 11 ---- openbsc/include/openbsc/rest_octets.h | 2 +- openbsc/src/libbsc/chan_alloc.c | 107 +------------------------------- openbsc/src/libbsc/rest_octets.c | 4 +- openbsc/src/libbsc/system_information.c | 2 +- 5 files changed, 5 insertions(+), 121 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 1 12:28:51 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:28:51 GMT Subject: libosmocore.git branch laforge/libctrl deleted. 0.7.0-1-g9c053b6 Message-ID: <201501011228.t01CSpro091289@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/libctrl has been deleted was 9c053b6fbee14e00240034f0583917543e3e787d ----------------------------------------------------------------------- 9c053b6fbee14e00240034f0583917543e3e787d libctrl: Add support for 'deferred control commands' ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 12:29:18 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:29:18 GMT Subject: openbsc.git branch master updated. 0.13.0-820-gc83f027 Message-ID: <201501011229.t01CTIiC091386@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via c83f0276b3d0e58b3c2187923f481026952b113b (commit) via 8db0788896221633dbe0660d08ca03e9dcfec2b2 (commit) via dfbc42c261b438271487822f0ccd687fda84129f (commit) via dc9b4e9ebf64e0227c85ebbb870254a1de6058d4 (commit) via 7465e4c2e19f25bad3c92288e323d4d0d9f7baf1 (commit) via 61c9156a744f48493aea3f7ff175a3ed56d154cd (commit) via 98ba6359a16ce6555dee87ccde09ba6ef46bc858 (commit) via b4771a6871efb3cf12b371aedc575912984ca528 (commit) from 7ff77ec713c6569715077344563ff9ab1719619c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c83f0276b3d0e58b3c2187923f481026952b113b commit c83f0276b3d0e58b3c2187923f481026952b113b Merge: 7ff77ec 8db0788 Author: Harald Welte Date: Thu Jan 1 13:23:49 2015 +0100 Merge branch 'laforge/meas_vis' I'm merging this code, as it is proven to be very useful. The only reason to keep it out of master was the fact that the UDP data structures it sends are non-portable, so you can only run it reliably on localhost or between identical systems (hardware/compiler/os). As this hasn't been fixed in the past >= 2 years, I am merging the code now anyway. We can still introduce a portable protocol by increasing the protocol version at a later point. There are two options: a) we make 'struct gsm_meas_rep' portable. This requires an ABI change with libosmocore, as it contains struct gsm_meas_rep_unidir :( b) we introduce a completely separate wire format with corresponding encoding and decoding functions. http://cgit.osmocom.org/openbsc/commit/?id=8db0788896221633dbe0660d08ca03e9dcfec2b2 commit 8db0788896221633dbe0660d08ca03e9dcfec2b2 Author: Harald Welte Date: Thu Jan 1 13:06:48 2015 +0100 meas_feed.c: Fix compiler warning http://cgit.osmocom.org/openbsc/commit/?id=dfbc42c261b438271487822f0ccd687fda84129f commit dfbc42c261b438271487822f0ccd687fda84129f Author: Harald Welte Date: Thu Nov 15 12:29:15 2012 +0100 meas_feed: add osmo-meas-udp2db for realtime feed into database This tool can save the meas_feed messages from UDP port 8888 directly to a sqlite3 database for further analysis. http://cgit.osmocom.org/openbsc/commit/?id=dc9b4e9ebf64e0227c85ebbb870254a1de6058d4 commit dc9b4e9ebf64e0227c85ebbb870254a1de6058d4 Author: Harald Welte Date: Thu Nov 15 00:12:56 2012 +0100 meas_feed: Add tool to read meas_feed PCAP and write it to sqlite3 In fact, the DB write code has been split out so we could later also have a binary that would listen to realtime meas_feed packets and stuff them into a database without any intermediate PCAP step. The database schema contains a couple of convenience wrapper views, most notably the "overview" view. http://cgit.osmocom.org/openbsc/commit/?id=7465e4c2e19f25bad3c92288e323d4d0d9f7baf1 commit 7465e4c2e19f25bad3c92288e323d4d0d9f7baf1 Author: Harald Welte Date: Tue Nov 13 07:06:54 2012 +0100 build meas_vis only if libcdk is available http://cgit.osmocom.org/openbsc/commit/?id=61c9156a744f48493aea3f7ff175a3ed56d154cd commit 61c9156a744f48493aea3f7ff175a3ed56d154cd Author: Harald Welte Date: Sun Nov 11 12:57:05 2012 +0100 meas_vis: Add header and print TA + TO values http://cgit.osmocom.org/openbsc/commit/?id=98ba6359a16ce6555dee87ccde09ba6ef46bc858 commit 98ba6359a16ce6555dee87ccde09ba6ef46bc858 Author: Harald Welte Date: Sun Nov 11 12:33:30 2012 +0100 meas_vis: assign bar colors depending on level, display RxQual http://cgit.osmocom.org/openbsc/commit/?id=b4771a6871efb3cf12b371aedc575912984ca528 commit b4771a6871efb3cf12b371aedc575912984ca528 Author: Harald Welte Date: Sun Nov 11 10:58:51 2012 +0100 Initial support for export + curses-visualization of measurements This extends osmo_nitb to offer a UDP feed of real-time measurement reports, which can be used by (a variety of) external tools for visualization or other processing. We also add a small ncurses based tool (meas_vis) which shows a baragraph display of the last few mobile stations that were active, indicating their uplink/downlink receive level and quality. This sends non-portable structures like gsm_meas_rep over UDP and assumes the receiver has identical alignment and endianness! Before this feature is merged, it either needs to be converted to a unix domain socket (but they don't do multicast, which would be nice) or the wire format needs to change into something portable with defined alignment and encoding ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 4 + openbsc/include/openbsc/Makefile.am | 2 +- openbsc/include/openbsc/meas_feed.h | 29 +++ openbsc/src/libmsc/Makefile.am | 6 +- openbsc/src/libmsc/meas_feed.c | 158 +++++++++++++++ openbsc/src/libmsc/meas_feed.h | 12 ++ openbsc/src/libmsc/vty_interface_layer3.c | 35 ++++ openbsc/src/utils/Makefile.am | 20 +- openbsc/src/utils/meas_db.c | 323 ++++++++++++++++++++++++++++++ openbsc/src/utils/meas_db.h | 17 ++ openbsc/src/utils/meas_pcap2db.c | 141 +++++++++++++ openbsc/src/utils/meas_udp2db.c | 123 ++++++++++++ openbsc/src/utils/meas_vis.c | 306 ++++++++++++++++++++++++++++ 13 files changed, 1172 insertions(+), 4 deletions(-) create mode 100644 openbsc/include/openbsc/meas_feed.h create mode 100644 openbsc/src/libmsc/meas_feed.c create mode 100644 openbsc/src/libmsc/meas_feed.h create mode 100644 openbsc/src/utils/meas_db.c create mode 100644 openbsc/src/utils/meas_db.h create mode 100644 openbsc/src/utils/meas_pcap2db.c create mode 100644 openbsc/src/utils/meas_udp2db.c create mode 100644 openbsc/src/utils/meas_vis.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 1 12:30:06 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:30:06 GMT Subject: libosmocore.git branch daniel/fixes deleted. 0.5.3-77-g1360712 Message-ID: <201501011230.t01CU6tY091497@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, daniel/fixes has been deleted was 13607121a3f6ff0ac2d9f943ff3b34fcce0c4e9e ----------------------------------------------------------------------- 13607121a3f6ff0ac2d9f943ff3b34fcce0c4e9e tests: Don't delete atconfig in clean ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 12:30:33 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:30:33 GMT Subject: libosmocore.git branch daniel/lapdm-desync-test deleted. 0.6.5-17-g3dc4e16 Message-ID: <201501011230.t01CUXDK091568@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, daniel/lapdm-desync-test has been deleted was 3dc4e16786d1e5723e76ad7c70ad54134957f9e5 ----------------------------------------------------------------------- 3dc4e16786d1e5723e76ad7c70ad54134957f9e5 gsm/lapdm: Prevent LAPD tx_queue from filling up in polling mode ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 12:31:19 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:31:19 GMT Subject: libosmocore.git branch daniel/osmo_fd_fixes deleted. 0.6.6-3-g3b978d2 Message-ID: <201501011231.t01CVJpL091651@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, daniel/osmo_fd_fixes has been deleted was 3b978d271daaf83bfd0312c237a6508fce4ed05d ----------------------------------------------------------------------- 3b978d271daaf83bfd0312c237a6508fce4ed05d select: Fix english in comment ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 12:35:43 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:35:43 GMT Subject: libosmocore.git branch origin/laforge/libctrl deleted. 0.6.6-81-ga857909 Message-ID: <201501011235.t01CZh7s092168@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, origin/laforge/libctrl has been deleted was a857909df392e566ea46b9d3437fc87cd6846e20 ----------------------------------------------------------------------- a857909df392e566ea46b9d3437fc87cd6846e20 libctrl: adopt to recent ipaccess/ipa naming change ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 12:47:19 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 12:47:19 GMT Subject: libosmocore.git branch laforge/smscb deleted. 0.7.0-95-g65f676d Message-ID: <201501011247.t01ClJJa093327@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/smscb has been deleted was 65f676dac581d5ff6240aa76104d38df2cbf93ab ----------------------------------------------------------------------- 65f676dac581d5ff6240aa76104d38df2cbf93ab test ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 13:22:34 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 13:22:34 GMT Subject: libosmocore.git branch master updated. 0.7.0-101-g419684e Message-ID: <201501011322.t01DMYH9096751@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 419684e30c2fe12d3e3441cfa9fea21f1c4de959 (commit) from c13cf8bbd3a0650993b43e1cea071c02d0f00d8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=419684e30c2fe12d3e3441cfa9fea21f1c4de959 commit 419684e30c2fe12d3e3441cfa9fea21f1c4de959 Author: Tobias Engel Date: Thu Mar 8 13:31:52 2012 +0100 Supplementary Services (de)activation, interrogation added These patches enhance the Supplementary Service (SS) processing from only being able to handle USSD to other SS, specifically activation, deactivation and interrogation of those SS. Registration is not yet implemented. include/osmocom/gsm/protocol/gsm_09_02.h has been added with needed values for SS. Modified by Harald Welte to keep the old ussd-only functiosn for API/ABI stability. ----------------------------------------------------------------------- Summary of changes: include/Makefile.am | 1 + include/osmocom/gsm/gsm0480.h | 16 +++- include/osmocom/gsm/protocol/gsm_09_02.h | 137 +++++++++++++++++++++++++++++++ src/gsm/gsm0480.c | 126 ++++++++++++++++++++++------ src/gsm/libosmogsm.map | 1 + tests/ussd/ussd_test.c | 14 ++-- 6 files changed, 262 insertions(+), 33 deletions(-) create mode 100644 include/osmocom/gsm/protocol/gsm_09_02.h hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 13:22:52 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 13:22:52 GMT Subject: libosmocore.git branch tobias/supplementary_services deleted. 0.4.1-27-g28ed8f6 Message-ID: <201501011322.t01DMqN9096816@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, tobias/supplementary_services has been deleted was 28ed8f63dc38f35e5c24e3939a70e353d5fd73b3 ----------------------------------------------------------------------- 28ed8f63dc38f35e5c24e3939a70e353d5fd73b3 Supplementary Services (de)activation, interrogation added ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Thu Jan 1 13:35:51 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 13:35:51 GMT Subject: openbsc.git branch laforge/tobias_sup_serv_rebased created. 0.13.0-824-g37bf662 Message-ID: <201501011335.t01DZppr098073@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, laforge/tobias_sup_serv_rebased has been created at 37bf6628972271e1054d8583313754cda1bbd2fc (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=37bf6628972271e1054d8583313754cda1bbd2fc commit 37bf6628972271e1054d8583313754cda1bbd2fc Author: Tobias Engel Date: Wed Mar 28 13:54:20 2012 +0200 SS: Send Return Error instead of Reject when service is not provisioned http://cgit.osmocom.org/openbsc/commit/?id=c146eba59841beccb5d9e84386c39d836dba9967 commit c146eba59841beccb5d9e84386c39d836dba9967 Author: Tobias Engel Date: Wed Mar 28 13:50:29 2012 +0200 SS: Return Error component added gsm0480_send_ss_return_error sends a return error component with the supplied error code, and optionally ASN.1 BER formatted parameters (GSM 04.80 4.3) http://cgit.osmocom.org/openbsc/commit/?id=4e13e522ffdd1cc3ee9741ebaeba1fd711144a0d commit 4e13e522ffdd1cc3ee9741ebaeba1fd711144a0d Author: Tobias Engel Date: Thu Mar 22 15:09:54 2012 +0100 SS: Call Waiting SS This patch adds the ability to activate, deactivate and interrogate the Call Waiting SS (GSM 04.83) from a mobile station using either the menu or the MMI codes *43#, #43# and *#43# (see GSM 02.30). struct gsm_subscriber now has a member active_cc_transactions which will be increased/decreased in new_cc_state. A call to a subscriber will now only proceed if active_cc_transactions is either 0, or CW has been provisioned and activated for that subscriber, otherwise the caller will receive a "busy" signal. http://cgit.osmocom.org/openbsc/commit/?id=33bc1716f435e81d837268cbb04ddf7487f14a32 commit 33bc1716f435e81d837268cbb04ddf7487f14a32 Author: Tobias Engel Date: Thu Mar 22 15:07:29 2012 +0100 SS: Supplementary Services (de)activation and interrogation These patches enhance the Supplementary Service (SS) processing from only being able to handle USSD to other SS, specifically activation, deactivation and interrogation of those SS. Registration is not yet implemented. The HLR db now includes a table SS_Status which contains fields for the SS code (GSM 09.02 17.7.5), basic service code (17.7.9 and 17.7.10) and SS status bits (17.7.4) and references the subscriber. db.c supports interrogating and setting the SS status with the functions db_ss_interrogate_status and db_ss_set_status. No automatic provisioning takes place. To do so, a record has to be added to the db referencing the subscriber and containing the desired SS code, BS code and having the 'P' bit in the SS status set to one. All occurrences of "ussd" have been replaced with "ss" where the corresponding file/function/variable deals not exclusively with USSD requests. ussd.c and ussd.h have been renamed to ss.c and ss.h. gsm0480_send_ss_return_result has been added to gsm_04_80.c. It takes a msgb as an argument which has to already contain the ASN.1 formatted Return Result minus the operation code and invoke id. change_ss_activation and interrogate_ss have been added to ss.c (formerly ussd.c). Currently, (de)activation and interrogation of SS will always be handled as if it was requested for the Telephony teleservice, no matter what was requested by the subscriber. Also, sending a Return Error has not been implemented yet (Reject is used instead). ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 1 18:06:59 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 1 Jan 2015 18:06:59 GMT Subject: openbsc.git branch laforge/meas_vis deleted. 0.13.0-579-g733e173 Message-ID: <201501011806.t01I6xoD020334@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, laforge/meas_vis has been deleted was 733e173a5dad052c7cc4e03db411fbd17c6887b0 ----------------------------------------------------------------------- 733e173a5dad052c7cc4e03db411fbd17c6887b0 meas_feed: add osmo-meas-udp2db for realtime feed into database ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 2 10:53:21 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 2 Jan 2015 10:53:21 GMT Subject: openbsc.git branch master updated. 0.13.0-825-g6995f24 Message-ID: <201501021053.t02ArLHh008624@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 6995f24831b70ef64bd08976f2aecc5314fe9862 (commit) via b7ccac4d620271e8780fdc7640cba96c275bdf85 (commit) via 454140e7fcd9c904ffbdf5b16af84e52efe9b4d4 (commit) via 52fa7bd2da381cf933052806eb1fd78f3fc0967c (commit) via c6e32ad0b8b4e040b836bcd6bf88a8279612d94d (commit) from c83f0276b3d0e58b3c2187923f481026952b113b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=6995f24831b70ef64bd08976f2aecc5314fe9862 commit 6995f24831b70ef64bd08976f2aecc5314fe9862 Author: Holger Hans Peter Freyther Date: Sun Dec 28 18:54:32 2014 +0100 logging: Only compare the subscr address Move the "logging filter imsi IMSI" into the BTS/NITB code to allow to set the gsm_subscriber and only compare it. This way we simply compare the subscriber address and don't have to care if the subscriber data is still valid. http://cgit.osmocom.org/openbsc/commit/?id=b7ccac4d620271e8780fdc7640cba96c275bdf85 commit b7ccac4d620271e8780fdc7640cba96c275bdf85 Author: Holger Hans Peter Freyther Date: Sun Dec 28 15:00:36 2014 +0100 logging: Set the context for paging requests as well. http://cgit.osmocom.org/openbsc/commit/?id=454140e7fcd9c904ffbdf5b16af84e52efe9b4d4 commit 454140e7fcd9c904ffbdf5b16af84e52efe9b4d4 Author: Holger Hans Peter Freyther Date: Sun Dec 28 12:08:28 2014 +0100 lchan: Remember why a channel is broken using static strings Remember why a channel is being marked as broken. So we can maybe understand what happend. http://cgit.osmocom.org/openbsc/commit/?id=52fa7bd2da381cf933052806eb1fd78f3fc0967c commit 52fa7bd2da381cf933052806eb1fd78f3fc0967c Author: Holger Hans Peter Freyther Date: Fri Jan 2 11:34:43 2015 +0100 misc: Ignore new binaries http://cgit.osmocom.org/openbsc/commit/?id=c6e32ad0b8b4e040b836bcd6bf88a8279612d94d commit c6e32ad0b8b4e040b836bcd6bf88a8279612d94d Author: Holger Hans Peter Freyther Date: Fri Jan 2 11:25:54 2015 +0100 Partial revert "Fix most compiler warnings with gcc-4.9.2" Most of the "fixes" have nothing to do with gcc-4.9.2 but are a question of ABI/Architecture (e.g. x86 vs. AMD64). Revert these for now. This partially reverts commit 7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90. abis_test.c: In function ???test_simple_sw_config???: abis_test.c:68:2: warning: format ???%ld??? expects argument of type ???long int???, but argument 2 has type ???int??? [-Wformat=] printf("Start: %ld len: %zu\n", descr[0].start - simple_config, descr[0].len); ^ abis_test.c: In function ???test_dual_sw_config???: abis_test.c:111:2: warning: format ???%ld??? expects argument of type ???long int???, but argument 2 has type ???int??? [-Wformat=] printf("Start: %ld len: %zu\n", descr[0].start - dual_config, descr[0].len); ^ abis_test.c:115:2: warning: format ???%ld??? expects argument of type ???long int???, but argument 2 has type ???int??? [-Wformat=] printf("Start: %ld len: %zu\n", descr[1].start - dual_config, descr[1].len); ^ abis_test.c: In function ???test_sw_selection???: abis_test.c:132:2: warning: format ???%ld??? expects argument of type ???long int???, but argument 2 has type ???int??? [-Wformat=] printf("Start: %ld len: %zu\n", descr[0].start - load_config, descr[0].len); ^ abis_test.c:136:2: warning: format ???%ld??? expects argument of type ???long int???, but argument 2 has type ???int??? [-Wformat=] printf("Start: %ld len: %zu\n", descr[1].start - load_config, descr[1].len); ----------------------------------------------------------------------- Summary of changes: openbsc/.gitignore | 4 ++++ openbsc/include/openbsc/abis_rsl.h | 1 + openbsc/include/openbsc/debug.h | 3 ++- openbsc/include/openbsc/gsm_data_shared.h | 1 + openbsc/src/libbsc/abis_rsl.c | 22 +++++++++++++++------- openbsc/src/libbsc/bsc_vty.c | 25 +++++-------------------- openbsc/src/libbsc/chan_alloc.c | 2 ++ openbsc/src/libbsc/paging.c | 8 ++++++++ openbsc/src/libcommon/debug.c | 18 +++++++++++------- openbsc/src/libmgcp/mgcp_protocol.c | 2 +- openbsc/src/libmsc/gsm_04_08.c | 1 + openbsc/src/libmsc/vty_interface_layer3.c | 28 ++++++++++++++++++++++++++++ openbsc/src/osmo-bsc/osmo_bsc_vty.c | 29 +++++++++++++++++++++++++++++ openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 3 --- openbsc/tests/abis/abis_test.c | 16 ++++++++-------- openbsc/tests/gbproxy/gbproxy_test.c | 16 ++++++++-------- 16 files changed, 124 insertions(+), 55 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 10:35:12 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 10:35:12 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-848-g3552fc0 Message-ID: <201501051035.t05AZCSK078792@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 3fb6fbddfd6c7c524d9718953e11d1253c176c03 (commit) discards 615c0089f0dd6c9794a93ff30136f4d5680b3527 (commit) discards 69dbfccd9617d890ab47f8f3be5f12268ef97fe4 (commit) discards 477687d28b2fd4d0c802980d9520a0dac9f48b1c (commit) discards fc1a40a908eed3783fd1ef952bff4439e92c011e (commit) discards 52cbc48dc3b34c8cbf0fbe4c3dec80fc115d6103 (commit) discards 0898453bcc9a4d29c1b7a350af3bb2c657c13887 (commit) discards d0d19575645fbb55675a920dddf9e0b908e344a6 (commit) discards dc705156990875cce47e91be02d6e11eb42ec297 (commit) discards 7ba0f5153d236baafae9c4fa35bd19b9dae8fa79 (commit) discards 877eaefa8b2f13758103eb77aeaa57db4bb58ef4 (commit) discards 20fba7e41677012efaf84b869f270c364b44067e (commit) discards 0331b92277f541f64b2928a7996e23f55ef86e1e (commit) discards b633cac56859a73cfe955aaca42e4624064c7a24 (commit) discards 8c53be038f73ef0ec41990cca44e3acf51c608e2 (commit) discards db0f3dc595fd081cb26df84b0a534614cf35e018 (commit) discards a458d7ef7835891237b2c271d9365e59691cbb0a (commit) discards 9b731ee8145248104016a66a5617706321d112a1 (commit) discards 82c9c6a70704677fd691e6a2c5e865d490a944bc (commit) discards 3e2ade7f718ceaaa7bfdc70da0c666c2a4096d6d (commit) discards db7e1e46f258f8697a952d0cec52601f8fb9d0e1 (commit) discards fd40f97341add367623ce9133ee47df62956db94 (commit) discards 91ba21fc94d0e2bcb1b2416d111e893232bc0c1b (commit) discards 20d9b880e538c8728e825b4bb74ededb1a67ee20 (commit) via 3552fc0ea816e0278737a9adf02bbebc0c9f3ea9 (commit) via b350f9b704e00b517b64374023c135fe447b2f74 (commit) via d472750bb78afdabc77e6b288ef31d1631f768ce (commit) via 5ae6ad4fd7365012256202177d876bbacb1be4b9 (commit) via 6ec5309642f5abd26571e8f4e4e40357f624382e (commit) via 9d6c76aa03956bc0176cc343f7599be2c203a734 (commit) via 5487c6829df406fcbadb0ad3f76dfa197f9b49ed (commit) via fb7c1d7d4539b3a1ed5de9d5fbe0ffd0ec99e9fb (commit) via 4d04272041fd00483c60135e8af978bab2d7bf28 (commit) via b887882fe3cc8df8684c64c22ab34118716612ed (commit) via 73b62d9f06461dcbf98159037337846d3d239093 (commit) via 0d06eb3b833f04a59621b84687c60780a40f49b1 (commit) via 57548870c02cb7408d1705e4af5fa54dcc64904a (commit) via 7900fcaf62feca60030c0cfa4c722b28f674258b (commit) via a86fa318ad1e420d66fc1b4f7928b9c3edea40b6 (commit) via 0e593b9acc8779dc4a88ef922ec3404f4eee76fd (commit) via 48136c24be1e7e0e46bfa2f2bc7c41c3a0ce8d8e (commit) via 143d59838a268fdbe733f98d91998f20b9d4dcec (commit) via 4196c41274448a6dc6bff78dd6545058fd9a09bd (commit) via c24ff2bf62e7ecbd6a55d413a23329d7f8837b31 (commit) via 6f45250cd43d17b5ca84fd35523d3afc785ee397 (commit) via d878b4d6aac174e9a4e8cda48ba64e8204fc79d6 (commit) via 01d24b8e05a63a1df4e08de2982b274b811fb60e (commit) via 6995f24831b70ef64bd08976f2aecc5314fe9862 (commit) via b7ccac4d620271e8780fdc7640cba96c275bdf85 (commit) via 454140e7fcd9c904ffbdf5b16af84e52efe9b4d4 (commit) via 52fa7bd2da381cf933052806eb1fd78f3fc0967c (commit) via c6e32ad0b8b4e040b836bcd6bf88a8279612d94d (commit) via c83f0276b3d0e58b3c2187923f481026952b113b (commit) via 8db0788896221633dbe0660d08ca03e9dcfec2b2 (commit) via dfbc42c261b438271487822f0ccd687fda84129f (commit) via dc9b4e9ebf64e0227c85ebbb870254a1de6058d4 (commit) via 7465e4c2e19f25bad3c92288e323d4d0d9f7baf1 (commit) via 61c9156a744f48493aea3f7ff175a3ed56d154cd (commit) via 98ba6359a16ce6555dee87ccde09ba6ef46bc858 (commit) via b4771a6871efb3cf12b371aedc575912984ca528 (commit) via 7ff77ec713c6569715077344563ff9ab1719619c (commit) via f86852ce0bc7d4c854d6f6825f74ab30be64b5c5 (commit) via 5468f768618c5d225e99f3ecf00c0ad068b1500b (commit) via 7b1d25a11e44bbc1cb0d2acd9f1a3d4a16ec7c90 (commit) via 7b129e76cebee739dc959d70d7c8c257e83c76b1 (commit) via c3e66ff5c36e47ca849b4f522d0f845437077076 (commit) via c3f0cb38cf626c349aa2fcf6c7aa6459ac22c476 (commit) via 979ac860954459ea8707815abeda96274e3de27b (commit) via 695675f53991a33681ab1fa6662f318170f72992 (commit) via 142d12d829d4207e2fe7dee34b8d82dd89015615 (commit) via 30f1f376383df3ae8d85e96542bf14d174c25d89 (commit) via 65be6de155407142ddab44faf8aee5f8d5ebf628 (commit) via be8e775776b2f39fe8a31412a4fcaaf5dcaae25e (commit) via 98a95ac17f701d94d2fa62d91cfe42a5beef4f23 (commit) via 7921ab1593f45f12588e074ad1280472416ae930 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (3fb6fbddfd6c7c524d9718953e11d1253c176c03) \ N -- N -- N (3552fc0ea816e0278737a9adf02bbebc0c9f3ea9) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3552fc0ea816e0278737a9adf02bbebc0c9f3ea9 commit 3552fc0ea816e0278737a9adf02bbebc0c9f3ea9 Author: Jacob Erlbeck Date: Mon Jan 5 09:43:51 2015 +0100 sgsn: Fix VTY command error handling (Coverity) Currently the result of the osmo_hexparse function in update_subscr_insert_auth_triplet is not handled correctly. There is a misplaced leading exclamation mark in a few conditional expressions. This effectively disables the error checks, as it is noticed by Coverity ("Missing parentheses" followed by "Logically dead code"). This patch removes the exclamation marks. Fixes: Coverity CID 1260435 and CID 1260434 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b350f9b704e00b517b64374023c135fe447b2f74 commit b350f9b704e00b517b64374023c135fe447b2f74 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Handle GSUP errors (WIP) Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d472750bb78afdabc77e6b288ef31d1631f768ce commit d472750bb78afdabc77e6b288ef31d1631f768ce Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5ae6ad4fd7365012256202177d876bbacb1be4b9 commit 5ae6ad4fd7365012256202177d876bbacb1be4b9 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6ec5309642f5abd26571e8f4e4e40357f624382e commit 6ec5309642f5abd26571e8f4e4e40357f624382e Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9d6c76aa03956bc0176cc343f7599be2c203a734 commit 9d6c76aa03956bc0176cc343f7599be2c203a734 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5487c6829df406fcbadb0ad3f76dfa197f9b49ed commit 5487c6829df406fcbadb0ad3f76dfa197f9b49ed Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fb7c1d7d4539b3a1ed5de9d5fbe0ffd0ec99e9fb commit fb7c1d7d4539b3a1ed5de9d5fbe0ffd0ec99e9fb Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4d04272041fd00483c60135e8af978bab2d7bf28 commit 4d04272041fd00483c60135e8af978bab2d7bf28 Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b887882fe3cc8df8684c64c22ab34118716612ed commit b887882fe3cc8df8684c64c22ab34118716612ed Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=73b62d9f06461dcbf98159037337846d3d239093 commit 73b62d9f06461dcbf98159037337846d3d239093 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0d06eb3b833f04a59621b84687c60780a40f49b1 commit 0d06eb3b833f04a59621b84687c60780a40f49b1 Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=57548870c02cb7408d1705e4af5fa54dcc64904a commit 57548870c02cb7408d1705e4af5fa54dcc64904a Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7900fcaf62feca60030c0cfa4c722b28f674258b commit 7900fcaf62feca60030c0cfa4c722b28f674258b Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a86fa318ad1e420d66fc1b4f7928b9c3edea40b6 commit a86fa318ad1e420d66fc1b4f7928b9c3edea40b6 Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0e593b9acc8779dc4a88ef922ec3404f4eee76fd commit 0e593b9acc8779dc4a88ef922ec3404f4eee76fd Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=48136c24be1e7e0e46bfa2f2bc7c41c3a0ce8d8e commit 48136c24be1e7e0e46bfa2f2bc7c41c3a0ce8d8e Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=143d59838a268fdbe733f98d91998f20b9d4dcec commit 143d59838a268fdbe733f98d91998f20b9d4dcec Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4196c41274448a6dc6bff78dd6545058fd9a09bd commit 4196c41274448a6dc6bff78dd6545058fd9a09bd Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c24ff2bf62e7ecbd6a55d413a23329d7f8837b31 commit c24ff2bf62e7ecbd6a55d413a23329d7f8837b31 Author: Jacob Erlbeck Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6f45250cd43d17b5ca84fd35523d3afc785ee397 commit 6f45250cd43d17b5ca84fd35523d3afc785ee397 Author: Jacob Erlbeck Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d878b4d6aac174e9a4e8cda48ba64e8204fc79d6 commit d878b4d6aac174e9a4e8cda48ba64e8204fc79d6 Author: Jacob Erlbeck Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=01d24b8e05a63a1df4e08de2982b274b811fb60e commit 01d24b8e05a63a1df4e08de2982b274b811fb60e Author: Jacob Erlbeck Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/.gitignore | 4 + openbsc/configure.ac | 4 + openbsc/include/openbsc/Makefile.am | 3 +- openbsc/include/openbsc/abis_rsl.h | 4 +- openbsc/include/openbsc/chan_alloc.h | 13 +- openbsc/include/openbsc/debug.h | 3 +- openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/gsm_data_shared.h | 10 +- openbsc/include/openbsc/meas_feed.h | 29 +++ openbsc/include/openbsc/rest_octets.h | 2 +- openbsc/include/openbsc/smpp.h | 4 + openbsc/src/gprs/sgsn_vty.c | 6 +- openbsc/src/libbsc/abis_rsl.c | 43 ++-- openbsc/src/libbsc/bsc_api.c | 5 +- openbsc/src/libbsc/bsc_vty.c | 75 +++++-- openbsc/src/libbsc/chan_alloc.c | 114 ++--------- openbsc/src/libbsc/paging.c | 8 + openbsc/src/libbsc/rest_octets.c | 4 +- openbsc/src/libbsc/system_information.c | 16 +- openbsc/src/libcommon/debug.c | 18 +- openbsc/src/libcommon/gsm_data_shared.c | 34 +++- openbsc/src/libmgcp/mgcp_protocol.c | 2 +- openbsc/src/libmsc/Makefile.am | 6 +- openbsc/src/libmsc/gsm_04_08.c | 5 +- openbsc/src/libmsc/gsm_04_11.c | 3 +- openbsc/src/libmsc/meas_feed.c | 158 +++++++++++++++ openbsc/src/libmsc/meas_feed.h | 12 ++ openbsc/src/libmsc/vty_interface_layer3.c | 63 ++++++ openbsc/src/libtrau/rtp_proxy.c | 36 ---- openbsc/src/osmo-bsc/osmo_bsc_vty.c | 29 +++ openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 3 - openbsc/src/osmo-nitb/bsc_hack.c | 1 + openbsc/src/utils/Makefile.am | 20 +- openbsc/src/utils/meas_db.c | 323 ++++++++++++++++++++++++++++++ openbsc/src/utils/meas_db.h | 17 ++ openbsc/src/utils/meas_pcap2db.c | 141 +++++++++++++ openbsc/src/utils/meas_udp2db.c | 123 ++++++++++++ openbsc/src/utils/meas_vis.c | 306 ++++++++++++++++++++++++++++ openbsc/src/utils/smpp_mirror.c | 6 +- openbsc/tests/db/db_test.c | 7 + openbsc/tests/sgsn/sgsn_test.c | 4 +- 41 files changed, 1442 insertions(+), 223 deletions(-) create mode 100644 openbsc/include/openbsc/meas_feed.h create mode 100644 openbsc/include/openbsc/smpp.h create mode 100644 openbsc/src/libmsc/meas_feed.c create mode 100644 openbsc/src/libmsc/meas_feed.h create mode 100644 openbsc/src/utils/meas_db.c create mode 100644 openbsc/src/utils/meas_db.h create mode 100644 openbsc/src/utils/meas_pcap2db.c create mode 100644 openbsc/src/utils/meas_udp2db.c create mode 100644 openbsc/src/utils/meas_vis.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 10:54:10 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 10:54:10 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-848-gb392f1b Message-ID: <201501051054.t05AsAlu080235@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 3552fc0ea816e0278737a9adf02bbebc0c9f3ea9 (commit) discards b350f9b704e00b517b64374023c135fe447b2f74 (commit) discards d472750bb78afdabc77e6b288ef31d1631f768ce (commit) discards 5ae6ad4fd7365012256202177d876bbacb1be4b9 (commit) discards 6ec5309642f5abd26571e8f4e4e40357f624382e (commit) discards 9d6c76aa03956bc0176cc343f7599be2c203a734 (commit) discards 5487c6829df406fcbadb0ad3f76dfa197f9b49ed (commit) discards fb7c1d7d4539b3a1ed5de9d5fbe0ffd0ec99e9fb (commit) discards 4d04272041fd00483c60135e8af978bab2d7bf28 (commit) discards b887882fe3cc8df8684c64c22ab34118716612ed (commit) discards 73b62d9f06461dcbf98159037337846d3d239093 (commit) discards 0d06eb3b833f04a59621b84687c60780a40f49b1 (commit) discards 57548870c02cb7408d1705e4af5fa54dcc64904a (commit) discards 7900fcaf62feca60030c0cfa4c722b28f674258b (commit) discards a86fa318ad1e420d66fc1b4f7928b9c3edea40b6 (commit) discards 0e593b9acc8779dc4a88ef922ec3404f4eee76fd (commit) discards 48136c24be1e7e0e46bfa2f2bc7c41c3a0ce8d8e (commit) discards 143d59838a268fdbe733f98d91998f20b9d4dcec (commit) discards 4196c41274448a6dc6bff78dd6545058fd9a09bd (commit) discards c24ff2bf62e7ecbd6a55d413a23329d7f8837b31 (commit) discards 6f45250cd43d17b5ca84fd35523d3afc785ee397 (commit) discards d878b4d6aac174e9a4e8cda48ba64e8204fc79d6 (commit) discards 01d24b8e05a63a1df4e08de2982b274b811fb60e (commit) via b392f1b1448b3eebf779457577fb439d533781c0 (commit) via 6888fef2394ec6e7cf9fa1667f6d990ea3323d6f (commit) via 4bddf37c8d4b54d94e2245250bdf44916f657ea2 (commit) via af31f22589327f0c4a13587ead4b0413af95f845 (commit) via 618dce764997e543cbe7e8b5c9313f981122f576 (commit) via 1793b8df0dda07fcf29baf31b3b08c748103887f (commit) via fa9af3fe29a549523a30e2af521f73b2f17819da (commit) via 00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e (commit) via 50a3edc6c2cca52464c40dd24756365acf57680d (commit) via 4cb99aad4fa93be5e4381152ae3fb1583b429b75 (commit) via d0d5a90281f54b0ddcfa54a715b01a30045ede62 (commit) via a4b21b7f740defe76e70fcb459667436da8bc8fd (commit) via bcb60cccc36aa2b48abeec55081decdce623b9a1 (commit) via cde63d0a32b7610ed077c7831b960c009e024b77 (commit) via 95961dd1282789ddd55cbf1c32ea2ce62bec61f0 (commit) via 694aad91d4b1bf658cfac767871ddffdcceb45d3 (commit) via 4fe374421b460a0f023a4fd7fda048d675d793d1 (commit) via 84c734570291d7e240ee473a614ac8f3af14771a (commit) via 65f625f2283553497d7cc0d15a4c9ca8e6656442 (commit) via 0163dbcc30575ee6953222183f2cbbd0741486b5 (commit) via e14a5903e5d1c9fce9d13f91e9a08eeade42a541 (commit) via 21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd (commit) via 5ca5699e61b2395fd822027c425be5f26bd33ac2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (3552fc0ea816e0278737a9adf02bbebc0c9f3ea9) \ N -- N -- N (b392f1b1448b3eebf779457577fb439d533781c0) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b392f1b1448b3eebf779457577fb439d533781c0 commit b392f1b1448b3eebf779457577fb439d533781c0 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Handle GSUP errors (WIP) Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6888fef2394ec6e7cf9fa1667f6d990ea3323d6f commit 6888fef2394ec6e7cf9fa1667f6d990ea3323d6f Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4bddf37c8d4b54d94e2245250bdf44916f657ea2 commit 4bddf37c8d4b54d94e2245250bdf44916f657ea2 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=af31f22589327f0c4a13587ead4b0413af95f845 commit af31f22589327f0c4a13587ead4b0413af95f845 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=618dce764997e543cbe7e8b5c9313f981122f576 commit 618dce764997e543cbe7e8b5c9313f981122f576 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1793b8df0dda07fcf29baf31b3b08c748103887f commit 1793b8df0dda07fcf29baf31b3b08c748103887f Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fa9af3fe29a549523a30e2af521f73b2f17819da commit fa9af3fe29a549523a30e2af521f73b2f17819da Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e commit 00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=50a3edc6c2cca52464c40dd24756365acf57680d commit 50a3edc6c2cca52464c40dd24756365acf57680d Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4cb99aad4fa93be5e4381152ae3fb1583b429b75 commit 4cb99aad4fa93be5e4381152ae3fb1583b429b75 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d0d5a90281f54b0ddcfa54a715b01a30045ede62 commit d0d5a90281f54b0ddcfa54a715b01a30045ede62 Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a4b21b7f740defe76e70fcb459667436da8bc8fd commit a4b21b7f740defe76e70fcb459667436da8bc8fd Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bcb60cccc36aa2b48abeec55081decdce623b9a1 commit bcb60cccc36aa2b48abeec55081decdce623b9a1 Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cde63d0a32b7610ed077c7831b960c009e024b77 commit cde63d0a32b7610ed077c7831b960c009e024b77 Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=95961dd1282789ddd55cbf1c32ea2ce62bec61f0 commit 95961dd1282789ddd55cbf1c32ea2ce62bec61f0 Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=694aad91d4b1bf658cfac767871ddffdcceb45d3 commit 694aad91d4b1bf658cfac767871ddffdcceb45d3 Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4fe374421b460a0f023a4fd7fda048d675d793d1 commit 4fe374421b460a0f023a4fd7fda048d675d793d1 Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=84c734570291d7e240ee473a614ac8f3af14771a commit 84c734570291d7e240ee473a614ac8f3af14771a Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=65f625f2283553497d7cc0d15a4c9ca8e6656442 commit 65f625f2283553497d7cc0d15a4c9ca8e6656442 Author: Jacob Erlbeck Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0163dbcc30575ee6953222183f2cbbd0741486b5 commit 0163dbcc30575ee6953222183f2cbbd0741486b5 Author: Jacob Erlbeck Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e14a5903e5d1c9fce9d13f91e9a08eeade42a541 commit e14a5903e5d1c9fce9d13f91e9a08eeade42a541 Author: Jacob Erlbeck Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd commit 21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd Author: Jacob Erlbeck Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5ca5699e61b2395fd822027c425be5f26bd33ac2 commit 5ca5699e61b2395fd822027c425be5f26bd33ac2 Author: Jacob Erlbeck Date: Mon Jan 5 09:43:51 2015 +0100 sgsn: Fix VTY command error handling (Coverity) Currently the result of the osmo_hexparse function in update_subscr_insert_auth_triplet is not handled correctly. There is a misplaced leading exclamation mark in a few conditional expressions. This effectively disables the error checks, as it is noticed by Coverity ("Missing parentheses" followed by "Logically dead code"). This patch removes the exclamation marks. Fixes: Coverity CID 1260435 and CID 1260434 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 11:04:17 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 11:04:17 GMT Subject: openbsc.git branch jerlbeck/wip/range_encode deleted. 0.13.0-262-gceee736 Message-ID: <201501051104.t05B4HBX081259@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/range_encode has been deleted was ceee736607a4b199f5a53a3513100b351c0f50da ----------------------------------------------------------------------- ceee736607a4b199f5a53a3513100b351c0f50da si: Implement range 128, 256, 1024 encoding ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 11:05:05 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 11:05:05 GMT Subject: openbsc.git branch jerlbeck/features/range-encode deleted. 0.13.0-261-g64277e6 Message-ID: <201501051105.t05B55Vr081354@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/features/range-encode has been deleted was 64277e6514d5b305af97d6cfe07601ba00d8afaa ----------------------------------------------------------------------- 64277e6514d5b305af97d6cfe07601ba00d8afaa si: Implement range 128, 256, 1024 encoding ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 11:09:11 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 11:09:11 GMT Subject: openbsc.git branch jerlbeck/features/mgcp-get-info-from-sdp deleted. 0.13.0-228-g82691a4 Message-ID: <201501051109.t05B9Bix081625@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/features/mgcp-get-info-from-sdp has been deleted was 82691a415f0e835664989274ea8236af7a5555dd ----------------------------------------------------------------------- 82691a415f0e835664989274ea8236af7a5555dd mgcp: Optionally send ptime in SDP ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 11:11:35 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 11:11:35 GMT Subject: openbsc.git branch jerlbeck/wip/rtp-keepalive-and-disable-output deleted. 0.13.0-245-g07c89da Message-ID: <201501051111.t05BBZiZ081935@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/rtp-keepalive-and-disable-output has been deleted was 07c89dabe517aad357a08ddb521902a3e0441553 ----------------------------------------------------------------------- 07c89dabe517aad357a08ddb521902a3e0441553 mgcp: TODO RTP keepalive ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 11:20:47 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 11:20:47 GMT Subject: openbsc.git branch jerlbeck/fixes/ussd-messages deleted. 0.9.14-216-g62ed0af Message-ID: <201501051120.t05BKlUH082785@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/fixes/ussd-messages has been deleted was 62ed0af0499477c6b768a51a9ae52ef247ec072d ----------------------------------------------------------------------- 62ed0af0499477c6b768a51a9ae52ef247ec072d debian: Add a new changelog entry (0.9.14~z11) ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 13:13:34 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 13:13:34 GMT Subject: openbsc.git branch master updated. 0.13.0-830-g0c4e400 Message-ID: <201501051313.t05DDY2i093505@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 0c4e400d2fdd6445da4dc24851945119517d8083 (commit) via c598e6e0a6d00827c2c974010d582815d66d0f14 (commit) via a9e420e93dca43b92b608a819ea782445eef52e0 (commit) via 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 (commit) via e5d2c60ae661e801b7049a2c9526712ded895cc1 (commit) from 6995f24831b70ef64bd08976f2aecc5314fe9862 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0c4e400d2fdd6445da4dc24851945119517d8083 commit 0c4e400d2fdd6445da4dc24851945119517d8083 Author: Harald Welte Date: Mon Jan 5 14:13:16 2015 +0100 meas_pcap2db.c: Fix build without CDK Spotted by Jacob Erlbeck. http://cgit.osmocom.org/openbsc/commit/?id=c598e6e0a6d00827c2c974010d582815d66d0f14 commit c598e6e0a6d00827c2c974010d582815d66d0f14 Author: Harald Welte Date: Thu Jun 6 07:30:29 2013 +0200 debug.c: use new libosmocore features to print and save log filter http://cgit.osmocom.org/openbsc/commit/?id=a9e420e93dca43b92b608a819ea782445eef52e0 commit a9e420e93dca43b92b608a819ea782445eef52e0 Author: Harald Welte Date: Tue Nov 13 04:26:22 2012 +0100 RSL: Change "... is back in operation" to an INFO level message http://cgit.osmocom.org/openbsc/commit/?id=1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 commit 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 Author: Harald Welte Date: Tue Nov 13 04:46:03 2012 +0100 Don't return an error to caller if we are out of lchan on CHAN RQD This is a normal situation under high load: The BTS is out of resources and the BSC cannot allocate any dedicated channel. We may send an IMM ASS REJECT back to the MS. All well within normal parameters, not an error that needs to be reported back to the caller, who propagates it all the way up to libosmo-abis. http://cgit.osmocom.org/openbsc/commit/?id=e5d2c60ae661e801b7049a2c9526712ded895cc1 commit e5d2c60ae661e801b7049a2c9526712ded895cc1 Author: Harald Welte Date: Tue Nov 13 06:52:42 2012 +0100 SMS: Attempting to send SMS is not a NOTICEable event ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_rsl.c | 4 ++-- openbsc/src/libcommon/debug.c | 46 ++++++++++++++++++++++++++++++++++++++++ openbsc/src/libmsc/sms_queue.c | 2 +- openbsc/src/utils/meas_pcap2db.c | 2 -- 4 files changed, 49 insertions(+), 5 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 13:15:59 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 13:15:59 GMT Subject: openbsc.git branch master updated. 0.13.0-831-ga677047 Message-ID: <201501051315.t05DFxlT093725@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via a67704753a6328f725d38d61af8bfbe29012fcbc (commit) from 0c4e400d2fdd6445da4dc24851945119517d8083 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=a67704753a6328f725d38d61af8bfbe29012fcbc commit a67704753a6328f725d38d61af8bfbe29012fcbc Author: Harald Welte Date: Mon Jan 5 14:15:16 2015 +0100 Revert "debug.c: use new libosmocore features to print and save log filter" This reverts commit c598e6e0a6d00827c2c974010d582815d66d0f14. It introduced a dependency from libcommon to libosmovty, which we don't want ----------------------------------------------------------------------- Summary of changes: openbsc/src/libcommon/debug.c | 46 ------------------------------------------- 1 file changed, 46 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 5 14:01:10 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 5 Jan 2015 14:01:10 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-854-g0b1caf7 Message-ID: <201501051401.t05E1AIu098270@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards b392f1b1448b3eebf779457577fb439d533781c0 (commit) discards 6888fef2394ec6e7cf9fa1667f6d990ea3323d6f (commit) discards 4bddf37c8d4b54d94e2245250bdf44916f657ea2 (commit) discards af31f22589327f0c4a13587ead4b0413af95f845 (commit) discards 618dce764997e543cbe7e8b5c9313f981122f576 (commit) discards 1793b8df0dda07fcf29baf31b3b08c748103887f (commit) discards fa9af3fe29a549523a30e2af521f73b2f17819da (commit) discards 00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e (commit) discards 50a3edc6c2cca52464c40dd24756365acf57680d (commit) discards 4cb99aad4fa93be5e4381152ae3fb1583b429b75 (commit) discards d0d5a90281f54b0ddcfa54a715b01a30045ede62 (commit) discards a4b21b7f740defe76e70fcb459667436da8bc8fd (commit) discards bcb60cccc36aa2b48abeec55081decdce623b9a1 (commit) discards cde63d0a32b7610ed077c7831b960c009e024b77 (commit) discards 95961dd1282789ddd55cbf1c32ea2ce62bec61f0 (commit) discards 694aad91d4b1bf658cfac767871ddffdcceb45d3 (commit) discards 4fe374421b460a0f023a4fd7fda048d675d793d1 (commit) discards 84c734570291d7e240ee473a614ac8f3af14771a (commit) discards 65f625f2283553497d7cc0d15a4c9ca8e6656442 (commit) discards 0163dbcc30575ee6953222183f2cbbd0741486b5 (commit) discards e14a5903e5d1c9fce9d13f91e9a08eeade42a541 (commit) discards 21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd (commit) discards 5ca5699e61b2395fd822027c425be5f26bd33ac2 (commit) via 0b1caf7da499d1cbce53795cf9deee4643636327 (commit) via 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit) via c6d308f59292adc572b680065192e9ed55ea19e9 (commit) via ba59d61d98064219b7618ffa254027b009201d80 (commit) via 7c2a048c2be60ea3e30bc755939503299b720904 (commit) via 5428ff90b1260769cc918a585abdb1c292d67f7f (commit) via 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 (commit) via 6231ed289064f453b5d2bb56d70afe7a992dfe77 (commit) via 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 (commit) via 65f35a28038ec7ed310a2fca5015b3018c5455e8 (commit) via 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 (commit) via 45292a23631fdb943c7aaec0dc1d1af2ce013792 (commit) via 424d584f82f8240c1325ca25ed186f446997de58 (commit) via 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 (commit) via 3d0895483f0d543af485413dedb40294b0efd9b4 (commit) via 79571191f2c526e18dc1257a3273a7235582d2a6 (commit) via ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 (commit) via 9f2e178f07b7d15733e862fca7c140b1475899ee (commit) via 847bf670e354fbd11bedbadf63deb0577a0a380b (commit) via 62068f8848f5c851a06053265b311dca9042b103 (commit) via 2ad5544bee5062301797a86a6adb44513abe27d2 (commit) via 5636470b9fa12827e190f3f38386f2824edfcf61 (commit) via 4e8a698c1173d71f9e0ee6eef182f5884c181493 (commit) via a67704753a6328f725d38d61af8bfbe29012fcbc (commit) via 0c4e400d2fdd6445da4dc24851945119517d8083 (commit) via c598e6e0a6d00827c2c974010d582815d66d0f14 (commit) via a9e420e93dca43b92b608a819ea782445eef52e0 (commit) via 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 (commit) via e5d2c60ae661e801b7049a2c9526712ded895cc1 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (b392f1b1448b3eebf779457577fb439d533781c0) \ N -- N -- N (0b1caf7da499d1cbce53795cf9deee4643636327) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0b1caf7da499d1cbce53795cf9deee4643636327 commit 0b1caf7da499d1cbce53795cf9deee4643636327 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Handle GSUP errors (WIP) Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7cfbae6fc6168148f937cf781bed962ed8ec1a32 commit 7cfbae6fc6168148f937cf781bed962ed8ec1a32 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c6d308f59292adc572b680065192e9ed55ea19e9 commit c6d308f59292adc572b680065192e9ed55ea19e9 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ba59d61d98064219b7618ffa254027b009201d80 commit ba59d61d98064219b7618ffa254027b009201d80 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7c2a048c2be60ea3e30bc755939503299b720904 commit 7c2a048c2be60ea3e30bc755939503299b720904 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5428ff90b1260769cc918a585abdb1c292d67f7f commit 5428ff90b1260769cc918a585abdb1c292d67f7f Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 commit 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6231ed289064f453b5d2bb56d70afe7a992dfe77 commit 6231ed289064f453b5d2bb56d70afe7a992dfe77 Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 commit 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=65f35a28038ec7ed310a2fca5015b3018c5455e8 commit 65f35a28038ec7ed310a2fca5015b3018c5455e8 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 commit 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=45292a23631fdb943c7aaec0dc1d1af2ce013792 commit 45292a23631fdb943c7aaec0dc1d1af2ce013792 Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=424d584f82f8240c1325ca25ed186f446997de58 commit 424d584f82f8240c1325ca25ed186f446997de58 Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5c455ae7a7326c19545258a6e247fe2f6b4c3e01 commit 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3d0895483f0d543af485413dedb40294b0efd9b4 commit 3d0895483f0d543af485413dedb40294b0efd9b4 Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79571191f2c526e18dc1257a3273a7235582d2a6 commit 79571191f2c526e18dc1257a3273a7235582d2a6 Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 commit ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9f2e178f07b7d15733e862fca7c140b1475899ee commit 9f2e178f07b7d15733e862fca7c140b1475899ee Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=847bf670e354fbd11bedbadf63deb0577a0a380b commit 847bf670e354fbd11bedbadf63deb0577a0a380b Author: Jacob Erlbeck Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=62068f8848f5c851a06053265b311dca9042b103 commit 62068f8848f5c851a06053265b311dca9042b103 Author: Jacob Erlbeck Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2ad5544bee5062301797a86a6adb44513abe27d2 commit 2ad5544bee5062301797a86a6adb44513abe27d2 Author: Jacob Erlbeck Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5636470b9fa12827e190f3f38386f2824edfcf61 commit 5636470b9fa12827e190f3f38386f2824edfcf61 Author: Jacob Erlbeck Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4e8a698c1173d71f9e0ee6eef182f5884c181493 commit 4e8a698c1173d71f9e0ee6eef182f5884c181493 Author: Jacob Erlbeck Date: Mon Jan 5 09:43:51 2015 +0100 sgsn: Fix VTY command error handling (Coverity) Currently the result of the osmo_hexparse function in update_subscr_insert_auth_triplet is not handled correctly. There is a misplaced leading exclamation mark in a few conditional expressions. This effectively disables the error checks, as it is noticed by Coverity ("Missing parentheses" followed by "Logically dead code"). This patch removes the exclamation marks. Fixes: Coverity CID 1260435 and CID 1260434 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_rsl.c | 4 ++-- openbsc/src/libmsc/sms_queue.c | 2 +- openbsc/src/utils/meas_pcap2db.c | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 6 10:25:51 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 6 Jan 2015 10:25:51 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-859-g1371326 Message-ID: <201501061025.t06APpGd014386@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 0b1caf7da499d1cbce53795cf9deee4643636327 (commit) discards 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit) discards c6d308f59292adc572b680065192e9ed55ea19e9 (commit) discards ba59d61d98064219b7618ffa254027b009201d80 (commit) discards 7c2a048c2be60ea3e30bc755939503299b720904 (commit) via 13713264aa539ce1343ad6c7dd0f8308b242a892 (commit) via f30d7455f17f8488b03d8727f33dfaa39e812107 (commit) via 917d8e33aa0f6f14d459124ab63961a1876b7379 (commit) via b0f9aae0e08b65ce2636218379853f88f33134fa (commit) via 033dacd0be40045485ce85fe6d736dad56277b97 (commit) via df41492476d1134f907c9eeaa8da592223012e30 (commit) via d255302af01073748213504bd65692941b30c01c (commit) via 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 (commit) via 67014fd5657394534326c99554f89ec85970e509 (commit) via e8978ac39c5e96877960f0df07644efc8a0bc321 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (0b1caf7da499d1cbce53795cf9deee4643636327) \ N -- N -- N (13713264aa539ce1343ad6c7dd0f8308b242a892) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=13713264aa539ce1343ad6c7dd0f8308b242a892 commit 13713264aa539ce1343ad6c7dd0f8308b242a892 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f30d7455f17f8488b03d8727f33dfaa39e812107 commit f30d7455f17f8488b03d8727f33dfaa39e812107 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=917d8e33aa0f6f14d459124ab63961a1876b7379 commit 917d8e33aa0f6f14d459124ab63961a1876b7379 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b0f9aae0e08b65ce2636218379853f88f33134fa commit b0f9aae0e08b65ce2636218379853f88f33134fa Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=033dacd0be40045485ce85fe6d736dad56277b97 commit 033dacd0be40045485ce85fe6d736dad56277b97 Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=df41492476d1134f907c9eeaa8da592223012e30 commit df41492476d1134f907c9eeaa8da592223012e30 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Use LOGMMCTX for logging To unify the layout of the logging messages, this patch replaces some calls to LOGP by calls to LOGMMCTXP. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d255302af01073748213504bd65692941b30c01c commit d255302af01073748213504bd65692941b30c01c Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 commit 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=67014fd5657394534326c99554f89ec85970e509 commit 67014fd5657394534326c99554f89ec85970e509 Author: Jacob Erlbeck Date: Mon Jan 5 17:51:17 2015 +0100 gprs: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e8978ac39c5e96877960f0df07644efc8a0bc321 commit e8978ac39c5e96877960f0df07644efc8a0bc321 Author: Jacob Erlbeck Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_04_08_gprs.h | 11 +++ openbsc/src/gprs/Makefile.am | 3 +- openbsc/src/gprs/gprs_gmm.c | 134 +++++------------------------ openbsc/src/gprs/gprs_gsup_messages.c | 4 +- openbsc/src/gprs/gprs_subscriber.c | 20 ++++- openbsc/src/gprs/gsm_04_08_gprs.c | 141 +++++++++++++++++++++++++++++++ openbsc/tests/sgsn/Makefile.am | 1 + 7 files changed, 192 insertions(+), 122 deletions(-) create mode 100644 openbsc/src/gprs/gsm_04_08_gprs.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 6 11:06:10 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 6 Jan 2015 11:06:10 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-859-ga43e25b Message-ID: <201501061106.t06B6ATO017659@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 13713264aa539ce1343ad6c7dd0f8308b242a892 (commit) discards f30d7455f17f8488b03d8727f33dfaa39e812107 (commit) discards 917d8e33aa0f6f14d459124ab63961a1876b7379 (commit) discards b0f9aae0e08b65ce2636218379853f88f33134fa (commit) discards 033dacd0be40045485ce85fe6d736dad56277b97 (commit) discards df41492476d1134f907c9eeaa8da592223012e30 (commit) discards d255302af01073748213504bd65692941b30c01c (commit) discards 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 (commit) via a43e25b50c1ad30a597e336c8f47e274a9911186 (commit) via 6a3dab12333b610ca35622d943647b17585f8871 (commit) via f2cde608fc40b767e540073c575fbd0479c1c0a7 (commit) via 156c91bc2e564894aa09b5ebe7f2ff13923cd8da (commit) via 1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8 (commit) via 76a917b02cff735d1bf7eaa4685462ab631dce76 (commit) via 93d39583080a58fb16597ecc341a1ce32ad38d7a (commit) via f8f8fba629ed6b861dacb1f997c9f28d83a162e0 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (13713264aa539ce1343ad6c7dd0f8308b242a892) \ N -- N -- N (a43e25b50c1ad30a597e336c8f47e274a9911186) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=a43e25b50c1ad30a597e336c8f47e274a9911186 commit a43e25b50c1ad30a597e336c8f47e274a9911186 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6a3dab12333b610ca35622d943647b17585f8871 commit 6a3dab12333b610ca35622d943647b17585f8871 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f2cde608fc40b767e540073c575fbd0479c1c0a7 commit f2cde608fc40b767e540073c575fbd0479c1c0a7 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=156c91bc2e564894aa09b5ebe7f2ff13923cd8da commit 156c91bc2e564894aa09b5ebe7f2ff13923cd8da Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8 commit 1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8 Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=76a917b02cff735d1bf7eaa4685462ab631dce76 commit 76a917b02cff735d1bf7eaa4685462ab631dce76 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages, this patch replaces some calls to LOGP by calls to LOGMMCTXP. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=93d39583080a58fb16597ecc341a1ce32ad38d7a commit 93d39583080a58fb16597ecc341a1ce32ad38d7a Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f8f8fba629ed6b861dacb1f997c9f28d83a162e0 commit f8f8fba629ed6b861dacb1f997c9f28d83a162e0 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_subscriber.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 6 15:40:09 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 6 Jan 2015 15:40:09 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-860-gab5820d Message-ID: <201501061540.t06Fe9BR044365@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated via ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc (commit) from a43e25b50c1ad30a597e336c8f47e274a9911186 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc commit ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries (TODO) Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is unset, the subscriber entry will be kept but no timer will be started. - [no] subscriber-expiry-time <0-999999> TODO: - commit message - fix test - send PURGE MS (other commit) - expire ununsed MM contexts (other commit) - which default timeout ??? Ticket: OW#???? Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 1 + openbsc/include/openbsc/sgsn.h | 4 ++++ openbsc/src/gprs/gprs_subscriber.c | 48 +++++++++++++++++++++++++++++++++++-- openbsc/src/gprs/sgsn_vty.c | 35 +++++++++++++++++++++++++++ 4 files changed, 86 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 6 18:15:38 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 6 Jan 2015 18:15:38 GMT Subject: osmo-bts.git branch zecke/sysmobts-calibration updated. 0.3.0-274-g83a549a Message-ID: <201501061815.t06IFc2A057518@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, zecke/sysmobts-calibration has been updated discards bc7b625afb3e5cf88e3e4e1320a5415bd48a9606 (commit) discards e121a761baaa2414de4a744392cacdc35db0d324 (commit) discards 02f2ded39e9ae83c89017b9036a6c6cd5bafd0b0 (commit) discards 3d75cb056d4b67b6cd3aeb6c786a201c4f9a6638 (commit) discards 2048b09a6443fab269ee2da55c32c4813482cad4 (commit) discards 814ec0773161fb9d4074cf35edef2ab2c8b2ac65 (commit) discards 1716cb479cfe1ddaa240e7ed1dc6a47f00bdc234 (commit) via 83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44 (commit) via a70c8f1c8ae5b222008888d98bdf7deee411d2e3 (commit) via 0ae0c43883fa3c60ed3adf9703236db873b4229f (commit) via 3bf0b4382a75cf8a36fe2eeed9d8ff7085c92125 (commit) via 84f21fbcb5b4b8677f6c20f73bb38430dbde0a48 (commit) via f2fbdcff6b49bab3f9f202d8f7212bfc63145ce7 (commit) via 553db72509fb6936e782a75cd04d1ed91d00f12c (commit) via d81b78b524c823122d569fc09f4a764b7a2e13f2 (commit) via 8fc2630dd4884ffeb4c5fc93457c8c06e6dbf918 (commit) via bd988f6ad3624ae0be3bdc19143d4db0290744f5 (commit) via 1e245336ecfe6cbdf3c4253ca5557146d493126d (commit) via 4457c0d9ba73a0f8f9e95bb24dd3f33f469b4fe3 (commit) via 660116fb9d7b382808377274ae4aed7c45e980e3 (commit) via b15d2c9d2f8ebe56672ab2191a4dc39d22fa0ab8 (commit) via 50dc96507caba9480938eb3d9d0db9236f877b49 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (bc7b625afb3e5cf88e3e4e1320a5415bd48a9606) \ N -- N -- N (83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44 commit 83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44 Author: Holger Hans Peter Freyther Date: Tue Dec 23 11:47:28 2014 +0100 sysmobts: Create a calibration loop that will be run Continously run the calibration process. Everytime we call the reset function classify the outcome. In case of a failure schedule the next command soon and otherwise wait several hours. Remember if the process was started through the VTY or the run loop. In case it can't be started immediately reset and schedule a new run. http://cgit.osmocom.org/osmo-bts/commit/?id=a70c8f1c8ae5b222008888d98bdf7deee411d2e3 commit a70c8f1c8ae5b222008888d98bdf7deee411d2e3 Author: Holger Hans Peter Freyther Date: Tue Dec 23 09:45:55 2014 +0100 sysmobts: Start the calibration the first time the link is up After a reboot the system might have been off for a long time and the currently used value might be wrong. Remember that we never ran the calibration and execute it on start. http://cgit.osmocom.org/osmo-bts/commit/?id=0ae0c43883fa3c60ed3adf9703236db873b4229f commit 0ae0c43883fa3c60ed3adf9703236db873b4229f Author: Holger Hans Peter Freyther Date: Mon Dec 22 18:24:57 2014 +0100 sysmobts: Initial version to use libgps to determine FIX state We should only calibrate the clock if there is a GPS fix. Start gpsd to determine if there is a fix or not. Work around trimble decoding issues (sent an email upstream). We need to gain some more experience to see if there memory leaks. We also need to re-schedule the calibration depending on the outcome. http://cgit.osmocom.org/osmo-bts/commit/?id=3bf0b4382a75cf8a36fe2eeed9d8ff7085c92125 commit 3bf0b4382a75cf8a36fe2eeed9d8ff7085c92125 Author: Holger Hans Peter Freyther Date: Tue Jan 6 19:11:49 2015 +0100 sysmobts: The correction for GPS is in the reverse direction Change the sign before passing it as correction value. The error is the difference between the TCXO and GPS. We need to correct by the reverse of the error. This seems to be different depending on the clock source we have. This is a last minute untested change. http://cgit.osmocom.org/osmo-bts/commit/?id=84f21fbcb5b4b8677f6c20f73bb38430dbde0a48 commit 84f21fbcb5b4b8677f6c20f73bb38430dbde0a48 Author: Holger Hans Peter Freyther Date: Fri Dec 12 21:54:43 2014 +0100 sysmobts: Use the ctrl interface for calibration This runs the entire procedure for calibration with reasonable error and success checking. It can be triggered from the VTY of the sysmobts-mgr right now. What is missing is to hook up with GPSD to check if the system has a fix and provide a mode that will continously run the calibration command. http://cgit.osmocom.org/osmo-bts/commit/?id=f2fbdcff6b49bab3f9f202d8f7212bfc63145ce7 commit f2fbdcff6b49bab3f9f202d8f7212bfc63145ce7 Author: Holger Hans Peter Freyther Date: Fri Dec 12 19:20:17 2014 +0100 sysmobts: Copy more of l1if_rf_clock_info_reset into the CTRL code The CTRL code should have used/extended the l1_if calibration code. The sysmobts-mgr code first needs to determine if the clock adjustment is necessary at all. This is done by first resetting the counters, then waiting, then asking for the diff and then applying the correction value. But the reference clock is only set by the application comand. Copy more code of l1if_rf_clock_info_reset to set the reference clock as value. This is leaving some todos inside the code that will be resolved as part of SYS#835. Related: SYS#835 http://cgit.osmocom.org/osmo-bts/commit/?id=553db72509fb6936e782a75cd04d1ed91d00f12c commit 553db72509fb6936e782a75cd04d1ed91d00f12c Author: Holger Hans Peter Freyther Date: Fri Dec 12 16:59:41 2014 +0100 sysmobts: Begin with calib control from the sysmobts manager In the long run we will connect to GPSD and wait for a fix and then run the calibration. The first step is to open (and re-open) the control connection to the BTS. As the connection is on localhost there should not be a computation overhead to always have the connection open. When connecting assume that the ASYNC connect worked directly as otherwise we get no notification of the failure. This looks like a "bug" of libosmo-abis that should check if the socket has been connected or not. http://cgit.osmocom.org/osmo-bts/commit/?id=d81b78b524c823122d569fc09f4a764b7a2e13f2 commit d81b78b524c823122d569fc09f4a764b7a2e13f2 Author: Holger Hans Peter Freyther Date: Fri Dec 12 16:54:08 2014 +0100 msg: Generalize the message structure test This was taken out of LaF0rge's OML router branch and is now used by the extended calibration feature. ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/Makefile.am | 2 +- include/osmo-bts/cbch.h | 16 +++ include/osmo-bts/gsm_data.h | 6 + src/common/Makefile.am | 3 +- src/common/bts.c | 2 + src/common/cbch.c | 196 +++++++++++++++++++++++++++ src/common/measurement.c | 4 + src/common/oml.c | 18 ++- src/common/rsl.c | 33 ++++- src/common/support.c | 4 + src/common/vty.c | 15 +- src/osmo-bts-sysmo/l1_if.c | 5 + src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c | 21 ++- src/osmo-bts-sysmo/misc/sysmobts_mgr_nl.c | 11 +- src/osmo-bts-sysmo/oml.c | 17 +++ 15 files changed, 340 insertions(+), 13 deletions(-) create mode 100644 include/osmo-bts/cbch.h create mode 100644 src/common/cbch.c hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Tue Jan 6 18:23:34 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 6 Jan 2015 18:23:34 GMT Subject: osmo-bts.git branch master updated. 0.3.0-267-gb7ebf54 Message-ID: <201501061823.t06INYCH058488@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via b7ebf545e6cc5eee17df254815c7838fbea61db7 (commit) from 8fc2630dd4884ffeb4c5fc93457c8c06e6dbf918 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=b7ebf545e6cc5eee17df254815c7838fbea61db7 commit b7ebf545e6cc5eee17df254815c7838fbea61db7 Author: Holger Hans Peter Freyther Date: Tue Jan 6 19:19:47 2015 +0100 cbch: Speculative change to not change CHAN ACK for CBCH Use the rel_act_kind to not send RSL channel acks for the CBCH to the BSC. This is similar to what we do for the BCCH a couple of lines above. ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-sysmo/oml.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Fri Jan 9 07:55:29 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 9 Jan 2015 07:55:29 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-867-gea0536b Message-ID: <201501090755.t097tTUA098656@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc (commit) via ea0536bf635e07db2f384781da98be7ab8827e5a (commit) via fcba963099af65e6f193eb6799ccac0a2efb86a9 (commit) via 769b6127cced3e611b9abd1b4ad82cb5be729c35 (commit) via a85733188e7ec86a88042004c033043f0b4ec8d9 (commit) via b316eb4edbd9abbc439796955d6a490bb179d3f7 (commit) via c586e0177e35c2ffde4ca8377be55703d6d0cf5d (commit) via bb25160f1b5e69957114d429279c3ba159b16215 (commit) via 8322ac6f11f4504add91c1a658c4103a5dedcf6b (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc) \ N -- N -- N (ea0536bf635e07db2f384781da98be7ab8827e5a) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=ea0536bf635e07db2f384781da98be7ab8827e5a commit ea0536bf635e07db2f384781da98be7ab8827e5a Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fcba963099af65e6f193eb6799ccac0a2efb86a9 commit fcba963099af65e6f193eb6799ccac0a2efb86a9 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=769b6127cced3e611b9abd1b4ad82cb5be729c35 commit 769b6127cced3e611b9abd1b4ad82cb5be729c35 Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a85733188e7ec86a88042004c033043f0b4ec8d9 commit a85733188e7ec86a88042004c033043f0b4ec8d9 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages (TODO) When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies, if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. TODO: - commit message - expire ununsed MM contexts (other commit) - blocking (see spec)? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b316eb4edbd9abbc439796955d6a490bb179d3f7 commit b316eb4edbd9abbc439796955d6a490bb179d3f7 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries (TODO) Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. TODO: - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c586e0177e35c2ffde4ca8377be55703d6d0cf5d commit c586e0177e35c2ffde4ca8377be55703d6d0cf5d Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bb25160f1b5e69957114d429279c3ba159b16215 commit bb25160f1b5e69957114d429279c3ba159b16215 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8322ac6f11f4504add91c1a658c4103a5dedcf6b commit 8322ac6f11f4504add91c1a658c4103a5dedcf6b Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add and use LOGGSUBSCRP macro to log subscriber Currently the LOGMMCTXP is used to log information related to subscribers. This relies on subscr->mm being set to include the IMSI in the output. This also means, that in doesn't show the IMSI in subscr entries that are not attached to an MM context, albeit the IMSI is stored in the gsm_subscriber object. This patch adds a new logging macro, that logs subscrs to DGPRS without using the mm reference. It also replaces all LOGMMCTXP and most LOGP in gprs_subscriber.c by LOGGSUBSCRP. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 14 ++ openbsc/src/gprs/gprs_subscriber.c | 249 ++++++++++++++++++++++++++---------- openbsc/src/gprs/sgsn_vty.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 28 ++-- 4 files changed, 219 insertions(+), 76 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 9 08:42:38 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 9 Jan 2015 08:42:38 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-867-gb706933 Message-ID: <201501090842.t098gc5E002539@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards ea0536bf635e07db2f384781da98be7ab8827e5a (commit) discards fcba963099af65e6f193eb6799ccac0a2efb86a9 (commit) discards 769b6127cced3e611b9abd1b4ad82cb5be729c35 (commit) discards a85733188e7ec86a88042004c033043f0b4ec8d9 (commit) discards b316eb4edbd9abbc439796955d6a490bb179d3f7 (commit) discards c586e0177e35c2ffde4ca8377be55703d6d0cf5d (commit) discards bb25160f1b5e69957114d429279c3ba159b16215 (commit) discards 8322ac6f11f4504add91c1a658c4103a5dedcf6b (commit) discards a43e25b50c1ad30a597e336c8f47e274a9911186 (commit) discards 6a3dab12333b610ca35622d943647b17585f8871 (commit) discards f2cde608fc40b767e540073c575fbd0479c1c0a7 (commit) discards 156c91bc2e564894aa09b5ebe7f2ff13923cd8da (commit) discards 1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8 (commit) discards 76a917b02cff735d1bf7eaa4685462ab631dce76 (commit) via b706933bd9cdf89bbe5b12d1b2541c1893a6537e (commit) via b9f5f4df87870041fc9e986ab841b6221e0a77f2 (commit) via 7ba4fa5066c39d03c6f760d0f1f618d92ef90b07 (commit) via 38fa6bf2cec58ec5ef3be16ec14424ed5a96674c (commit) via 3bf946c49d9a21dafca29b990a856e61cadaff91 (commit) via 3d7b2e6a26c54ebf38f9b30e00a73ec1f040e245 (commit) via 4872cdfa622889444854f76cc9bc4ddb97a6d0dc (commit) via 18391a453805bc14748bbd313273bf2b585145c7 (commit) via 515fdd662b120f5afc46345cd1be6592c852671b (commit) via c87fa1b94435a51ade34ea99b5ef39135e309275 (commit) via d39fe2f96d7cea3250be82abcdef6333e9422f67 (commit) via 33de2ebc61bad4973f64e1dc07478393cf66f783 (commit) via c52716e55d3ba88173c3feb47a3233c4aa69e92b (commit) via 52a5229ca8b55ee804a7a911512af8617e21c5da (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (ea0536bf635e07db2f384781da98be7ab8827e5a) \ N -- N -- N (b706933bd9cdf89bbe5b12d1b2541c1893a6537e) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b706933bd9cdf89bbe5b12d1b2541c1893a6537e commit b706933bd9cdf89bbe5b12d1b2541c1893a6537e Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b9f5f4df87870041fc9e986ab841b6221e0a77f2 commit b9f5f4df87870041fc9e986ab841b6221e0a77f2 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7ba4fa5066c39d03c6f760d0f1f618d92ef90b07 commit 7ba4fa5066c39d03c6f760d0f1f618d92ef90b07 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=38fa6bf2cec58ec5ef3be16ec14424ed5a96674c commit 38fa6bf2cec58ec5ef3be16ec14424ed5a96674c Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3bf946c49d9a21dafca29b990a856e61cadaff91 commit 3bf946c49d9a21dafca29b990a856e61cadaff91 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3d7b2e6a26c54ebf38f9b30e00a73ec1f040e245 commit 3d7b2e6a26c54ebf38f9b30e00a73ec1f040e245 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4872cdfa622889444854f76cc9bc4ddb97a6d0dc commit 4872cdfa622889444854f76cc9bc4ddb97a6d0dc Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=18391a453805bc14748bbd313273bf2b585145c7 commit 18391a453805bc14748bbd313273bf2b585145c7 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages (TODO) When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies, if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. TODO: - commit message - expire ununsed MM contexts (other commit) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=515fdd662b120f5afc46345cd1be6592c852671b commit 515fdd662b120f5afc46345cd1be6592c852671b Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries (TODO) Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. TODO: - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c87fa1b94435a51ade34ea99b5ef39135e309275 commit c87fa1b94435a51ade34ea99b5ef39135e309275 Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d39fe2f96d7cea3250be82abcdef6333e9422f67 commit d39fe2f96d7cea3250be82abcdef6333e9422f67 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=33de2ebc61bad4973f64e1dc07478393cf66f783 commit 33de2ebc61bad4973f64e1dc07478393cf66f783 Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c52716e55d3ba88173c3feb47a3233c4aa69e92b commit c52716e55d3ba88173c3feb47a3233c4aa69e92b Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGGSUBSCRP and LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages in gprs_subscriber.c, this patch replaces each LOGP by LOGGSUBSCRP, unless a non-NULL pointer to a subscr is not available. In those cases, it uses LOGMMCTXP if a pointer to an MM context is available or LOGP otherwise. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=52a5229ca8b55ee804a7a911512af8617e21c5da commit 52a5229ca8b55ee804a7a911512af8617e21c5da Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add LOGGSUBSCRP macro to log subscriber info This patch adds a new logging macro, that logs to DGPRS and provides a uniform prefix containing the IMSI without using the mm reference. This is an improvement over using LOGMMCTXP, since the new macro also provides an IMSI if no MM context is attached. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 9 08:49:59 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 9 Jan 2015 08:49:59 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-868-ge2e2ef3 Message-ID: <201501090849.t098nxO1003178@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated via e2e2ef39a05b6840b6670ca8e1f1d889bafffdb6 (commit) from b706933bd9cdf89bbe5b12d1b2541c1893a6537e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=e2e2ef39a05b6840b6670ca8e1f1d889bafffdb6 commit e2e2ef39a05b6840b6670ca8e1f1d889bafffdb6 Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 9 18:52:03 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 9 Jan 2015 18:52:03 GMT Subject: osmo-trx.git branch master updated. 93b7f373097f3b1563ff327ffa163846b8da0987 Message-ID: <201501091852.t09Iq36h055683@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via 93b7f373097f3b1563ff327ffa163846b8da0987 (commit) via 4ad9ea69aba4a556d105e55cc5b67c5b3fc78fca (commit) via eb54bddf47e087cf340c8a65b36a03cebd4f174b (commit) via a4d1a4124421473f5f92255e2f3bc44bfa3937ea (commit) via b99975917585dc8973cc806a5da0aa3fc791b198 (commit) from 1ae25561fa3f6fe8295526b28031686c1123a8b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: CommonLibs/Threads.h | 9 +- Transceiver52M/Transceiver.cpp | 244 +++++++++++++++++++++++--------------- Transceiver52M/Transceiver.h | 20 +++- Transceiver52M/UHDDevice.cpp | 111 +++++++++++++---- Transceiver52M/osmo-trx.cpp | 2 - Transceiver52M/radioClock.cpp | 13 +- Transceiver52M/radioInterface.cpp | 44 +++++-- Transceiver52M/radioInterface.h | 5 +- 8 files changed, 303 insertions(+), 145 deletions(-) hooks/post-receive -- OpenBTS' transceiver retro-fit From gitosis at osmocom.org Fri Jan 9 18:52:12 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 9 Jan 2015 18:52:12 GMT Subject: osmo-trx.git branch staging deleted. 93b7f373097f3b1563ff327ffa163846b8da0987 Message-ID: <201501091852.t09IqCCr055773@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, staging has been deleted was 93b7f373097f3b1563ff327ffa163846b8da0987 ----------------------------------------------------------------------- 93b7f373097f3b1563ff327ffa163846b8da0987 b210: Lock dual-channel tuning access ----------------------------------------------------------------------- hooks/post-receive -- OpenBTS' transceiver retro-fit From gitosis at osmocom.org Sat Jan 10 08:15:54 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 10 Jan 2015 08:15:54 GMT Subject: osmo-bts.git branch master updated. 0.3.0-276-g84e4dd9 Message-ID: <201501100815.t0A8FsiL030005@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 84e4dd92d454cd58e9cbe127c0d969e248f0e588 (commit) via 55da9874c0306516b8f3bb6f1db486a3c9c51fb2 (commit) via d8d5f5904fa83786b01dbf77593232eb6f6954bc (commit) via 9acc82ce4a01d502db1be8cdf15d2328ae181c5c (commit) via c017e309c4d73420a31c32e95aeae30f5e09c161 (commit) via 2e59b20204e2ebcf5baff60774f0fd4ac707404f (commit) via fd425b1484ceac900c02f7d8fcb5fb199ef2bbf6 (commit) via 50131c125e2298cc4f71fa2b69881f6a40a7000a (commit) via 5a03e129a633637d0a6b57b3b5aa6d6596b938fe (commit) from b7ebf545e6cc5eee17df254815c7838fbea61db7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=84e4dd92d454cd58e9cbe127c0d969e248f0e588 commit 84e4dd92d454cd58e9cbe127c0d969e248f0e588 Author: Holger Hans Peter Freyther Date: Fri Jan 9 22:06:28 2015 +0100 sysmobts: Improve some log messages for calib control * Print the GPS FD that was opened (e.g. to see if it was closed again) * Print the state changes/expectations * Print the correct to be applied. I wondered if I shouldo do a cor = cor * -1.. cor = -cor.. or add CLOCK_CORR(err) macro to use it inside the printf and correction and decided the gain is not worth the risk. http://cgit.osmocom.org/osmo-bts/commit/?id=55da9874c0306516b8f3bb6f1db486a3c9c51fb2 commit 55da9874c0306516b8f3bb6f1db486a3c9c51fb2 Author: Holger Hans Peter Freyther Date: Tue Dec 23 11:47:28 2014 +0100 sysmobts: Create a calibration loop that will be run Continously run the calibration process. Everytime we call the reset function classify the outcome. In case of a failure schedule the next command soon and otherwise wait several hours. Remember if the process was started through the VTY or the run loop. In case it can't be started immediately reset and schedule a new run. http://cgit.osmocom.org/osmo-bts/commit/?id=d8d5f5904fa83786b01dbf77593232eb6f6954bc commit d8d5f5904fa83786b01dbf77593232eb6f6954bc Author: Holger Hans Peter Freyther Date: Tue Dec 23 09:45:55 2014 +0100 sysmobts: Start the calibration the first time the link is up After a reboot the system might have been off for a long time and the currently used value might be wrong. Remember that we never ran the calibration and execute it on start. http://cgit.osmocom.org/osmo-bts/commit/?id=9acc82ce4a01d502db1be8cdf15d2328ae181c5c commit 9acc82ce4a01d502db1be8cdf15d2328ae181c5c Author: Holger Hans Peter Freyther Date: Mon Dec 22 18:24:57 2014 +0100 sysmobts: Initial version to use libgps to determine FIX state We should only calibrate the clock if there is a GPS fix. Start gpsd to determine if there is a fix or not. Work around trimble decoding issues (sent an email upstream). We need to gain some more experience to see if there memory leaks. We also need to re-schedule the calibration depending on the outcome. http://cgit.osmocom.org/osmo-bts/commit/?id=c017e309c4d73420a31c32e95aeae30f5e09c161 commit c017e309c4d73420a31c32e95aeae30f5e09c161 Author: Holger Hans Peter Freyther Date: Tue Jan 6 19:11:49 2015 +0100 sysmobts: The correction for GPS is in the reverse direction Change the sign before passing it as correction value. The error is the difference between the TCXO and GPS. We need to correct by the reverse of the error. This seems to be different depending on the clock source we have. This is a last minute untested change. http://cgit.osmocom.org/osmo-bts/commit/?id=2e59b20204e2ebcf5baff60774f0fd4ac707404f commit 2e59b20204e2ebcf5baff60774f0fd4ac707404f Author: Holger Hans Peter Freyther Date: Fri Dec 12 21:54:43 2014 +0100 sysmobts: Use the ctrl interface for calibration This runs the entire procedure for calibration with reasonable error and success checking. It can be triggered from the VTY of the sysmobts-mgr right now. What is missing is to hook up with GPSD to check if the system has a fix and provide a mode that will continously run the calibration command. http://cgit.osmocom.org/osmo-bts/commit/?id=fd425b1484ceac900c02f7d8fcb5fb199ef2bbf6 commit fd425b1484ceac900c02f7d8fcb5fb199ef2bbf6 Author: Holger Hans Peter Freyther Date: Fri Dec 12 19:20:17 2014 +0100 sysmobts: Copy more of l1if_rf_clock_info_reset into the CTRL code The CTRL code should have used/extended the l1_if calibration code. The sysmobts-mgr code first needs to determine if the clock adjustment is necessary at all. This is done by first resetting the counters, then waiting, then asking for the diff and then applying the correction value. But the reference clock is only set by the application comand. Copy more code of l1if_rf_clock_info_reset to set the reference clock as value. This is leaving some todos inside the code that will be resolved as part of SYS#835. Related: SYS#835 http://cgit.osmocom.org/osmo-bts/commit/?id=50131c125e2298cc4f71fa2b69881f6a40a7000a commit 50131c125e2298cc4f71fa2b69881f6a40a7000a Author: Holger Hans Peter Freyther Date: Fri Dec 12 16:59:41 2014 +0100 sysmobts: Begin with calib control from the sysmobts manager In the long run we will connect to GPSD and wait for a fix and then run the calibration. The first step is to open (and re-open) the control connection to the BTS. As the connection is on localhost there should not be a computation overhead to always have the connection open. When connecting assume that the ASYNC connect worked directly as otherwise we get no notification of the failure. This looks like a "bug" of libosmo-abis that should check if the socket has been connected or not. http://cgit.osmocom.org/osmo-bts/commit/?id=5a03e129a633637d0a6b57b3b5aa6d6596b938fe commit 5a03e129a633637d0a6b57b3b5aa6d6596b938fe Author: Holger Hans Peter Freyther Date: Fri Dec 12 16:54:08 2014 +0100 msg: Generalize the message structure test This was taken out of LaF0rge's OML router branch and is now used by the extended calibration feature. ----------------------------------------------------------------------- Summary of changes: configure.ac | 1 + src/common/msg_utils.c | 18 +- src/osmo-bts-sysmo/Makefile.am | 5 +- src/osmo-bts-sysmo/misc/sysmobts_mgr.c | 9 + src/osmo-bts-sysmo/misc/sysmobts_mgr.h | 36 ++ src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c | 538 +++++++++++++++++++++++++++ src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c | 16 + src/osmo-bts-sysmo/sysmobts_ctrl.c | 17 + 8 files changed, 630 insertions(+), 10 deletions(-) create mode 100644 src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sat Jan 10 08:54:42 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 10 Jan 2015 08:54:42 GMT Subject: openbsc.git branch master updated. 0.13.0-832-gbb06eb9 Message-ID: <201501100854.t0A8sgtY033262@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via bb06eb9d7c9c048b5297511b329f0029ecbfd9fc (commit) from a67704753a6328f725d38d61af8bfbe29012fcbc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=bb06eb9d7c9c048b5297511b329f0029ecbfd9fc commit bb06eb9d7c9c048b5297511b329f0029ecbfd9fc Author: Holger Hans Peter Freyther Date: Sat Jan 10 09:51:31 2015 +0100 meas: Unbreak the build once more The code assumes that sqlite3.h is in the standard include path. Maybe sqlite3 wasn't installed or resides in a non standard (/usr/local) location? Fix the build as it has been broken since 1st of January. ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 5 +++++ openbsc/src/utils/Makefile.am | 14 ++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sat Jan 10 12:08:37 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 10 Jan 2015 12:08:37 GMT Subject: osmo-bts.git branch master updated. 0.3.0-277-g7e10bd6 Message-ID: <201501101208.t0AC8btQ049497@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 7e10bd6401916d1768f5b2caaaae1ee35db85735 (commit) from 84e4dd92d454cd58e9cbe127c0d969e248f0e588 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=7e10bd6401916d1768f5b2caaaae1ee35db85735 commit 7e10bd6401916d1768f5b2caaaae1ee35db85735 Author: Holger Hans Peter Freyther Date: Sat Jan 10 13:07:49 2015 +0100 misc: Fix up testcase after 5a03e129a633637d0a6b57b3b5aa6d6596b938fe In 5a03e129a633637d0a6b57b3b5aa6d6596b938fe we generalized the structural parser so we need to update the expected behavior of that routine. ----------------------------------------------------------------------- Summary of changes: tests/misc/misc_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sat Jan 10 13:01:14 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 10 Jan 2015 13:01:14 GMT Subject: gr-osmosdr.git branch master updated. v0.1.4-9-g48045b5 Message-ID: <201501101301.t0AD1ExL054444@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNURadio hardware abstraction block". The branch, master has been updated via 48045b597d3a605d2cb1cd2df62d07317009b9ea (commit) from 46bb1ad1a08b44f9c06dd2bf099731aa3bc0e995 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-osmosdr/commit/?id=48045b597d3a605d2cb1cd2df62d07317009b9ea commit 48045b597d3a605d2cb1cd2df62d07317009b9ea Author: Dimitri Stolnikov Date: Sat Jan 10 14:01:09 2015 +0100 bladerf: include rxvga1 to the BB gain setting Patch provided by Samu Laaja ----------------------------------------------------------------------- Summary of changes: lib/bladerf/bladerf_source_c.cc | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) hooks/post-receive -- GNURadio hardware abstraction block From gitosis at osmocom.org Sat Jan 10 17:13:05 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 10 Jan 2015 17:13:05 GMT Subject: osmo-bts.git branch master updated. 0.3.0-278-g0d69467 Message-ID: <201501101713.t0AHD5vq074825@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 0d6946741c7b5697a58e7650b6e60d495a6cfb32 (commit) from 7e10bd6401916d1768f5b2caaaae1ee35db85735 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=0d6946741c7b5697a58e7650b6e60d495a6cfb32 commit 0d6946741c7b5697a58e7650b6e60d495a6cfb32 Author: Holger Hans Peter Freyther Date: Sat Jan 10 18:06:29 2015 +0100 sysmobts: Check mgr->calib.bts_conn for NULL Check the right variable for NULL. Fixes: CID 1262214 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Jan 11 16:36:58 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 11 Jan 2015 16:36:58 GMT Subject: openbsc.git branch master updated. 0.13.0-837-ga6ddc2d Message-ID: <201501111636.t0BGawX9096216@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via a6ddc2d99f8463edb0b5eacf080db0b5ca571efc (commit) via f3a271fa73ea58a628a51aa310e1da20a5526f31 (commit) via 46684dcfd2d0aadcf63f9493d0d84afe467c7193 (commit) via 0024cee9f84c0f24b70e4bc98756702d5182a20b (commit) via 17fb3d46ffcf48685943cc9dd4a2e80700f4fa64 (commit) from bb06eb9d7c9c048b5297511b329f0029ecbfd9fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=a6ddc2d99f8463edb0b5eacf080db0b5ca571efc commit a6ddc2d99f8463edb0b5eacf080db0b5ca571efc Author: Jacob Erlbeck Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf [hfreyther: Added a msgb_free gprs_subscr_tx_gsup_message] http://cgit.osmocom.org/openbsc/commit/?id=f3a271fa73ea58a628a51aa310e1da20a5526f31 commit f3a271fa73ea58a628a51aa310e1da20a5526f31 Author: Jacob Erlbeck Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=46684dcfd2d0aadcf63f9493d0d84afe467c7193 commit 46684dcfd2d0aadcf63f9493d0d84afe467c7193 Author: Jacob Erlbeck Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0024cee9f84c0f24b70e4bc98756702d5182a20b commit 0024cee9f84c0f24b70e4bc98756702d5182a20b Author: Jacob Erlbeck Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=17fb3d46ffcf48685943cc9dd4a2e80700f4fa64 commit 17fb3d46ffcf48685943cc9dd4a2e80700f4fa64 Author: Jacob Erlbeck Date: Mon Jan 5 09:43:51 2015 +0100 sgsn: Fix VTY command error handling (Coverity) Currently the result of the osmo_hexparse function in update_subscr_insert_auth_triplet is not handled correctly. There is a misplaced leading exclamation mark in a few conditional expressions. This effectively disables the error checks, as it is noticed by Coverity ("Missing parentheses" followed by "Logically dead code"). This patch removes the exclamation marks. Fixes: Coverity CID 1260435 and CID 1260434 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 391 ++++++++++++++++++++++++++ openbsc/include/openbsc/Makefile.am | 2 +- openbsc/include/openbsc/gprs_gsup_messages.h | 103 +++++++ openbsc/include/openbsc/gprs_sgsn.h | 1 + openbsc/src/gprs/Makefile.am | 3 +- openbsc/src/gprs/gprs_gsup_messages.c | 405 +++++++++++++++++++++++++++ openbsc/src/gprs/gprs_subscriber.c | 211 +++++++++++++- openbsc/src/gprs/sgsn_vty.c | 6 +- openbsc/tests/gprs/Makefile.am | 6 +- openbsc/tests/gprs/gprs_test.c | 137 +++++++++ openbsc/tests/gprs/gprs_test.ok | 10 + openbsc/tests/sgsn/Makefile.am | 2 + openbsc/tests/sgsn/sgsn_test.c | 165 +++++++++++ openbsc/tests/sgsn/sgsn_test.ok | 1 + 14 files changed, 1430 insertions(+), 13 deletions(-) create mode 100644 openbsc/doc/sgsn-remote-protocol.txt create mode 100644 openbsc/include/openbsc/gprs_gsup_messages.h create mode 100644 openbsc/src/gprs/gprs_gsup_messages.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 13 15:56:31 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 13 Jan 2015 15:56:31 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-877-g2eb4ee2 Message-ID: <201501131556.t0DFuV3h071960@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards e2e2ef39a05b6840b6670ca8e1f1d889bafffdb6 (commit) discards b706933bd9cdf89bbe5b12d1b2541c1893a6537e (commit) discards b9f5f4df87870041fc9e986ab841b6221e0a77f2 (commit) discards 7ba4fa5066c39d03c6f760d0f1f618d92ef90b07 (commit) discards 38fa6bf2cec58ec5ef3be16ec14424ed5a96674c (commit) discards 3bf946c49d9a21dafca29b990a856e61cadaff91 (commit) discards 3d7b2e6a26c54ebf38f9b30e00a73ec1f040e245 (commit) discards 4872cdfa622889444854f76cc9bc4ddb97a6d0dc (commit) discards 18391a453805bc14748bbd313273bf2b585145c7 (commit) discards 515fdd662b120f5afc46345cd1be6592c852671b (commit) discards c87fa1b94435a51ade34ea99b5ef39135e309275 (commit) discards d39fe2f96d7cea3250be82abcdef6333e9422f67 (commit) discards 33de2ebc61bad4973f64e1dc07478393cf66f783 (commit) discards c52716e55d3ba88173c3feb47a3233c4aa69e92b (commit) discards 52a5229ca8b55ee804a7a911512af8617e21c5da (commit) discards 93d39583080a58fb16597ecc341a1ce32ad38d7a (commit) discards f8f8fba629ed6b861dacb1f997c9f28d83a162e0 (commit) discards 67014fd5657394534326c99554f89ec85970e509 (commit) discards e8978ac39c5e96877960f0df07644efc8a0bc321 (commit) discards 5428ff90b1260769cc918a585abdb1c292d67f7f (commit) discards 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 (commit) discards 6231ed289064f453b5d2bb56d70afe7a992dfe77 (commit) discards 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 (commit) discards 65f35a28038ec7ed310a2fca5015b3018c5455e8 (commit) discards 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 (commit) discards 45292a23631fdb943c7aaec0dc1d1af2ce013792 (commit) discards 424d584f82f8240c1325ca25ed186f446997de58 (commit) discards 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 (commit) discards 3d0895483f0d543af485413dedb40294b0efd9b4 (commit) discards 79571191f2c526e18dc1257a3273a7235582d2a6 (commit) discards ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 (commit) discards 9f2e178f07b7d15733e862fca7c140b1475899ee (commit) discards 847bf670e354fbd11bedbadf63deb0577a0a380b (commit) discards 62068f8848f5c851a06053265b311dca9042b103 (commit) discards 2ad5544bee5062301797a86a6adb44513abe27d2 (commit) discards 5636470b9fa12827e190f3f38386f2824edfcf61 (commit) discards 4e8a698c1173d71f9e0ee6eef182f5884c181493 (commit) via 2eb4ee28fce464f60231209d4cacfa18400ac9a6 (commit) via 11c8dcd10f3fd98f054ef2918d49798274ffbfd8 (commit) via f09050db39ea04dfa67e3595a3b41f7a59661c03 (commit) via 872b45b49b8620d114d38cfb7d170f78b316e24b (commit) via f17c812f882a37bda959118cace5c9c2a1cc3d62 (commit) via f75a490a5bc0d36803593add58a7fc8f1368c7d0 (commit) via 829f83d5e77d59706e39268f73109db1321ee6e8 (commit) via 6fc9f67182d4c77e77d51dc89f5b1a8e19df7431 (commit) via 84063c3aaf55626231ba2a392d52709919a33ee1 (commit) via 339e30b1401efe55b7412876bfb1ced493a5f0fa (commit) via fee76dc614eb42e341bf2f7604c0735b59830f37 (commit) via b331205e1d4ad569563900520632b4d3493be721 (commit) via d1e0a4229184ee84114060c0ab0f948689a32917 (commit) via 78318bc48628e616e06f3ae4a852816576fa32e0 (commit) via 861ae1d2e82e19432bdec6659df1b0f092ba6b92 (commit) via 0e73459fb2d544f09f6819560477ba63a8216912 (commit) via 27f69157b043394425e4a885be646d8e6439d62b (commit) via 285ee97c76471cef0f4af747b3357f794785ca6d (commit) via af3014f08ec7412ad54b90252579adc86b9ae99c (commit) via 343b6c9bc5eb60ec838351c3a72ce13cc5e0eb51 (commit) via 35961439f25e09653ebd0192634235d397914b95 (commit) via d52aa3ae5ceef7ef3a943c0d9835d08c7bea06cb (commit) via 1ce3ecbb31b5883bd72c56ac4b280e094bfe5ccf (commit) via bbb44231295c3d0dc03c2461e4660028956be03e (commit) via 12173e836bef5821e8ac95cbb2a84b76ca295c45 (commit) via c82af7ed9b976783fdc6245e1e6bd86527529d79 (commit) via 0bededf3fe61fe25af2c130e47ebb0f2cd2a36c4 (commit) via ed2e4de87f8e6468592146df63e92fe63cae5d6d (commit) via f0c08a363f6c8e84dcc4117c7108ff27159fa50a (commit) via 9c344c709536551f2a632d4872c26a7a1c32b685 (commit) via af2030b4ff24914fe62a8149447f7c914f62185d (commit) via 997ec59c14f6d5a68cf344d4a4e96d304d8578dc (commit) via a278ef42ac38d3f2945c27763063d6ace84d29f1 (commit) via 09ebc580c02c361076d1df9678913b800eb441da (commit) via 75973f7cf58d9011666a264f1a60f0c31f4a76fc (commit) via fd0134c8622110678b524ebeb6d889b68d0639c7 (commit) via 3a6aa7f3b7e74bd7ed9089bddb81bd91cd948d81 (commit) via d3e7137cc2168ec99e4de7a31f481cce6a76da09 (commit) via 74cd902cb970e64f25456f81b1c7899b15b53c4e (commit) via 6a7288c1d6779bf83f005f19f12e446ca17e24b6 (commit) via a6ddc2d99f8463edb0b5eacf080db0b5ca571efc (commit) via f3a271fa73ea58a628a51aa310e1da20a5526f31 (commit) via 46684dcfd2d0aadcf63f9493d0d84afe467c7193 (commit) via 0024cee9f84c0f24b70e4bc98756702d5182a20b (commit) via 17fb3d46ffcf48685943cc9dd4a2e80700f4fa64 (commit) via bb06eb9d7c9c048b5297511b329f0029ecbfd9fc (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (e2e2ef39a05b6840b6670ca8e1f1d889bafffdb6) \ N -- N -- N (2eb4ee28fce464f60231209d4cacfa18400ac9a6) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=2eb4ee28fce464f60231209d4cacfa18400ac9a6 commit 2eb4ee28fce464f60231209d4cacfa18400ac9a6 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=11c8dcd10f3fd98f054ef2918d49798274ffbfd8 commit 11c8dcd10f3fd98f054ef2918d49798274ffbfd8 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f09050db39ea04dfa67e3595a3b41f7a59661c03 commit f09050db39ea04dfa67e3595a3b41f7a59661c03 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=872b45b49b8620d114d38cfb7d170f78b316e24b commit 872b45b49b8620d114d38cfb7d170f78b316e24b Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f17c812f882a37bda959118cace5c9c2a1cc3d62 commit f17c812f882a37bda959118cace5c9c2a1cc3d62 Author: Jacob Erlbeck Date: Tue Jan 13 11:56:28 2015 +0100 gprs: Fix GSUP msgb freeing Currently the code relies on the lower layers (socket read) to free the msgb after the callbacks have been processed linke it is being done in the NS layer. Unfortunately the IPA client connection implementation does this differently so the current msgb handling in the GSUP related code in broken at the moment and leaks msgbs. This patch adds missing calls to msgb_free. The talloc report in sgsn_test no longer contains msgbs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f75a490a5bc0d36803593add58a7fc8f1368c7d0 commit f75a490a5bc0d36803593add58a7fc8f1368c7d0 Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect leakage This commit adds talloc reports to log remaining chunks after the testing has been finished. It also adds explicit checks for an empty subscriber list. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=829f83d5e77d59706e39268f73109db1321ee6e8 commit 829f83d5e77d59706e39268f73109db1321ee6e8 Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6fc9f67182d4c77e77d51dc89f5b1a8e19df7431 commit 6fc9f67182d4c77e77d51dc89f5b1a8e19df7431 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=84063c3aaf55626231ba2a392d52709919a33ee1 commit 84063c3aaf55626231ba2a392d52709919a33ee1 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=339e30b1401efe55b7412876bfb1ced493a5f0fa commit 339e30b1401efe55b7412876bfb1ced493a5f0fa Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fee76dc614eb42e341bf2f7604c0735b59830f37 commit fee76dc614eb42e341bf2f7604c0735b59830f37 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages (TODO) When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies, if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. TODO: - commit message - expire ununsed MM contexts (other commit) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b331205e1d4ad569563900520632b4d3493be721 commit b331205e1d4ad569563900520632b4d3493be721 Author: Jacob Erlbeck Date: Fri Jan 9 15:07:16 2015 +0100 sgsn/test: Add test that intercepts gprs_gsup_client_send This test replaces gprs_gsup_client_send by a custom function, that emulates a GSUP remote peer by calling gprs_subscr_rx_gsup_message with responses for all requests. It then executes a full Attach/Detach cycle. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d1e0a4229184ee84114060c0ab0f948689a32917 commit d1e0a4229184ee84114060c0ab0f948689a32917 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=78318bc48628e616e06f3ae4a852816576fa32e0 commit 78318bc48628e616e06f3ae4a852816576fa32e0 Author: Jacob Erlbeck Date: Fri Jan 9 11:59:50 2015 +0100 sgsn/test: Refactor subscriber test The code sequence that checks, whether a subscriber is still reachable for a given IMSI, is repeated several times. This patch puts this code sequence into a single function and adds a check for the IMSI after the entry has been found. In addition, some comments are extended. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=861ae1d2e82e19432bdec6659df1b0f092ba6b92 commit 861ae1d2e82e19432bdec6659df1b0f092ba6b92 Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0e73459fb2d544f09f6819560477ba63a8216912 commit 0e73459fb2d544f09f6819560477ba63a8216912 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=27f69157b043394425e4a885be646d8e6439d62b commit 27f69157b043394425e4a885be646d8e6439d62b Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=285ee97c76471cef0f4af747b3357f794785ca6d commit 285ee97c76471cef0f4af747b3357f794785ca6d Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGGSUBSCRP and LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages in gprs_subscriber.c, this patch replaces each LOGP by LOGGSUBSCRP, unless a non-NULL pointer to a subscr is not available. In those cases, it uses LOGMMCTXP if a pointer to an MM context is available or LOGP otherwise. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=af3014f08ec7412ad54b90252579adc86b9ae99c commit af3014f08ec7412ad54b90252579adc86b9ae99c Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add LOGGSUBSCRP macro to log subscriber info This patch adds a new logging macro, that logs to DGPRS and provides a uniform prefix containing the IMSI without using the mm reference. This is an improvement over using LOGMMCTXP, since the new macro also provides an IMSI if no MM context is attached. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=343b6c9bc5eb60ec838351c3a72ce13cc5e0eb51 commit 343b6c9bc5eb60ec838351c3a72ce13cc5e0eb51 Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=35961439f25e09653ebd0192634235d397914b95 commit 35961439f25e09653ebd0192634235d397914b95 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d52aa3ae5ceef7ef3a943c0d9835d08c7bea06cb commit d52aa3ae5ceef7ef3a943c0d9835d08c7bea06cb Author: Jacob Erlbeck Date: Mon Jan 5 17:51:17 2015 +0100 gprs: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1ce3ecbb31b5883bd72c56ac4b280e094bfe5ccf commit 1ce3ecbb31b5883bd72c56ac4b280e094bfe5ccf Author: Jacob Erlbeck Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bbb44231295c3d0dc03c2461e4660028956be03e commit bbb44231295c3d0dc03c2461e4660028956be03e Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=12173e836bef5821e8ac95cbb2a84b76ca295c45 commit 12173e836bef5821e8ac95cbb2a84b76ca295c45 Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c82af7ed9b976783fdc6245e1e6bd86527529d79 commit c82af7ed9b976783fdc6245e1e6bd86527529d79 Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0bededf3fe61fe25af2c130e47ebb0f2cd2a36c4 commit 0bededf3fe61fe25af2c130e47ebb0f2cd2a36c4 Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ed2e4de87f8e6468592146df63e92fe63cae5d6d commit ed2e4de87f8e6468592146df63e92fe63cae5d6d Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f0c08a363f6c8e84dcc4117c7108ff27159fa50a commit f0c08a363f6c8e84dcc4117c7108ff27159fa50a Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9c344c709536551f2a632d4872c26a7a1c32b685 commit 9c344c709536551f2a632d4872c26a7a1c32b685 Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=af2030b4ff24914fe62a8149447f7c914f62185d commit af2030b4ff24914fe62a8149447f7c914f62185d Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=997ec59c14f6d5a68cf344d4a4e96d304d8578dc commit 997ec59c14f6d5a68cf344d4a4e96d304d8578dc Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a278ef42ac38d3f2945c27763063d6ace84d29f1 commit a278ef42ac38d3f2945c27763063d6ace84d29f1 Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09ebc580c02c361076d1df9678913b800eb441da commit 09ebc580c02c361076d1df9678913b800eb441da Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=75973f7cf58d9011666a264f1a60f0c31f4a76fc commit 75973f7cf58d9011666a264f1a60f0c31f4a76fc Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fd0134c8622110678b524ebeb6d889b68d0639c7 commit fd0134c8622110678b524ebeb6d889b68d0639c7 Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3a6aa7f3b7e74bd7ed9089bddb81bd91cd948d81 commit 3a6aa7f3b7e74bd7ed9089bddb81bd91cd948d81 Author: Jacob Erlbeck Date: Mon Jan 12 13:54:39 2015 +0100 gprs: Clear GSUP message structures before decoding Currently the message structure is not cleared before the message is parsed which can cause information leaking between messages if the same gprs_gsup_message object is used. Especially list elements (auth tuples and pdp info) are not replaced by an IE, but the IE is appended. This patch uses the assignment operator to clear gprs_gsup_message, gsm_auth_tuple, and gprs_gsup_pdp_info before using them. This also replaces the use of memcpy of the latter. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d3e7137cc2168ec99e4de7a31f481cce6a76da09 commit d3e7137cc2168ec99e4de7a31f481cce6a76da09 Author: Jacob Erlbeck Date: Mon Jan 12 13:39:15 2015 +0100 gprs: Always reset auth tuples/pdp infos in gprs_gsup_decode Currently auth tuples are always appended to the lists when gprs_gsup_decode is called with a gsup_msg structure. This makes a test case fail, where the same gsup_msg is used again and again without clearing it after each use. Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=74cd902cb970e64f25456f81b1c7899b15b53c4e commit 74cd902cb970e64f25456f81b1c7899b15b53c4e Author: Jacob Erlbeck Date: Mon Jan 12 13:23:05 2015 +0100 gprs: Handle empty GSUP messages correctly Currently, the gprs_gsup_decode function doesn't check the return value of gprs_shift_v_fixed before using the value pointer. The function fails, if the GSUP message length (not including IPA headers) is 0. In this case, a segfault can happen, depending on the value of the uninitialized 'value' pointer. The test case doesn't trigger a segfault, but valgrind complains about reading uninitialized data. This patch adds a check for the return value that would return with an error code if the shift function failed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6a7288c1d6779bf83f005f19f12e446ca17e24b6 commit 6a7288c1d6779bf83f005f19f12e446ca17e24b6 Author: Jacob Erlbeck Date: Mon Jan 12 11:14:18 2015 +0100 gprs/test: Add tests for invalid GSUP messages Currently, the tests only use valid GSUP messages. This does not check the robustness of the parser. This commit adds a test for truncated messages and another for modified messages. Thanks to Holger for the basic truncation test. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 5 + openbsc/src/gprs/gprs_gsup_client.c | 17 ++- openbsc/src/gprs/gprs_gsup_messages.c | 18 ++- openbsc/src/gprs/gprs_subscriber.c | 15 ++- openbsc/src/utils/Makefile.am | 14 ++- openbsc/tests/gprs/gprs_test.c | 92 +++++++++++++++ openbsc/tests/sgsn/Makefile.am | 3 +- openbsc/tests/sgsn/sgsn_test.c | 209 ++++++++++++++++++++++++++++++---- openbsc/tests/sgsn/sgsn_test.ok | 1 + 9 files changed, 330 insertions(+), 44 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 13 16:23:12 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 13 Jan 2015 16:23:12 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-877-gfc37625 Message-ID: <201501131623.t0DGNCxY074546@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 2eb4ee28fce464f60231209d4cacfa18400ac9a6 (commit) discards 11c8dcd10f3fd98f054ef2918d49798274ffbfd8 (commit) discards f09050db39ea04dfa67e3595a3b41f7a59661c03 (commit) discards 872b45b49b8620d114d38cfb7d170f78b316e24b (commit) discards f17c812f882a37bda959118cace5c9c2a1cc3d62 (commit) discards f75a490a5bc0d36803593add58a7fc8f1368c7d0 (commit) discards 829f83d5e77d59706e39268f73109db1321ee6e8 (commit) discards 6fc9f67182d4c77e77d51dc89f5b1a8e19df7431 (commit) discards 84063c3aaf55626231ba2a392d52709919a33ee1 (commit) discards 339e30b1401efe55b7412876bfb1ced493a5f0fa (commit) discards fee76dc614eb42e341bf2f7604c0735b59830f37 (commit) discards b331205e1d4ad569563900520632b4d3493be721 (commit) discards d1e0a4229184ee84114060c0ab0f948689a32917 (commit) discards 78318bc48628e616e06f3ae4a852816576fa32e0 (commit) discards 861ae1d2e82e19432bdec6659df1b0f092ba6b92 (commit) discards 0e73459fb2d544f09f6819560477ba63a8216912 (commit) discards 27f69157b043394425e4a885be646d8e6439d62b (commit) discards 285ee97c76471cef0f4af747b3357f794785ca6d (commit) discards af3014f08ec7412ad54b90252579adc86b9ae99c (commit) discards 343b6c9bc5eb60ec838351c3a72ce13cc5e0eb51 (commit) discards 35961439f25e09653ebd0192634235d397914b95 (commit) discards d52aa3ae5ceef7ef3a943c0d9835d08c7bea06cb (commit) discards 1ce3ecbb31b5883bd72c56ac4b280e094bfe5ccf (commit) discards bbb44231295c3d0dc03c2461e4660028956be03e (commit) discards 12173e836bef5821e8ac95cbb2a84b76ca295c45 (commit) discards c82af7ed9b976783fdc6245e1e6bd86527529d79 (commit) discards 0bededf3fe61fe25af2c130e47ebb0f2cd2a36c4 (commit) discards ed2e4de87f8e6468592146df63e92fe63cae5d6d (commit) discards f0c08a363f6c8e84dcc4117c7108ff27159fa50a (commit) discards 9c344c709536551f2a632d4872c26a7a1c32b685 (commit) discards af2030b4ff24914fe62a8149447f7c914f62185d (commit) discards 997ec59c14f6d5a68cf344d4a4e96d304d8578dc (commit) discards a278ef42ac38d3f2945c27763063d6ace84d29f1 (commit) discards 09ebc580c02c361076d1df9678913b800eb441da (commit) discards 75973f7cf58d9011666a264f1a60f0c31f4a76fc (commit) via fc376259e0a306d41e17cab43de7c2a4796f9aba (commit) via bf5805ff4d5e0433185811a359baccc2e73f32ce (commit) via f567963a36a541a46bd226632c7368c3d507c064 (commit) via 147cf8a851eedf117450541ba068ced3f802f1dc (commit) via d06b20c0a9e171ba9143d73e882c44c3b9b0744d (commit) via 93a0fcd78a9e2d0c7fdf9ad90be3f41619ce5c2e (commit) via c7c48fa68cd9e4790c9883b0f6031bd73a2dd737 (commit) via 8dec82b096df85227171eea0d34cf6cfbea3724e (commit) via 50a0d6984536691466b6154288ddc83f1defae9c (commit) via 249a5375c66e1d3560218eeedbc7a1c524673275 (commit) via bd4d5bb2c921e7e6333019fda885430ebd3aa3df (commit) via a5b9ea754883d2d7a547ba4b2da7c3fb8c40efc0 (commit) via f47dc130732e3a29fc729d9f859231646c5cac6c (commit) via 43e71d624c7be3cce2cec7cb419f8b4129977a9e (commit) via f1393090b4a164bb480f45cce9f8ab54b1bc6089 (commit) via 1636e5f607325fb2cf0fa39c7c51eea0df49a9a3 (commit) via 9c420d46836a7bee7dbb74b75763c92a7ee1d6ad (commit) via a5a1af953fefa425b7a1611dab0ab67f8fe9285d (commit) via 9d3c9d60d842bf053a1481703c9615bac0312295 (commit) via 4fc87b30c4dda8c6897b148bb0d9e400c8e22c4f (commit) via 1fcb2dca60a43cffedb9e40fca13e86a1832b7b4 (commit) via 866eb9fbc5711a66538fb5da2ac2238c9b035116 (commit) via 287cf4ee746ff1eb49eea52858de7304b1735b87 (commit) via df61af7043081b1a20646dec088677b09d67fa78 (commit) via a77c6904227149fdea29b8ed27ac3dddf2e9cf47 (commit) via b13a67d78b35170fed891413569b203c8b63c8a5 (commit) via 48abb3007302f2dab329e301bbabcb75782b3a4a (commit) via af5d51b0f6494f4b222880abef35cc696e52a013 (commit) via 1fdcbf613508ededda08689db16c2785de614d96 (commit) via 7c83c0e1c4670ba2c70b3093b4135f4a8ba31ed1 (commit) via c3c9c3277519a1ed70f3bf4d3d5ae5872cd24c7a (commit) via 771f20df7863d8d805000c19db24ed1e6754e16d (commit) via e2e60dac618a28a80786d9d29597852e5fab52b5 (commit) via 2159e39353aa5b30b8844921e5987df83b696630 (commit) via c33fcd7a33d13c5cf15d0b378dc46884e7c01e59 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (2eb4ee28fce464f60231209d4cacfa18400ac9a6) \ N -- N -- N (fc376259e0a306d41e17cab43de7c2a4796f9aba) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=fc376259e0a306d41e17cab43de7c2a4796f9aba commit fc376259e0a306d41e17cab43de7c2a4796f9aba Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bf5805ff4d5e0433185811a359baccc2e73f32ce commit bf5805ff4d5e0433185811a359baccc2e73f32ce Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f567963a36a541a46bd226632c7368c3d507c064 commit f567963a36a541a46bd226632c7368c3d507c064 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=147cf8a851eedf117450541ba068ced3f802f1dc commit 147cf8a851eedf117450541ba068ced3f802f1dc Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d06b20c0a9e171ba9143d73e882c44c3b9b0744d commit d06b20c0a9e171ba9143d73e882c44c3b9b0744d Author: Jacob Erlbeck Date: Tue Jan 13 11:56:28 2015 +0100 gprs: Fix GSUP msgb freeing Currently the code relies on the lower layers (socket read) to free the msgb after the callbacks have been processed linke it is being done in the NS layer. Unfortunately the IPA client connection implementation does this differently so the current msgb handling in the GSUP related code in broken at the moment and leaks msgbs. This patch adds missing calls to msgb_free. The talloc report in sgsn_test no longer contains msgbs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=93a0fcd78a9e2d0c7fdf9ad90be3f41619ce5c2e commit 93a0fcd78a9e2d0c7fdf9ad90be3f41619ce5c2e Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect leakage This commit adds talloc reports to log remaining chunks after the testing has been finished. It also adds explicit checks for an empty subscriber list. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c7c48fa68cd9e4790c9883b0f6031bd73a2dd737 commit c7c48fa68cd9e4790c9883b0f6031bd73a2dd737 Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8dec82b096df85227171eea0d34cf6cfbea3724e commit 8dec82b096df85227171eea0d34cf6cfbea3724e Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=50a0d6984536691466b6154288ddc83f1defae9c commit 50a0d6984536691466b6154288ddc83f1defae9c Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=249a5375c66e1d3560218eeedbc7a1c524673275 commit 249a5375c66e1d3560218eeedbc7a1c524673275 Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bd4d5bb2c921e7e6333019fda885430ebd3aa3df commit bd4d5bb2c921e7e6333019fda885430ebd3aa3df Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages (TODO) When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies, if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. TODO: - commit message - expire ununsed MM contexts (other commit) Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a5b9ea754883d2d7a547ba4b2da7c3fb8c40efc0 commit a5b9ea754883d2d7a547ba4b2da7c3fb8c40efc0 Author: Jacob Erlbeck Date: Fri Jan 9 15:07:16 2015 +0100 sgsn/test: Add test that intercepts gprs_gsup_client_send This test replaces gprs_gsup_client_send by a custom function, that emulates a GSUP remote peer by calling gprs_subscr_rx_gsup_message with responses for all requests. It then executes a full Attach/Detach cycle. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f47dc130732e3a29fc729d9f859231646c5cac6c commit f47dc130732e3a29fc729d9f859231646c5cac6c Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=43e71d624c7be3cce2cec7cb419f8b4129977a9e commit 43e71d624c7be3cce2cec7cb419f8b4129977a9e Author: Jacob Erlbeck Date: Fri Jan 9 11:59:50 2015 +0100 sgsn/test: Refactor subscriber test The code sequence that checks, whether a subscriber is still reachable for a given IMSI, is repeated several times. This patch puts this code sequence into a single function and adds a check for the IMSI after the entry has been found. In addition, some comments are extended. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f1393090b4a164bb480f45cce9f8ab54b1bc6089 commit f1393090b4a164bb480f45cce9f8ab54b1bc6089 Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1636e5f607325fb2cf0fa39c7c51eea0df49a9a3 commit 1636e5f607325fb2cf0fa39c7c51eea0df49a9a3 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9c420d46836a7bee7dbb74b75763c92a7ee1d6ad commit 9c420d46836a7bee7dbb74b75763c92a7ee1d6ad Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a5a1af953fefa425b7a1611dab0ab67f8fe9285d commit a5a1af953fefa425b7a1611dab0ab67f8fe9285d Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGGSUBSCRP and LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages in gprs_subscriber.c, this patch replaces each LOGP by LOGGSUBSCRP, unless a non-NULL pointer to a subscr is not available. In those cases, it uses LOGMMCTXP if a pointer to an MM context is available or LOGP otherwise. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9d3c9d60d842bf053a1481703c9615bac0312295 commit 9d3c9d60d842bf053a1481703c9615bac0312295 Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add LOGGSUBSCRP macro to log subscriber info This patch adds a new logging macro, that logs to DGPRS and provides a uniform prefix containing the IMSI without using the mm reference. This is an improvement over using LOGMMCTXP, since the new macro also provides an IMSI if no MM context is attached. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4fc87b30c4dda8c6897b148bb0d9e400c8e22c4f commit 4fc87b30c4dda8c6897b148bb0d9e400c8e22c4f Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1fcb2dca60a43cffedb9e40fca13e86a1832b7b4 commit 1fcb2dca60a43cffedb9e40fca13e86a1832b7b4 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=866eb9fbc5711a66538fb5da2ac2238c9b035116 commit 866eb9fbc5711a66538fb5da2ac2238c9b035116 Author: Jacob Erlbeck Date: Mon Jan 5 17:51:17 2015 +0100 gprs: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=287cf4ee746ff1eb49eea52858de7304b1735b87 commit 287cf4ee746ff1eb49eea52858de7304b1735b87 Author: Jacob Erlbeck Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=df61af7043081b1a20646dec088677b09d67fa78 commit df61af7043081b1a20646dec088677b09d67fa78 Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a77c6904227149fdea29b8ed27ac3dddf2e9cf47 commit a77c6904227149fdea29b8ed27ac3dddf2e9cf47 Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b13a67d78b35170fed891413569b203c8b63c8a5 commit b13a67d78b35170fed891413569b203c8b63c8a5 Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=48abb3007302f2dab329e301bbabcb75782b3a4a commit 48abb3007302f2dab329e301bbabcb75782b3a4a Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=af5d51b0f6494f4b222880abef35cc696e52a013 commit af5d51b0f6494f4b222880abef35cc696e52a013 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1fdcbf613508ededda08689db16c2785de614d96 commit 1fdcbf613508ededda08689db16c2785de614d96 Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7c83c0e1c4670ba2c70b3093b4135f4a8ba31ed1 commit 7c83c0e1c4670ba2c70b3093b4135f4a8ba31ed1 Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c3c9c3277519a1ed70f3bf4d3d5ae5872cd24c7a commit c3c9c3277519a1ed70f3bf4d3d5ae5872cd24c7a Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=771f20df7863d8d805000c19db24ed1e6754e16d commit 771f20df7863d8d805000c19db24ed1e6754e16d Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e2e60dac618a28a80786d9d29597852e5fab52b5 commit e2e60dac618a28a80786d9d29597852e5fab52b5 Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2159e39353aa5b30b8844921e5987df83b696630 commit 2159e39353aa5b30b8844921e5987df83b696630 Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c33fcd7a33d13c5cf15d0b378dc46884e7c01e59 commit c33fcd7a33d13c5cf15d0b378dc46884e7c01e59 Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Ticket: OW#1338 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 13 16:39:12 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 13 Jan 2015 16:39:12 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-877-g89b5af1 Message-ID: <201501131639.t0DGdCcA075858@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards fc376259e0a306d41e17cab43de7c2a4796f9aba (commit) discards bf5805ff4d5e0433185811a359baccc2e73f32ce (commit) discards f567963a36a541a46bd226632c7368c3d507c064 (commit) discards 147cf8a851eedf117450541ba068ced3f802f1dc (commit) discards d06b20c0a9e171ba9143d73e882c44c3b9b0744d (commit) discards 93a0fcd78a9e2d0c7fdf9ad90be3f41619ce5c2e (commit) discards c7c48fa68cd9e4790c9883b0f6031bd73a2dd737 (commit) discards 8dec82b096df85227171eea0d34cf6cfbea3724e (commit) discards 50a0d6984536691466b6154288ddc83f1defae9c (commit) discards 249a5375c66e1d3560218eeedbc7a1c524673275 (commit) discards bd4d5bb2c921e7e6333019fda885430ebd3aa3df (commit) discards a5b9ea754883d2d7a547ba4b2da7c3fb8c40efc0 (commit) discards f47dc130732e3a29fc729d9f859231646c5cac6c (commit) via 89b5af1f8d450e039602030d06ea6b0bd62925a2 (commit) via 488cc66679e20973fc85c4bc9a39eacf46548f80 (commit) via 51d8be51f7a4c099a72a5ebc025f3daf8710918d (commit) via cfe222efff4a215043b6828d246b433e2faa0710 (commit) via 71e61686c3a469f057636eec6ff2003affdbe1c1 (commit) via c20303e00196a96b08d5be4e716774983ea92fce (commit) via 328c5c1d40aecfe2c72e352d0d6beda4b7c86f86 (commit) via 5355202011c9ac4a751608ecdb7d825c7f335d1e (commit) via 7ed031b2c876d8c2ab1471d27569131c683011ee (commit) via 77057d0820690d6f67716670ff94b240b370c118 (commit) via 157392a168916b6828676d53d943b099e0d0708d (commit) via 0df73b1093c7d720cc64fa967a2268a13a929c72 (commit) via aee0cdc4db6d34855597ebe7e09abc647d8e692e (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (fc376259e0a306d41e17cab43de7c2a4796f9aba) \ N -- N -- N (89b5af1f8d450e039602030d06ea6b0bd62925a2) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=89b5af1f8d450e039602030d06ea6b0bd62925a2 commit 89b5af1f8d450e039602030d06ea6b0bd62925a2 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=488cc66679e20973fc85c4bc9a39eacf46548f80 commit 488cc66679e20973fc85c4bc9a39eacf46548f80 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=51d8be51f7a4c099a72a5ebc025f3daf8710918d commit 51d8be51f7a4c099a72a5ebc025f3daf8710918d Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cfe222efff4a215043b6828d246b433e2faa0710 commit cfe222efff4a215043b6828d246b433e2faa0710 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=71e61686c3a469f057636eec6ff2003affdbe1c1 commit 71e61686c3a469f057636eec6ff2003affdbe1c1 Author: Jacob Erlbeck Date: Tue Jan 13 11:56:28 2015 +0100 gprs: Fix GSUP msgb freeing Currently the code relies on the lower layers (socket read) to free the msgb after the callbacks have been processed linke it is being done in the NS layer. Unfortunately the IPA client connection implementation does this differently so the current msgb handling in the GSUP related code in broken at the moment and leaks msgbs. This patch adds missing calls to msgb_free. The talloc report in sgsn_test no longer contains msgbs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c20303e00196a96b08d5be4e716774983ea92fce commit c20303e00196a96b08d5be4e716774983ea92fce Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect leakage This commit adds talloc reports to log remaining chunks after the testing has been finished. It also adds explicit checks for an empty subscriber list. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=328c5c1d40aecfe2c72e352d0d6beda4b7c86f86 commit 328c5c1d40aecfe2c72e352d0d6beda4b7c86f86 Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5355202011c9ac4a751608ecdb7d825c7f335d1e commit 5355202011c9ac4a751608ecdb7d825c7f335d1e Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7ed031b2c876d8c2ab1471d27569131c683011ee commit 7ed031b2c876d8c2ab1471d27569131c683011ee Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=77057d0820690d6f67716670ff94b240b370c118 commit 77057d0820690d6f67716670ff94b240b370c118 Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=157392a168916b6828676d53d943b099e0d0708d commit 157392a168916b6828676d53d943b099e0d0708d Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0df73b1093c7d720cc64fa967a2268a13a929c72 commit 0df73b1093c7d720cc64fa967a2268a13a929c72 Author: Jacob Erlbeck Date: Fri Jan 9 15:07:16 2015 +0100 sgsn/test: Add test that intercepts gprs_gsup_client_send This test replaces gprs_gsup_client_send by a custom function, that emulates a GSUP remote peer by calling gprs_subscr_rx_gsup_message with responses for all requests. It then executes a full Attach/Detach cycle. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=aee0cdc4db6d34855597ebe7e09abc647d8e692e commit aee0cdc4db6d34855597ebe7e09abc647d8e692e Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. Note that unused MM contexts are not expired yet. Therefore the subscriber will only be expired after a successful MM detach. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 14 10:28:30 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 14 Jan 2015 10:28:30 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-878-g64d0007 Message-ID: <201501141028.t0EASUk1070579@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 89b5af1f8d450e039602030d06ea6b0bd62925a2 (commit) discards 488cc66679e20973fc85c4bc9a39eacf46548f80 (commit) discards 51d8be51f7a4c099a72a5ebc025f3daf8710918d (commit) discards cfe222efff4a215043b6828d246b433e2faa0710 (commit) discards 71e61686c3a469f057636eec6ff2003affdbe1c1 (commit) discards c20303e00196a96b08d5be4e716774983ea92fce (commit) discards 328c5c1d40aecfe2c72e352d0d6beda4b7c86f86 (commit) discards 5355202011c9ac4a751608ecdb7d825c7f335d1e (commit) discards 7ed031b2c876d8c2ab1471d27569131c683011ee (commit) discards 77057d0820690d6f67716670ff94b240b370c118 (commit) discards 157392a168916b6828676d53d943b099e0d0708d (commit) discards 0df73b1093c7d720cc64fa967a2268a13a929c72 (commit) discards aee0cdc4db6d34855597ebe7e09abc647d8e692e (commit) discards 43e71d624c7be3cce2cec7cb419f8b4129977a9e (commit) discards f1393090b4a164bb480f45cce9f8ab54b1bc6089 (commit) discards 1636e5f607325fb2cf0fa39c7c51eea0df49a9a3 (commit) discards 9c420d46836a7bee7dbb74b75763c92a7ee1d6ad (commit) discards a5a1af953fefa425b7a1611dab0ab67f8fe9285d (commit) discards 9d3c9d60d842bf053a1481703c9615bac0312295 (commit) discards 4fc87b30c4dda8c6897b148bb0d9e400c8e22c4f (commit) discards 1fcb2dca60a43cffedb9e40fca13e86a1832b7b4 (commit) discards 866eb9fbc5711a66538fb5da2ac2238c9b035116 (commit) discards 287cf4ee746ff1eb49eea52858de7304b1735b87 (commit) discards df61af7043081b1a20646dec088677b09d67fa78 (commit) discards a77c6904227149fdea29b8ed27ac3dddf2e9cf47 (commit) discards b13a67d78b35170fed891413569b203c8b63c8a5 (commit) discards 48abb3007302f2dab329e301bbabcb75782b3a4a (commit) discards af5d51b0f6494f4b222880abef35cc696e52a013 (commit) discards 1fdcbf613508ededda08689db16c2785de614d96 (commit) discards 7c83c0e1c4670ba2c70b3093b4135f4a8ba31ed1 (commit) discards c3c9c3277519a1ed70f3bf4d3d5ae5872cd24c7a (commit) discards 771f20df7863d8d805000c19db24ed1e6754e16d (commit) discards e2e60dac618a28a80786d9d29597852e5fab52b5 (commit) discards 2159e39353aa5b30b8844921e5987df83b696630 (commit) discards c33fcd7a33d13c5cf15d0b378dc46884e7c01e59 (commit) discards fd0134c8622110678b524ebeb6d889b68d0639c7 (commit) discards 3a6aa7f3b7e74bd7ed9089bddb81bd91cd948d81 (commit) discards d3e7137cc2168ec99e4de7a31f481cce6a76da09 (commit) discards 74cd902cb970e64f25456f81b1c7899b15b53c4e (commit) discards 6a7288c1d6779bf83f005f19f12e446ca17e24b6 (commit) via 64d0007aca0bc5f3c53aa3e710d9db6b745af36e (commit) via f0974ae238ee109b046051441a9599076ddcc0f0 (commit) via abf773d673a29b3e927e8151f9d47458bfeb9153 (commit) via 3586c3491555ef7e686bcbc145a64ac2d9405710 (commit) via 6551d3169355de7e05d94c905014ff1ec9fbf264 (commit) via 145d7ddb84ef36122a0bf6a539923b558d0b3928 (commit) via 5d2546d1597645a88ef70bcbdc706c9e8a16fb9a (commit) via 3ea2200407b17dac2b704979bd92cb7563d51d15 (commit) via 1da5e744766689acca7cf5b477a0c9bb4b900c95 (commit) via ea5906244efac709eb1fbcbd021a285fc4cbe7b8 (commit) via 82b3b65f217a0432ab88909f9fb29d7aa1856541 (commit) via 5b88584b0604269b1a830f8dfe1fec7319f3cdc7 (commit) via 4c3cf3701c217c99cdaee39d28ee0acea2e1c374 (commit) via 6cc8140d2b32abf620d6b47cd691162728029122 (commit) via 018d3829388438da9a7734bcd6972077c8c35090 (commit) via d8abd5df576d0180b2f78009fbe5707094e8aef1 (commit) via b92861ddbc4a559a6e4c82b875a2b1406f6d6279 (commit) via 4ffbfd3e4ebf5bfb5fa4ee298d88a6b721525420 (commit) via 1d89966270e03838fa61a15a874ceb8be34c3de3 (commit) via 98ed3fd8089b26895ef0177f1c1f3567cc3d0871 (commit) via 7c998bd273986d5cbd38b93523e8bfd59ec6fbae (commit) via bf6f8f6186f4cbd757e8c72083214493a95bc60d (commit) via e08b0de9fe2d7c0ad60a7eb6b4bdc0af2d62177c (commit) via 0b9733bfb3d15544b867210f138367bcf7d25cf5 (commit) via a4c1213fd7b7da144b011a7d74d28f5ba670df1a (commit) via 46d6fcc2cc2cbf6ad034a20fc6461f5016aa0bca (commit) via 666d4c7f68e56bc380f1028509c60cbec5eebe87 (commit) via 7275bd4d224ec91b50c0938d31b602a3c19a9a18 (commit) via 13266266b9a8c6518b7153b8fdea4aa2c0328ffe (commit) via 83c3f0be610073a5fe001ba39e45d4ac1f925e4c (commit) via 3ee9213a6d3131da085f97929051a0b0d3e65d0c (commit) via 49bf767559c5beb4d7de145fdbabe02a9cae577f (commit) via dfb5722cf088eca6bc3bcbb74cdf5704b5638568 (commit) via 418f6de75d1e54405e4e5501f50b1c4b2146551c (commit) via 18e441b66e0a974028f4042141b1a801fb5f21e0 (commit) via 71cd89a3e591951e7efd4b7065acfa9b15177ac5 (commit) via 91740a67cb090f0507b8c364f8f3950b73a52beb (commit) via d390bc452c0dca5c2e455ccdcda5515204a11413 (commit) via a6cb44ea20e173b50c8197f44f588411c25c1c31 (commit) via 33245e2c62baf0569edc53b4d39c3344a0372eba (commit) via 2892ebf3ea5ae575c3760fd2fca95b331f9ba9d2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (89b5af1f8d450e039602030d06ea6b0bd62925a2) \ N -- N -- N (64d0007aca0bc5f3c53aa3e710d9db6b745af36e) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=64d0007aca0bc5f3c53aa3e710d9db6b745af36e commit 64d0007aca0bc5f3c53aa3e710d9db6b745af36e Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f0974ae238ee109b046051441a9599076ddcc0f0 commit f0974ae238ee109b046051441a9599076ddcc0f0 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=abf773d673a29b3e927e8151f9d47458bfeb9153 commit abf773d673a29b3e927e8151f9d47458bfeb9153 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3586c3491555ef7e686bcbc145a64ac2d9405710 commit 3586c3491555ef7e686bcbc145a64ac2d9405710 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6551d3169355de7e05d94c905014ff1ec9fbf264 commit 6551d3169355de7e05d94c905014ff1ec9fbf264 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure (TODO) TODO: - Commit message - Reply to cancellation request (either with RES or ERR) Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=145d7ddb84ef36122a0bf6a539923b558d0b3928 commit 145d7ddb84ef36122a0bf6a539923b558d0b3928 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) TODO: - commit message - move LOGGSUBSCRP fix in gprs_subscr_purge to HEAD^^ - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d2546d1597645a88ef70bcbdc706c9e8a16fb9a commit 5d2546d1597645a88ef70bcbdc706c9e8a16fb9a Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3ea2200407b17dac2b704979bd92cb7563d51d15 commit 3ea2200407b17dac2b704979bd92cb7563d51d15 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Support PURGE MS messages When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1da5e744766689acca7cf5b477a0c9bb4b900c95 commit 1da5e744766689acca7cf5b477a0c9bb4b900c95 Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ea5906244efac709eb1fbcbd021a285fc4cbe7b8 commit ea5906244efac709eb1fbcbd021a285fc4cbe7b8 Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect subscr leakage This commit adds talloc reports to log remaining NULL chunks after the terminates. It also adds explicit checks for empty subscriber lists. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=82b3b65f217a0432ab88909f9fb29d7aa1856541 commit 82b3b65f217a0432ab88909f9fb29d7aa1856541 Author: Jacob Erlbeck Date: Fri Jan 9 15:07:16 2015 +0100 sgsn/test: Add test that intercepts gprs_gsup_client_send This test replaces gprs_gsup_client_send by a custom function, that emulates a GSUP remote peer by calling gprs_subscr_rx_gsup_message with responses for all requests. It then executes a full Attach/Detach cycle. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5b88584b0604269b1a830f8dfe1fec7319f3cdc7 commit 5b88584b0604269b1a830f8dfe1fec7319f3cdc7 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. Note that unused MM contexts are not expired yet. Therefore the subscriber will only be expired after a successful MM detach. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4c3cf3701c217c99cdaee39d28ee0acea2e1c374 commit 4c3cf3701c217c99cdaee39d28ee0acea2e1c374 Author: Jacob Erlbeck Date: Fri Jan 9 11:59:50 2015 +0100 sgsn/test: Refactor subscriber test The code sequence that checks, whether a subscriber is still reachable for a given IMSI, is repeated several times. This patch puts this code sequence into a single function and adds a check for the IMSI after the entry has been found. In addition, some comments are extended. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6cc8140d2b32abf620d6b47cd691162728029122 commit 6cc8140d2b32abf620d6b47cd691162728029122 Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=018d3829388438da9a7734bcd6972077c8c35090 commit 018d3829388438da9a7734bcd6972077c8c35090 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d8abd5df576d0180b2f78009fbe5707094e8aef1 commit d8abd5df576d0180b2f78009fbe5707094e8aef1 Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b92861ddbc4a559a6e4c82b875a2b1406f6d6279 commit b92861ddbc4a559a6e4c82b875a2b1406f6d6279 Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGGSUBSCRP and LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages in gprs_subscriber.c, this patch replaces each LOGP by LOGGSUBSCRP, unless a non-NULL pointer to a subscr is not available. In those cases, it uses LOGMMCTXP if a pointer to an MM context is available or LOGP otherwise. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4ffbfd3e4ebf5bfb5fa4ee298d88a6b721525420 commit 4ffbfd3e4ebf5bfb5fa4ee298d88a6b721525420 Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add LOGGSUBSCRP macro to log subscriber info This patch adds a new logging macro, that logs to DGPRS and provides a uniform prefix containing the IMSI without using the mm reference. This is an improvement over using LOGMMCTXP, since the new macro also provides an IMSI if no MM context is attached. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1d89966270e03838fa61a15a874ceb8be34c3de3 commit 1d89966270e03838fa61a15a874ceb8be34c3de3 Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=98ed3fd8089b26895ef0177f1c1f3567cc3d0871 commit 98ed3fd8089b26895ef0177f1c1f3567cc3d0871 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7c998bd273986d5cbd38b93523e8bfd59ec6fbae commit 7c998bd273986d5cbd38b93523e8bfd59ec6fbae Author: Jacob Erlbeck Date: Mon Jan 5 17:51:17 2015 +0100 sgsn: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bf6f8f6186f4cbd757e8c72083214493a95bc60d commit bf6f8f6186f4cbd757e8c72083214493a95bc60d Author: Jacob Erlbeck Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e08b0de9fe2d7c0ad60a7eb6b4bdc0af2d62177c commit e08b0de9fe2d7c0ad60a7eb6b4bdc0af2d62177c Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0b9733bfb3d15544b867210f138367bcf7d25cf5 commit 0b9733bfb3d15544b867210f138367bcf7d25cf5 Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 gprs: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a4c1213fd7b7da144b011a7d74d28f5ba670df1a commit a4c1213fd7b7da144b011a7d74d28f5ba670df1a Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 gprs: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=46d6fcc2cc2cbf6ad034a20fc6461f5016aa0bca commit 46d6fcc2cc2cbf6ad034a20fc6461f5016aa0bca Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 gprs: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=666d4c7f68e56bc380f1028509c60cbec5eebe87 commit 666d4c7f68e56bc380f1028509c60cbec5eebe87 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 gprs: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7275bd4d224ec91b50c0938d31b602a3c19a9a18 commit 7275bd4d224ec91b50c0938d31b602a3c19a9a18 Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 gprs: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=13266266b9a8c6518b7153b8fdea4aa2c0328ffe commit 13266266b9a8c6518b7153b8fdea4aa2c0328ffe Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=83c3f0be610073a5fe001ba39e45d4ac1f925e4c commit 83c3f0be610073a5fe001ba39e45d4ac1f925e4c Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3ee9213a6d3131da085f97929051a0b0d3e65d0c commit 3ee9213a6d3131da085f97929051a0b0d3e65d0c Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=49bf767559c5beb4d7de145fdbabe02a9cae577f commit 49bf767559c5beb4d7de145fdbabe02a9cae577f Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dfb5722cf088eca6bc3bcbb74cdf5704b5638568 commit dfb5722cf088eca6bc3bcbb74cdf5704b5638568 Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=418f6de75d1e54405e4e5501f50b1c4b2146551c commit 418f6de75d1e54405e4e5501f50b1c4b2146551c Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=18e441b66e0a974028f4042141b1a801fb5f21e0 commit 18e441b66e0a974028f4042141b1a801fb5f21e0 Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 gprs: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=71cd89a3e591951e7efd4b7065acfa9b15177ac5 commit 71cd89a3e591951e7efd4b7065acfa9b15177ac5 Author: Jacob Erlbeck Date: Mon Jan 12 13:54:39 2015 +0100 gprs: Clear GSUP message structures before decoding Currently the message structure is not cleared before the message is parsed which can cause information leaking between messages if the same gprs_gsup_message object is used. Especially list elements (auth tuples and pdp info) are not replaced by an IE, but the IE is appended. This patch uses the assignment operator to clear gprs_gsup_message, gsm_auth_tuple, and gprs_gsup_pdp_info before using them. This also replaces the use of memcpy of the latter. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=91740a67cb090f0507b8c364f8f3950b73a52beb commit 91740a67cb090f0507b8c364f8f3950b73a52beb Author: Jacob Erlbeck Date: Mon Jan 12 13:39:15 2015 +0100 gprs: Always reset auth tuples/pdp infos in gprs_gsup_decode Currently auth tuples are always appended to the lists when gprs_gsup_decode is called with a gsup_msg structure. This makes a test case fail, where the same gsup_msg is used again and again without clearing it after each use. Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d390bc452c0dca5c2e455ccdcda5515204a11413 commit d390bc452c0dca5c2e455ccdcda5515204a11413 Author: Jacob Erlbeck Date: Mon Jan 12 13:23:05 2015 +0100 gprs: Handle empty GSUP messages correctly Currently, the gprs_gsup_decode function doesn't check the return value of gprs_shift_v_fixed before using the value pointer. The function fails, if the GSUP message length (not including IPA headers) is 0. In this case, a segfault can happen, depending on the value of the uninitialized 'value' pointer. The test case doesn't trigger a segfault, but valgrind complains about reading uninitialized data. This patch adds a check for the return value that would return with an error code if the shift function failed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a6cb44ea20e173b50c8197f44f588411c25c1c31 commit a6cb44ea20e173b50c8197f44f588411c25c1c31 Author: Jacob Erlbeck Date: Mon Jan 12 11:14:18 2015 +0100 gprs/test: Add tests for invalid GSUP messages Currently, the tests only use valid GSUP messages. This does not check the robustness of the parser. This commit adds a test for truncated messages and another for modified messages. Thanks to Holger for the basic truncation test. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=33245e2c62baf0569edc53b4d39c3344a0372eba commit 33245e2c62baf0569edc53b4d39c3344a0372eba Author: Jacob Erlbeck Date: Tue Jan 13 11:56:28 2015 +0100 sgsn/test: Fix msgb freeing in mocked bssgp_tx_dl_ud Currently the mocked bssgp_tx_dl_ud function used for testing in sgsn_test.c does not free the msg as it is done by the original function. This leads to a msgb leak in the test. This patch fixes the test code accordingly and uncomments the assertion that checks for left-over msgbs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2892ebf3ea5ae575c3760fd2fca95b331f9ba9d2 commit 2892ebf3ea5ae575c3760fd2fca95b331f9ba9d2 Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect msgb leakage This commit adds talloc reports to log remaining chunks after the testing has been finished. It also adds a (currently disabled) check, that no msgbs are allocated after running the tests. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/tests/sgsn/sgsn_test.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 15 18:08:48 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 15 Jan 2015 18:08:48 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-882-ge0eb96d Message-ID: <201501151808.t0FI8mak033344@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 64d0007aca0bc5f3c53aa3e710d9db6b745af36e (commit) discards f0974ae238ee109b046051441a9599076ddcc0f0 (commit) discards abf773d673a29b3e927e8151f9d47458bfeb9153 (commit) discards 3586c3491555ef7e686bcbc145a64ac2d9405710 (commit) discards 6551d3169355de7e05d94c905014ff1ec9fbf264 (commit) discards 145d7ddb84ef36122a0bf6a539923b558d0b3928 (commit) discards 5d2546d1597645a88ef70bcbdc706c9e8a16fb9a (commit) discards 3ea2200407b17dac2b704979bd92cb7563d51d15 (commit) discards 1da5e744766689acca7cf5b477a0c9bb4b900c95 (commit) via e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf (commit) via 30550cd100ef2ed127c6ac2c29b4d745fed49e35 (commit) via ea3cea021b59b8a6f9341faaf1081f031d04206c (commit) via 3bcbbebcc04a1f8a6e0557bd5701b97af7015c24 (commit) via 89be7c6d55347411aea23405236284f6e785eb57 (commit) via 30997b9dd3040058dea7dd7c427d2c3d63db7de0 (commit) via d41ed3277136f2a35a88a8e9f04c4a52f34e47d2 (commit) via c014e1ad93e620be528c6ff0cc131be08d34a8f3 (commit) via 427ecd1ebafe39fb95b0948b0f4b868d62186abb (commit) via 523731fceba3e2b805bc2e3c1205f4a7c691bad8 (commit) via e341cff4a0e3f1e4525be9d216fe09cdabb0111e (commit) via cabb6cbbd299a5a48a3d8eb798f747ab6383b265 (commit) via c940371242ec50cd2981c69a1e6667c7f80fbbef (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (64d0007aca0bc5f3c53aa3e710d9db6b745af36e) \ N -- N -- N (e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf commit e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf Author: Jacob Erlbeck Date: Thu Jan 15 18:51:31 2015 +0100 sgsn: Fix P-TMSI generator's periodicity Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then sets to upper 2 MSB. Therefore there is no lower limit of the distance between 2 identical P-TMSI. This patch changes the implementation to discard any random value above 2^30 and to generate a new random number in that case until a fitting number is found (or a repetition limit is reached). This way, all number below 2^30 within the PRNG's period are used. Ticket: OW#1362 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=30550cd100ef2ed127c6ac2c29b4d745fed49e35 commit 30550cd100ef2ed127c6ac2c29b4d745fed49e35 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ea3cea021b59b8a6f9341faaf1081f031d04206c commit ea3cea021b59b8a6f9341faaf1081f031d04206c Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3bcbbebcc04a1f8a6e0557bd5701b97af7015c24 commit 3bcbbebcc04a1f8a6e0557bd5701b97af7015c24 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=89be7c6d55347411aea23405236284f6e785eb57 commit 89be7c6d55347411aea23405236284f6e785eb57 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=30997b9dd3040058dea7dd7c427d2c3d63db7de0 commit 30997b9dd3040058dea7dd7c427d2c3d63db7de0 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure Currently no GSUP LocationCancellationResult message is sent back to the peer (HLR), if the procedure succeeded at the SGSN's side. This patch adds the missing message and put the whole request handling of this procedure into a separate function. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d41ed3277136f2a35a88a8e9f04c4a52f34e47d2 commit d41ed3277136f2a35a88a8e9f04c4a52f34e47d2 Author: Jacob Erlbeck Date: Thu Jan 15 17:50:16 2015 +0100 gprs: Don't create a subscr entry on InsertSubscriberData Currently gprs_subscr_rx_gsup_message creates a subscriber entry if such an entry doesn't exist for the IMSI within an InsertSubscriberData GSUP message. This behaviour is not compliant to GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is defined, that an error ("Unidentified subscriber") shall be returned. This patch removes the case distinction, so that an existing subscriber entry is required for all incoming GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c014e1ad93e620be528c6ff0cc131be08d34a8f3 commit c014e1ad93e620be528c6ff0cc131be08d34a8f3 Author: Jacob Erlbeck Date: Thu Jan 15 17:08:30 2015 +0100 gprs: Add replies for all GSUP requests Currently, an incoming GSUP request message isn't answered at all if it is not handled due to an error or missing implementation. This patch adds GSUP error replies for these requests (and only for requests). It also adds tests for these cases. Note that several of these tests check for GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when the features are implemented. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=427ecd1ebafe39fb95b0948b0f4b868d62186abb commit 427ecd1ebafe39fb95b0948b0f4b868d62186abb Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS (TODO) GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be started until the PURGE_MS procedure has been completed. This patch implements this by adding corresponding state and checks to gprs_subscr_purge, gprs_subscr_location_update, and gprs_subscr_update_auth_info. If an Update Location or a Send Auth Info Req procedure is not started because of blocking, the retry mechanism is aborted to shorten the blocking time. The outstanding Purge MS procedure itself is not aborted. TODO: - testing Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=523731fceba3e2b805bc2e3c1205f4a7c691bad8 commit 523731fceba3e2b805bc2e3c1205f4a7c691bad8 Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e341cff4a0e3f1e4525be9d216fe09cdabb0111e commit e341cff4a0e3f1e4525be9d216fe09cdabb0111e Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Use PURGE MS messages When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been optained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. Note that GSM 09.02, 19.1.4.4 implies that the subscriber data is not to be removed when the procedure fails which is not the way the feature has been implemented. Note that handling 'P-TMSI freezing' is not implemented. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cabb6cbbd299a5a48a3d8eb798f747ab6383b265 commit cabb6cbbd299a5a48a3d8eb798f747ab6383b265 Author: Jacob Erlbeck Date: Thu Jan 15 11:50:08 2015 +0100 gprs: Implement PURGE_MS GSUP messages This commit implements the encoding and decoding of the messages - Purge MS Request - Purge MS Error - Purge MS Result and adds corresponding tests. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c940371242ec50cd2981c69a1e6667c7f80fbbef commit c940371242ec50cd2981c69a1e6667c7f80fbbef Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 2 + openbsc/include/openbsc/gprs_gsup_messages.h | 6 ++ openbsc/include/openbsc/gprs_sgsn.h | 3 +- openbsc/src/gprs/gprs_gsup_messages.c | 7 ++ openbsc/src/gprs/gprs_sgsn.c | 28 ++++++- openbsc/src/gprs/gprs_subscriber.c | 109 ++++++++++++++++++++++----- openbsc/tests/gprs/gprs_test.c | 23 ++++++ openbsc/tests/gprs/gprs_test.ok | 3 + openbsc/tests/sgsn/sgsn_test.c | 63 +++++++++++++++- 9 files changed, 221 insertions(+), 23 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 16 08:44:24 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 16 Jan 2015 08:44:24 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-882-g47c7031 Message-ID: <201501160844.t0G8iO4L017602@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf (commit) discards 30550cd100ef2ed127c6ac2c29b4d745fed49e35 (commit) discards ea3cea021b59b8a6f9341faaf1081f031d04206c (commit) discards 3bcbbebcc04a1f8a6e0557bd5701b97af7015c24 (commit) discards 89be7c6d55347411aea23405236284f6e785eb57 (commit) discards 30997b9dd3040058dea7dd7c427d2c3d63db7de0 (commit) discards d41ed3277136f2a35a88a8e9f04c4a52f34e47d2 (commit) discards c014e1ad93e620be528c6ff0cc131be08d34a8f3 (commit) discards 427ecd1ebafe39fb95b0948b0f4b868d62186abb (commit) via 47c7031e8374c7f62fee4302ea4542db337dd805 (commit) via a6f76044db12fad60f40df8711d5405956c9d121 (commit) via be80c25828ed77525f4c16c8d4355aa082b549c7 (commit) via de0a00f169dea08e6a9382d8c0b0954ee4d4dfbc (commit) via de07f985b57ac534764d9020bac4d2e9550f3cb1 (commit) via bb23b837207f293b8e375f44fe5c24a1172036f5 (commit) via 209b4e36e3e642b0986bbacf3f41c496e4a27a43 (commit) via 4a1139a07134956d1c68472381b6bebc5d29bb93 (commit) via 435ac559683d4813c6f4ae9896deae60dc6d7f09 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf) \ N -- N -- N (47c7031e8374c7f62fee4302ea4542db337dd805) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=47c7031e8374c7f62fee4302ea4542db337dd805 commit 47c7031e8374c7f62fee4302ea4542db337dd805 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a6f76044db12fad60f40df8711d5405956c9d121 commit a6f76044db12fad60f40df8711d5405956c9d121 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=be80c25828ed77525f4c16c8d4355aa082b549c7 commit be80c25828ed77525f4c16c8d4355aa082b549c7 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=de0a00f169dea08e6a9382d8c0b0954ee4d4dfbc commit de0a00f169dea08e6a9382d8c0b0954ee4d4dfbc Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=de07f985b57ac534764d9020bac4d2e9550f3cb1 commit de07f985b57ac534764d9020bac4d2e9550f3cb1 Author: Jacob Erlbeck Date: Thu Jan 15 18:51:31 2015 +0100 sgsn: Fix P-TMSI generator's distance of equal values Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then sets to upper 2 MSB. Therefore there is no lower limit of the distance between 2 identical P-TMSI. This patch changes the implementation to discard any random value above 2^30 and to generate a new random number in that case until a fitting number is found (or a repetition limit is reached). This way, all number below 2^30 within the PRNG's period are used. Ticket: OW#1362 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bb23b837207f293b8e375f44fe5c24a1172036f5 commit bb23b837207f293b8e375f44fe5c24a1172036f5 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure Currently no GSUP LocationCancellationResult message is sent back to the peer (HLR), if the procedure succeeded at the SGSN's side. This patch adds the missing message and put the whole request handling of this procedure into a separate function. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=209b4e36e3e642b0986bbacf3f41c496e4a27a43 commit 209b4e36e3e642b0986bbacf3f41c496e4a27a43 Author: Jacob Erlbeck Date: Thu Jan 15 17:50:16 2015 +0100 gprs: Don't create a subscr entry on InsertSubscriberData Currently gprs_subscr_rx_gsup_message creates a subscriber entry if such an entry doesn't exist for the IMSI within an InsertSubscriberData GSUP message. This behaviour is not compliant to GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is defined, that an error ("Unidentified subscriber") shall be returned. This patch removes the case distinction, so that an existing subscriber entry is required for all incoming GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4a1139a07134956d1c68472381b6bebc5d29bb93 commit 4a1139a07134956d1c68472381b6bebc5d29bb93 Author: Jacob Erlbeck Date: Thu Jan 15 17:08:30 2015 +0100 gprs: Add replies for all GSUP requests Currently, an incoming GSUP request message isn't answered at all if it is not handled due to an error or missing implementation. This patch adds GSUP error replies for these requests (and only for requests). It also adds tests for these cases. Note that several of these tests check for GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when the features are implemented. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=435ac559683d4813c6f4ae9896deae60dc6d7f09 commit 435ac559683d4813c6f4ae9896deae60dc6d7f09 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be started until the PURGE_MS procedure has been completed. This patch implements this by adding corresponding state and checks to gprs_subscr_purge, gprs_subscr_location_update, and gprs_subscr_update_auth_info. If an Update Location or a Send Auth Info Req procedure is not started because of blocking, the retry mechanism is aborted to shorten the blocking time. The outstanding Purge MS procedure itself is not aborted. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 4 ++ openbsc/src/gprs/gprs_subscriber.c | 54 ++++++++++++---------- openbsc/tests/sgsn/sgsn_test.c | 92 +++++++++++++++++++++++++++++++++++++ openbsc/tests/sgsn/sgsn_test.ok | 1 + 4 files changed, 126 insertions(+), 25 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sun Jan 18 16:54:53 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 16:54:53 GMT Subject: libosmo-abis.git branch master updated. 0.3.0-6-g9087859 Message-ID: <201501181654.t0IGsrgB003290@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via 90878590575cdcedbaf7b8f431e0fa102d0d2e50 (commit) from adfa01f041e3b9a515b65a732c92eabf74e2ba08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=90878590575cdcedbaf7b8f431e0fa102d0d2e50 commit 90878590575cdcedbaf7b8f431e0fa102d0d2e50 Author: Holger Hans Peter Freyther Date: Sun Jan 18 17:50:05 2015 +0100 ipa: Add API to clear the tx queue Jacob noticed that after a re-connect old messages would be sent. This can be the wanted behavior but add a method that allows a caller to clear the tx queue. The implementation has not been verified and there is no existing unit test where I could easily add this code to. ----------------------------------------------------------------------- Summary of changes: include/osmocom/abis/ipa.h | 1 + src/input/ipa.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+) hooks/post-receive -- Osmocom A-bis protcol interface library From gitosis at osmocom.org Sun Jan 18 17:50:31 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 17:50:31 GMT Subject: openbsc.git branch master updated. 0.13.0-874-g743dec4 Message-ID: <201501181750.t0IHoVea008202@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 743dec4c0c80383556efac60f03d307287ecf024 (commit) via 65fa3f73a1151e896e4c74196680b7886a3b6be6 (commit) via 69d271376cce7d26a0469bbb948f272c399ac6c7 (commit) via cde0bb27a14553bba2f680cd1307a5f9b3581f0e (commit) via 058bc26e1bb1350c9077f99edd24887bb84bc8c5 (commit) via c157ee7d2ccdb7524e76d25b22cb7eec8de9a656 (commit) via 0f47b8fae743769a6627f8654444b4f0d665e050 (commit) via b8fb1409d1ed18dc198b430895a74e680640c2b1 (commit) via e1beb6f51d3822593d56e071d47e12a74f077826 (commit) via d3cde1ecf49940fae90ec5e1d36824ee0ba17501 (commit) via f06fe29f61c0089ca2f0c10faea18c65d5014f95 (commit) via bf34c67f3f5f747d71f844aec9ae61d26b273d6d (commit) via 42755785707a11c8349b86c2afb98b7bc15c85dc (commit) via bce2061b43c1e38b766cc3738b4ad669211dc6a4 (commit) via 9aa9991efe207f5c12bbcf655b0660e3466c02e0 (commit) via af3d5c508c9ca3ebae9388d3e09c5d7726db4f5c (commit) via afcf23001e600bedc51db08a22846dada9bc06b3 (commit) via 8054799963f4b3b936d601eb4b1f5774f2c41fec (commit) via 03b463034885e7ebb09160f6d63c05ac120a8098 (commit) via e154d8bdd45974fa6e9408b9d543eb9e9ea94b79 (commit) via 69e16b9ea5dc991f8373c11b9fcf45b7b1a8e940 (commit) via 4188c30c4a6574201d62df1be818eed038608d16 (commit) via 849d0a83e8598e0f21a3e9c5438c222d8ab417eb (commit) via 7660ffa29fb463fc24b2ac8d735b9b345017bba6 (commit) via 3d722450de1cf34931d95f7a748a9b6c48e933f0 (commit) via e21e184d84d6a932b58079084d254f498599e29e (commit) via 771573c535ae97ce7c7ed7694670e3b98eeae48a (commit) via a071c1ccc07074272f6cb7626b781f45f85564c6 (commit) via 9d4f46c975c3a4c92071c70ebadd6edc345581da (commit) via 39f040d62b16b2d99352f5facd83ce098fa2f462 (commit) via bb23dc17f8f56be836dc50c925c04a5aeaec979c (commit) via 1610626fe9e65693c6d8743129b10ed4958ec6ea (commit) via a2315eebf972412e122033ac036dd21bcdad5335 (commit) via 424ffa480630a4242d2a6f6b27b9e6b1ec08d206 (commit) via 0572ee045d1b7c29a0c34b27867b3f8669eb5038 (commit) via f0b06d82cd6f2a340db052a2fa2e559aa75f1fa8 (commit) via 07de92e2c0ccfa89b9498c8c49a74d0848b7b85a (commit) from a6ddc2d99f8463edb0b5eacf080db0b5ca571efc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=743dec4c0c80383556efac60f03d307287ecf024 commit 743dec4c0c80383556efac60f03d307287ecf024 Author: Jacob Erlbeck Date: Thu Jan 8 15:18:39 2015 +0100 gprs: Retry PURGE_MS procedure after timeout Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a connection or peer failure), the expired subscriber entry will not get deleted. This commit adds a retry mechanism then restarts the procedure after a timeout (currently 10s). The maximum number of retries is limited (currently to 3 PURGE_MS messages). If none of these procedures is completed (either with success or error), the subscriber data is deleted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=65fa3f73a1151e896e4c74196680b7886a3b6be6 commit 65fa3f73a1151e896e4c74196680b7886a3b6be6 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Use PURGE MS messages When a subscriber entry is going to be deleted by SGSN and when the subscriber info has been obtained from a remote peer via GSUP, the peer should be informed before the entry is really deleted. For this purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4). This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and invokes the procedure when the subscriber entry is going to be removed. This only applies if GSUP is being used, the Update Location procedure has been completed successfully, and the subscriber has not been cancelled. The removal of the entry is delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received. Note that GSM 09.02, 19.1.4.4 implies that the subscriber data is not to be removed when the procedure fails which is not the way the feature has been implemented. Note that handling 'P-TMSI freezing' is not implemented. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=69d271376cce7d26a0469bbb948f272c399ac6c7 commit 69d271376cce7d26a0469bbb948f272c399ac6c7 Author: Jacob Erlbeck Date: Thu Jan 15 11:50:08 2015 +0100 gprs: Implement PURGE_MS GSUP messages This commit implements the encoding and decoding of the messages - Purge MS Request - Purge MS Error - Purge MS Result and adds corresponding tests. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cde0bb27a14553bba2f680cd1307a5f9b3581f0e commit cde0bb27a14553bba2f680cd1307a5f9b3581f0e Author: Jacob Erlbeck Date: Fri Jan 9 09:46:43 2015 +0100 sgsn/doc: Add message definitions for PURGE_MS responses Currently the definitions of the message PURGE_MS_RES and PURGE_MS_ERR are missing in the specification. This patch adds those definitions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=058bc26e1bb1350c9077f99edd24887bb84bc8c5 commit 058bc26e1bb1350c9077f99edd24887bb84bc8c5 Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect subscr leakage This commit adds talloc reports to log remaining NULL chunks after the terminates. It also adds explicit checks for empty subscriber lists. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c157ee7d2ccdb7524e76d25b22cb7eec8de9a656 commit c157ee7d2ccdb7524e76d25b22cb7eec8de9a656 Author: Jacob Erlbeck Date: Fri Jan 9 15:07:16 2015 +0100 sgsn/test: Add test that intercepts gprs_gsup_client_send This test replaces gprs_gsup_client_send by a custom function, that emulates a GSUP remote peer by calling gprs_subscr_rx_gsup_message with responses for all requests. It then executes a full Attach/Detach cycle. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0f47b8fae743769a6627f8654444b4f0d665e050 commit 0f47b8fae743769a6627f8654444b4f0d665e050 Author: Jacob Erlbeck Date: Tue Jan 6 16:32:41 2015 +0100 gprs: Add expiry timeout for subscriber entries Set the expiry delay after the subscriber has been deleted (e.g. by freeing the MM context). If cancelled, the subscriber will be deleted immediately and no timeout will be set. If the expiry time is set to SGSN_TIMEOUT_NEVER, no timer will be started and the subscriber entry will be kept until it is cancelled. The following VTY command is added to the sgsn node: - subscriber-expiry-time <0-999999> set expiry time in seconds - no subscriber-expiry-time set to SGSN_TIMEOUT_NEVER The default is an expiry time of 0 seconds, which means that the subscriber entries are wiped out immediately after an MM context is destroyed. Note that unused MM contexts are not expired yet. Therefore the subscriber will only be expired after a successful MM detach. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b8fb1409d1ed18dc198b430895a74e680640c2b1 commit b8fb1409d1ed18dc198b430895a74e680640c2b1 Author: Jacob Erlbeck Date: Fri Jan 9 11:59:50 2015 +0100 sgsn/test: Refactor subscriber test The code sequence that checks, whether a subscriber is still reachable for a given IMSI, is repeated several times. This patch puts this code sequence into a single function and adds a check for the IMSI after the entry has been found. In addition, some comments are extended. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e1beb6f51d3822593d56e071d47e12a74f077826 commit e1beb6f51d3822593d56e071d47e12a74f077826 Author: Jacob Erlbeck Date: Thu Jan 8 14:13:46 2015 +0100 sgsn/test: Fix subscriber cleanup Currently the subscribers are not really deleted by cleanup_subscr_by_imsi, but kept in RAM instead. This patch fixes this and adds a test to verify, that the subscriber is really deleted afterwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d3cde1ecf49940fae90ec5e1d36824ee0ba17501 commit d3cde1ecf49940fae90ec5e1d36824ee0ba17501 Author: Jacob Erlbeck Date: Thu Jan 8 14:08:16 2015 +0100 gprs/test: Move subscr cleanup code into a separate function Refactor several occurences of the same subscriber cleanup code into a seperate cleanup_subscr_by_imsi function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f06fe29f61c0089ca2f0c10faea18c65d5014f95 commit f06fe29f61c0089ca2f0c10faea18c65d5014f95 Author: Jacob Erlbeck Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bf34c67f3f5f747d71f844aec9ae61d26b273d6d commit bf34c67f3f5f747d71f844aec9ae61d26b273d6d Author: Jacob Erlbeck Date: Tue Dec 23 14:24:16 2014 +0100 gprs: Use LOGGSUBSCRP and LOGMMCTX for logging in gprs_susbcriber.c To unify the layout of the logging messages in gprs_subscriber.c, this patch replaces each LOGP by LOGGSUBSCRP, unless a non-NULL pointer to a subscr is not available. In those cases, it uses LOGMMCTXP if a pointer to an MM context is available or LOGP otherwise. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=42755785707a11c8349b86c2afb98b7bc15c85dc commit 42755785707a11c8349b86c2afb98b7bc15c85dc Author: Jacob Erlbeck Date: Thu Jan 8 12:02:12 2015 +0100 gprs: Add LOGGSUBSCRP macro to log subscriber info This patch adds a new logging macro, that logs to DGPRS and provides a uniform prefix containing the IMSI without using the mm reference. This is an improvement over using LOGMMCTXP, since the new macro also provides an IMSI if no MM context is attached. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bce2061b43c1e38b766cc3738b4ad669211dc6a4 commit bce2061b43c1e38b766cc3738b4ad669211dc6a4 Author: Jacob Erlbeck Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9aa9991efe207f5c12bbcf655b0660e3466c02e0 commit 9aa9991efe207f5c12bbcf655b0660e3466c02e0 Author: Jacob Erlbeck Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=af3d5c508c9ca3ebae9388d3e09c5d7726db4f5c commit af3d5c508c9ca3ebae9388d3e09c5d7726db4f5c Author: Jacob Erlbeck Date: Mon Jan 5 17:51:17 2015 +0100 sgsn: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf Conflicts: openbsc/include/openbsc/gprs_sgsn.h [hfreyther: Conflict due the removal of the unused authenticate flag] http://cgit.osmocom.org/openbsc/commit/?id=afcf23001e600bedc51db08a22846dada9bc06b3 commit afcf23001e600bedc51db08a22846dada9bc06b3 Author: Jacob Erlbeck Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8054799963f4b3b936d601eb4b1f5774f2c41fec commit 8054799963f4b3b936d601eb4b1f5774f2c41fec Author: Jacob Erlbeck Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=03b463034885e7ebb09160f6d63c05ac120a8098 commit 03b463034885e7ebb09160f6d63c05ac120a8098 Author: Jacob Erlbeck Date: Fri Dec 19 19:18:54 2014 +0100 gprs: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf Conflicts: openbsc/src/gprs/gprs_gsup_client.c [hfreyther: Conflicts due the potential memleak fix by me. Removed another TODO from the code as we stop the ping/pong timer] http://cgit.osmocom.org/openbsc/commit/?id=e154d8bdd45974fa6e9408b9d543eb9e9ea94b79 commit e154d8bdd45974fa6e9408b9d543eb9e9ea94b79 Author: Jacob Erlbeck Date: Fri Dec 19 19:15:55 2014 +0100 gprs: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=69e16b9ea5dc991f8373c11b9fcf45b7b1a8e940 commit 69e16b9ea5dc991f8373c11b9fcf45b7b1a8e940 Author: Jacob Erlbeck Date: Fri Dec 19 19:00:56 2014 +0100 gprs: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4188c30c4a6574201d62df1be818eed038608d16 commit 4188c30c4a6574201d62df1be818eed038608d16 Author: Jacob Erlbeck Date: Fri Dec 19 18:50:05 2014 +0100 gprs: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf [hfreyther: Replaced while (!llist_empty(&gsupc->link->tx_queue)) llist_del(gsupc->link->tx_queue.next); with new libosmo-abis API] http://cgit.osmocom.org/openbsc/commit/?id=849d0a83e8598e0f21a3e9c5438c222d8ab417eb commit 849d0a83e8598e0f21a3e9c5438c222d8ab417eb Author: Jacob Erlbeck Date: Thu Dec 18 15:00:29 2014 +0100 gprs: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7660ffa29fb463fc24b2ac8d735b9b345017bba6 commit 7660ffa29fb463fc24b2ac8d735b9b345017bba6 Author: Jacob Erlbeck Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3d722450de1cf34931d95f7a748a9b6c48e933f0 commit 3d722450de1cf34931d95f7a748a9b6c48e933f0 Author: Jacob Erlbeck Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e21e184d84d6a932b58079084d254f498599e29e commit e21e184d84d6a932b58079084d254f498599e29e Author: Jacob Erlbeck Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=771573c535ae97ce7c7ed7694670e3b98eeae48a commit 771573c535ae97ce7c7ed7694670e3b98eeae48a Author: Jacob Erlbeck Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a071c1ccc07074272f6cb7626b781f45f85564c6 commit a071c1ccc07074272f6cb7626b781f45f85564c6 Author: Holger Hans Peter Freyther Date: Sun Jan 18 13:22:37 2015 +0100 gprs: Remove now unused authenticate flag This has been obsoleted by the previous commit. Remove it. http://cgit.osmocom.org/openbsc/commit/?id=9d4f46c975c3a4c92071c70ebadd6edc345581da commit 9d4f46c975c3a4c92071c70ebadd6edc345581da Author: Jacob Erlbeck Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=39f040d62b16b2d99352f5facd83ce098fa2f462 commit 39f040d62b16b2d99352f5facd83ce098fa2f462 Author: Jacob Erlbeck Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bb23dc17f8f56be836dc50c925c04a5aeaec979c commit bb23dc17f8f56be836dc50c925c04a5aeaec979c Author: Jacob Erlbeck Date: Thu Dec 18 12:28:21 2014 +0100 gprs: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1610626fe9e65693c6d8743129b10ed4958ec6ea commit 1610626fe9e65693c6d8743129b10ed4958ec6ea Author: Jacob Erlbeck Date: Mon Jan 12 13:54:39 2015 +0100 gprs: Clear GSUP message structures before decoding Currently the message structure is not cleared before the message is parsed which can cause information leaking between messages if the same gprs_gsup_message object is used. Especially list elements (auth tuples and pdp info) are not replaced by an IE, but the IE is appended. This patch uses the assignment operator to clear gprs_gsup_message, gsm_auth_tuple, and gprs_gsup_pdp_info before using them. This also replaces the use of memcpy of the latter. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a2315eebf972412e122033ac036dd21bcdad5335 commit a2315eebf972412e122033ac036dd21bcdad5335 Author: Jacob Erlbeck Date: Mon Jan 12 13:39:15 2015 +0100 gprs: Always reset auth tuples/pdp infos in gprs_gsup_decode Currently auth tuples are always appended to the lists when gprs_gsup_decode is called with a gsup_msg structure. This makes a test case fail, where the same gsup_msg is used again and again without clearing it after each use. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=424ffa480630a4242d2a6f6b27b9e6b1ec08d206 commit 424ffa480630a4242d2a6f6b27b9e6b1ec08d206 Author: Jacob Erlbeck Date: Mon Jan 12 13:23:05 2015 +0100 gprs: Handle empty GSUP messages correctly Currently, the gprs_gsup_decode function doesn't check the return value of gprs_shift_v_fixed before using the value pointer. The function fails, if the GSUP message length (not including IPA headers) is 0. In this case, a segfault can happen, depending on the value of the uninitialized 'value' pointer. The test case doesn't trigger a segfault, but valgrind complains about reading uninitialized data. This patch adds a check for the return value that would return with an error code if the shift function failed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0572ee045d1b7c29a0c34b27867b3f8669eb5038 commit 0572ee045d1b7c29a0c34b27867b3f8669eb5038 Author: Jacob Erlbeck Date: Mon Jan 12 11:14:18 2015 +0100 gprs/test: Add tests for invalid GSUP messages Currently, the tests only use valid GSUP messages. This does not check the robustness of the parser. This commit adds a test for truncated messages and another for modified messages. Thanks to Holger for the basic truncation test. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f0b06d82cd6f2a340db052a2fa2e559aa75f1fa8 commit f0b06d82cd6f2a340db052a2fa2e559aa75f1fa8 Author: Jacob Erlbeck Date: Tue Jan 13 11:56:28 2015 +0100 sgsn/test: Fix msgb freeing in mocked bssgp_tx_dl_ud Currently the mocked bssgp_tx_dl_ud function used for testing in sgsn_test.c does not free the msg as it is done by the original function. This leads to a msgb leak in the test. This patch fixes the test code accordingly and uncomments the assertion that checks for left-over msgbs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=07de92e2c0ccfa89b9498c8c49a74d0848b7b85a commit 07de92e2c0ccfa89b9498c8c49a74d0848b7b85a Author: Jacob Erlbeck Date: Tue Jan 13 11:46:32 2015 +0100 sgsn/test: Add checks and reports to detect msgb leakage This commit adds talloc reports to log remaining chunks after the testing has been finished. It also adds a (currently disabled) check, that no msgbs are allocated after running the tests. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 12 +- openbsc/include/openbsc/Makefile.am | 3 +- openbsc/include/openbsc/gprs_gmm.h | 4 +- openbsc/include/openbsc/gprs_gsup_client.h | 54 ++++ openbsc/include/openbsc/gprs_gsup_messages.h | 2 + openbsc/include/openbsc/gprs_sgsn.h | 11 +- openbsc/include/openbsc/gsm_04_08_gprs.h | 11 + openbsc/include/openbsc/sgsn.h | 14 + openbsc/src/gprs/Makefile.am | 3 +- openbsc/src/gprs/gprs_gmm.c | 184 +++--------- openbsc/src/gprs/gprs_gsup_client.c | 285 +++++++++++++++++++ openbsc/src/gprs/gprs_gsup_messages.c | 23 +- openbsc/src/gprs/gprs_subscriber.c | 367 ++++++++++++++++++++---- openbsc/src/gprs/gsm_04_08_gprs.c | 141 +++++++++ openbsc/src/gprs/sgsn_auth.c | 22 +- openbsc/src/gprs/sgsn_main.c | 6 + openbsc/src/gprs/sgsn_vty.c | 93 +++++- openbsc/tests/gprs/gprs_test.c | 115 ++++++++ openbsc/tests/gprs/gprs_test.ok | 3 + openbsc/tests/sgsn/Makefile.am | 6 +- openbsc/tests/sgsn/sgsn_test.c | 408 ++++++++++++++++++++++----- openbsc/tests/sgsn/sgsn_test.ok | 3 + 22 files changed, 1474 insertions(+), 296 deletions(-) create mode 100644 openbsc/include/openbsc/gprs_gsup_client.h create mode 100644 openbsc/src/gprs/gprs_gsup_client.c create mode 100644 openbsc/src/gprs/gsm_04_08_gprs.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sun Jan 18 18:26:22 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 18:26:22 GMT Subject: libosmocore.git branch master updated. 0.7.0-105-g25aeab7 Message-ID: <201501181826.t0IIQMAB011663@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 25aeab7a8235141a72c7cbb37155d8949071ec3f (commit) via 4deb2dfa2547adb5ee71ff03c2ffdd0be088fa36 (commit) via c869069950515add4155dfb37d94bd29d833d3fe (commit) via 78ffdb8ab2cc16251974bc2a93aa1d9ae35b7874 (commit) from 419684e30c2fe12d3e3441cfa9fea21f1c4de959 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=25aeab7a8235141a72c7cbb37155d8949071ec3f commit 25aeab7a8235141a72c7cbb37155d8949071ec3f Author: Holger Hans Peter Freyther Date: Sun Jan 18 19:05:19 2015 +0100 Prepare a new libosmocore release http://cgit.osmocom.org/libosmocore/commit/?id=4deb2dfa2547adb5ee71ff03c2ffdd0be088fa36 commit 4deb2dfa2547adb5ee71ff03c2ffdd0be088fa36 Author: Holger Hans Peter Freyther Date: Sun Jan 18 19:20:19 2015 +0100 ctrl: Link to libraries we use symbols from Fixes: dpkg-shlibdeps: warning: symbol vector_free used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol vector_set used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol vector_set_index used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol tall_vty_vec_ctx used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol ipa_msg_recv_buffered used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol cmd_free_strvec used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol vector_lookup used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol vector_lookup_ensure used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol cmd_make_strvec used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol vector_init used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries http://cgit.osmocom.org/libosmocore/commit/?id=c869069950515add4155dfb37d94bd29d833d3fe commit c869069950515add4155dfb37d94bd29d833d3fe Author: Holger Hans Peter Freyther Date: Sun Jan 18 19:16:25 2015 +0100 sim: Link to libosmocore and libosmogsm The big LIBOSMOCORE_CFLAGS and LIBOSMOCORE_LIBS macros are not defined when building linosmocore. Use the .la files directly Fixes: dpkg-shlibdeps: warning: symbol osmo_hexdump used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol gsm48_parse_ra used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _talloc_zero used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _talloc_memdup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol talloc_strndup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol msgb_length used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol msgb_alloc used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol msgb_free used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol talloc_strdup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol talloc_free used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries http://cgit.osmocom.org/libosmocore/commit/?id=78ffdb8ab2cc16251974bc2a93aa1d9ae35b7874 commit 78ffdb8ab2cc16251974bc2a93aa1d9ae35b7874 Author: Holger Hans Peter Freyther Date: Sun Jan 18 19:06:01 2015 +0100 misc: Ignore a file generated by doxygen ----------------------------------------------------------------------- Summary of changes: .gitignore | 2 ++ TODO-RELEASE | 3 --- debian/changelog | 8 +++++++- debian/control | 6 +++--- debian/{libosmocore5.install => libosmocore6.install} | 0 debian/{libosmovty0.install => libosmovty1.install} | 0 src/Makefile.am | 2 +- src/ctrl/Makefile.am | 5 ++++- src/sim/Makefile.am | 7 +++++-- src/vty/Makefile.am | 2 +- 10 files changed, 23 insertions(+), 12 deletions(-) rename debian/{libosmocore5.install => libosmocore6.install} (100%) rename debian/{libosmovty0.install => libosmovty1.install} (100%) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Jan 18 18:27:26 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 18:27:26 GMT Subject: libosmo-abis.git branch master updated. 0.3.0-7-g2f0dd0c Message-ID: <201501181827.t0IIRQn0011771@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via 2f0dd0c01930fbc0dbf0c86946dd0a429f3cd6e2 (commit) from 90878590575cdcedbaf7b8f431e0fa102d0d2e50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=2f0dd0c01930fbc0dbf0c86946dd0a429f3cd6e2 commit 2f0dd0c01930fbc0dbf0c86946dd0a429f3cd6e2 Author: Holger Hans Peter Freyther Date: Sun Jan 18 19:27:07 2015 +0100 New upstream release ----------------------------------------------------------------------- Summary of changes: debian/changelog | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- Osmocom A-bis protcol interface library From gitosis at osmocom.org Sun Jan 18 18:28:31 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 18:28:31 GMT Subject: libosmo-abis.git annotated tag v0.3.1 created. v0.3.1 Message-ID: <201501181828.t0IISVAN011906@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The annotated tag, v0.3.1 has been created at 9d6abc04cdf6c293238c77759d7229fda9ed5770 (tag) tagging 2f0dd0c01930fbc0dbf0c86946dd0a429f3cd6e2 (commit) replaces 0.3.0 tagged by Holger Hans Peter Freyther on Sun Jan 18 19:27:58 2015 +0100 - Log ----------------------------------------------------------------- This is version 0.3.1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlS7+zMACgkQGckbdURWU2qlnwCePG3I+BFTPbeSqYEs12GY/Kjh 9mUAnixHr3tpUce53rba68Mrfy9yAo5B =oOlL -----END PGP SIGNATURE----- Holger Hans Peter Freyther (6): misc: Work with src != builddir ipa: Partially revert the e1inp_ipa_bts_rsl_connect_n commit ipa: Set the BSC_FD_WRITE in ipa_client_conn_open misdn: Close the file descriptor if the ioctl is failing ipa: Add API to clear the tx queue New upstream release Jacob Erlbeck (1): ipa: Declare all structs used ----------------------------------------------------------------------- hooks/post-receive -- Osmocom A-bis protcol interface library From gitosis at osmocom.org Sun Jan 18 18:30:07 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 18:30:07 GMT Subject: libosmocore.git annotated tag 0.8.0 created. 0.8.0 Message-ID: <201501181830.t0IIU7gB012094@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The annotated tag, 0.8.0 has been created at 0cdb8f1fe888f21d6de52201ffb0a58611623c31 (tag) tagging 25aeab7a8235141a72c7cbb37155d8949071ec3f (commit) replaces 0.7.0 tagged by Holger Hans Peter Freyther on Sun Jan 18 19:29:20 2015 +0100 - Log ----------------------------------------------------------------- This is version 0.8.0 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlS7+4YACgkQGckbdURWU2o82QCghG/21lU2F46JpffKEcbyRmY6 rSsAnA8HYLpDkLSGg0/jsvPwoZHq655n =4cZb -----END PGP SIGNATURE----- Ciaby (2): debian: fix build errors with libosmogsm and libosmoctrl Fix debian packaging Daniel Willmann (1): smscb/gsm0341_test: Add \r padding to the message Harald Welte (51): libctrl: Add support for 'deferred control commands' add port number 4238 for BTS control interface gsm48.h: define the reserved TMSI in libosmocore, not openbsc logging: Add ability to save/print current log filters add missing copyright statements to source code files Fix copyright header in gan.c msgb: make msgb_get() finally work as expected initial checkin of 'libosmosim' sim: osmo-sim-test: Also dump binary files sim: add copyright notices and merge file_codec.c into core.c sim: Use autotools for libpcsc-lite linkage sim: strip the SW from the returned data, as SW is passed in msgb->cb sim: add decoding of status words sim: further updates/fixes sim: Add minimal/recommended size of file / record sim: Add sfi to EF_*() macros sim: mark osim_msgb_cb as __may_alias__ to avoid gcc warnings sim: reader_pcsc.c: Avoid compiler warnings by using pcsc-lite LONG sim: Make osmo-sim-test compile again sim: Update to latest SIM/USIM specs and include size information sim: Add 3GPP TS 31.103 ISIM definitions sim: Only one default_decode() function for all card types sim: Make TETRA SIM (TSIM) support compile sim: More comments in sim.h sim: Prepare infrastructure for protocols != T=0 and other drivers sim: add missing const to reader_ops member of reader_handle sim: More talloc return NULL checking make sure to register DF.TELECOM and DF.GSM for SIM, USIM + TSIM remove doxygen_sqlite3.db during 'make clean' Merge branch 'laforge/sim' Change license of libosmogb from AGPLv3+ to GPLv2+ Change license of gsm0411_smc/smr to GPLv2+ Change copyright notice of ipa.c to GPLv2+ sttrb / loggingrb: Use GPLv2+ as license, not AGPLv3+ sim: reader_pcsc:Remove dead code osmo-sim-test: Fix read_binary() return check select.c: Add missing #include lines for string.h and sys/select.h strrb.c: Use string.h, not strings.h remove references to u_char type, use 'unsigned char' instead remove references to u_long type, use 'unsigned long' instead vty/vector.c: Use string.h, not memory.h fix libosmocore build for NuttX target libosmo-gsm: Add PCHAN/LCHAN types for CBCH Add Cell Broadcast MSGIDs from TS 23.041 v12.6.0 Release 12 add gsm0341_test to generate SMSCB hex strings fixup test add missing gsm0341.h SMS-CB: Add #defines for maximum block/msg size and payload chars use the new GSM341 / GSM412 size constants SMS-CB: introduce and use GSM341_7BIT_PADDING Holger Hans Peter Freyther (23): ctrl: Attempt fix the build on FreeBSD and add include file msgfile: Fix memleak in the test and release the list logging: Document the ABI breakage in the release todo debian: Depend on libosmocore5 for the legacy package debian: Depend on the right version of libosmogsm as well misc: Look into the build directory for generated files gprs-ns/test: Re-add return value check for gprs_nsvc_reset bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg bssgp: Include sys/socket.h for AF_INET on FreeBSD misc: Ignore the new test file as well pcsc: Fix the include path pcsc: Allow to disable the PCSC dependency vty: Check with the application before writing the config gtp: Add a global region for the gtp library of OpenGGSN logging: Make it possible to print category/subsys and timestamps logging: Call color only once and use the result ipa: Make a reservation for the GSUP protocol bitvec: Fix typo in the csn1 encoding code log: "logging level everything" is a badly named option. misc: Ignore a file generated by doxygen sim: Link to libosmocore and libosmogsm ctrl: Link to libraries we use symbols from Prepare a new libosmocore release Jacob Erlbeck (15): gprs: Fix and check BVCI in BSSGP STATUS messages gprs: Fix bssgp_rcvmsg to handle signalling msgs with BVCI IE gprs: Set bssgph field in bssgp_msgb_alloc() gprs-ns/test: Use gprs_nsvc_reset instead of gprs_ns_tx_reset gprs-ns/test: Save the last PDU type sent gprs-ns/test: Add expire_nsvc_timer gprs-ns/test: Add test_sgsn_reset_invalid_state gprs-ns: Let gprs_nsvc_reset return a value gprs-ns: Fix reset state handling gprs-ns/test: Check the nsvc state explicitely gprs/test: Add BSSGP tests gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg bssgp: Fix VTY command 'show bssgp nsei N' ipa: Add forward declaration of struct osmo_fd ipa: Return -errno instead of -1 in ipa_send Jan Engelhardt (4): utils: resolve compiler warnings on implicit declarations build: remove unused all_includes and use AM_CPPFLAGS build: fix linker error with kasumi_test build: resolve compiler warning about implicit delcaration Kevin Redon (7): sim: comment/explain signature of osim_new_apdumsg sim: add comment/explaination for structure osim_apdu_case sim: renamed case to the one defined in ISO7816-3 sim: added utils/osmo-sim-test to .gitignore sim: add comment/explaination for structure osim_apdu_cmd_hdr sim: add comment/explaination for structure osim_msgb_cb sim: replaced function/structure comments with doxygen comments Max (1): Move common socket routine into separate function Tobias Engel (1): Supplementary Services (de)activation, interrogation added ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Jan 18 22:16:08 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 22:16:08 GMT Subject: libosmocore.git branch master updated. 0.8.0-1-gf6a0ceb Message-ID: <201501182216.t0IMG8pA032255@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b (commit) from 25aeab7a8235141a72c7cbb37155d8949071ec3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b commit f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b Author: altaf Date: Mon Jan 12 12:51:44 2015 +0100 core/gsmtap: LTE RRC message types and LTE MAC define Submitted-by: altaf Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/gsmtap.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Jan 18 22:37:05 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 22:37:05 GMT Subject: gr-fosphor.git branch master updated. 55104042072ce202b49d4eab456de00f55d3f2b5 Message-ID: <201501182237.t0IMb56d034355@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNURadio block for spectrum visualization using GPU". The branch, master has been updated via 55104042072ce202b49d4eab456de00f55d3f2b5 (commit) via 95f603cc513c9fb33cfcf4558d0befe4d24f8448 (commit) via b1ec76c2f4ea0e0160d0207216e5c2c9b3c77a8f (commit) via f2ed7b07a3fa7b34158f327621e070dae974d9b0 (commit) from 36ce5e78430bcf87e219a97219051a9d62d1d834 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-fosphor/commit/?id=55104042072ce202b49d4eab456de00f55d3f2b5 commit 55104042072ce202b49d4eab456de00f55d3f2b5 Author: Sylvain Munaut Date: Sun Jan 18 23:26:05 2015 +0100 fosphor/cl: Balance the score of local_mem size a bit more Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=95f603cc513c9fb33cfcf4558d0befe4d24f8448 commit 95f603cc513c9fb33cfcf4558d0befe4d24f8448 Author: Sylvain Munaut Date: Sun Jan 18 23:24:04 2015 +0100 fosphor/cl: Fix overflow when querying local_mem size CL_DEVICE_LOCAL_MEM_SIZE is an unsigned long and can be quite large. Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=b1ec76c2f4ea0e0160d0207216e5c2c9b3c77a8f commit b1ec76c2f4ea0e0160d0207216e5c2c9b3c77a8f Author: Sylvain Munaut Date: Sun Jan 18 23:22:43 2015 +0100 fosphor/cl_compat: Blacklist POCL POCL pretends to be OpenCL 1.2 but it doesn't implement some of the required functions yet ... Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=f2ed7b07a3fa7b34158f327621e070dae974d9b0 commit f2ed7b07a3fa7b34158f327621e070dae974d9b0 Author: Sylvain Munaut Date: Fri Dec 26 16:53:17 2014 +0100 fosphor: Acquire the GL objects before cleaning buffers in cl_finish Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: lib/fosphor/cl.c | 22 +++++++++++++++++----- lib/fosphor/cl_compat.c | 5 +++++ 2 files changed, 22 insertions(+), 5 deletions(-) hooks/post-receive -- GNURadio block for spectrum visualization using GPU From gitosis at osmocom.org Sun Jan 18 23:23:56 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 18 Jan 2015 23:23:56 GMT Subject: gr-fosphor.git branch master updated. 1169b7efece549879e5a4cfae2df24cb72949e4a Message-ID: <201501182323.t0INNutM038402@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNURadio block for spectrum visualization using GPU". The branch, master has been updated via 1169b7efece549879e5a4cfae2df24cb72949e4a (commit) from 55104042072ce202b49d4eab456de00f55d3f2b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-fosphor/commit/?id=1169b7efece549879e5a4cfae2df24cb72949e4a commit 1169b7efece549879e5a4cfae2df24cb72949e4a Author: Sylvain Munaut Date: Mon Jan 19 00:23:24 2015 +0100 fosphor/cl: Fix warning due to unused var This should have been removed with a previous commit ... Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: lib/fosphor/cl.c | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- GNURadio block for spectrum visualization using GPU From gitosis at osmocom.org Mon Jan 19 13:17:09 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 19 Jan 2015 13:17:09 GMT Subject: gr-fosphor.git branch master updated. 8c9d6a21526b58ad281a782127dd76808c8dc12f Message-ID: <201501191317.t0JDH9Is011924@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNURadio block for spectrum visualization using GPU". The branch, master has been updated via 8c9d6a21526b58ad281a782127dd76808c8dc12f (commit) via 11f27973a948531283fbb42f6dc54bd42032762f (commit) via 720e702ee9e13b5427d1b07d075e91a22193933b (commit) via 95bb75593af23f6b44ad16fed7ee1620773f0b83 (commit) via 6da6cfe26213e1988fc5c592fb3b7e7253d8e6af (commit) via 64cf8a305b6a89a790d6c687c28cc959eb18d3bf (commit) from 1169b7efece549879e5a4cfae2df24cb72949e4a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-fosphor/commit/?id=8c9d6a21526b58ad281a782127dd76808c8dc12f commit 8c9d6a21526b58ad281a782127dd76808c8dc12f Author: Sylvain Munaut Date: Mon Jan 19 14:13:38 2015 +0100 gr-fosphor: Disable the color scale for the main view when zoomed Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=11f27973a948531283fbb42f6dc54bd42032762f commit 11f27973a948531283fbb42f6dc54bd42032762f Author: Sylvain Munaut Date: Mon Jan 19 13:57:04 2015 +0100 fosphor: Add a color intensity scale on the right side Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=720e702ee9e13b5427d1b07d075e91a22193933b commit 720e702ee9e13b5427d1b07d075e91a22193933b Author: Sylvain Munaut Date: Mon Jan 19 12:13:37 2015 +0100 fosphor/shaders: Use GLSL 1.3 instead of "1.5 compatibility" I originally used 1.5 compatibility because it still allows immediate mode / fixed pipeline without warning. But Intel Cards on linux and OSX in general don't implement it. Using 1.3 works fine since I don't need anything more recent, but if you display the compilation results, it will for a deprecation warning. Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=95bb75593af23f6b44ad16fed7ee1620773f0b83 commit 95bb75593af23f6b44ad16fed7ee1620773f0b83 Author: Sylvain Munaut Date: Mon Jan 19 09:44:39 2015 +0100 fosphor/gl_font: Make sure to set GL_TEXTURE_ENV_MODE properly GL_MODULATE is required and since it might be used in other mode for other function, we need to set it explicitely. Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=6da6cfe26213e1988fc5c592fb3b7e7253d8e6af commit 6da6cfe26213e1988fc5c592fb3b7e7253d8e6af Author: Sylvain Munaut Date: Mon Jan 19 00:58:46 2015 +0100 fosphor/gl: Allow fallback to GL_LUMINANCE32F_ARB internal format Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=64cf8a305b6a89a790d6c687c28cc959eb18d3bf commit 64cf8a305b6a89a790d6c687c28cc959eb18d3bf Author: Sylvain Munaut Date: Mon Jan 19 00:52:42 2015 +0100 fosphor/gl: Use glTexSubImage2D for texture update Much faster than glTexImage2D since it only updates the data and doesn't delete/create a new storage space for the data. Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: lib/base_sink_c_impl.cc | 2 ++ lib/fosphor/cmap_bicubic.glsl | 9 ++++++-- lib/fosphor/cmap_simple.glsl | 9 ++++++-- lib/fosphor/fosphor.c | 19 ++++++++++------ lib/fosphor/fosphor.h | 1 + lib/fosphor/gl.c | 50 +++++++++++++++++++++++++++++++++++++------ lib/fosphor/gl_cmap.c | 23 ++++++++++++++++++++ lib/fosphor/gl_cmap.h | 3 +++ lib/fosphor/gl_font.c | 2 ++ lib/fosphor/main.c | 2 ++ 10 files changed, 104 insertions(+), 16 deletions(-) hooks/post-receive -- GNURadio block for spectrum visualization using GPU From gitosis at osmocom.org Mon Jan 19 17:37:52 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 19 Jan 2015 17:37:52 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-891-g1b2e8e1 Message-ID: <201501191737.t0JHbq83035535@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 47c7031e8374c7f62fee4302ea4542db337dd805 (commit) discards a6f76044db12fad60f40df8711d5405956c9d121 (commit) discards be80c25828ed77525f4c16c8d4355aa082b549c7 (commit) discards de0a00f169dea08e6a9382d8c0b0954ee4d4dfbc (commit) discards de07f985b57ac534764d9020bac4d2e9550f3cb1 (commit) discards bb23b837207f293b8e375f44fe5c24a1172036f5 (commit) discards 209b4e36e3e642b0986bbacf3f41c496e4a27a43 (commit) discards 4a1139a07134956d1c68472381b6bebc5d29bb93 (commit) discards 435ac559683d4813c6f4ae9896deae60dc6d7f09 (commit) discards 523731fceba3e2b805bc2e3c1205f4a7c691bad8 (commit) discards e341cff4a0e3f1e4525be9d216fe09cdabb0111e (commit) discards cabb6cbbd299a5a48a3d8eb798f747ab6383b265 (commit) discards c940371242ec50cd2981c69a1e6667c7f80fbbef (commit) discards ea5906244efac709eb1fbcbd021a285fc4cbe7b8 (commit) discards 82b3b65f217a0432ab88909f9fb29d7aa1856541 (commit) discards 5b88584b0604269b1a830f8dfe1fec7319f3cdc7 (commit) discards 4c3cf3701c217c99cdaee39d28ee0acea2e1c374 (commit) discards 6cc8140d2b32abf620d6b47cd691162728029122 (commit) discards 018d3829388438da9a7734bcd6972077c8c35090 (commit) discards d8abd5df576d0180b2f78009fbe5707094e8aef1 (commit) discards b92861ddbc4a559a6e4c82b875a2b1406f6d6279 (commit) discards 4ffbfd3e4ebf5bfb5fa4ee298d88a6b721525420 (commit) discards 1d89966270e03838fa61a15a874ceb8be34c3de3 (commit) discards 98ed3fd8089b26895ef0177f1c1f3567cc3d0871 (commit) discards 7c998bd273986d5cbd38b93523e8bfd59ec6fbae (commit) discards bf6f8f6186f4cbd757e8c72083214493a95bc60d (commit) discards e08b0de9fe2d7c0ad60a7eb6b4bdc0af2d62177c (commit) discards 0b9733bfb3d15544b867210f138367bcf7d25cf5 (commit) discards a4c1213fd7b7da144b011a7d74d28f5ba670df1a (commit) discards 46d6fcc2cc2cbf6ad034a20fc6461f5016aa0bca (commit) discards 666d4c7f68e56bc380f1028509c60cbec5eebe87 (commit) discards 7275bd4d224ec91b50c0938d31b602a3c19a9a18 (commit) discards 13266266b9a8c6518b7153b8fdea4aa2c0328ffe (commit) discards 83c3f0be610073a5fe001ba39e45d4ac1f925e4c (commit) discards 3ee9213a6d3131da085f97929051a0b0d3e65d0c (commit) discards 49bf767559c5beb4d7de145fdbabe02a9cae577f (commit) discards dfb5722cf088eca6bc3bcbb74cdf5704b5638568 (commit) discards 418f6de75d1e54405e4e5501f50b1c4b2146551c (commit) discards 18e441b66e0a974028f4042141b1a801fb5f21e0 (commit) discards 71cd89a3e591951e7efd4b7065acfa9b15177ac5 (commit) discards 91740a67cb090f0507b8c364f8f3950b73a52beb (commit) discards d390bc452c0dca5c2e455ccdcda5515204a11413 (commit) discards a6cb44ea20e173b50c8197f44f588411c25c1c31 (commit) discards 33245e2c62baf0569edc53b4d39c3344a0372eba (commit) discards 2892ebf3ea5ae575c3760fd2fca95b331f9ba9d2 (commit) via 1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9 (commit) via 647ae2ff68b4e9a95c62b5837bf7330eb9a9aa2d (commit) via 3aa1f5242c550ab940ab913dc444fe24163a3dd9 (commit) via dd399a0da4f3d78ff980c8b2e741119fa1991319 (commit) via b25cd3064cf4c613ed19633657071ea2a9668582 (commit) via 50f009135d5814ba55e1fb718538eca1154d1b48 (commit) via ca4ec2cd26fef34825b430c7e0e16faaa8cb9fcd (commit) via a94708c025f864b38a6c1f4463f3e8de9a542547 (commit) via bbb716965344a46653ab388823570d575a7a6d8d (commit) via cedc73bf6346353e6c04a2ace9986a99cfa30475 (commit) via 870f7c20e1af47129ab055b72c288919cb89f6fc (commit) via 3793b21a42a3e33c0356a59d3153988bc40c7820 (commit) via a1f7a53a95483560f91fe601ed837581e25ebda1 (commit) via 244aeadb616702b34d479be3872a5e1bf71120b0 (commit) via 10a8847d671260da5d94d76c5751424f2f367a0e (commit) via 1635150f2ccfb3cba636b42ac8aa1c916e0ae8ec (commit) via a688976f10bfb0c14954a066aa133f28bce3a541 (commit) via 743dec4c0c80383556efac60f03d307287ecf024 (commit) via 65fa3f73a1151e896e4c74196680b7886a3b6be6 (commit) via 69d271376cce7d26a0469bbb948f272c399ac6c7 (commit) via cde0bb27a14553bba2f680cd1307a5f9b3581f0e (commit) via 058bc26e1bb1350c9077f99edd24887bb84bc8c5 (commit) via c157ee7d2ccdb7524e76d25b22cb7eec8de9a656 (commit) via 0f47b8fae743769a6627f8654444b4f0d665e050 (commit) via b8fb1409d1ed18dc198b430895a74e680640c2b1 (commit) via e1beb6f51d3822593d56e071d47e12a74f077826 (commit) via d3cde1ecf49940fae90ec5e1d36824ee0ba17501 (commit) via f06fe29f61c0089ca2f0c10faea18c65d5014f95 (commit) via bf34c67f3f5f747d71f844aec9ae61d26b273d6d (commit) via 42755785707a11c8349b86c2afb98b7bc15c85dc (commit) via bce2061b43c1e38b766cc3738b4ad669211dc6a4 (commit) via 9aa9991efe207f5c12bbcf655b0660e3466c02e0 (commit) via af3d5c508c9ca3ebae9388d3e09c5d7726db4f5c (commit) via afcf23001e600bedc51db08a22846dada9bc06b3 (commit) via 8054799963f4b3b936d601eb4b1f5774f2c41fec (commit) via 03b463034885e7ebb09160f6d63c05ac120a8098 (commit) via e154d8bdd45974fa6e9408b9d543eb9e9ea94b79 (commit) via 69e16b9ea5dc991f8373c11b9fcf45b7b1a8e940 (commit) via 4188c30c4a6574201d62df1be818eed038608d16 (commit) via 849d0a83e8598e0f21a3e9c5438c222d8ab417eb (commit) via 7660ffa29fb463fc24b2ac8d735b9b345017bba6 (commit) via 3d722450de1cf34931d95f7a748a9b6c48e933f0 (commit) via e21e184d84d6a932b58079084d254f498599e29e (commit) via 771573c535ae97ce7c7ed7694670e3b98eeae48a (commit) via a071c1ccc07074272f6cb7626b781f45f85564c6 (commit) via 9d4f46c975c3a4c92071c70ebadd6edc345581da (commit) via 39f040d62b16b2d99352f5facd83ce098fa2f462 (commit) via bb23dc17f8f56be836dc50c925c04a5aeaec979c (commit) via 1610626fe9e65693c6d8743129b10ed4958ec6ea (commit) via a2315eebf972412e122033ac036dd21bcdad5335 (commit) via 424ffa480630a4242d2a6f6b27b9e6b1ec08d206 (commit) via 0572ee045d1b7c29a0c34b27867b3f8669eb5038 (commit) via f0b06d82cd6f2a340db052a2fa2e559aa75f1fa8 (commit) via 07de92e2c0ccfa89b9498c8c49a74d0848b7b85a (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (47c7031e8374c7f62fee4302ea4542db337dd805) \ N -- N -- N (1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9 commit 1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9 Author: Jacob Erlbeck Date: Mon Jan 19 18:01:42 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout (TODO) Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is removed. If such an MM context doesn't exist, the LLME is unassigned directly. TODO: - split commit - replace hard-coded values by real config - age_timeout -> age, timeout: age = (age == RESET ? 1 : age + TICK) Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=647ae2ff68b4e9a95c62b5837bf7330eb9a9aa2d commit 647ae2ff68b4e9a95c62b5837bf7330eb9a9aa2d Author: Jacob Erlbeck Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions (TODO) TODO: - commit message - test Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3aa1f5242c550ab940ab913dc444fe24163a3dd9 commit 3aa1f5242c550ab940ab913dc444fe24163a3dd9 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dd399a0da4f3d78ff980c8b2e741119fa1991319 commit dd399a0da4f3d78ff980c8b2e741119fa1991319 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b25cd3064cf4c613ed19633657071ea2a9668582 commit b25cd3064cf4c613ed19633657071ea2a9668582 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=50f009135d5814ba55e1fb718538eca1154d1b48 commit 50f009135d5814ba55e1fb718538eca1154d1b48 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ca4ec2cd26fef34825b430c7e0e16faaa8cb9fcd commit ca4ec2cd26fef34825b430c7e0e16faaa8cb9fcd Author: Jacob Erlbeck Date: Mon Jan 19 14:11:46 2015 +0100 sgsn: Restructure the 'update-subscriber' command This patch drops the following commands: - update-subscriber imsi IMSI insert authorized <0-1> - update-subscriber imsi IMSI commit since they are already covered by the 'update-location-result' sub-command, except that this command doesn't create an new entry if none is found with the given IMSI. It adds the following command: - update-subscriber imsi IMSI create which can be used to create a new entry. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a94708c025f864b38a6c1f4463f3e8de9a542547 commit a94708c025f864b38a6c1f4463f3e8de9a542547 Author: Jacob Erlbeck Date: Mon Jan 19 14:29:43 2015 +0100 sgsn: Fix vty_out newlines Currently '\n' is used to end lines in the VTY output string constants instead of inserting VTY_NEWLINE. This leads to incorrect line starts in error messages. This patch fixes that accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=bbb716965344a46653ab388823570d575a7a6d8d commit bbb716965344a46653ab388823570d575a7a6d8d Author: Jacob Erlbeck Date: Mon Jan 19 11:10:04 2015 +0100 sgsn: Add SGSN_ERROR_CAUSE_NONE and use it instead of 0 Currently an error_cause of 0 is being used to indicate normal operation. Albeit this is not a defined GMM cause, the value is not explicitly reserved. This commit adds the macro SGSN_ERROR_CAUSE_NONE and uses it for initialisation (instead of relying on talloc_zero) and comparisons. The value is set to -1 to be on the safe side. The VTY code is updated to set the error_cause when using the 'update-subscriber imsi IMSI update-location-result CAUSE' command. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cedc73bf6346353e6c04a2ace9986a99cfa30475 commit cedc73bf6346353e6c04a2ace9986a99cfa30475 Author: Jacob Erlbeck Date: Mon Jan 19 10:56:15 2015 +0100 gprs: Return 0 from gsup_client_connect if ok or retry timer enabled Currently the gsup_client_connect return 0 if the call to ipa_client_conn_open was successful and -errno otherwise. This makes it difficult for the caller to determine, whether the the whole operation has been cancelled (currently on EBADF, ENOTSOCK, EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to connect after a timeout. This will cause gprs_gsup_client_create to destroy the GSUP client object, even if the error might be temporary. This patch changes the function to return 0 if (and only if) ipa_client_conn_open was successful or the retry timer has been started. Since the return value 0 doesn't guarantee, that a subsequent call to gprs_gsup_client_send will succeed, this shouldn't break anything. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=870f7c20e1af47129ab055b72c288919cb89f6fc commit 870f7c20e1af47129ab055b72c288919cb89f6fc Author: Jacob Erlbeck Date: Mon Jan 19 09:13:05 2015 +0100 sgsn: Fix access to subscr in sgsn_auth_update (Coverity) Currently the access to subscr->sgsn_data->error_cause is not protected against subscr == NULL like it is done in other code paths of sgsn_auth_update. This commit adds a conditional to avoid a NULL-dereference. Fixes: Coverity CID 1264589 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3793b21a42a3e33c0356a59d3153988bc40c7820 commit 3793b21a42a3e33c0356a59d3153988bc40c7820 Author: Jacob Erlbeck Date: Mon Jan 19 08:57:07 2015 +0100 sgsn/test: Make assert_substr safer (Coverity) Currently, if assert_subscr were called with subscr == NULL, the later call to subscr_put might fail, as Coverity has complained. In addition, the call to subscr_put would free the subscr object if it were in the cache with a refcount of 0 at the time assert_substr was called. This patch adds a check for the subscr being non-NULL and reorders the checks, so that the subscr_put comes last. Fixes: Coverity CID 1264590 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a1f7a53a95483560f91fe601ed837581e25ebda1 commit a1f7a53a95483560f91fe601ed837581e25ebda1 Author: Jacob Erlbeck Date: Thu Jan 15 18:51:31 2015 +0100 sgsn: Fix P-TMSI generator's distance of equal values Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then sets to upper 2 MSB. Therefore there is no lower limit of the distance between 2 identical P-TMSI. This patch changes the implementation to discard any random value above 2^30 and to generate a new random number in that case until a fitting number is found (or a repetition limit is reached). This way, all number below 2^30 within the PRNG's period are used. Ticket: OW#1362 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=244aeadb616702b34d479be3872a5e1bf71120b0 commit 244aeadb616702b34d479be3872a5e1bf71120b0 Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure Currently no GSUP LocationCancellationResult message is sent back to the peer (HLR), if the procedure succeeded at the SGSN's side. This patch adds the missing message and put the whole request handling of this procedure into a separate function. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=10a8847d671260da5d94d76c5751424f2f367a0e commit 10a8847d671260da5d94d76c5751424f2f367a0e Author: Jacob Erlbeck Date: Thu Jan 15 17:50:16 2015 +0100 gprs: Don't create a subscr entry on InsertSubscriberData Currently gprs_subscr_rx_gsup_message creates a subscriber entry if such an entry doesn't exist for the IMSI within an InsertSubscriberData GSUP message. This behaviour is not compliant to GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is defined, that an error ("Unidentified subscriber") shall be returned. This patch removes the case distinction, so that an existing subscriber entry is required for all incoming GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1635150f2ccfb3cba636b42ac8aa1c916e0ae8ec commit 1635150f2ccfb3cba636b42ac8aa1c916e0ae8ec Author: Jacob Erlbeck Date: Thu Jan 15 17:08:30 2015 +0100 gprs: Add replies for all GSUP requests Currently, an incoming GSUP request message isn't answered at all if it is not handled due to an error or missing implementation. This patch adds GSUP error replies for these requests (and only for requests). It also adds tests for these cases. Note that several of these tests check for GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when the features are implemented. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a688976f10bfb0c14954a066aa133f28bce3a541 commit a688976f10bfb0c14954a066aa133f28bce3a541 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be started until the PURGE_MS procedure has been completed. This patch implements this by adding corresponding state and checks to gprs_subscr_purge, gprs_subscr_location_update, and gprs_subscr_update_auth_info. If an Update Location or a Send Auth Info Req procedure is not started because of blocking, the retry mechanism is aborted to shorten the blocking time. The outstanding Purge MS procedure itself is not aborted. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_llc.h | 5 ++ openbsc/include/openbsc/gprs_sgsn.h | 4 +- openbsc/include/openbsc/gprs_utils.h | 5 ++ openbsc/include/openbsc/gsm_04_08_gprs.h | 5 +- openbsc/include/openbsc/sgsn.h | 2 + openbsc/src/gprs/gprs_gmm.c | 14 +++-- openbsc/src/gprs/gprs_gsup_client.c | 13 +++-- openbsc/src/gprs/gprs_llc.c | 4 ++ openbsc/src/gprs/gprs_llc_vty.c | 7 ++- openbsc/src/gprs/gprs_sgsn.c | 64 +++++++++++++++++++++++ openbsc/src/gprs/gprs_subscriber.c | 10 ++-- openbsc/src/gprs/gprs_utils.c | 31 ++++++++++++ openbsc/src/gprs/sgsn_auth.c | 4 +- openbsc/src/gprs/sgsn_main.c | 1 + openbsc/src/gprs/sgsn_vty.c | 87 +++++++++++++++----------------- openbsc/tests/sgsn/sgsn_test.c | 5 +- openbsc/tests/vty_test_runner.py | 10 ++-- 17 files changed, 201 insertions(+), 70 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 19 18:00:16 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 19 Jan 2015 18:00:16 GMT Subject: osmo-trx.git branch master updated. 722d4f70a4085448e0c02ba3fb9a4ee6a9077118 Message-ID: <201501191800.t0JI0GQM037624@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via 722d4f70a4085448e0c02ba3fb9a4ee6a9077118 (commit) from 93b7f373097f3b1563ff327ffa163846b8da0987 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=722d4f70a4085448e0c02ba3fb9a4ee6a9077118 commit 722d4f70a4085448e0c02ba3fb9a4ee6a9077118 Author: Tom Tsou Date: Mon Jan 19 09:54:17 2015 -0800 usrp1: Update device API for frequency offset tuning Commit 8e17df7374367d57 "Add option for baseband frequency offset", modified the base device API to allow for RF tuning, which was never updated for the USRP1. Update the implementation to match the API, however, note actual offset in the USRP1 remains unsupported. Signed-off-by: Tom Tsou ----------------------------------------------------------------------- Summary of changes: Transceiver52M/USRPDevice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- OpenBTS' transceiver retro-fit From gitosis at osmocom.org Tue Jan 20 10:38:44 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 10:38:44 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-891-g8d7aaa5 Message-ID: <201501201038.t0KAciXG026530@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9 (commit) via 8d7aaa590e9b952eef001ba01150e8e58c7debd2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (1b2e8e11206f00ca1a0b8367c2ea65a49a49b8c9) \ N -- N -- N (8d7aaa590e9b952eef001ba01150e8e58c7debd2) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8d7aaa590e9b952eef001ba01150e8e58c7debd2 commit 8d7aaa590e9b952eef001ba01150e8e58c7debd2 Author: Jacob Erlbeck Date: Mon Jan 19 18:01:42 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout (TODO) Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is removed. If such an MM context doesn't exist, the LLME is unassigned directly. TODO: - split commit - replace hard-coded values by real config - Consider: age_timeout -> age, timeout: age = (age == RESET ? 1 : age + TICK) Ticket: OW#1364 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/Makefile.am | 2 +- openbsc/tests/sgsn/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:09:50 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:09:50 GMT Subject: openbsc.git branch hfreyther/jerlbeck/mgcp-cleanups deleted. 0.13.0-197-gadf2c2c Message-ID: <201501201509.t0KF9oIf048178@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, hfreyther/jerlbeck/mgcp-cleanups has been deleted was adf2c2c2e7fd29c1e88a9e1142c4b50d78892d99 ----------------------------------------------------------------------- adf2c2c2e7fd29c1e88a9e1142c4b50d78892d99 mgcp: Handle SDP in CRCX received by the MGW ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:15:03 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:15:03 GMT Subject: openbsc.git branch master updated. 0.13.0-884-gd919343 Message-ID: <201501201515.t0KFF34C048734@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via d91934357fe28e5362da600e61fd6473f33ff62b (commit) via 15cc8c812553e60422ce1917ba8e4230d7eab0b4 (commit) via d6267d12d8bd945f219b3d2f7bf04060fe2d83bd (commit) via 2585620857a3a6c17b17a65a3d9a863824b8e401 (commit) via 6be9ffa3b811311043194d04ae06e05d216c57bb (commit) via d8a65536ecc6eae026898822b58f520f5ee25ac7 (commit) via 87c7ffccea5fb8a579ade220e6e4754f857e4ecc (commit) via 4dedb27d7e7829099bf0873ecd6af3b9b9e570b5 (commit) via 9999fd9026fbb3f4a7d07a455698230d209dbcb6 (commit) via f81cacc6814dde73f203d125b0065d1451a98317 (commit) from 743dec4c0c80383556efac60f03d307287ecf024 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=d91934357fe28e5362da600e61fd6473f33ff62b commit d91934357fe28e5362da600e61fd6473f33ff62b Author: Jacob Erlbeck Date: Mon Jan 19 14:11:46 2015 +0100 sgsn: Restructure the 'update-subscriber' command This patch drops the following commands: - update-subscriber imsi IMSI insert authorized <0-1> - update-subscriber imsi IMSI commit since they are already covered by the 'update-location-result' sub-command, except that this command doesn't create an new entry if none is found with the given IMSI. It adds the following command: - update-subscriber imsi IMSI create which can be used to create a new entry. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=15cc8c812553e60422ce1917ba8e4230d7eab0b4 commit 15cc8c812553e60422ce1917ba8e4230d7eab0b4 Author: Jacob Erlbeck Date: Mon Jan 19 14:29:43 2015 +0100 sgsn: Fix vty_out newlines Currently '\n' is used to end lines in the VTY output string constants instead of inserting VTY_NEWLINE. This leads to incorrect line starts in error messages. This patch fixes that accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d6267d12d8bd945f219b3d2f7bf04060fe2d83bd commit d6267d12d8bd945f219b3d2f7bf04060fe2d83bd Author: Jacob Erlbeck Date: Mon Jan 19 11:10:04 2015 +0100 sgsn: Add SGSN_ERROR_CAUSE_NONE and use it instead of 0 Currently an error_cause of 0 is being used to indicate normal operation. Albeit this is not a defined GMM cause, the value is not explicitly reserved. This commit adds the macro SGSN_ERROR_CAUSE_NONE and uses it for initialisation (instead of relying on talloc_zero) and comparisons. The value is set to -1 to be on the safe side. The VTY code is updated to set the error_cause when using the 'update-subscriber imsi IMSI update-location-result CAUSE' command. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2585620857a3a6c17b17a65a3d9a863824b8e401 commit 2585620857a3a6c17b17a65a3d9a863824b8e401 Author: Jacob Erlbeck Date: Mon Jan 19 09:13:05 2015 +0100 sgsn: Fix access to subscr in sgsn_auth_update (Coverity) Currently the access to subscr->sgsn_data->error_cause is not protected against subscr == NULL like it is done in other code paths of sgsn_auth_update. This commit adds a conditional to avoid a NULL-dereference. Fixes: Coverity CID 1264589 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6be9ffa3b811311043194d04ae06e05d216c57bb commit 6be9ffa3b811311043194d04ae06e05d216c57bb Author: Jacob Erlbeck Date: Mon Jan 19 08:57:07 2015 +0100 sgsn/test: Make assert_substr safer (Coverity) Currently, if assert_subscr were called with subscr == NULL, the later call to subscr_put might fail, as Coverity has complained. In addition, the call to subscr_put would free the subscr object if it were in the cache with a refcount of 0 at the time assert_substr was called. This patch adds a check for the subscr being non-NULL and reorders the checks, so that the subscr_put comes last. Fixes: Coverity CID 1264590 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d8a65536ecc6eae026898822b58f520f5ee25ac7 commit d8a65536ecc6eae026898822b58f520f5ee25ac7 Author: Jacob Erlbeck Date: Thu Jan 15 18:51:31 2015 +0100 sgsn: Fix P-TMSI generator's distance of equal values Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then sets to upper 2 MSB. Therefore there is no lower limit of the distance between 2 identical P-TMSI. This patch changes the implementation to discard any random value above 2^30 and to generate a new random number in that case until a fitting number is found (or a repetition limit is reached). This way, all number below 2^30 within the PRNG's period are used. Ticket: OW#1362 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=87c7ffccea5fb8a579ade220e6e4754f857e4ecc commit 87c7ffccea5fb8a579ade220e6e4754f857e4ecc Author: Jacob Erlbeck Date: Thu Jan 8 15:29:01 2015 +0100 gprs: Support the full cancellation procedure Currently no GSUP LocationCancellationResult message is sent back to the peer (HLR), if the procedure succeeded at the SGSN's side. This patch adds the missing message and put the whole request handling of this procedure into a separate function. Ticket: OW#1338 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4dedb27d7e7829099bf0873ecd6af3b9b9e570b5 commit 4dedb27d7e7829099bf0873ecd6af3b9b9e570b5 Author: Jacob Erlbeck Date: Thu Jan 15 17:50:16 2015 +0100 gprs: Don't create a subscr entry on InsertSubscriberData Currently gprs_subscr_rx_gsup_message creates a subscriber entry if such an entry doesn't exist for the IMSI within an InsertSubscriberData GSUP message. This behaviour is not compliant to GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is defined, that an error ("Unidentified subscriber") shall be returned. This patch removes the case distinction, so that an existing subscriber entry is required for all incoming GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9999fd9026fbb3f4a7d07a455698230d209dbcb6 commit 9999fd9026fbb3f4a7d07a455698230d209dbcb6 Author: Jacob Erlbeck Date: Thu Jan 15 17:08:30 2015 +0100 gprs: Add replies for all GSUP requests Currently, an incoming GSUP request message isn't answered at all if it is not handled due to an error or missing implementation. This patch adds GSUP error replies for these requests (and only for requests). It also adds tests for these cases. Note that several of these tests check for GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when the features are implemented. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f81cacc6814dde73f203d125b0065d1451a98317 commit f81cacc6814dde73f203d125b0065d1451a98317 Author: Jacob Erlbeck Date: Thu Jan 8 16:23:25 2015 +0100 gprs: Block other GSUP procedures during PURGE_MS GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be started until the PURGE_MS procedure has been completed. This patch implements this by adding corresponding state and checks to gprs_subscr_purge, gprs_subscr_location_update, and gprs_subscr_update_auth_info. If an Update Location or a Send Auth Info Req procedure is not started because of blocking, the retry mechanism is aborted to shorten the blocking time. The outstanding Purge MS procedure itself is not aborted. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_gsup_messages.h | 4 + openbsc/include/openbsc/gprs_sgsn.h | 17 ++- openbsc/src/gprs/gprs_gmm.c | 4 +- openbsc/src/gprs/gprs_sgsn.c | 28 ++++- openbsc/src/gprs/gprs_subscriber.c | 151 +++++++++++++++++++++---- openbsc/src/gprs/sgsn_auth.c | 4 +- openbsc/src/gprs/sgsn_vty.c | 87 +++++++-------- openbsc/tests/sgsn/sgsn_test.c | 160 ++++++++++++++++++++++++++- openbsc/tests/sgsn/sgsn_test.ok | 1 + openbsc/tests/vty_test_runner.py | 10 +- 10 files changed, 386 insertions(+), 80 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:17:00 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:17:00 GMT Subject: openbsc.git branch jerlbeck/enh/mgcp-use-sdp deleted. 0.13.0-196-g257e5d4 Message-ID: <201501201517.t0KFH0Y5048892@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/enh/mgcp-use-sdp has been deleted was 257e5d435c3335feab4401af00870327b096f155 ----------------------------------------------------------------------- 257e5d435c3335feab4401af00870327b096f155 mgcp: Handle SDP in CRCX received by the MGW ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:18:41 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:18:41 GMT Subject: openbsc.git branch jerlbeck/features/mgcp-rtp-keep-alive deleted. 0.13.0-271-g23fccbd Message-ID: <201501201518.t0KFIfJT049085@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/features/mgcp-rtp-keep-alive has been deleted was 23fccbdc023aa125b2976c627e6bc9c99ed4a36b ----------------------------------------------------------------------- 23fccbdc023aa125b2976c627e6bc9c99ed4a36b mgcp: Send RTP keepalive dummy packets to net ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:19:55 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:19:55 GMT Subject: openbsc.git branch jerlbeck/features/rtp-header-patching deleted. 0.13.0-208-gf6ec0e9 Message-ID: <201501201519.t0KFJtSO049192@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/features/rtp-header-patching has been deleted was f6ec0e9fc4261d2173286e9b23fd19060040d1d1 ----------------------------------------------------------------------- f6ec0e9fc4261d2173286e9b23fd19060040d1d1 mgcp/rtp: Refactored packet_duration computation ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:21:18 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:21:18 GMT Subject: openbsc.git branch jerlbeck/features/mgcp-transcoding deleted. 0.13.0-414-g452c183 Message-ID: <201501201521.t0KFLISr049620@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/features/mgcp-transcoding has been deleted was 452c183c5ee9cc2c1b0225d9706d0425b8c655e3 ----------------------------------------------------------------------- 452c183c5ee9cc2c1b0225d9706d0425b8c655e3 mgcp: Set net_end audio params in recvonly mode ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 15:22:35 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 15:22:35 GMT Subject: openbsc.git branch jerlbeck/hacks/mgcp-audio-processing deleted. 0.13.0-331-g4781762 Message-ID: <201501201522.t0KFMZVc049848@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/hacks/mgcp-audio-processing has been deleted was 47817623d57cd1ff5b754eaa650d7a18e1764da4 ----------------------------------------------------------------------- 47817623d57cd1ff5b754eaa650d7a18e1764da4 mgcp: Fix CRCX payload type in SDP (TODO) ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 20 20:54:47 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 20:54:47 GMT Subject: gr-fosphor.git branch master updated. 985c78ffa7ecfc0d4b5b43d2541e68a9e6d94576 Message-ID: <201501202054.t0KKslEI077361@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNURadio block for spectrum visualization using GPU". The branch, master has been updated via 985c78ffa7ecfc0d4b5b43d2541e68a9e6d94576 (commit) via 1603497411d30a12e9822abe0a6cf3c021298941 (commit) via 7e195eea1bc2e938eda86f13ee9868bc1afc7232 (commit) via 5aa7c2f7bdba58f57a243fd4fe65270561165433 (commit) from 8c9d6a21526b58ad281a782127dd76808c8dc12f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-fosphor/commit/?id=985c78ffa7ecfc0d4b5b43d2541e68a9e6d94576 commit 985c78ffa7ecfc0d4b5b43d2541e68a9e6d94576 Author: Sylvain Munaut Date: Tue Jan 20 21:52:47 2015 +0100 fosphor/cl: Handle invalid (infinite/nan) data better so it recovers Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=1603497411d30a12e9822abe0a6cf3c021298941 commit 1603497411d30a12e9822abe0a6cf3c021298941 Author: Sylvain Munaut Date: Tue Jan 20 21:52:12 2015 +0100 fosphor/gl: Use the right cmap when drawing the histogram intensity scale Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=7e195eea1bc2e938eda86f13ee9868bc1afc7232 commit 7e195eea1bc2e938eda86f13ee9868bc1afc7232 Author: Sylvain Munaut Date: Mon Jan 19 23:17:06 2015 +0100 fosphor/cl: Allow to use APIs deprecated in 2.0 without warnings This app is CL 1.1 compatible and so we're forced to use some API that were deprecated in 2.0, no need to be constantly reminded of it Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/gr-fosphor/commit/?id=5aa7c2f7bdba58f57a243fd4fe65270561165433 commit 5aa7c2f7bdba58f57a243fd4fe65270561165433 Author: Sylvain Munaut Date: Mon Jan 19 23:12:24 2015 +0100 build: Fix CMake 3.x.x warnings Corresponding commit in the cmake git tree : 2509c7678feb2efab79a384fd0b0b35cee8d02b0 Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: cmake/Modules/GrSetupQt4.cmake | 8 +------- lib/fosphor/cl_platform.h | 1 + lib/fosphor/display.cl | 13 +++++++++---- lib/fosphor/gl.c | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) hooks/post-receive -- GNURadio block for spectrum visualization using GPU From gitosis at osmocom.org Tue Jan 20 20:59:04 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 20 Jan 2015 20:59:04 GMT Subject: openbsc.git branch hfreyther/changes/remove-gprs-subscriber-cache created. 0.13.0-885-gcf8cc22 Message-ID: <201501202059.t0KKx4r5077850@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, hfreyther/changes/remove-gprs-subscriber-cache has been created at cf8cc2289bf343ca07bd2de58066acf569f932b2 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=cf8cc2289bf343ca07bd2de58066acf569f932b2 commit cf8cc2289bf343ca07bd2de58066acf569f932b2 Author: Holger Hans Peter Freyther Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove the "permanent" subscriber cache The subscriber cache would help in case: * GPRS DETACH, GPRS ATTACH. In that case we might still have some cached authentication tuples we avoid another sendAuthenticationInfo request. * After a detach the cache expiry would make sure to eventually send a purgeMS to the HLR (which might be ignored). At the same time to make the cache work we will need to make sure to start and stop timers. In case we don't start we might accumulate subscribers. I am afraid that the above two benefits do not outweight the complexity of this implementation. Modify sgsn_mm_ctx_free to remove the entry from the list as otherwise we might double free the context from within gprs_subscriber_delete. ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 10:44:41 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 10:44:41 GMT Subject: openbsc.git branch master updated. 0.13.0-885-g9be675e Message-ID: <201501211044.t0LAif9M051501@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 9be675ea52c2da4b7e2de3339e3d600efc8a853b (commit) from d91934357fe28e5362da600e61fd6473f33ff62b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=9be675ea52c2da4b7e2de3339e3d600efc8a853b commit 9be675ea52c2da4b7e2de3339e3d600efc8a853b Author: Holger Hans Peter Freyther Date: Wed Jan 21 11:39:47 2015 +0100 mgcp: Honor the rtp IP_TOS settings for Osmux Honor the IP_TOS settings for Osmux as well. Re-use the RTP setting as it makes sense to classify the audio packets the same way. Fixes: OW#1369 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/mgcp_internal.h | 2 ++ openbsc/src/libmgcp/mgcp_network.c | 6 +++--- openbsc/src/libmgcp/mgcp_osmux.c | 1 + openbsc/src/libmgcp/mgcp_vty.c | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 10:48:03 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 10:48:03 GMT Subject: openbsc.git branch on-waves/201504 created. 0.13.0-665-g743654f Message-ID: <201501211048.t0LAm3rn051782@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, on-waves/201504 has been created at 743654f3603e9209b4d7de75122bdd99ce4e97ae (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=743654f3603e9209b4d7de75122bdd99ce4e97ae commit 743654f3603e9209b4d7de75122bdd99ce4e97ae Author: Holger Hans Peter Freyther Date: Wed Jan 21 11:39:47 2015 +0100 mgcp: Honor the rtp IP_TOS settings for Osmux Honor the IP_TOS settings for Osmux as well. Re-use the RTP setting as it makes sense to classify the audio packets the same way. Fixes: OW#1369 Conflicts: openbsc/include/openbsc/mgcp_internal.h ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 11:19:56 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 11:19:56 GMT Subject: openbsc.git branch jerlbeck/packages/sgsn created. 0.13.0-895-gb7ae3e7 Message-ID: <201501211119.t0LBJuWj054396@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/packages/sgsn has been created at b7ae3e742fdd0ec18b0aac40c66233da80d42bee (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b7ae3e742fdd0ec18b0aac40c66233da80d42bee commit b7ae3e742fdd0ec18b0aac40c66233da80d42bee Author: Jacob Erlbeck Date: Tue Jan 20 09:15:40 2015 +0100 debian: Prepare testing release 0.13.2+j1 http://cgit.osmocom.org/openbsc/commit/?id=28480a65fc8d8140715e84d4acefe54eb182b498 commit 28480a65fc8d8140715e84d4acefe54eb182b498 Author: Jacob Erlbeck Date: Tue Jan 20 09:03:19 2015 +0100 debian: Fix dependencies The dependecies do not match the current package names or are missing: Build-Depends: - renamed libgtp-dev -> libgtp0-dev - added libosmo-netif-dev Depends: - renamed libgtp -> libgtp0 Other run time dependencies might still be missing and have to be installed manually. This is taken from Holger's e744ebd17c3761b5cad81d718d0349f2f820ec66. In addition, the build-dependency on libgtp-dev is replaced by libgtp0-dev. http://cgit.osmocom.org/openbsc/commit/?id=f2e95c9d58e207a4c68e90b52c636c98ea55a32d commit f2e95c9d58e207a4c68e90b52c636c98ea55a32d Author: Holger Hans Peter Freyther Date: Sun Mar 3 18:27:55 2013 +0100 Revert "libgb/gprs: don't use log_info from libcommon anymore" This reverts commit 11461a64574314fbc4747fe6251ca000fdd56b75. This is causing crashes as soon as the VTY is used. Debugged by Katerina and spotted by the customer and during VTY testing. Conflicts: openbsc/include/osmocom/gprs/gprs_msgb.h openbsc/src/gprs/sgsn_main.c openbsc/src/libgb/common_vty.c http://cgit.osmocom.org/openbsc/commit/?id=3688abb0b24bf5065f5f8fdf3bac6442cb87812a commit 3688abb0b24bf5065f5f8fdf3bac6442cb87812a Author: Jacob Erlbeck Date: Tue Jan 20 09:25:43 2015 +0100 gbproxy: Remove dummy definition of subscr_put The definition of subscr_put in gb_proxy_main.c will break linking if symbols from libcommon are used. Since subscr_put is in libcommon, there is no need for this dummy definition anymore. This needs to be fixed to apply 'Revert "libgb/gprs: don't use log_info...'. This patch removes the dummy definition. Adresses: ../../src/libcommon/libcommon.a(gsm_subscriber_base.o): In function `subscr_put': /home/jerlbeck/git/build/openbsc/openbsc/src/libcommon/gsm_subscriber_base.c:90: multiple definition of `subscr_put' gb_proxy_main.o:/home/jerlbeck/git/build/openbsc/openbsc/src/gprs/gb_proxy_main.c:56: first defined here c Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 12:01:57 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 12:01:57 GMT Subject: openbsc.git branch hfreyther/packages created. 0.13.0-908-gfdf4ade Message-ID: <201501211201.t0LC1v65060601@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, hfreyther/packages has been created at fdf4adee32a51001eb2b4aeb0209c7529fa07cd3 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=fdf4adee32a51001eb2b4aeb0209c7529fa07cd3 commit fdf4adee32a51001eb2b4aeb0209c7529fa07cd3 Author: Holger Hans Peter Freyther Date: Wed Jan 21 12:58:49 2015 +0100 debian: Add current changelog entry http://cgit.osmocom.org/openbsc/commit/?id=aa037de859f4f7ef8b789695ecd401561e285c6e commit aa037de859f4f7ef8b789695ecd401561e285c6e Merge: b7ae3e7 9be675e Author: Holger Hans Peter Freyther Date: Wed Jan 21 12:58:13 2015 +0100 Merge remote-tracking branch 'origin/master' into hfreyther/packages Conflicts: openbsc/include/openbsc/gprs_sgsn.h ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 14:14:15 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 14:14:15 GMT Subject: openbsc.git branch master updated. 0.13.0-886-gb194862 Message-ID: <201501211414.t0LEEFeO071613@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via b194862b62ffd808c91011f37f2412ebd3cb7378 (commit) from 9be675ea52c2da4b7e2de3339e3d600efc8a853b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b194862b62ffd808c91011f37f2412ebd3cb7378 commit b194862b62ffd808c91011f37f2412ebd3cb7378 Author: Jacob Erlbeck Date: Tue Jan 20 09:03:19 2015 +0100 debian: Fix dependencies The dependecies do not match the current package names or are missing: Build-Depends: - renamed libgtp-dev -> libgtp0-dev - added libosmo-netif-dev Depends: - renamed libgtp -> libgtp0 Other run time dependencies might still be missing and have to be installed manually. This is taken from Holger's e744ebd17c3761b5cad81d718d0349f2f820ec66. In addition, the build-dependency on libgtp-dev is replaced by libgtp0-dev. ----------------------------------------------------------------------- Summary of changes: debian/control | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 15:57:27 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 15:57:27 GMT Subject: openbsc.git branch master updated. 0.13.0-887-g9d1a17e Message-ID: <201501211557.t0LFvRs3082951@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) from b194862b62ffd808c91011f37f2412ebd3cb7378 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=9d1a17e15f6902bc9591680da3375b2d14db16ab commit 9d1a17e15f6902bc9591680da3375b2d14db16ab Author: Holger Hans Peter Freyther Date: Wed Jan 21 16:53:53 2015 +0100 osmux: Initialize the socket only once The per BSC code didn't guard against the init already having been executed. This lead to: Adding a osmo_fd that is already in the list. <000b> bsc_nat_vty.c:1200 Setting up OSMUX socket So a new socket got created and the old one leaked. Luckily Linux appears to allow to bind multiple times so we were able to just read from the new one. Use the same guard that is used on the MGCP MGW. Re-order the log message to say "Setting up" before we actually do that. I manually verified that osmux_init is called at most once. The log message was spotted by Roch ----------------------------------------------------------------------- Summary of changes: openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Jan 21 16:02:10 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 21 Jan 2015 16:02:10 GMT Subject: openbsc.git branch hfreyther/packages updated. 0.13.0-912-ga96c6d7 Message-ID: <201501211602.t0LG2AZJ083495@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, hfreyther/packages has been updated via a96c6d7aa2a4b588398e1c872d275b4c3660e4ba (commit) via fd5aefb73ec944e138d53488916b58421bf44992 (commit) via 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) via b194862b62ffd808c91011f37f2412ebd3cb7378 (commit) from fdf4adee32a51001eb2b4aeb0209c7529fa07cd3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=a96c6d7aa2a4b588398e1c872d275b4c3660e4ba commit a96c6d7aa2a4b588398e1c872d275b4c3660e4ba Author: Holger Hans Peter Freyther Date: Wed Jan 21 17:01:53 2015 +0100 debian: Create a new package http://cgit.osmocom.org/openbsc/commit/?id=fd5aefb73ec944e138d53488916b58421bf44992 commit fd5aefb73ec944e138d53488916b58421bf44992 Merge: fdf4ade 9d1a17e Author: Holger Hans Peter Freyther Date: Wed Jan 21 17:01:19 2015 +0100 Merge remote-tracking branch 'origin/master' into hfreyther/packages ----------------------------------------------------------------------- Summary of changes: debian/changelog | 3 ++- openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 22 17:08:50 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 22 Jan 2015 17:08:50 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-894-g9668599 Message-ID: <201501221708.t0MH8oIx028691@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 8d7aaa590e9b952eef001ba01150e8e58c7debd2 (commit) discards 647ae2ff68b4e9a95c62b5837bf7330eb9a9aa2d (commit) discards 3aa1f5242c550ab940ab913dc444fe24163a3dd9 (commit) discards dd399a0da4f3d78ff980c8b2e741119fa1991319 (commit) discards b25cd3064cf4c613ed19633657071ea2a9668582 (commit) discards 50f009135d5814ba55e1fb718538eca1154d1b48 (commit) discards ca4ec2cd26fef34825b430c7e0e16faaa8cb9fcd (commit) discards a94708c025f864b38a6c1f4463f3e8de9a542547 (commit) discards bbb716965344a46653ab388823570d575a7a6d8d (commit) discards cedc73bf6346353e6c04a2ace9986a99cfa30475 (commit) discards 870f7c20e1af47129ab055b72c288919cb89f6fc (commit) discards 3793b21a42a3e33c0356a59d3153988bc40c7820 (commit) discards a1f7a53a95483560f91fe601ed837581e25ebda1 (commit) discards 244aeadb616702b34d479be3872a5e1bf71120b0 (commit) discards 10a8847d671260da5d94d76c5751424f2f367a0e (commit) discards 1635150f2ccfb3cba636b42ac8aa1c916e0ae8ec (commit) discards a688976f10bfb0c14954a066aa133f28bce3a541 (commit) via 966859933250d61a05c069e8871e20e08fd0c2af (commit) via 3f90ab1f019b734efbca778a0f3f169ce5e48379 (commit) via fe625302549c8a27f901f417cb816d7c05a00e8b (commit) via 70fb27bcfcfd79480e16a888588198747b6b9a13 (commit) via d185e9814d6fe44a3d86627c0fef3cc1d6849e13 (commit) via 0daf96a5e5dfe0e060e2f0992eba17cc7abb6b19 (commit) via b2426e6af78d6fc057e45696168c7c3d56b86584 (commit) via 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) via b194862b62ffd808c91011f37f2412ebd3cb7378 (commit) via 9be675ea52c2da4b7e2de3339e3d600efc8a853b (commit) via d91934357fe28e5362da600e61fd6473f33ff62b (commit) via 15cc8c812553e60422ce1917ba8e4230d7eab0b4 (commit) via d6267d12d8bd945f219b3d2f7bf04060fe2d83bd (commit) via 2585620857a3a6c17b17a65a3d9a863824b8e401 (commit) via 6be9ffa3b811311043194d04ae06e05d216c57bb (commit) via d8a65536ecc6eae026898822b58f520f5ee25ac7 (commit) via 87c7ffccea5fb8a579ade220e6e4754f857e4ecc (commit) via 4dedb27d7e7829099bf0873ecd6af3b9b9e570b5 (commit) via 9999fd9026fbb3f4a7d07a455698230d209dbcb6 (commit) via f81cacc6814dde73f203d125b0065d1451a98317 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (8d7aaa590e9b952eef001ba01150e8e58c7debd2) \ N -- N -- N (966859933250d61a05c069e8871e20e08fd0c2af) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=966859933250d61a05c069e8871e20e08fd0c2af commit 966859933250d61a05c069e8871e20e08fd0c2af Author: Jacob Erlbeck Date: Mon Jan 19 18:01:42 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout (TODO) Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is removed. If such an MM context doesn't exist, the LLME is unassigned directly. TODO: - split commit - replace hard-coded values by real config - Consider: age_timeout -> age, timeout: age = (age == RESET ? 1 : age + TICK) pro: avoid clock_gettime cons: dirty cache per LLME, osmo_timer is based on CLOCK_REALTIME Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3f90ab1f019b734efbca778a0f3f169ce5e48379 commit 3f90ab1f019b734efbca778a0f3f169ce5e48379 Author: Jacob Erlbeck Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions (TODO) TODO: - commit message Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fe625302549c8a27f901f417cb816d7c05a00e8b commit fe625302549c8a27f901f417cb816d7c05a00e8b Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=70fb27bcfcfd79480e16a888588198747b6b9a13 commit 70fb27bcfcfd79480e16a888588198747b6b9a13 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d185e9814d6fe44a3d86627c0fef3cc1d6849e13 commit d185e9814d6fe44a3d86627c0fef3cc1d6849e13 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0daf96a5e5dfe0e060e2f0992eba17cc7abb6b19 commit 0daf96a5e5dfe0e060e2f0992eba17cc7abb6b19 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b2426e6af78d6fc057e45696168c7c3d56b86584 commit b2426e6af78d6fc057e45696168c7c3d56b86584 Author: Jacob Erlbeck Date: Mon Jan 19 10:56:15 2015 +0100 gprs: Return 0 from gsup_client_connect if ok or retry timer enabled Currently the gsup_client_connect return 0 if the call to ipa_client_conn_open was successful and -errno otherwise. This makes it difficult for the caller to determine, whether the the whole operation has been cancelled (currently on EBADF, ENOTSOCK, EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to connect after a timeout. This will cause gprs_gsup_client_create to destroy the GSUP client object, even if the error might be temporary. This patch changes the function to return 0 if (and only if) ipa_client_conn_open was successful or the retry timer has been started. Since the return value 0 doesn't guarantee, that a subsequent call to gprs_gsup_client_send will succeed, this shouldn't break anything. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: debian/control | 4 +-- openbsc/include/openbsc/gprs_gmm.h | 2 ++ openbsc/include/openbsc/mgcp_internal.h | 2 ++ openbsc/src/gprs/gprs_gmm.c | 21 +++++++++--- openbsc/src/gprs/gprs_sgsn.c | 5 ++- openbsc/src/gprs/gprs_utils.c | 10 ++++-- openbsc/src/libmgcp/mgcp_network.c | 6 ++-- openbsc/src/libmgcp/mgcp_osmux.c | 1 + openbsc/src/libmgcp/mgcp_vty.c | 2 +- openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 8 +++-- openbsc/tests/gprs/gprs_test.c | 58 +++++++++++++++++++++++++++++++++ openbsc/tests/gprs/gprs_test.ok | 1 + 12 files changed, 100 insertions(+), 20 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 23 08:41:45 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 23 Jan 2015 08:41:45 GMT Subject: osmo-st-all.git branch master updated. 718ab61e798bc4ce8b5566c017303020c6aba786 Message-ID: <201501230841.t0N8fj1w018220@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Git submodule with Smalltalk modules". The branch, master has been updated via 718ab61e798bc4ce8b5566c017303020c6aba786 (commit) via aba6a6f030732f6f1a5cb714c2658fb086d9d880 (commit) via 6708e541594aef7e2c5c9b587885fe74ede7691c (commit) via ea1d89b8e8ec7f73421a40717ce0e1170c35b7d5 (commit) via 89e653a41aff48b9d861673affd17722744ed8cb (commit) via 9161371a3215e5be0f010d83bd26a9655abe338e (commit) via d5248eceecd9d2f8c7061538163bc8ec80168dfc (commit) via ab3b8e23fdf2cf40847bdcc854e14207908d1391 (commit) via fb5ddd43bb1383e5e2d7f9c4f38df422fa98e647 (commit) via a536a7a788f21222fbca001d2df4b2578ab47721 (commit) via 1a20f003aa5fc7cbeee06db76a9872ea12725ae1 (commit) via 1e43d02ed39d926714ee68b213bfbe234f395d1e (commit) via df79f4c46949379f263db8d10392059428af7bbd (commit) via 0ffe0afcb511d3abb2c0dda69c15f2b1bf74c770 (commit) via 9bd9a9e3b6826f99ec330ec0086321a599e470f6 (commit) via 77d1ac2eabfb594af4e84acef58c8632870c3190 (commit) via 88c800559736a39edc67fda0506460dcbf4976cf (commit) via aa8d9b64c62440f11f71226da1dd507fc0af4cc1 (commit) via 18c4ddfd7bb95b403eaf953ebdf3b2100bcae9d4 (commit) via 216c6fdcb65446358b4efd74f6f50b024ed9812b (commit) via 4e38ef3ece26759e8799871461e7424187b1fe1f (commit) via 854d244d695d63f13716c091ac52d015220a0f57 (commit) via 91a745ba9043d074ae8fb042bf5b8c5bc274193f (commit) from 89ea51e62edc9c27ee4092ed9e59247b2480977f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=718ab61e798bc4ce8b5566c017303020c6aba786 commit 718ab61e798bc4ce8b5566c017303020c6aba786 Author: Holger Hans Peter Freyther Date: Fri Jan 23 09:41:06 2015 +0100 Update with more recent code for various libs http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=aba6a6f030732f6f1a5cb714c2658fb086d9d880 commit aba6a6f030732f6f1a5cb714c2658fb086d9d880 Merge: 6708e54 89e653a Author: Holger Hans Peter Freyther Date: Fri Jan 23 09:39:33 2015 +0100 Merge commit '89e653a41aff48b9d861673affd17722744ed8cb' http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=6708e541594aef7e2c5c9b587885fe74ede7691c commit 6708e541594aef7e2c5c9b587885fe74ede7691c Merge: ea1d89b d5248ec Author: Holger Hans Peter Freyther Date: Fri Jan 23 09:36:54 2015 +0100 Merge commit 'd5248eceecd9d2f8c7061538163bc8ec80168dfc' http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=ea1d89b8e8ec7f73421a40717ce0e1170c35b7d5 commit ea1d89b8e8ec7f73421a40717ce0e1170c35b7d5 Merge: 89ea51e ab3b8e2 Author: Holger Hans Peter Freyther Date: Fri Jan 23 09:35:42 2015 +0100 Merge commit 'ab3b8e23fdf2cf40847bdcc854e14207908d1391' http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=89e653a41aff48b9d861673affd17722744ed8cb commit 89e653a41aff48b9d861673affd17722744ed8cb Author: Holger Hans Peter Freyther Date: Fri Aug 29 20:30:20 2014 +0200 call: Handle CANCEL and verify that the right messages are returned The code does not verify that sessionFailed is called but it does verify that the dialogue is scheduled for removal and that 487/200 is returned. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=9161371a3215e5be0f010d83bd26a9655abe338e commit 9161371a3215e5be0f010d83bd26a9655abe338e Author: Holger Hans Peter Freyther Date: Mon Aug 11 20:41:52 2014 +0200 perf: Various changes to speed up various operations * Do not use >>#instVarNamed:put: but add selectors * Pre-allocate some arrays with a default string to avoid re-allocations at the start * Share same parser trees to avoid construction costs * Remove some lazy allocation and always allocate it http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=d5248eceecd9d2f8c7061538163bc8ec80168dfc commit d5248eceecd9d2f8c7061538163bc8ec80168dfc Author: Holger Hans Peter Freyther Date: Tue Aug 26 19:04:52 2014 +0200 mgcp: Be able to parse the X-Osmux extension we have http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=ab3b8e23fdf2cf40847bdcc854e14207908d1391 commit ab3b8e23fdf2cf40847bdcc854e14207908d1391 Author: Holger Hans Peter Freyther Date: Wed Aug 20 23:21:29 2014 +0200 messages: Use self error: here as well http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=fb5ddd43bb1383e5e2d7f9c4f38df422fa98e647 commit fb5ddd43bb1383e5e2d7f9c4f38df422fa98e647 Author: Holger Hans Peter Freyther Date: Wed Aug 20 23:14:42 2014 +0200 gsm: Use "self error:" instead of Exception signal The issue is that [] on: Error do: [] will not handle the Exception. Use the plain self error handling. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=a536a7a788f21222fbca001d2df4b2578ab47721 commit a536a7a788f21222fbca001d2df4b2578ab47721 Author: Holger Hans Peter Freyther Date: Sun Aug 10 19:37:19 2014 +0200 callagent: Do not mix From/To in the response we generate In the SIPDialog we need to switch from/to to send messages from the right "From" but for a response we musn't do that. YATE doesn't like if we respond with From/To mixed to their BYE request. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=1a20f003aa5fc7cbeee06db76a9872ea12725ae1 commit 1a20f003aa5fc7cbeee06db76a9872ea12725ae1 Author: Holger Hans Peter Freyther Date: Sun Aug 10 20:28:59 2014 +0200 misc: Re-use the parser for a great speed-up during the tests Creating a PetitParser is expensive due the usage of >>#become: so let us re-use the one from the SIPCallAgent. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=1e43d02ed39d926714ee68b213bfbe234f395d1e commit 1e43d02ed39d926714ee68b213bfbe234f395d1e Author: Holger Hans Peter Freyther Date: Sun Aug 10 19:22:33 2014 +0200 transaction: ACK the 401 Unauthorized message before we change So this code acks the 401 Unauthorized message. It is possible that this message is lost on the way we will not be able to respond to the 401 again. The right thing would be to "fork" off the transaction to deal with re-transmissions. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=df79f4c46949379f263db8d10392059428af7bbd commit df79f4c46949379f263db8d10392059428af7bbd Author: Holger Hans Peter Freyther Date: Sun Aug 10 19:24:50 2014 +0200 call: Deal with both ends hanging up at the same time http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=0ffe0afcb511d3abb2c0dda69c15f2b1bf74c770 commit 0ffe0afcb511d3abb2c0dda69c15f2b1bf74c770 Author: Holger Hans Peter Freyther Date: Sat Aug 9 21:15:20 2014 +0200 Add >>#endpointNumber and add some test cases for it. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=9bd9a9e3b6826f99ec330ec0086321a599e470f6 commit 9bd9a9e3b6826f99ec330ec0086321a599e470f6 Author: Holger Hans Peter Freyther Date: Tue Jul 29 17:13:27 2014 +0200 Add a routine to just expand from 7bit packing to unpacked Modernize the tests. Use #[] if we want a ByteArray and use >>#asert:equals: to see what is going on. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=77d1ac2eabfb594af4e84acef58c8632870c3190 commit 77d1ac2eabfb594af4e84acef58c8632870c3190 Author: Holger Hans Peter Freyther Date: Tue Jul 29 17:04:06 2014 +0200 misc: Ease porting to pharo In Pharo ByteArray does not inherit from Array but directly from the ArrayedCollection class. Move the extensions one level up. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=88c800559736a39edc67fda0506460dcbf4976cf commit 88c800559736a39edc67fda0506460dcbf4976cf Author: Holger Hans Peter Freyther Date: Thu Jul 24 15:49:29 2014 +0200 misc: Make code more portable by using "self basicNew initialize" http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=aa8d9b64c62440f11f71226da1dd507fc0af4cc1 commit aa8d9b64c62440f11f71226da1dd507fc0af4cc1 Author: Holger Hans Peter Freyther Date: Thu Jul 24 15:45:42 2014 +0200 misc: Use "self basicNew initialize" to be portable http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=18c4ddfd7bb95b403eaf953ebdf3b2100bcae9d4 commit 18c4ddfd7bb95b403eaf953ebdf3b2100bcae9d4 Author: Holger Hans Peter Freyther Date: Thu Jul 24 15:42:51 2014 +0200 misc: Ease porting and use "self basicNew initialize" for init self basicNew initialize will work on Pharo and various versions of GST and will make sure to call initialize exactly once. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=216c6fdcb65446358b4efd74f6f50b024ed9812b commit 216c6fdcb65446358b4efd74f6f50b024ed9812b Author: Holger Hans Peter Freyther Date: Thu Jul 10 18:58:45 2014 +0200 mgcp: We want to create an Error and raise it here This is not a log message. This means the area: argument of the message is completely bogus. Found while running a MGCP CallAgent and the MGCP GW was restarting. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=4e38ef3ece26759e8799871461e7424187b1fe1f commit 4e38ef3ece26759e8799871461e7424187b1fe1f Author: Holger Hans Peter Freyther Date: Fri Jul 4 19:33:01 2014 +0200 call: For a re-invite we need to handle the ACK In case the remote will do a re-invite to verify that we are still aware of the call we need to handle >>#sessionAcked:dialog: This probably got introduced when I introduced the incoming call support that will send a 200 and receive the ACK. The incoming call will print a warning that session->session is not a valid state transition but nothing bad will happen. http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=854d244d695d63f13716c091ac52d015220a0f57 commit 854d244d695d63f13716c091ac52d015220a0f57 Author: Holger Hans Peter Freyther Date: Fri Jun 20 18:34:45 2014 +0200 gsm: Be able to parse a GSM CC Progress message http://cgit.osmocom.org/smalltalk/osmo-st-all/commit/?id=91a745ba9043d074ae8fb042bf5b8c5bc274193f commit 91a745ba9043d074ae8fb042bf5b8c5bc274193f Author: Holger Hans Peter Freyther Date: Fri Jun 20 18:24:37 2014 +0200 todo: We need to implement record-route and route parsing for SIPgate This means that the way we look at headers we need to support a list of them. ----------------------------------------------------------------------- Summary of changes: debian/changelog | 8 ++- osmo-st-gsm/GSM48.st | 21 +++++- osmo-st-gsm/GSMEncoding.st | 6 +- osmo-st-gsm/Messages.st | 2 +- osmo-st-gsm/SCCPHandler.st | 4 +- osmo-st-gsm/Tests.st | 19 ++++- osmo-st-mgcp/callagent/MGCPEndpoint.st | 7 +- osmo-st-mgcp/callagent/MGCPTrunk.st | 4 +- osmo-st-mgcp/callagent/Tests.st | 26 ++++++- osmo-st-mgcp/grammar/MGCPGrammar.st | 3 +- osmo-st-sip/TODO | 76 ++++++++++++++++++++ osmo-st-sip/callagent/SIPResponse.st | 23 ++++-- .../authorization/SIPProxyAuthorization.st | 4 +- osmo-st-sip/callagent/parameters/SIPCSeq.st | 20 ++++-- .../callagent/parameters/SIPGenericParam.st | 19 +++-- osmo-st-sip/callagent/parameters/SIPToFromParam.st | 20 ++++-- osmo-st-sip/callagent/parameters/SIPVia.st | 26 +++++-- osmo-st-sip/callagent/parser/Extensions.st | 2 +- osmo-st-sip/callagent/parser/SIPParser.st | 2 +- osmo-st-sip/callagent/session/Extensions.st | 8 +++ osmo-st-sip/callagent/session/SIPCall.st | 7 ++ osmo-st-sip/callagent/session/SIPIncomingCall.st | 32 +++++++-- osmo-st-sip/callagent/tests/SIPCallAgentTest.st | 47 +++++++----- osmo-st-sip/callagent/tests/SIPInviteTest.st | 83 ++++++++++++++++++---- .../callagent/tests/SIPRegisterTransactionTest.st | 10 ++- .../callagent/transactions/SIPTransaction.st | 8 +++ osmo-st-sip/callagent/useragent/SIPUserAgent.st | 8 +-- osmo-st-sip/grammar/SIPGrammar.st | 42 +++++------ 28 files changed, 419 insertions(+), 118 deletions(-) hooks/post-receive -- Git submodule with Smalltalk modules From gitosis at osmocom.org Fri Jan 23 12:14:39 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 23 Jan 2015 12:14:39 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-896-g6163f8d Message-ID: <201501231214.t0NCEdeX036778@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 966859933250d61a05c069e8871e20e08fd0c2af (commit) discards 3f90ab1f019b734efbca778a0f3f169ce5e48379 (commit) discards fe625302549c8a27f901f417cb816d7c05a00e8b (commit) discards 70fb27bcfcfd79480e16a888588198747b6b9a13 (commit) discards d185e9814d6fe44a3d86627c0fef3cc1d6849e13 (commit) discards 0daf96a5e5dfe0e060e2f0992eba17cc7abb6b19 (commit) via 6163f8d7f56a027ccef4462c71af5a8020aa1813 (commit) via 0fae97efdc9fec894ebf8b6ab39c0c5e2586ff3b (commit) via ad73bc60fcd31988302c40793add3392bef9d84a (commit) via cc748e0f24faa5d0eb9b11750ff07b0ee0f2e668 (commit) via f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d (commit) via ce8de7ab10ed34f29123d8723b13cacf00c7bf46 (commit) via c0a9bf36067363696814bf72fc3edf553e00290f (commit) via 3fe133576ccdcd09b475296de01ad49aa93f3aef (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (966859933250d61a05c069e8871e20e08fd0c2af) \ N -- N -- N (6163f8d7f56a027ccef4462c71af5a8020aa1813) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=6163f8d7f56a027ccef4462c71af5a8020aa1813 commit 6163f8d7f56a027ccef4462c71af5a8020aa1813 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0fae97efdc9fec894ebf8b6ab39c0c5e2586ff3b commit 0fae97efdc9fec894ebf8b6ab39c0c5e2586ff3b Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ad73bc60fcd31988302c40793add3392bef9d84a commit ad73bc60fcd31988302c40793add3392bef9d84a Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cc748e0f24faa5d0eb9b11750ff07b0ee0f2e668 commit cc748e0f24faa5d0eb9b11750ff07b0ee0f2e668 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d commit f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d Author: Jacob Erlbeck Date: Fri Jan 23 11:33:51 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is cancelled. If such an MM context doesn't exist, the LLME is unassigned directly. The implementation works as follows. - llme->age_timestamp is reset on each received PTP LLC message - sgsn_llme_check_cb is invoked periodically (each 30s) - sgsn_llme_check_cb sets the age_timestamp to the current time if it has been reset - sgsn_llme_check_cb computes the age and expires the LLME if it exceeds gprs_max_time_to_idle() Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ce8de7ab10ed34f29123d8723b13cacf00c7bf46 commit ce8de7ab10ed34f29123d8723b13cacf00c7bf46 Author: Jacob Erlbeck Date: Fri Jan 23 12:32:38 2015 +0100 gprs: Use a macro value to set the 'Periodic RA update timer' Currently the T3312 timer is directly set as encoded value when generating the Attach/RAU Accept messages. This patch adds GSM0408_T3312_SECS and uses it to set the information element's value. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c0a9bf36067363696814bf72fc3edf553e00290f commit c0a9bf36067363696814bf72fc3edf553e00290f Author: Jacob Erlbeck Date: Fri Jan 23 11:44:39 2015 +0100 gprs: Add 'Negotiated READY timer value' IE to Attach/RAU Accept Currently this optional IE is omitted, so that the optional 'Requested READY timer value' of the corresponding Request message is used by the MS (or the default value if this IE is not used). This patch extends gsm48_tx_gmm_att_ack and gsm48_tx_gmm_ra_upd_ack to always include the IE set to the default value of T3312 (44s, see GSM 04.08, table 11.4a). Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3fe133576ccdcd09b475296de01ad49aa93f3aef commit 3fe133576ccdcd09b475296de01ad49aa93f3aef Author: Jacob Erlbeck Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions Currently, all GPRS timer values are hard-coded. To make these values configurable in seconds and to show them, conversion functions from and to seconds are needed. This patch adds gprs_tmr_to_secs and gprs_secs_to_tmr_floor. Due to the limited number of bits used to encode GPRS timer values, only a few durations can be represented. gprs_secs_to_tmr_floor therefore always returns the timer value that represents either the exact number (if an exact representation exists) or the next lower number for that an exact representation exists. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_utils.c | 16 +++++++++++++--- openbsc/tests/gprs/gprs_test.c | 22 ++++++++++++++++------ 2 files changed, 29 insertions(+), 9 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 23 14:01:05 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 23 Jan 2015 14:01:05 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-899-g5a8a00a Message-ID: <201501231401.t0NE15BG045789@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 6163f8d7f56a027ccef4462c71af5a8020aa1813 (commit) discards 0fae97efdc9fec894ebf8b6ab39c0c5e2586ff3b (commit) discards ad73bc60fcd31988302c40793add3392bef9d84a (commit) discards cc748e0f24faa5d0eb9b11750ff07b0ee0f2e668 (commit) via 5a8a00afe6f037a39b407bcacdcd35bd6b399f76 (commit) via 3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b (commit) via 4c200652f7c54ff2e7e1708d93adf75be9f86712 (commit) via b6d0eaa0da84758fad88d213bb42fd00f1e030be (commit) via 99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 (commit) via b10b16f9bdc4d916035313b68a7eeb6f55499c78 (commit) via 7113c90e8476cc97271aeec7b2bb345474c95d64 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (6163f8d7f56a027ccef4462c71af5a8020aa1813) \ N -- N -- N (5a8a00afe6f037a39b407bcacdcd35bd6b399f76) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=5a8a00afe6f037a39b407bcacdcd35bd6b399f76 commit 5a8a00afe6f037a39b407bcacdcd35bd6b399f76 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - implement age based MM context expiry - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b commit 3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4c200652f7c54ff2e7e1708d93adf75be9f86712 commit 4c200652f7c54ff2e7e1708d93adf75be9f86712 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b6d0eaa0da84758fad88d213bb42fd00f1e030be commit b6d0eaa0da84758fad88d213bb42fd00f1e030be Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 commit 99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 Author: Jacob Erlbeck Date: Fri Jan 23 13:52:55 2015 +0100 gprs: Do not put the subscr in gprs_subscr_delete Currently gprs_subscr_delete implicitely calls subscr_put, which makes the code more complex than necessary (additional subscr_get) in a few places. It also makes it more difficult to see, whether get/put are balanced within a function. In addition, the functions are not named consistently (gprs_subscr_delete vs. gprs_subscr_put_and_cancel). This commit changes the semantics of gprs_subscr_delete and indirectly of gprs_subscr_put_and_cancel to not call subscr_put on their argument, but to leave that for the caller to do it explicitely. It renames gprs_subscr_put_and_cancel to gprs_subscr_cancel to reflect that change in the name, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b10b16f9bdc4d916035313b68a7eeb6f55499c78 commit b10b16f9bdc4d916035313b68a7eeb6f55499c78 Author: Holger Hans Peter Freyther Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove the "permanent" subscriber cache The subscriber cache would help in case: * GPRS DETACH, GPRS ATTACH. In that case we might still have some cached authentication tuples we avoid another sendAuthenticationInfo request. * After a detach the cache expiry would make sure to eventually send a purgeMS to the HLR (which might be ignored). At the same time to make the cache work we will need to make sure to start and stop timers. In case we don't start we might accumulate subscribers. I am afraid that the above two benefits do not outweight the complexity of this implementation. http://cgit.osmocom.org/openbsc/commit/?id=7113c90e8476cc97271aeec7b2bb345474c95d64 commit 7113c90e8476cc97271aeec7b2bb345474c95d64 Author: Holger Hans Peter Freyther Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove MM from the list before gprs_subscr_delete is called Modify sgsn_mm_ctx_free to remove the entry from the list as otherwise we might double free the context from within gprs_subscriber_delete. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 4 +- openbsc/include/openbsc/sgsn.h | 4 -- openbsc/src/gprs/gprs_sgsn.c | 7 +-- openbsc/src/gprs/gprs_subscriber.c | 91 ++++--------------------------------- openbsc/src/gprs/sgsn_vty.c | 40 +--------------- openbsc/tests/sgsn/sgsn_test.c | 83 ++++++--------------------------- 6 files changed, 28 insertions(+), 201 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 08:12:57 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 08:12:57 GMT Subject: openbsc.git branch master updated. 0.13.0-895-g37139e5 Message-ID: <201501260812.t0Q8CvrR004409@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) via 1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit) via e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit) via 81ffb740f78ccdada8ece786cfab852bc10172e8 (commit) via 841d95f86701b9e813402c65a7b1f88d132593fb (commit) via 8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit) via 79af67d7c02a25e36146369b60f7f25c9655c862 (commit) via 37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit) from 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=37139e5933337e3e24f4bd83955c3492123e9ed0 commit 37139e5933337e3e24f4bd83955c3492123e9ed0 Author: Jacob Erlbeck Date: Fri Jan 23 13:52:55 2015 +0100 gprs: Do not put the subscr in gprs_subscr_delete Currently gprs_subscr_delete implicitely calls subscr_put, which makes the code more complex than necessary (additional subscr_get) in a few places. It also makes it more difficult to see, whether get/put are balanced within a function. In addition, the functions are not named consistently (gprs_subscr_delete vs. gprs_subscr_put_and_cancel). This commit changes the semantics of gprs_subscr_delete and indirectly of gprs_subscr_put_and_cancel to not call subscr_put on their argument, but to leave that for the caller to do it explicitely. It renames gprs_subscr_put_and_cancel to gprs_subscr_cancel to reflect that change in the name, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1d778fdce3bc4aab16dc203463d0067f2f063d16 commit 1d778fdce3bc4aab16dc203463d0067f2f063d16 Author: Holger Hans Peter Freyther Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove the "permanent" subscriber cache The subscriber cache would help in case: * GPRS DETACH, GPRS ATTACH. In that case we might still have some cached authentication tuples we avoid another sendAuthenticationInfo request. * After a detach the cache expiry would make sure to eventually send a purgeMS to the HLR (which might be ignored). At the same time to make the cache work we will need to make sure to start and stop timers. In case we don't start we might accumulate subscribers. I am afraid that the above two benefits do not outweight the complexity of this implementation. http://cgit.osmocom.org/openbsc/commit/?id=e47d4f6d1187d453b846ea48f95ee75a42efc23b commit e47d4f6d1187d453b846ea48f95ee75a42efc23b Author: Holger Hans Peter Freyther Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove MM from the list before gprs_subscr_delete is called Modify sgsn_mm_ctx_free to remove the entry from the list as otherwise we might double free the context from within gprs_subscriber_delete. http://cgit.osmocom.org/openbsc/commit/?id=81ffb740f78ccdada8ece786cfab852bc10172e8 commit 81ffb740f78ccdada8ece786cfab852bc10172e8 Author: Jacob Erlbeck Date: Fri Jan 23 11:33:51 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is cancelled. If such an MM context doesn't exist, the LLME is unassigned directly. The implementation works as follows. - llme->age_timestamp is reset on each received PTP LLC message - sgsn_llme_check_cb is invoked periodically (each 30s) - sgsn_llme_check_cb sets the age_timestamp to the current time if it has been reset - sgsn_llme_check_cb computes the age and expires the LLME if it exceeds gprs_max_time_to_idle() Ticket: OW#1364 Sponsored-by: On-Waves ehf [hfreyther: Fix typo in comment LMME -> LLME] http://cgit.osmocom.org/openbsc/commit/?id=841d95f86701b9e813402c65a7b1f88d132593fb commit 841d95f86701b9e813402c65a7b1f88d132593fb Author: Jacob Erlbeck Date: Fri Jan 23 12:32:38 2015 +0100 gprs: Use a macro value to set the 'Periodic RA update timer' Currently the T3312 timer is directly set as encoded value when generating the Attach/RAU Accept messages. This patch adds GSM0408_T3312_SECS and uses it to set the information element's value. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8de9c48c997a84f1afbfd3306435403bdbfd9f6a commit 8de9c48c997a84f1afbfd3306435403bdbfd9f6a Author: Jacob Erlbeck Date: Fri Jan 23 11:44:39 2015 +0100 gprs: Add 'Negotiated READY timer value' IE to Attach/RAU Accept Currently this optional IE is omitted, so that the optional 'Requested READY timer value' of the corresponding Request message is used by the MS (or the default value if this IE is not used). This patch extends gsm48_tx_gmm_att_ack and gsm48_tx_gmm_ra_upd_ack to always include the IE set to the default value of T3312 (44s, see GSM 04.08, table 11.4a). Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79af67d7c02a25e36146369b60f7f25c9655c862 commit 79af67d7c02a25e36146369b60f7f25c9655c862 Author: Jacob Erlbeck Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions Currently, all GPRS timer values are hard-coded. To make these values configurable in seconds and to show them, conversion functions from and to seconds are needed. This patch adds gprs_tmr_to_secs and gprs_secs_to_tmr_floor. Due to the limited number of bits used to encode GPRS timer values, only a few durations can be represented. gprs_secs_to_tmr_floor therefore always returns the timer value that represents either the exact number (if an exact representation exists) or the next lower number for that an exact representation exists. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=37184900e7f4f8566fbd71914f55b3cc8c0196e9 commit 37184900e7f4f8566fbd71914f55b3cc8c0196e9 Author: Jacob Erlbeck Date: Mon Jan 19 10:56:15 2015 +0100 gprs: Return 0 from gsup_client_connect if ok or retry timer enabled Currently the gsup_client_connect return 0 if the call to ipa_client_conn_open was successful and -errno otherwise. This makes it difficult for the caller to determine, whether the the whole operation has been cancelled (currently on EBADF, ENOTSOCK, EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to connect after a timeout. This will cause gprs_gsup_client_create to destroy the GSUP client object, even if the error might be temporary. This patch changes the function to return 0 if (and only if) ipa_client_conn_open was successful or the retry timer has been started. Since the return value 0 doesn't guarantee, that a subsequent call to gprs_gsup_client_send will succeed, this shouldn't break anything. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_gmm.h | 2 + openbsc/include/openbsc/gprs_llc.h | 5 ++ openbsc/include/openbsc/gprs_sgsn.h | 5 +- openbsc/include/openbsc/gprs_utils.h | 5 ++ openbsc/include/openbsc/gsm_04_08_gprs.h | 5 +- openbsc/include/openbsc/sgsn.h | 6 +-- openbsc/src/gprs/Makefile.am | 2 +- openbsc/src/gprs/gprs_gmm.c | 27 ++++++++-- openbsc/src/gprs/gprs_gsup_client.c | 5 +- openbsc/src/gprs/gprs_llc.c | 4 ++ openbsc/src/gprs/gprs_llc_vty.c | 7 ++- openbsc/src/gprs/gprs_sgsn.c | 70 ++++++++++++++++++++++-- openbsc/src/gprs/gprs_subscriber.c | 91 +++----------------------------- openbsc/src/gprs/gprs_utils.c | 45 ++++++++++++++++ openbsc/src/gprs/sgsn_main.c | 1 + openbsc/src/gprs/sgsn_vty.c | 40 +------------- openbsc/tests/gprs/gprs_test.c | 68 ++++++++++++++++++++++++ openbsc/tests/gprs/gprs_test.ok | 1 + openbsc/tests/sgsn/Makefile.am | 2 +- openbsc/tests/sgsn/sgsn_test.c | 83 +++++------------------------ 20 files changed, 264 insertions(+), 210 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 10:01:03 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 10:01:03 GMT Subject: openbsc.git branch master updated. 0.13.0-896-g496aee7 Message-ID: <201501261001.t0QA13Vm014341@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) from 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=496aee7cb809069133fe37f39ccac7607ec6c9b3 commit 496aee7cb809069133fe37f39ccac7607ec6c9b3 Author: Jacob Erlbeck Date: Mon Jan 26 10:38:12 2015 +0100 sgsn: Ensure 0-terminated imsi strings (Coverity) Currently the size argument of strncpy is set to sizeof(mm->imsi) in some places. If the source IMSI string is too long, the terminating NUL byte in the static mm->imsi field gets overwritten. This patch limits the size to sizeof(mm->imsi)-1, so that the last byte of the buffer (that has been initialized to 0) is not overwritten. Fixes: Coverity CID 12065751, 12065754, 1206575 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_gmm.c | 6 +++--- openbsc/src/gprs/sgsn_auth.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 14:11:23 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 14:11:23 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-905-gc58270a Message-ID: <201501261411.t0QEBNq6088236@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 5a8a00afe6f037a39b407bcacdcd35bd6b399f76 (commit) discards 3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b (commit) discards 4c200652f7c54ff2e7e1708d93adf75be9f86712 (commit) discards b6d0eaa0da84758fad88d213bb42fd00f1e030be (commit) discards 99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 (commit) discards b10b16f9bdc4d916035313b68a7eeb6f55499c78 (commit) discards 7113c90e8476cc97271aeec7b2bb345474c95d64 (commit) discards f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d (commit) discards ce8de7ab10ed34f29123d8723b13cacf00c7bf46 (commit) discards c0a9bf36067363696814bf72fc3edf553e00290f (commit) discards 3fe133576ccdcd09b475296de01ad49aa93f3aef (commit) discards b2426e6af78d6fc057e45696168c7c3d56b86584 (commit) via c58270ab5fcc634839ad69b427ad4d9d34be1d1c (commit) via f312b96b9c734e03de1222379a4a0305725192c2 (commit) via 4c0f08b58407ca8b2ca3d9502ca50212d330af63 (commit) via a51b777ce0f2c178833fba4bd33cfda75a99f7a8 (commit) via cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 (commit) via 200b4689c90841ac18cc0754c7a3a95d3c4e4de4 (commit) via d272b4c7c8c9e2d8a510c85896a661c312d96c0a (commit) via 09695de8c253ab5ee271c372ea21fd84f7377b99 (commit) via fa11430d857f006459664e7314a6be79e21a20dd (commit) via 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) via 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) via 1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit) via e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit) via 81ffb740f78ccdada8ece786cfab852bc10172e8 (commit) via 841d95f86701b9e813402c65a7b1f88d132593fb (commit) via 8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit) via 79af67d7c02a25e36146369b60f7f25c9655c862 (commit) via 37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (5a8a00afe6f037a39b407bcacdcd35bd6b399f76) \ N -- N -- N (c58270ab5fcc634839ad69b427ad4d9d34be1d1c) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c58270ab5fcc634839ad69b427ad4d9d34be1d1c commit c58270ab5fcc634839ad69b427ad4d9d34be1d1c Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f312b96b9c734e03de1222379a4a0305725192c2 commit f312b96b9c734e03de1222379a4a0305725192c2 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4c0f08b58407ca8b2ca3d9502ca50212d330af63 commit 4c0f08b58407ca8b2ca3d9502ca50212d330af63 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a51b777ce0f2c178833fba4bd33cfda75a99f7a8 commit a51b777ce0f2c178833fba4bd33cfda75a99f7a8 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 commit cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 Author: Jacob Erlbeck Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=200b4689c90841ac18cc0754c7a3a95d3c4e4de4 commit 200b4689c90841ac18cc0754c7a3a95d3c4e4de4 Author: Jacob Erlbeck Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d272b4c7c8c9e2d8a510c85896a661c312d96c0a commit d272b4c7c8c9e2d8a510c85896a661c312d96c0a Author: Jacob Erlbeck Date: Mon Jan 26 13:41:11 2015 +0100 sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr field that is also present in gprs_subscr_cleanup, which is called directly afterwards. This commit modifies the code path, so that the cleanup is done by the gprs_subscr_cleanup function. The additional reference counter increment is needed, since mm->subscr->mm->subscr (which is the same like mm->subscr) will be reset (and unref'd) within gprs_subscr_cleanup. Because the local variable subscr in sgsn_mm_ctx_free is an additional pointer to the subscriber object, it is consequent to adjust the reference counter when the assignment is done. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09695de8c253ab5ee271c372ea21fd84f7377b99 commit 09695de8c253ab5ee271c372ea21fd84f7377b99 Author: Jacob Erlbeck Date: Mon Jan 26 11:07:24 2015 +0100 gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup The old name is somewhat misleading. The function is rather preparing the subscriber for a subsequent subscr_free, that is possibly invoked by a subscr_put. It detaches the subscriber from the MM context and optionally invokes a PURGE_MS procedure. Therefore the _cleanup suffix is chosen (see mm_ctx_cleanup_free). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fa11430d857f006459664e7314a6be79e21a20dd commit fa11430d857f006459664e7314a6be79e21a20dd Author: Jacob Erlbeck Date: Mon Jan 26 09:22:39 2015 +0100 gprs: Don't check for EINPROGRESS in gprs_gsup_client_create Currently, the return value of gsup_client_connect is checked whether it is < 0 and != -EINPROGESS. Since gsup_client_connect will only return a negative value on a few permanent errors (not including EINPROGRESS), rc is always != EINPROGRESS. This patch removes the explicit check againt -EINPROGRESS and just leaves the check rc < 0. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 6 ++-- openbsc/include/openbsc/sgsn.h | 2 +- openbsc/src/gprs/gprs_gmm.c | 30 +++-------------- openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/src/gprs/gprs_sgsn.c | 66 +++++++++++++++++++------------------ openbsc/src/gprs/gprs_subscriber.c | 10 +++--- openbsc/src/gprs/sgsn_auth.c | 2 +- openbsc/tests/sgsn/sgsn_test.c | 37 +++++++++------------ 8 files changed, 66 insertions(+), 89 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 14:22:00 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 14:22:00 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-904-g4a16998 Message-ID: <201501261422.t0QEM0Mq089361@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards c58270ab5fcc634839ad69b427ad4d9d34be1d1c (commit) discards f312b96b9c734e03de1222379a4a0305725192c2 (commit) via 4a1699800c7856f1ba7d4fec922f4436230d1507 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c58270ab5fcc634839ad69b427ad4d9d34be1d1c) \ N -- N -- N (4a1699800c7856f1ba7d4fec922f4436230d1507) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4a1699800c7856f1ba7d4fec922f4436230d1507 commit 4a1699800c7856f1ba7d4fec922f4436230d1507 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_llc.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 14:33:08 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 14:33:08 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-905-gc11f614 Message-ID: <201501261433.t0QEX8NZ090345@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 4a1699800c7856f1ba7d4fec922f4436230d1507 (commit) discards 4c0f08b58407ca8b2ca3d9502ca50212d330af63 (commit) discards a51b777ce0f2c178833fba4bd33cfda75a99f7a8 (commit) via c11f61401664eb9bb8282445356f5ca851ac1265 (commit) via f2a3d66e09ba7b0f986dcc54796a0228402ecbca (commit) via 469b80457e4627c5fd9cbcadedfe27cd9f569b4c (commit) via 44408848c85a85b0437bb810f8589f696a099fe5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (4a1699800c7856f1ba7d4fec922f4436230d1507) \ N -- N -- N (c11f61401664eb9bb8282445356f5ca851ac1265) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c11f61401664eb9bb8282445356f5ca851ac1265 commit c11f61401664eb9bb8282445356f5ca851ac1265 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f2a3d66e09ba7b0f986dcc54796a0228402ecbca commit f2a3d66e09ba7b0f986dcc54796a0228402ecbca Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=469b80457e4627c5fd9cbcadedfe27cd9f569b4c commit 469b80457e4627c5fd9cbcadedfe27cd9f569b4c Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=44408848c85a85b0437bb810f8589f696a099fe5 commit 44408848c85a85b0437bb810f8589f696a099fe5 Author: Jacob Erlbeck Date: Tue Jan 20 09:25:43 2015 +0100 gbproxy: Remove dummy definition of subscr_put The definition of subscr_put in gb_proxy_main.c will break linking if symbols from libcommon are used. Since subscr_put is in libcommon, there is no need for this dummy definition anymore. This patch removes the dummy definition. Adresses: ../../src/libcommon/libcommon.a(gsm_subscriber_base.o): In function `subscr_put': /home/jerlbeck/git/build/openbsc/openbsc/src/libcommon/gsm_subscriber_base.c:90: multiple definition of `subscr_put' gb_proxy_main.o:/home/jerlbeck/git/build/openbsc/openbsc/src/gprs/gb_proxy_main.c:56: first defined here Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy_main.c | 3 --- 1 file changed, 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Mon Jan 26 15:05:12 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 26 Jan 2015 15:05:12 GMT Subject: openbsc.git branch shared/packages/testing created. 0.13.0-910-g9d77901 Message-ID: <201501261505.t0QF5C42092933@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, shared/packages/testing has been created at 9d77901f9870d923c558cb321ad1f8f5e87b4c8b (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=9d77901f9870d923c558cb321ad1f8f5e87b4c8b commit 9d77901f9870d923c558cb321ad1f8f5e87b4c8b Author: Jacob Erlbeck Date: Mon Jan 26 15:42:27 2015 +0100 debian: Prepare testing release 0.13.2+j4 http://cgit.osmocom.org/openbsc/commit/?id=5c43716b7edd13e23c536d675841b339ec6a2b39 commit 5c43716b7edd13e23c536d675841b339ec6a2b39 Author: Holger Hans Peter Freyther Date: Wed Jan 21 17:01:53 2015 +0100 debian: Create a new package http://cgit.osmocom.org/openbsc/commit/?id=2714c2fe33ec702964ad234e9da3a0e302b85fc5 commit 2714c2fe33ec702964ad234e9da3a0e302b85fc5 Author: Holger Hans Peter Freyther Date: Wed Jan 21 12:58:49 2015 +0100 debian: Add current changelog entry http://cgit.osmocom.org/openbsc/commit/?id=7a58220410b96a6b38ec6b9455bab806971edafa commit 7a58220410b96a6b38ec6b9455bab806971edafa Author: Jacob Erlbeck Date: Tue Jan 20 09:15:40 2015 +0100 debian: Prepare testing release 0.13.2+j1 http://cgit.osmocom.org/openbsc/commit/?id=95d04b804f62515f8f04038000ea0031de1fd601 commit 95d04b804f62515f8f04038000ea0031de1fd601 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 27 07:35:40 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 27 Jan 2015 07:35:40 GMT Subject: openbsc.git branch master updated. 0.13.0-901-g120250a Message-ID: <201501270735.t0R7ZeFu086130@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) via 306bb993aab07f115ff6cbc89d81f862e08f7c32 (commit) via 3e4e58f349c201a2ed02971ef95051773fcef39b (commit) via 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec (commit) via abb347853317427a227592c4fa4b38e99f9e7152 (commit) from 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=120250ad6fe8d2b641b716d5b37d48b125db23ca commit 120250ad6fe8d2b641b716d5b37d48b125db23ca Author: Jacob Erlbeck Date: Tue Jan 20 09:25:43 2015 +0100 gbproxy: Remove dummy definition of subscr_put The definition of subscr_put in gb_proxy_main.c will break linking if symbols from libcommon are used. Since subscr_put is in libcommon, there is no need for this dummy definition anymore. This patch removes the dummy definition. Adresses: ../../src/libcommon/libcommon.a(gsm_subscriber_base.o): In function `subscr_put': /home/jerlbeck/git/build/openbsc/openbsc/src/libcommon/gsm_subscriber_base.c:90: multiple definition of `subscr_put' gb_proxy_main.o:/home/jerlbeck/git/build/openbsc/openbsc/src/gprs/gb_proxy_main.c:56: first defined here Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=306bb993aab07f115ff6cbc89d81f862e08f7c32 commit 306bb993aab07f115ff6cbc89d81f862e08f7c32 Author: Jacob Erlbeck Date: Mon Jan 26 13:41:11 2015 +0100 sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr field that is also present in gprs_subscr_cleanup, which is called directly afterwards. This commit modifies the code path, so that the cleanup is done by the gprs_subscr_cleanup function. The additional reference counter increment is needed, since mm->subscr->mm->subscr (which is the same like mm->subscr) will be reset (and unref'd) within gprs_subscr_cleanup. Because the local variable subscr in sgsn_mm_ctx_free is an additional pointer to the subscriber object, it is consequent to adjust the reference counter when the assignment is done. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e4e58f349c201a2ed02971ef95051773fcef39b commit 3e4e58f349c201a2ed02971ef95051773fcef39b Author: Jacob Erlbeck Date: Mon Jan 26 11:07:24 2015 +0100 gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup The old name is somewhat misleading. The function is rather preparing the subscriber for a subsequent subscr_free, that is possibly invoked by a subscr_put. It detaches the subscriber from the MM context and optionally invokes a PURGE_MS procedure. Therefore the _cleanup suffix is chosen (see mm_ctx_cleanup_free). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3ee67ff5c2f9da513c77b8ab9dfc0067296dadec commit 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec Author: Jacob Erlbeck Date: Mon Jan 26 09:22:39 2015 +0100 gprs: Don't check for EINPROGRESS in gprs_gsup_client_create Currently, the return value of gsup_client_connect is checked whether it is < 0 and != -EINPROGESS. Since gsup_client_connect will only return a negative value on a few permanent errors (not including EINPROGRESS), rc is always != EINPROGRESS. This patch removes the explicit check againt -EINPROGRESS and just leaves the check rc < 0. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=abb347853317427a227592c4fa4b38e99f9e7152 commit abb347853317427a227592c4fa4b38e99f9e7152 Author: Holger Hans Peter Freyther Date: Mon Jan 26 10:26:36 2015 +0100 gb_proxy: No need to copy optarg Fixes: Coverity CID 1206578 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 2 +- openbsc/src/gprs/gb_proxy_main.c | 5 +---- openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/src/gprs/gprs_sgsn.c | 6 ++---- openbsc/src/gprs/gprs_subscriber.c | 4 ++-- openbsc/tests/sgsn/sgsn_test.c | 6 +++--- 6 files changed, 10 insertions(+), 15 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 27 09:20:42 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 27 Jan 2015 09:20:42 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-906-g1789a16 Message-ID: <201501270920.t0R9KgQg095320@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards c11f61401664eb9bb8282445356f5ca851ac1265 (commit) discards f2a3d66e09ba7b0f986dcc54796a0228402ecbca (commit) discards 469b80457e4627c5fd9cbcadedfe27cd9f569b4c (commit) discards 44408848c85a85b0437bb810f8589f696a099fe5 (commit) discards cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 (commit) discards 200b4689c90841ac18cc0754c7a3a95d3c4e4de4 (commit) discards d272b4c7c8c9e2d8a510c85896a661c312d96c0a (commit) discards 09695de8c253ab5ee271c372ea21fd84f7377b99 (commit) discards fa11430d857f006459664e7314a6be79e21a20dd (commit) via 1789a16e884fa069bc2244791a4659c84efdffc8 (commit) via 08001dc2d5c02f67622de15fe7b36bc6b7098bda (commit) via 83c92aca6904b44f129c3aa2dbced8cc0bacea91 (commit) via 3b928ed5ed7e93144714fbe4e332ef04769d0b08 (commit) via 34287fbf01125845844f84de7e6111e77d137775 (commit) via 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) via 306bb993aab07f115ff6cbc89d81f862e08f7c32 (commit) via 3e4e58f349c201a2ed02971ef95051773fcef39b (commit) via 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec (commit) via abb347853317427a227592c4fa4b38e99f9e7152 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c11f61401664eb9bb8282445356f5ca851ac1265) \ N -- N -- N (1789a16e884fa069bc2244791a4659c84efdffc8) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=1789a16e884fa069bc2244791a4659c84efdffc8 commit 1789a16e884fa069bc2244791a4659c84efdffc8 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=08001dc2d5c02f67622de15fe7b36bc6b7098bda commit 08001dc2d5c02f67622de15fe7b36bc6b7098bda Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=83c92aca6904b44f129c3aa2dbced8cc0bacea91 commit 83c92aca6904b44f129c3aa2dbced8cc0bacea91 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3b928ed5ed7e93144714fbe4e332ef04769d0b08 commit 3b928ed5ed7e93144714fbe4e332ef04769d0b08 Author: Jacob Erlbeck Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=34287fbf01125845844f84de7e6111e77d137775 commit 34287fbf01125845844f84de7e6111e77d137775 Author: Jacob Erlbeck Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy_main.c | 2 +- openbsc/tests/sgsn/sgsn_test.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 27 10:09:18 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 27 Jan 2015 10:09:18 GMT Subject: libosmocore.git branch master updated. 0.8.0-3-g879acef Message-ID: <201501271009.t0RA9Igd001228@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 879acef39465bb978f9a3bcb349594b818aec442 (commit) via 19d00517af53261523b35e14b14de7b87ea8d669 (commit) from f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=879acef39465bb978f9a3bcb349594b818aec442 commit 879acef39465bb978f9a3bcb349594b818aec442 Author: Holger Hans Peter Freyther Date: Tue Jan 27 11:06:51 2015 +0100 vty: Fix typo in the state creation This got introduced in 2d6ad13d8daf860595e6d4025861e122ce574871 and I thought that our vty tests would have caught such mistakes. http://cgit.osmocom.org/libosmocore/commit/?id=19d00517af53261523b35e14b14de7b87ea8d669 commit 19d00517af53261523b35e14b14de7b87ea8d669 Author: Holger Hans Peter Freyther Date: Sun Jan 18 21:23:16 2015 +0100 debian: Add pcsc build depends and pkg-config for the m4 macro ----------------------------------------------------------------------- Summary of changes: debian/control | 2 +- src/vty/logging_vty.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Tue Jan 27 10:09:43 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 27 Jan 2015 10:09:43 GMT Subject: openbsc.git branch master updated. 0.13.0-903-g925c57f Message-ID: <201501271009.t0RA9h5A001323@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 925c57fb545b072159a831bff852c92795704dfe (commit) via 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 (commit) from 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=925c57fb545b072159a831bff852c92795704dfe commit 925c57fb545b072159a831bff852c92795704dfe Author: Holger Hans Peter Freyther Date: Tue Jan 27 10:58:29 2015 +0100 nitb: Make the last change configurable Introduce a NITB node and add the subscriber creation as config name in there. http://cgit.osmocom.org/openbsc/commit/?id=1ba0730a7109b06e4043e7b17c11d8d2c34358c5 commit 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 Author: Holger Hans Peter Freyther Date: Tue Jan 27 10:27:53 2015 +0100 nitb: Allow the network to decide if a subscriber should be created ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/libbsc/net_init.c | 2 ++ openbsc/src/libcommon/common_vty.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 29 +++++++++++++------ openbsc/src/libmsc/vty_interface_layer3.c | 47 +++++++++++++++++++++++++++++++ 6 files changed, 72 insertions(+), 9 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Tue Jan 27 14:45:52 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 27 Jan 2015 14:45:52 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-909-g70992b3 Message-ID: <201501271445.t0REjqaB025759@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 1789a16e884fa069bc2244791a4659c84efdffc8 (commit) discards 08001dc2d5c02f67622de15fe7b36bc6b7098bda (commit) discards 83c92aca6904b44f129c3aa2dbced8cc0bacea91 (commit) via 70992b3369bb8922d92aabdbd54a33d3a52d8c05 (commit) via 0153212b910a6c01103e1f4dc914457ac733bd9c (commit) via 7d08477daa44919b65bbbaa794947e70bc88e407 (commit) via 8f4a1762c82e25093de13c30fd58d0b3645c8e9f (commit) via 78198111ebf1f60fb369a9788b5f8045d9b0beb8 (commit) via c3f158e84846fc1fbd58aa0e377acd12a78d29ab (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (1789a16e884fa069bc2244791a4659c84efdffc8) \ N -- N -- N (70992b3369bb8922d92aabdbd54a33d3a52d8c05) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=70992b3369bb8922d92aabdbd54a33d3a52d8c05 commit 70992b3369bb8922d92aabdbd54a33d3a52d8c05 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0153212b910a6c01103e1f4dc914457ac733bd9c commit 0153212b910a6c01103e1f4dc914457ac733bd9c Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7d08477daa44919b65bbbaa794947e70bc88e407 commit 7d08477daa44919b65bbbaa794947e70bc88e407 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8f4a1762c82e25093de13c30fd58d0b3645c8e9f commit 8f4a1762c82e25093de13c30fd58d0b3645c8e9f Author: Jacob Erlbeck Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=78198111ebf1f60fb369a9788b5f8045d9b0beb8 commit 78198111ebf1f60fb369a9788b5f8045d9b0beb8 Author: Jacob Erlbeck Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c3f158e84846fc1fbd58aa0e377acd12a78d29ab commit c3f158e84846fc1fbd58aa0e377acd12a78d29ab Author: Jacob Erlbeck Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_subscriber.c | 48 +++++++++++++++++++++++++++++++++----- openbsc/src/gprs/sgsn_vty.c | 40 +++++++++++++++++++++++++++++-- openbsc/tests/vty_test_runner.py | 5 +++- 3 files changed, 84 insertions(+), 9 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Thu Jan 29 14:09:15 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 29 Jan 2015 14:09:15 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-917-g0ee763f Message-ID: <201501291409.t0TE9F5C086228@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 70992b3369bb8922d92aabdbd54a33d3a52d8c05 (commit) discards 0153212b910a6c01103e1f4dc914457ac733bd9c (commit) discards 7d08477daa44919b65bbbaa794947e70bc88e407 (commit) discards 8f4a1762c82e25093de13c30fd58d0b3645c8e9f (commit) discards 78198111ebf1f60fb369a9788b5f8045d9b0beb8 (commit) discards c3f158e84846fc1fbd58aa0e377acd12a78d29ab (commit) discards 3b928ed5ed7e93144714fbe4e332ef04769d0b08 (commit) discards 34287fbf01125845844f84de7e6111e77d137775 (commit) via 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 (commit) via 97113dccfc7af33e7443e1086932306718f87554 (commit) via b2186d39d547280a73ff24cc0a4d657301cd0cc4 (commit) via 367e17ab4fac2388bba6329101fce721fcec28ca (commit) via 5bb5439eaf769bc63159df1875e11da158695f69 (commit) via 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba (commit) via 01a346c7320c9f9eceae8245d75700242cf65151 (commit) via 09283010307a88941f1c47746bbdce29e0e3b783 (commit) via 612ecee1666fc6d42eebbeda73e21bd86740023b (commit) via 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 (commit) via fdb18e8c191648abe1b9f1393157b106d8d03c1b (commit) via c735ef9a098d94bd2a3451f7004855bcf973fe91 (commit) via d5d594fcc93a7719bd1a64d51e9c10e331f2a43d (commit) via a1f0dd1e5193556b9cdfb57dead27457230f4415 (commit) via 925c57fb545b072159a831bff852c92795704dfe (commit) via 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (70992b3369bb8922d92aabdbd54a33d3a52d8c05) \ N -- N -- N (0ee763fe1b99390f23eb62cc86d1848e89cdbeb4) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 commit 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=97113dccfc7af33e7443e1086932306718f87554 commit 97113dccfc7af33e7443e1086932306718f87554 Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b2186d39d547280a73ff24cc0a4d657301cd0cc4 commit b2186d39d547280a73ff24cc0a4d657301cd0cc4 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=367e17ab4fac2388bba6329101fce721fcec28ca commit 367e17ab4fac2388bba6329101fce721fcec28ca Author: Jacob Erlbeck Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5bb5439eaf769bc63159df1875e11da158695f69 commit 5bb5439eaf769bc63159df1875e11da158695f69 Author: Jacob Erlbeck Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d2620dd4a233dafcf1c8e170a0934521e3ae8ba commit 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba Author: Jacob Erlbeck Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=01a346c7320c9f9eceae8245d75700242cf65151 commit 01a346c7320c9f9eceae8245d75700242cf65151 Author: Jacob Erlbeck Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09283010307a88941f1c47746bbdce29e0e3b783 commit 09283010307a88941f1c47746bbdce29e0e3b783 Author: Jacob Erlbeck Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI (TODO) Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI, too. TODO: - add logging Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=612ecee1666fc6d42eebbeda73e21bd86740023b commit 612ecee1666fc6d42eebbeda73e21bd86740023b Author: Jacob Erlbeck Date: Thu Jan 29 11:36:35 2015 +0100 gprs: Extend specification of GSUP cause values (TODO) Currently, every error message contains a mandantory Cause IE just referring to GSM 04.08 for further details. This leaves the mapping from MAP User Errors to GMM Cause values undefined. It is also not specified, which GMM Cause to assume, if no User Error has been included in the MAP message. This commit makes the Cause IE conditional, it is only required if the MAP message contained a User Error. A mapping from User Errors to GMM Causes is also added. The default value for GMM Causes in GSUP error messages is now 'Network failure' to keep the impact low. TODO: - the mapping is not finished, it needs review and some values are not yet specified. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 commit 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 Author: Jacob Erlbeck Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fdb18e8c191648abe1b9f1393157b106d8d03c1b commit fdb18e8c191648abe1b9f1393157b106d8d03c1b Author: Jacob Erlbeck Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c735ef9a098d94bd2a3451f7004855bcf973fe91 commit c735ef9a098d94bd2a3451f7004855bcf973fe91 Author: Jacob Erlbeck Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d5d594fcc93a7719bd1a64d51e9c10e331f2a43d commit d5d594fcc93a7719bd1a64d51e9c10e331f2a43d Author: Jacob Erlbeck Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a1f0dd1e5193556b9cdfb57dead27457230f4415 commit a1f0dd1e5193556b9cdfb57dead27457230f4415 Author: Jacob Erlbeck Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 77 +++++++++++++++++++++++++++---- openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/gprs/gprs_subscriber.c | 11 ++++- openbsc/src/libbsc/net_init.c | 2 + openbsc/src/libcommon/common_vty.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 29 ++++++++---- openbsc/src/libmsc/vty_interface_layer3.c | 47 +++++++++++++++++++ openbsc/tests/gprs/gprs_test.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 37 +++++++++++++++ 10 files changed, 187 insertions(+), 23 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 30 09:32:40 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 30 Jan 2015 09:32:40 GMT Subject: osmo-gmr.git branch sylvain/gr updated. v0.2-86-g93b2ce9 Message-ID: <201501300932.t0U9Wemo094354@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software for ETSI GMR (GEO Mobile Radio)". The branch, sylvain/gr has been updated via 93b2ce91b037b3369edcd6e480c2271ff088418e (commit) via 5ec66c633738d86043cc9c34347cf839710a6763 (commit) via 6ea35456ea7b2b7e7e548a62568d679c8ed08ef0 (commit) from ce3c94735cf8cfb832868e73bca6ccae178548be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gmr/commit/?id=93b2ce91b037b3369edcd6e480c2271ff088418e commit 93b2ce91b037b3369edcd6e480c2271ff088418e Author: Sylvain Munaut Date: Fri Jan 30 10:11:02 2015 +0100 Make use of the new delimited burst feature Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/osmo-gmr/commit/?id=5ec66c633738d86043cc9c34347cf839710a6763 commit 5ec66c633738d86043cc9c34347cf839710a6763 Author: Sylvain Munaut Date: Fri Jan 30 10:07:22 2015 +0100 Import new burst_to_tagged_stream logic Note that this cheats a little since I use the output buffer as temporary storage (i.e. writing samples to it and not telling GR until later ...) Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/osmo-gmr/commit/?id=6ea35456ea7b2b7e7e548a62568d679c8ed08ef0 commit 6ea35456ea7b2b7e7e548a62568d679c8ed08ef0 Author: Sylvain Munaut Date: Thu Jan 29 10:51:09 2015 +0100 Improvement to the FFT detection to prevent false positives ----------------------------------------------------------------------- Summary of changes: gr-gmr1/apps/gmr_rach_scan.grc | 264 ++++++++++----------- gr-gmr1/grc/CMakeLists.txt | 1 + .../{rach_demod.xml => burst_to_tagged_stream.xml} | 21 +- gr-gmr1/include/gnuradio/gmr1/CMakeLists.txt | 1 + .../{gsmtap_sink.h => burst_to_tagged_stream.h} | 18 +- gr-gmr1/lib/CMakeLists.txt | 1 + gr-gmr1/lib/burst_to_tagged_stream_impl.cc | 192 +++++++++++++++ ...t_core_impl.h => burst_to_tagged_stream_impl.h} | 38 +-- gr-gmr1/lib/rach_detect_fft_impl.cc | 65 ++++- gr-gmr1/lib/rach_detect_fft_impl.h | 10 +- gr-gmr1/swig/gmr1_swig.i | 4 + 11 files changed, 415 insertions(+), 200 deletions(-) copy gr-gmr1/grc/{rach_demod.xml => burst_to_tagged_stream.xml} (51%) copy gr-gmr1/include/gnuradio/gmr1/{gsmtap_sink.h => burst_to_tagged_stream.h} (67%) create mode 100644 gr-gmr1/lib/burst_to_tagged_stream_impl.cc copy gr-gmr1/lib/{rach_detect_core_impl.h => burst_to_tagged_stream_impl.h} (55%) hooks/post-receive -- Software for ETSI GMR (GEO Mobile Radio) From gitosis at osmocom.org Fri Jan 30 15:52:56 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 30 Jan 2015 15:52:56 GMT Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-918-g8b77456 Message-ID: <201501301552.t0UFquXI025230@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 (commit) discards 97113dccfc7af33e7443e1086932306718f87554 (commit) discards b2186d39d547280a73ff24cc0a4d657301cd0cc4 (commit) discards 367e17ab4fac2388bba6329101fce721fcec28ca (commit) discards 5bb5439eaf769bc63159df1875e11da158695f69 (commit) discards 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba (commit) discards 01a346c7320c9f9eceae8245d75700242cf65151 (commit) discards 09283010307a88941f1c47746bbdce29e0e3b783 (commit) via 8b77456f406e8215f92150868062edf1122e3aa7 (commit) via 9b9c689b7f4895d12030105b804ab5ac20a3b2bd (commit) via 16a341029d698b58db0b42a5b454b34fc0fb6589 (commit) via 8bd72827e74c49ebb504f31bc2118bfe6bdd65a7 (commit) via b922a3dcb059cdf9aefd1574d74cdf1e88cb1ea2 (commit) via df2627ad89e6ed2d217e960832545e56bc639b35 (commit) via 6a3d6fdb84c7e5d91df2c1b340cd28c20fe1c503 (commit) via a16c1ef5660370c88f20df65bc593b63d3bcfcb7 (commit) via 6cc717596131558b374520aaa42d9c70decab786 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (0ee763fe1b99390f23eb62cc86d1848e89cdbeb4) \ N -- N -- N (8b77456f406e8215f92150868062edf1122e3aa7) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8b77456f406e8215f92150868062edf1122e3aa7 commit 8b77456f406e8215f92150868062edf1122e3aa7 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9b9c689b7f4895d12030105b804ab5ac20a3b2bd commit 9b9c689b7f4895d12030105b804ab5ac20a3b2bd Author: Jacob Erlbeck Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw APN representation ??? - tests - check PDP data list on PDP Ctx Act (other commit) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=16a341029d698b58db0b42a5b454b34fc0fb6589 commit 16a341029d698b58db0b42a5b454b34fc0fb6589 Author: Jacob Erlbeck Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8bd72827e74c49ebb504f31bc2118bfe6bdd65a7 commit 8bd72827e74c49ebb504f31bc2118bfe6bdd65a7 Author: Jacob Erlbeck Date: Fri Jan 30 11:57:25 2015 +0100 sgsn/test: Fix memory leak in test_subscriber_gsup Currently the MM context is not deleted when a GSUP location cancellation message is processed, because the real sgsn_update_subscriber_data function has been wrapped to a dummy implementation. This commit adds an explicit call to sgsn_mm_ctx_cleanup_free which also unassigns the LLME, so the call to gprs_llgmm_assign is removed. It also adds an assertion to check that there are no talloc'ed blocks left in tall_bsc_ctx. Addresses: == 372 bytes in 1 blocks are possibly lost in loss record 7 of 9 == at 0x402A17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) == by 0x4059FB8: _talloc_zero (talloc.c:354) == by 0x8055B82: sgsn_mm_ctx_alloc (gprs_sgsn.c:167) == by 0x804A336: alloc_mm_ctx (sgsn_test.c:140) == by 0x804B24D: test_subscriber_gsup (sgsn_test.c:503) == by 0x804EC99: main (sgsn_test.c:1853) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b922a3dcb059cdf9aefd1574d74cdf1e88cb1ea2 commit b922a3dcb059cdf9aefd1574d74cdf1e88cb1ea2 Author: Jacob Erlbeck Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=df2627ad89e6ed2d217e960832545e56bc639b35 commit df2627ad89e6ed2d217e960832545e56bc639b35 Author: Jacob Erlbeck Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6a3d6fdb84c7e5d91df2c1b340cd28c20fe1c503 commit 6a3d6fdb84c7e5d91df2c1b340cd28c20fe1c503 Author: Jacob Erlbeck Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a16c1ef5660370c88f20df65bc593b63d3bcfcb7 commit a16c1ef5660370c88f20df65bc593b63d3bcfcb7 Author: Jacob Erlbeck Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6cc717596131558b374520aaa42d9c70decab786 commit 6cc717596131558b374520aaa42d9c70decab786 Author: Jacob Erlbeck Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI either. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 13 +++---- openbsc/src/gprs/gprs_subscriber.c | 72 ++++++++++++++++++++++++++++++++----- openbsc/src/gprs/sgsn_vty.c | 7 ++++ openbsc/tests/sgsn/sgsn_test.c | 32 +++++++++++------ 4 files changed, 96 insertions(+), 28 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Fri Jan 30 20:43:38 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 30 Jan 2015 20:43:38 GMT Subject: openbsc.git branch master updated. 0.13.0-914-g4b2d02d Message-ID: <201501302043.t0UKhcw8049678@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 (commit) via baf0f94a7dd858eba37548253959747838b1cc16 (commit) via 9ff82892da2b58ba344b2f6e70256d08947b9c34 (commit) via 85ba655788b49dc83e33109368f81b7c3ea0b090 (commit) via 466cedd052427254d5f90b4bd02795129b2c60a4 (commit) via 07f6e36ab42380f9a4c1af058c3021cb0e945dc4 (commit) via 8000e0ea509c5a4488a5d1878f465418d32b7fdb (commit) via 929acdf6bf4ef25c8cc587a6aa48651696348881 (commit) via e988ae471d8e699a4045d77048986570349203fa (commit) via e671d254cbc294f87620c2938eb6fa2883253fcb (commit) via 555b2e5ac128211edffa34a586fe5f548eb3acba (commit) from 925c57fb545b072159a831bff852c92795704dfe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 commit 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 Author: Jacob Erlbeck Date: Fri Jan 30 11:57:25 2015 +0100 sgsn/test: Fix memory leak in test_subscriber_gsup Currently the MM context is not deleted when a GSUP location cancellation message is processed, because the real sgsn_update_subscriber_data function has been wrapped to a dummy implementation. This commit adds an explicit call to sgsn_mm_ctx_cleanup_free which also unassigns the LLME, so the call to gprs_llgmm_assign is removed. It also adds an assertion to check that there are no talloc'ed blocks left in tall_bsc_ctx. Addresses: == 372 bytes in 1 blocks are possibly lost in loss record 7 of 9 == at 0x402A17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) == by 0x4059FB8: _talloc_zero (talloc.c:354) == by 0x8055B82: sgsn_mm_ctx_alloc (gprs_sgsn.c:167) == by 0x804A336: alloc_mm_ctx (sgsn_test.c:140) == by 0x804B24D: test_subscriber_gsup (sgsn_test.c:503) == by 0x804EC99: main (sgsn_test.c:1853) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=baf0f94a7dd858eba37548253959747838b1cc16 commit baf0f94a7dd858eba37548253959747838b1cc16 Author: Jacob Erlbeck Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9ff82892da2b58ba344b2f6e70256d08947b9c34 commit 9ff82892da2b58ba344b2f6e70256d08947b9c34 Author: Jacob Erlbeck Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=85ba655788b49dc83e33109368f81b7c3ea0b090 commit 85ba655788b49dc83e33109368f81b7c3ea0b090 Author: Jacob Erlbeck Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=466cedd052427254d5f90b4bd02795129b2c60a4 commit 466cedd052427254d5f90b4bd02795129b2c60a4 Author: Jacob Erlbeck Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=07f6e36ab42380f9a4c1af058c3021cb0e945dc4 commit 07f6e36ab42380f9a4c1af058c3021cb0e945dc4 Author: Jacob Erlbeck Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI either. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8000e0ea509c5a4488a5d1878f465418d32b7fdb commit 8000e0ea509c5a4488a5d1878f465418d32b7fdb Author: Jacob Erlbeck Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=929acdf6bf4ef25c8cc587a6aa48651696348881 commit 929acdf6bf4ef25c8cc587a6aa48651696348881 Author: Jacob Erlbeck Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e988ae471d8e699a4045d77048986570349203fa commit e988ae471d8e699a4045d77048986570349203fa Author: Jacob Erlbeck Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e671d254cbc294f87620c2938eb6fa2883253fcb commit e671d254cbc294f87620c2938eb6fa2883253fcb Author: Jacob Erlbeck Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=555b2e5ac128211edffa34a586fe5f548eb3acba commit 555b2e5ac128211edffa34a586fe5f548eb3acba Author: Jacob Erlbeck Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 4 +- openbsc/src/gprs/gprs_gmm.c | 24 +--------- openbsc/src/gprs/gprs_sgsn.c | 60 +++++++++++++------------ openbsc/src/gprs/gprs_subscriber.c | 65 +++++++++++++++++++++++---- openbsc/src/gprs/sgsn_vty.c | 40 ++++++++++++++++- openbsc/tests/gprs/gprs_test.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 90 +++++++++++++++++++++++++++---------- openbsc/tests/vty_test_runner.py | 5 ++- 8 files changed, 202 insertions(+), 90 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sat Jan 31 18:11:24 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 31 Jan 2015 18:11:24 GMT Subject: openbsc.git branch master updated. 0.13.0-917-g7af5f81 Message-ID: <201501311811.t0VIBO2G067057@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 (commit) via 8657326093b6e1eed8cc24fe62039d70aa27d47d (commit) via a07e38d4bf4298be0f3f9676f8de0c0f8ee534b6 (commit) from 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7af5f8130f7282e98d0dcf11c4a058a66c2617a6 commit 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 Author: Holger Hans Peter Freyther Date: Sat Jan 31 12:36:07 2015 +0100 rsl: Remove unused code for channel activation The code has been unused for a long time. Let's remove it. http://cgit.osmocom.org/openbsc/commit/?id=8657326093b6e1eed8cc24fe62039d70aa27d47d commit 8657326093b6e1eed8cc24fe62039d70aa27d47d Author: Holger Hans Peter Freyther Date: Sat Jan 31 09:47:37 2015 +0100 meas: Install the scenario command and test it http://cgit.osmocom.org/openbsc/commit/?id=a07e38d4bf4298be0f3f9676f8de0c0f8ee534b6 commit a07e38d4bf4298be0f3f9676f8de0c0f8ee534b6 Author: Holger Hans Peter Freyther Date: Sat Jan 31 09:26:20 2015 +0100 meas: Add VTY documentation for the measurement commands Document the parameters that can be passed on. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_rsl.c | 35 ------------------------------- openbsc/src/libmsc/vty_interface_layer3.c | 11 ++++++++-- openbsc/tests/vty_test_runner.py | 19 +++++++++++++++++ 3 files changed, 28 insertions(+), 37 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sat Jan 31 20:15:49 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 31 Jan 2015 20:15:49 GMT Subject: osmo-python-tests.git branch master updated. b819b57a98d142ba004d9dbc6c786c1cd9f1c76c Message-ID: <201501312015.t0VKFn9p077768@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via b819b57a98d142ba004d9dbc6c786c1cd9f1c76c (commit) from 4e98c266b77d0629db2e313ab527b5180b16eaa9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=b819b57a98d142ba004d9dbc6c786c1cd9f1c76c commit b819b57a98d142ba004d9dbc6c786c1cd9f1c76c Author: Holger Hans Peter Freyther Date: Sat Jan 31 21:15:06 2015 +0100 testconfig: Do not fail due wrong numbers Fix the script and don't fail ----------------------------------------------------------------------- Summary of changes: osmopy/osmotestconfig.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Sat Jan 31 20:22:59 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 31 Jan 2015 20:22:59 GMT Subject: openbsc.git branch master updated. 0.13.0-918-gb8c204c Message-ID: <201501312022.t0VKMxZo078709@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via b8c204cb929a8455bfa6006a95a958d57274ab08 (commit) from 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b8c204cb929a8455bfa6006a95a958d57274ab08 commit b8c204cb929a8455bfa6006a95a958d57274ab08 Author: Holger Hans Peter Freyther Date: Sat Jan 31 19:42:42 2015 +0100 ctrl/bsc: Fix copy and paste error and update text 30f1f376383df3ae8d85e96542bf14d174c25d89 introduced new channel combinations but had a copy and paste error in the description. The jenkins system didn't run the external tests so this issue and others were not noticed until now. Fix the copy and paste and update the test result. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/bsc_ctrl_commands.c | 2 ++ openbsc/src/libcommon/gsm_data_shared.c | 4 ++-- openbsc/tests/ctrl_test_runner.py | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Sat Jan 31 21:45:18 2015 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 31 Jan 2015 21:45:18 GMT Subject: openbsc.git branch master updated. 0.13.0-919-g4e13a8f Message-ID: <201501312145.t0VLjIuD085967@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 4e13a8f9f9d40e5d62c9cee7d76348ef8b558981 (commit) from b8c204cb929a8455bfa6006a95a958d57274ab08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4e13a8f9f9d40e5d62c9cee7d76348ef8b558981 commit 4e13a8f9f9d40e5d62c9cee7d76348ef8b558981 Author: Holger Hans Peter Freyther Date: Sat Jan 31 22:16:00 2015 +0100 bsc/nitb: Allow to set the GPRS mode through the ctrl command Create a control command to read and modify the gprs mode. Use the get_string_value to indicate if the value was found or not. This is useful for the ctrl interface where I didn't want to replicate "none", "gprs" and "egprs". Share code to verify that a BTS supports the mode. Related: SYS#591 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 3 ++- openbsc/src/libbsc/bsc_ctrl_commands.c | 44 ++++++++++++++++++++++++++++++++-- openbsc/src/libbsc/bsc_vty.c | 11 ++------- openbsc/src/libcommon/gsm_data.c | 23 ++++++++++++++++-- openbsc/tests/ctrl_test_runner.py | 19 +++++++++++++++ 5 files changed, 86 insertions(+), 14 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)