This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via b6b3c7eb2727da98fbba231d9a1e9fe4a33b2dd0 (commit)
from 1c95bd383e07f0c58805084d36a46d774ea91726 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=b6b3c7eb2727da98fbba231d9a1e9fe4a33b2dd0
commit b6b3c7eb2727da98fbba231d9a1e9fe4a33b2dd0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date: Fri Aug 28 12:07:14 2015 +0200
tbf: Use explicit initialisations in constructor (Coverity)
Currently when allocating tbf_alloc_ul_tbf or tbf_alloc_dl_tbf
objects, the allocated memory area is pre-initialised by talloc_zero
before the C++ constructors are called. This is not recognised by
Coverity, since there is no talloc model file yet. Thus Coverity
complains about missing initialisers.
On the other hand, it is still planned to convert the TBF classes
into real C++ ones. So instead of silencing Coverity directly, this
is an opportunity to do it the C++ way.
This commit adds initialisers and initialisation code for all
members that relied on talloc_zero. The corresponding calls to
talloc_zero are replaced by calls to talloc to give ASAN/valgrind
a chance to detect future initialisation errors. Some initialisation
code is also moved from setup_tbf to the constructors, notably the
initialisation of the bts pointer.
Fixes: Coverity CID 1320604, 1320605, 1320606
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/tbf.cpp | 103 ++++++++++++++++++++++++++++++++++++++++++----------
src/tbf.h | 14 ++++---
tests/ms/MsTest.cpp | 22 +++++------
3 files changed, 103 insertions(+), 36 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT