osmo-pcu.git branch jerlbeck/master updated. 0.2-561-gebebad1

gitosis at osmocom.org gitosis at osmocom.org
Mon Aug 17 15:30:49 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/master has been updated
       via  ebebad1c92e8bcbe28780b4d5ee2ac32091089ff (commit)
       via  56af6d55ed50c34d28e49c16f7c00da5820d22f3 (commit)
       via  f76fedeed5bb52f5ee471b2cabc9fb7aa0c4ccf8 (commit)
       via  fea17f8b8cc4835c9a92dfa018e38de0d6fc8cb5 (commit)
       via  af9a39d9542c1f4f337fe2cc5596000eb2c60d53 (commit)
       via  28c40b17574a2dc792278baffb6f4f87e3559bb6 (commit)
       via  3449a61032cbf91f1a042e02264142b4df3d61a7 (commit)
      from  1c3b8998bc6d9d6f78a2bc29ac1f0ba9cffa4fb8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit ebebad1c92e8bcbe28780b4d5ee2ac32091089ff
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Aug 17 14:43:52 2015 +0200

    ns: Reconnect NSVC after timeout
    Currently the signal S_NS_ALIVE_EXP emitted by the NS layer if the
    alive check has timed out too often is ignored. This prevents the PCU
    from reconnecting to the SGSN if it has not been accessible for some
    This commit modifies nsvc_signal_cb to reset the NSCV if
    S_NS_ALIVE_EXP is sent, so that the PCU continues to send NS RESET
    message if that happened.
    Sponsored-by: On-Waves ehf


commit 56af6d55ed50c34d28e49c16f7c00da5820d22f3
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Aug 17 14:06:21 2015 +0200

    ns: Add logging support
    Currently there is not support for Network Service (NS) logging.
    This commit adds the missing definitions and sets the default level
    to INFO. Further configuration can now be done with the 'logging
    level ns' VTY command.
    Sponsored-by: On-Waves ehf


commit f76fedeed5bb52f5ee471b2cabc9fb7aa0c4ccf8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Aug 17 13:42:46 2015 +0200

    vty: Change API to have node installation be done by int
    This commit fixes the go_parent_cb API according to libosmocore's
    commit of the same name.
    pcu_vty.c:799:2: warning: initialization from incompatible pointer
    type [enabled by default]
      .go_parent_cb = pcu_vty_go_parent,
    Sponsored-by: On-Waves ehf


commit fea17f8b8cc4835c9a92dfa018e38de0d6fc8cb5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Sun Aug 16 21:36:32 2015 +0200

    ms: Do not retrieve MS with IMSI 000 from the storage
    The IMSI '000' is used as default value for an incoming BSSGP
    message's IMSI IE. This can lead to the retrieval of the wrong MS
    object from the storage.
    This commit changes the get_ms method to skip the IMSI search if such
    an IMSI is passed as selector.
    Note that changing the default value in the BSSGP code does not help
    Sponsored-by: On-Waves ehf


commit af9a39d9542c1f4f337fe2cc5596000eb2c60d53
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Sun Aug 16 21:27:34 2015 +0200

    tbf: Use update_ms instead of confirm_tlli in handle()
    The confirm_tlli method does not handle TLLI clashes in the MS
    This commit changes gprs_rlcmac_dl_tbf::handle() to use update_ms
    Sponsored-by: On-Waves ehf


commit 28c40b17574a2dc792278baffb6f4f87e3559bb6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Sun Aug 16 18:19:32 2015 +0200

    tbf: Clean old MS objects if they have the same TLLI
    Currently if an MS retries to access the PCU by using RACH and if
    there is already an entry for that MS, a duplicated MS object
    referring to the same TLLI is created. This is caused by blindly
    setting the TLLI without querying the MS storage to avoid
    This leads to several entries in the MS storage that are assigned to
    the same TLLI. If that happens, 'show ms all' can display multiple
    entries with the same TLLI (note that an MS object can belong to
    several TLLIs, so there might be an intersection that is not visible
    in the list) or 'show tbf all' can show entries with MS_CLASS == 0 in
    some cases.
    This commit changes update_ms() to merge and clean up old entries
    that belong to the given TLLI if they exist. Some data (like the MS
    class) is copied to the new MS object.
    Note that TBF belonging to the old MS object are deleted immediately
    if they have not registered a timer.
    Sponsored-by: On-Waves ehf


Summary of changes:
 examples/osmo-pcu.cfg   |  4 ++--
 src/gprs_bssgp_pcu.cpp  | 30 +++++++++++++++++++++++++
 src/gprs_bssgp_pcu.h    |  1 +
 src/gprs_debug.cpp      |  1 +
 src/gprs_debug.h        |  1 +
 src/gprs_ms_storage.cpp |  4 +++-
 src/pcu_main.cpp        |  1 +
 src/pcu_vty.c           |  2 +-
 src/pcu_vty.h           |  2 +-
 src/tbf.cpp             | 58 ++++++++++++++++++++++++++++++++++++++++++++++++-
 src/tbf.h               |  1 +
 src/tbf_dl.cpp          |  6 +----
 tests/tbf/TbfTest.cpp   | 20 +++++++++++------
 tests/tbf/TbfTest.err   | 17 ++++++++-------
 14 files changed, 122 insertions(+), 26 deletions(-)


More information about the osmocom-commitlog mailing list