openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-816-g35aa453

gitosis at gitosis at
Fri Dec 19 18:20:20 UTC 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, jerlbeck/wip/gprs-patching has been updated
       via  35aa453126a061ad6fa06e0ea86969529de9cd28 (commit)
       via  b26e659a088ad866c56eb3397bc8aff0a7350640 (commit)
       via  318bcda0c07c4bc3c3be6d622ce312faa1b5a6a5 (commit)
       via  392c4754e2ddd572ac1d1c2ed80cf481b1c63ee8 (commit)
       via  34887ace4d92eed6c478c44add5056e93e695d2e (commit)
       via  b3116782778dc8125e232fb2808a523782ab30af (commit)
       via  637ba7592e37ffe1bf8053bd7e56ad48b1347fb7 (commit)
       via  b908f5b672827402e59af33a03e9df1350e0453b (commit)
       via  407bff0c6e0c607f8e7d5ec6e0a093df57284707 (commit)
       via  c1b63debaa95506b9e0ca066c0f93d6d00b07967 (commit)
       via  4a73b1aed68590370fbeb9bc0ec5b7bf7daa8300 (commit)
       via  4e8f42720a530fca0a44f761990b64bb77446ddb (commit)
      from  5b4c44f4f0f902fa3762793b9a10b3392031f140 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 35aa453126a061ad6fa06e0ea86969529de9cd28
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 19:19:46 2014 +0100

    sgsn: Show GSUP client info on 'show sgsn' (TODO)
    Ticket: OW#????
    Sponsored-by: On-Waves ehf

commit b26e659a088ad866c56eb3397bc8aff0a7350640
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 19:18:54 2014 +0100

    sgsn: Send PING and eventually reconnect (TODO)
    Ticket: OW#????
    Sponsored-by: On-Waves ehf

commit 318bcda0c07c4bc3c3be6d622ce312faa1b5a6a5
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 19:15:55 2014 +0100

    sgsn: Handle incoming IPA CCM message in gsup_client_read_cb (TODO)
    This patch adds a call to ipaccess_bts_handle_ccm and continues
    depending on the return code.
      - commit message (what changes this?)
    Sponsored-by: On-Waves ehf

commit 392c4754e2ddd572ac1d1c2ed80cf481b1c63ee8
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 19:11:20 2014 +0100

    sgsn: Add logging to connect_timer_cb (TODO)
      - LOGLevel ?
    Sponsored-by: On-Waves ehf

commit 34887ace4d92eed6c478c44add5056e93e695d2e
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 19:00:56 2014 +0100

    sgsn: Handle return code of ipa_client_conn_open correctly
    The ipa_client_conn_open function does not distinguish between a
    connection being already established or waiting for establishment.
    In either case, the application gets informed about the connection
    state via the updown_cb. The 'up' parameter is only set, if
    poll/select consider the socket as writable.
    This patch handles both cases equally and fully relies on the
    updown_cb to adjust the gsupc obejct state.
    Sponsored-by: On-Waves ehf

commit b3116782778dc8125e232fb2808a523782ab30af
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:50:05 2014 +0100

    sgsn: Avoid sending stale GSUP requests after reconnect
    Currently, messages are added to the tx queue even if the connection
    is down for some reason and all of these messages are eventually sent
    after a re-connect.  The MS has probably sent several Attach Requests
    while the connection was down and will continue doing so. Therefore
    these stored messages could be dropped.
    This patch clears the queue before re-connecting and also extends
    gprs_gsup_client_send to return immediately, when the connection is
    not established instead of calling ipa_client_conn_send.
    Sponsored-by: On-Waves ehf

commit 637ba7592e37ffe1bf8053bd7e56ad48b1347fb7
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:43:41 2014 +0100

    gprs: Stop the GSUP client connect timer
    Currently the connection timer is not stopped before reconnect before
    calling talloc_free on the gsupc object.
    This patch adds calls to osmo_timer_del() to gsup_client_connect and
    gprs_gsup_client_destroy. The latter is now called instead of
    talloc_free in gprs_gsup_client_create on error to be on the safe
    Sponsored-by: On-Waves ehf

commit b908f5b672827402e59af33a03e9df1350e0453b
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:30:41 2014 +0100

    sgsn/test: Extend tests to simulate lost GSUP requests
    This patch extends test_gmm_attach to optionally resend Attach
    Requests until the SGSN responds to it instead of calling
    OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth
    test optionally uses this feature. It is called once in either mode.
    Sponsored-by: On-Waves ehf

commit 407bff0c6e0c607f8e7d5ec6e0a093df57284707
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:26:09 2014 +0100

    sgsn/test: Add GMM test for a GSUP based attach procedure
    This test calls test_gmm_attach() where the mocked subscriber
    functions insert GSUP messages instead of manipulating the
    subscriber structure directly.
    Sponsored-by: On-Waves ehf

commit c1b63debaa95506b9e0ca066c0f93d6d00b07967
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:19:50 2014 +0100

    sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message
    Currently, several lines of boiler plate are needed around a call to
    This patch puts all of this (including the call to
    gprs_subscr_rx_gsup_message) into a separate function.
    Sponsored-by: On-Waves ehf

commit 4a73b1aed68590370fbeb9bc0ec5b7bf7daa8300
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:17:10 2014 +0100

    sgsn: Log requested state change in sgsn_auth_update
    Sponsored-by: On-Waves ehf

commit 4e8f42720a530fca0a44f761990b64bb77446ddb
Author: Jacob Erlbeck <jerlbeck at>
Date:   Fri Dec 19 18:08:48 2014 +0100

    sgsn: Add global require_update_location flag
    This flag is used to determine, whether the Update Location procedure
    shall be invoked. This is currently only set, when the 'remote'
    authorization policy is set. When the flag is set, sgsn_auth_update
    will not never be called directly by sgsn_auth_request, if an Attach
    Request procedure is pending, even if the remote connection fails for
    some reason.
    Sponsored-by: On-Waves ehf


Summary of changes:
 openbsc/include/openbsc/gprs_gsup_client.h |   2 +
 openbsc/include/openbsc/sgsn.h             |   1 +
 openbsc/src/gprs/gprs_gsup_client.c        | 125 +++++++++++++++++++--
 openbsc/src/gprs/sgsn_auth.c               |  18 ++-
 openbsc/src/gprs/sgsn_vty.c                |  12 ++
 openbsc/tests/sgsn/sgsn_test.c             | 171 +++++++++++++++++++++++------
 6 files changed, 278 insertions(+), 51 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list