RFC: talloc contexts / automatic free at select loop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pau Espin Pedrol pespin at sysmocom.de
Wed Mar 20 11:54:11 UTC 2019


Hi,

First of all, I'm not against addition of this "select scoped talloc 
context", and it's fine for me to merge if others find it's a really 
handy feature. But I have the feeling it really adds unneeded extra 
complexity and scenarios to take care in the code. New ways to get shot 
on your knee, having to use talloc_steal() and talloc_reparent(). Not 
sure if the benefits are worth the effort and increase of complexity.

IMHO we should be fine using regular global context (and freeing stuff 
around) together with static/stack buffers when possible.

Regards,
Pau

-- 
- Pau Espin Pedrol <pespin at sysmocom.de>         http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte



More information about the OpenBSC mailing list