coding style: fixed indenting vs align-with-brace

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Feb 6 18:12:28 UTC 2019


On Wed, Feb 06, 2019 at 09:44:39PM +0700, Vadim Yanitskiy wrote:
> 1. let's don't enforce the "opening brace alignment" during code review;

If we decided on this, then the next one would be a problem:

> 1.a. if a new file is to be introduced, the alignment style is up to the author;

I will not change my cinoptions according to .c file, I will pick one style and
always use that. The only way I would accept to adopt single-tab indent would
be to allow it anywhere, even when mixing style in files; i.e. allow both.

I still agree that a single-tab indenting is better for using the line width
and for having less whitespace changes in patches. I also have a number of
other preferences in coding style.

But in coding style questions, I'm taking Harald's and Holger's opinions as the
benchmark and last word on things...  So I guess it was worth a try, but I'll
just continue as before, then.

~N
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20190206/8ac669b4/attachment.bin>


More information about the OpenBSC mailing list