Rationale behind ipa_ccm_idtag_parse_off() ?

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Sun Jul 29 10:11:13 UTC 2018



> On 29. Jul 2018, at 10:33, Harald Welte <laforge at gnumonks.org> wrote:
> 
> 
> I'm getting back to the following libosmocore commit introduced in 2015:
> 
>> commit f558ed4bb9c0f00997b8f97c2b251a574c1a64c4
>> Author: Holger Hans Peter Freyther <holger at moiji-mobile.com>
>> Date:   Tue Jun 2 15:52:06 2015 +0200
> 
> I can see what you are doing, but I have absolutely no idea as to why.


> So if the function was just added for that test case, why not structure the data
> used in the test to reflect the on-the-wire protocol reality?
> 
> There must be some genius rationale behind it, but I'm unable to figure it out.
> 
> Maybe you still remember? Thanks!

I might not have time until next week to replicate it (and my nanobts is not
with me right now either). IIRC (my first memory but the commit message points
me to it as well): I struggled a lot to parse ipaccess-find (IPAC_MSGT_ID_GET)
from the nanoBTS.

It seemed it was disobeying a reasonable TLV structure and the closest I found
back then seemed to have been this patch? Could you check if the testcase matches
an ipaccess-find result?

I will try to find some next during the week to have a look.


holger


More information about the OpenBSC mailing list