log level everything

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Keith keith at rhizomatica.org
Sun Sep 10 09:53:14 UTC 2017


Hi Max!

Since  https://gerrit.osmocom.org/#/c/3148/

I am no longer able to individually control log levels in
the vty.

I used to use logging level all everything, then this
allowed me to do such as

logging level smpp fatal (get rid of annoying bind check
every 30 secs)

logging level [category i'm interested in] debug

Now, all I seem to be able to do is turn all categories to a
level with

logging level all debug or logging level all notice.

individual category directives such as logging level pag
fatal make no difference.

What am I missing?

Thanks!

BTW, I get the behaviour I need back by moving your check
below the check for "all"::

diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 01480b1..fb2cab8 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -213,17 +213,18 @@ DEFUN(logging_level,
                return CMD_WARNING;
        }
 
-       if (strcmp(argv[1], "everything") == 0) { /* FIXME:
remove this check once 'everything' is phased out */
-               vty_out(vty, "%% Ignoring deprecated logging
level %s%s", argv[1], VTY_NEWLINE);
-               return CMD_SUCCESS;
-       }
-
        /* Check for special case where we want to set
global log level */
        if (!strcmp(argv[0], "all")) {
                log_set_log_level(tgt, level);
                return CMD_SUCCESS;
        }
 
+       if (strcmp(argv[1], "everything") == 0) { /* FIXME:
remove this check once 'everything' is phased out */
+               vty_out(vty, "%% Ignoring deprecated logging
level %s%s", argv[1], VTY_NEWLINE);
+               return CMD_SUCCESS;
+       }
+
+
        if (category < 0) {
                vty_out(vty, "Invalid category `%s'%s",
argv[0], VTY_NEWLINE);
                return CMD_WARNING;




More information about the OpenBSC mailing list