Proposal: Usage of stow in jenkins build scripts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Huemer alexander.huemer at xx.vu
Mon May 15 20:25:18 UTC 2017


Hi!

On Mon, May 15, 2017 at 10:18:03PM +0200, Neels Hofmeyr wrote:
> The attached patch below indeed looks like errors in our build. Can you please
> push this as a patch to gerrit?

Will do.
 
> And you are meaning to say: if we used stow in our jenkins builds, we would
> catch these errors and fail builds if new ones are introduced, right?

That is the intention, yes, although stow is a convenience layer, not 
strictly required.

> What role exactly does stow play here -- do I get the same when I install to
> separate '--prefix'es and then add all those prefixes to the PKG_CONFIG_PATH
> and LD_LIBRARY_PATH?

Yes, the effect would be the same. Stow just makes all of that much more 
convenient and straight-forward, as you end up with just one location 
where (symlinks to) libs and so forth have to be searched. stow takes 
care of that.

> The jenkins build scripts for each project are included in the contrib/ dir of
> each git tree, using scripts found in the osmo-ci.git (also on gerrit). Feel
> free to go ahead and submit patches that use stow, e.g. for the openbsc.git
> build to begin with. If it improves our build by catching CFLAGS omissions I'll
> happily merge it. I can also install packages that you need for this on the
> build slaves.

I will take a look into that as well.
 
> On Mon, May 15, 2017 at 09:39:57PM +0200, Alexander Huemer wrote:
> > From e9fc0ed9c7b6c1acc70714f703983708f5d8a1ee Mon Sep 17 00:00:00 2001
> > From: Alexander Huemer <alexander.huemer at xx.vu>
> > Date: Mon, 15 May 2017 20:42:47 +0200
> > Subject: [PATCH] Add missing _CFLAGS and _LIBS
> > 
> > These missing pieces go unnoticed if dependencies are not installed in
> > distinct directories.
> > 
> > Change-Id: If8d57b72f63d79cc0d8efba7466c6ec177207cbb
> > ---
> >  openbsc/src/utils/Makefile.am       | 3 +++
> >  openbsc/tests/sndcp_xid/Makefile.am | 3 ++-
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/openbsc/src/utils/Makefile.am b/openbsc/src/utils/Makefile.am
> > index 9c3837a36..26494e13d 100644
> > --- a/openbsc/src/utils/Makefile.am
> > +++ b/openbsc/src/utils/Makefile.am
> > @@ -109,6 +109,7 @@ osmo_meas_pcap2db_LDADD = \
> >  osmo_meas_pcap2db_CFLAGS = \
> >  	$(LIBOSMOCORE_CFLAGS) \
> >  	$(LIBOSMOGSM_CFLAGS) \
> > +	$(LIBOSMOABIS_CFLAGS) \
> >  	$(NULL)
> >  
> >  osmo_meas_udp2db_SOURCES = \
> > @@ -125,6 +126,7 @@ osmo_meas_udp2db_LDADD = \
> >  osmo_meas_udp2db_CFLAGS = \
> >  	$(LIBOSMOCORE_CFLAGS) \
> >  	$(LIBOSMOGSM_CFLAGS) \
> > +	$(LIBOSMOABIS_CFLAGS) \
> >  	$(NULL)
> >  
> >  meas_json_SOURCES = \
> > @@ -140,5 +142,6 @@ meas_json_LDADD = \
> >  meas_json_CFLAGS = \
> >  	$(LIBOSMOCORE_CFLAGS) \
> >  	$(LIBOSMOGSM_CFLAGS) \
> > +	$(LIBOSMOABIS_CFLAGS) \
> >  	$(NULL)
> >  
> > diff --git a/openbsc/tests/sndcp_xid/Makefile.am b/openbsc/tests/sndcp_xid/Makefile.am
> > index 99b9d1a4f..d09c41b28 100644
> > --- a/openbsc/tests/sndcp_xid/Makefile.am
> > +++ b/openbsc/tests/sndcp_xid/Makefile.am
> > @@ -15,6 +15,7 @@ sndcp_xid_test_LDADD = \
> >  	$(LIBOSMOGB_LIBS) \
> >  	$(LIBCARES_LIBS) \
> >  	$(LIBCRYPTO_LIBS) \
> > -	-lgtp -lrt -lm
> > +	$(LIBGTP_LIBS) \
> > +	-lrt -lm
> >  
> >  
> > -- 
> > 2.11.0
> > 
> 
> 
> 
> 
> -- 
> - Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
> =======================================================================
> * sysmocom - systems for mobile communications GmbH
> * Alt-Moabit 93
> * 10559 Berlin, Germany
> * Sitz / Registered office: Berlin, HRB 134158 B
> * Geschäftsführer / Managing Directors: Harald Welte


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20170515/cde6ec6b/attachment.bin>


More information about the OpenBSC mailing list