This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi Andreas,
On Mon, Jan 30, 2017 at 05:37:11PM +0100, Andreas Schultz wrote:
> Consolidate duplicate code into helper.
Makes complete sense.
However:
> +static void pdp_context_delete(struct pdp_ctx *pctx);
> +
why introduce the forward-declaration and then define the function
further down in the file? I think in general, it is preferred to put
helper functions on top, before their first use, so forward declarations
can be avoided? Particularly if the helper function doesn't call any
other functions that are not yet declared at this point.
Please note the above might just be my personal taste, not sure if
that's a general habit in the kernel networking code these days.
So with or without the re-ordering:
Acked-by: Harald Welte <laforge at gnumonks.org>
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)