[MERGED] libosmo-abis[master]: Resync RTP session in case of timestamp jump

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Oct 12 11:37:31 UTC 2016


In below patch (already merged) there's apparently only a LOGP tweak.
Looks like something is missing there and Harald didn't spot it?
It can't possibly fix OS#1803, can it?

~Neels

On Wed, Oct 12, 2016 at 09:26:01AM +0000, Harald Welte wrote:
> Harald Welte has submitted this change and it was merged.
> 
> Change subject: Resync RTP session in case of timestamp jump
> ......................................................................
> 
> 
> Resync RTP session in case of timestamp jump
> 
> This will prevent the timestamp jump to occur between each call for DTX
> if something goes wrong. It's handy as oRTP does not manage well
> timestamp jump if it is not resynced.
> 
> Fixes: OS#1803
> Change-Id: Iae5da832218dbd1ede7a9451102074f2a5eb66df
> ---
> M src/trau/osmo_ortp.c
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Approvals:
>   Harald Welte: Looks good to me, approved
>   Jenkins Builder: Verified
> 
> 
> 
> diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c
> index 6ce70d2..e3c6234 100644
> --- a/src/trau/osmo_ortp.c
> +++ b/src/trau/osmo_ortp.c
> @@ -139,7 +139,8 @@
>  	uint32_t ts = rtp_session_get_current_recv_ts(rs);
>  
>  	LOGP(DLMIB, LOGL_NOTICE,
> -	     "osmo-ortp(%d): timestamp_jump, new TS %d\n", port, ts);
> +	     "osmo-ortp(%d): timestamp_jump, new TS %d, resyncing\n", port, ts);
> +	rtp_session_resync(rs);
>  }
>  
>  
> 
> -- 
> To view, visit https://gerrit.osmocom.org/1028
> To unsubscribe, visit https://gerrit.osmocom.org/settings
> 
> Gerrit-MessageType: merged
> Gerrit-Change-Id: Iae5da832218dbd1ede7a9451102074f2a5eb66df
> Gerrit-PatchSet: 4
> Gerrit-Project: libosmo-abis
> Gerrit-Branch: master
> Gerrit-Owner: Max <msuraev at sysmocom.de>
> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
> Gerrit-Reviewer: Jenkins Builder

-- 
- Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20161012/b8298c17/attachment.bin>


More information about the OpenBSC mailing list