This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Philipp Maier pmaier at sysmocom.deHallo Neels, > The point of this complaint: > > - gprs_sndcp_comp.c:67 implies that v42bis_params might be NULL > - on line 104 we call gprs_sndcp_dcomp_init() > - then this function (gprs_sndcp_dcomp.c near 88) dereferences > comp_field->v42bis_params without checking for NULL (instead relies on > comp_entity->algo == V42BIS) > > I think I'd add an OSMO_ASSERT(comp_field->v42bis_params) in > gprs_sndcp_dcomp_init(). pmaier? I am ok with that, but I think this CID is a false alarm anyway. I have now added OSMO_ASSERT()s for both gprs_sndcp_dcomp_init() and gprs_sndcp_pcomp_init(). See also: https://gerrit.osmocom.org/1279 regards, Philipp -- Philipp Maier <pmaier at sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte