This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 6: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/118/6/tests/codec/codec_test.c
File tests/codec/codec_test.c:
Line 54: printf("[%d] encode [%d]\n", rc, memcmp(tmp, t, SID_LEN));
Okay. I will accept this to not have you spend more time on it. One thing both Jacob and me learned the hardway is:
* Capturing textual output is good to catch accidental changes
* But it is not replacing OSMO_ASSERT. So e.g. in future tests use OSMO_ASSERT on that memcmp.
I am accepting this change now.
--
To view, visit https://gerrit.osmocom.org/118
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia217679a07d3fbc970f435e20f6eac33d34bd597
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes