[MERGED] osmo-pcu[master]: tbf_ul: use correct size for chunk_size

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed May 25 19:45:50 UTC 2016


Holger Freyther has submitted this change and it was merged.

Change subject: tbf_ul: use correct size for chunk_size
......................................................................


tbf_ul: use correct size for chunk_size

The size of the hole array in bytes was used instead of the size of elements.

Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf
Reviewed-on: https://gerrit.osmocom.org/105
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger at freyther.de>
---
M src/tbf_ul.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 9e763f4..1316204 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -60,7 +60,7 @@
 	LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len);
 
 	num_frames = Decoding::rlc_data_from_ul_data(
-		rdbi, cs, data, &(frames[0]), sizeof(frames),
+		rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frames),
 		&dummy_tlli);
 
 	/* create LLC frames */

-- 
To view, visit https://gerrit.osmocom.org/105
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>



More information about the OpenBSC mailing list