openbsc[master]: Fix copy-paste error in SI6

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon May 23 16:24:38 UTC 2016


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/101/1/openbsc/src/libbsc/system_information.c
File openbsc/src/libbsc/system_information.c:

Line 935: 	gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
Okay. so we are not on BCCH so it needs to be false here. But what do you think of using an enum value in the long run here?


-- 
To view, visit https://gerrit.osmocom.org/101
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d41df0068783c8fb33ddeeab1d1dcf63c2c259f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list