openbsc[master]: gsm04_08_clear_request(): release loc with arg release=0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun May 22 11:54:55 UTC 2016


Patch Set 2:

I know that in_release==1 so msc_release_connection() is a nop.
It is really weird to set a flag that disables a function completely
and then call that function anyway.

I find that confusing, but if you don't agree we can drop this change.

-- 
To view, visit https://gerrit.osmocom.org/93
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf9eb4889d32ad5e42ac7d096bf62fa3a493e20
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the OpenBSC mailing list