untested patch: gprs_cipher_run() invocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Sat May 21 14:50:29 UTC 2016


I have this patch, but am not sure how to test its validity. Looks sane though.
We were passing a uint64_t kc as uint8_t* to:

int gprs_cipher_run(uint8_t *out, uint16_t len, enum gprs_ciph_algo algo,
                    uint8_t *kc, uint32_t iv, enum gprs_cipher_direction dir);

so instead of passing kc's address, we would pass the kc *as* address.

See attached patch.
Any opinions and/or testers? Why would no-one have noticed this before?

Thanks!
~Neels

-- 
- Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sgsn-fix-use-of-libosmocore-GPRS-encryption-plugins-.patch
Type: text/x-diff
Size: 1461 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160521/0bd85433/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160521/0bd85433/attachment-0001.bin>


More information about the OpenBSC mailing list