openbsc[master]: bsc: Create minimal SI6 rest octets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu May 19 09:54:40 UTC 2016


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/71/1/openbsc/include/openbsc/rest_octets.h
File openbsc/include/openbsc/rest_octets.h:

Line 15: int rest_octets_si6(uint8_t *data, int is1800_net);
I would prefer bool unless is1800_net can potentially take something else besides 0 and 1 but that's matter of taste of course.


https://gerrit.osmocom.org/#/c/71/1/openbsc/src/libbsc/rest_octets.c
File openbsc/src/libbsc/rest_octets.c:

Line 453: 
I would prefer 3GPP TS 44.018 for new code - it's newer and already referred to in this file.


Line 487: 
bitvec_spare_padding() accept up_to_bit as a 2nd argument so it's better to put last bit in there: bitvec_spare_padding(&bv, (bv.data_len * 8) - 1);
This way we don't have to change it while extending rest octets in future.


-- 
To view, visit https://gerrit.osmocom.org/71
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I417a40eb91f42a3416b4e07bb9fb4d7a01aaa36b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list