openbsc[master]: Make extending subscriber creation easier

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu May 19 06:53:48 UTC 2016


Patch Set 5:

(1 comment)

Last comment about the vty write but we can move to the follow up patch soon. Is there a ticket reference as well?

https://gerrit.osmocom.org/#/c/42/5/openbsc/src/libmsc/vty_interface_layer3.c
File openbsc/src/libmsc/vty_interface_layer3.c:

Line 1075: 		gsmnet->subscr_creation_mode ? "" : "no ", VTY_NEWLINE);
You change that to a switch in a follow-up commit? Then maybe have the enum only have the two values 0 / 1 so this doesn't look as fragile?


-- 
To view, visit https://gerrit.osmocom.org/42
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b10a9a764fd3a7bb96717a990e52caae16266da
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list