Change in libosmo-sccp[master]: Add selector for ANSI or ITU variant

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

gerrit-no-reply at lists.osmocom.org gerrit-no-reply at lists.osmocom.org
Tue May 17 21:53:22 UTC 2016


>From Holger Freyther <holger at freyther.de>:

Holger Freyther has posted comments on this change.

Change subject: Add selector for ANSI or ITU variant
......................................................................


Patch Set 1:

> This is for initial review.  Wouldn't expect this to be merged as
 > is (needs tests for a start).
 > 
 > More to get feedback on whether ANSI support is desired.  In the
 > project we're doing currently it is.  I have similar patches for
 > the MTP3 layer in osmobsc, but there needs to be more discussion
 > around that.

Yes, ANSI (and Japan, China?) would be nice to have (for being complete). I don't know much about the differences of ANSI SCCP.

In general:
* It should not break ITU support
* It should not make code more ugly/slower (not saying the patch does)
* ANSI code should have test cases by itself (and preferable make traces available, e.g. to the wireshark Sample Captures).

-- 
To view, visit https://gerrit.osmocom.org/73
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia17eef8c9b7d8e1092c587f469b4a68aa9702651
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Arran Cudbard-bell <a.cudbardb at freeradius.org>
Gerrit-Reviewer: Arran Cudbard-bell <a.cudbardb at freeradius.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the OpenBSC mailing list