Change in libosmocore[master]: gsm48: move to hex TMSI representation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

gerrit-no-reply at lists.osmocom.org gerrit-no-reply at lists.osmocom.org
Sat May 14 10:15:32 UTC 2016


>From Holger Freyther <holger at freyther.de>:

Holger Freyther has posted comments on this change.

Change subject: gsm48: move to hex TMSI representation
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/57/1/src/gsm/gsm48.c
File src/gsm/gsm48.c:

PS1, Line 461:  
It is not a "reverse" anymore. Should the comment be updated? Specially with gsm48_generate_mid_from_tmsi just taking the uint32?


PS1, Line 465: string
Why do you prefix it with 0x here?  In the commit message I would like to have a small statement about the minimum size of the "string" not having.

Who consumes the result and does the represntation matter?


-- 
To view, visit https://gerrit.osmocom.org/57
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list