Change in openbsc[master]: db.c: implemented incremental migration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

gerrit-no-reply at lists.osmocom.org gerrit-no-reply at lists.osmocom.org
Fri May 13 10:19:39 UTC 2016


>From Holger Freyther <holger at freyther.de>:

Holger Freyther has posted comments on this change.

Change subject: db.c: implemented incremental migration
......................................................................


Patch Set 1:

(2 comments)

Could you please add a test db with version 1 preferable and "test" the migration? IIRC we already one case for the SMS conversion I did a couple of years ago.

https://gerrit.osmocom.org/#/c/62/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:

Line 412: 			goto error;
For coverity we will most likely need to add a "fallthrough" comment or such.


PS1, Line 418: break
indent


-- 
To view, visit https://gerrit.osmocom.org/62
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c2aa86f96b88ad8a710d0a23879ce219bc82dc
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list