Change in openbsc[master]: Make extending subscriber creation easier

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

gerrit-no-reply at lists.osmocom.org gerrit-no-reply at lists.osmocom.org
Wed May 11 11:10:51 UTC 2016


>From Neels Hofmeyr <nhofmeyr at sysmocom.de>:

Neels Hofmeyr has posted comments on this change.

Change subject: Make extending subscriber creation easier
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

maybe tweak cosmetics, and what hwelte said (vty)

https://gerrit.osmocom.org/#/c/42/1/openbsc/src/libmsc/gsm_04_08.c
File openbsc/src/libmsc/gsm_04_08.c:

Line 513: 	if (GSM_SUBSCR_DONT_CREATE == net->subscr_creation_mode)
yoda conditional


Line 652: 			subscr = subscr_create(	bts->network, mi_string);
whitespace "(\t"


-- 
To view, visit https://gerrit.osmocom.org/42
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b10a9a764fd3a7bb96717a990e52caae16266da
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the OpenBSC mailing list