[PATCH] move to hex TMSI representation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Tue Mar 29 16:39:16 UTC 2016


> On 29 Mar 2016, at 18:10, Вадим Яницкий <axilirator at gmail.com> wrote:
> 
> Hello!
> 
> > thanks a lot, I am afraid we need one more round.
> 
> No problem :)
> 
> > -#define tmsi_from_string(str) strtoul(str, NULL, 10)
> > +#define tmsi_from_string(str) strtoul(str + 2, NULL, 16)
> >
> > this macro is used for parsing strings from the network. We should not modify it.
> 
> I cannot find where...


ah I see. You change the invocations in gsm_04_08.c. I would prefer if the name of this method is changed but once we work with uint32_t it will mostly go away anyway?

holger


More information about the OpenBSC mailing list