[PATCH 1/2] Refactor internal mncc code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Wed Mar 23 18:35:16 UTC 2016


> On 23 Mar 2016, at 19:14, msuraev at sysmocom.de wrote:
> 
> From: Max <msuraev at sysmocom.de>
> 
> Consistently use enums instead of (u)int, char etc.
> Use bool for boolean types.
> Add extra debug output with channel mode and type to simplify
> troubleshooting.

Nack.

* You touch an external protocol that is versioned. Does the size of the structure change? Either way it needs to be in the commit messages.

* You are mixing "add debug messages" and "change types". There is no connection between these two logical changes and they should not be in the same commit.





More information about the OpenBSC mailing list