[PATCH] move to hex TMSI representation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Thu Mar 17 16:34:40 UTC 2016


> On 17 Mar 2016, at 17:21, Вадим Яницкий <axilirator at gmail.com> wrote:
> 
> Hi Guys!
> 
> > If you have time, please check if there are other occurrences in OpenBSC
> > or OsmocomBB where the TMSI is printed as integer.  Thanks!
> 
> No problem! :)
> 
> > I think it was a bit too quick. I foresee one problem. Let's assume someone
> > is using TMSIs and now upgrade the sourcecode. All CM Service Requests
> > will fail because the TMSI is not known. What is the migration/mitigation plan?
> 
> I absolutely agree with Holger. Maybe we can add some code that will check
> if database still stores TMSIs in old representation style and convert them to
> uint32_t? We can change the libmsc/db.c:db_prepare() for this purpose.


yes, we have a schema version and can just increase it. E.g. have a look at how we migrate SMS.



> 
> > tmsi_from_string will not work for this anymore.
> 
> Yes, I forgot to change the gsm_subscriber.c ... Sorry.


it happens. thanks for contributing



> 
> > there is no length check but that doesn't seem to be a big issue right now.
> 
> We can just write a function that will do this check instead of using #define.

I think you will not need to touch this define at all. We might want to change the name to _from_mi_string. 


> 
> > * a DB schema upgrade and store the TMSI as uint32_t
> > * Use hex presentation in VTY
> 
> +1


looking forward for the follow up.


holger


More information about the OpenBSC mailing list