[PATCH 2/2] Add basic EARFCN support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Max msuraev at sysmocom.de
Thu Mar 17 14:10:05 UTC 2016


Done - see Fix earfcn struct header
<https://patchwork.ozlabs.org/patch/599042/> patch.

On 03/17/2016 02:11 PM, Harald Welte wrote:
> Hi Max,
>
> I have already merged the patch, but now have one more comment that
> should definitely be addressed ASAP:
>
> On Thu, Mar 17, 2016 at 11:51:09AM +0100, msuraev at sysmocom.de wrote:
>> +struct earfcn {
> 1) this misses the osmo_ prefix which must be used for all new data
>    types and symbols in the libraries
>
> 2) it is not just an EARFCN (which is an integer), but it is actually
>    some SI-specific EARFCN parameters.  So please let's give it a proper
>    name. like osmo_earfcn_meas_pars (for measurement parameters) or the
>    like.
>
> Please provide a follow-up patch quickly so we can resolve this before
> any users rely on the old naming.  Thanks.
>
> Regards,
> 	Harald

-- 
Max Suraev <msuraev at sysmocom.de> http://www.sysmocom.de/
======================================================================= 
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93 
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B 
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160317/547ef667/attachment.htm>


More information about the OpenBSC mailing list