This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi Max, On Wed, Mar 16, 2016 at 05:34:58PM +0100, msuraev at sysmocom.de wrote: > +/* EARFCN (16 bits) array */ > + uint16_t *arfcn; comment should have same indent as the struct member > + for (i = 0; i < e->length; i++) > + if (OSMO_EARFCN_INVALID == e->arfcn[i]) { missing {} around the indented if block. The rule is (please check Linux kernel coding style) that only if there is a single line inside the block, we dont use curly braces. > + return ENOMEM; generally we return negative values for errors, so it should be -ENOMEM. -- - Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)