[PATCH 1/2] Improve BSSGP debug output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Mon Mar 14 18:04:07 UTC 2016


Hi Max,

On Mon, Mar 14, 2016 at 06:27:54PM +0100, msuraev at sysmocom.de wrote:
> -		DEBUGP(DBSSGP, "BSSGP BVCI=%u PDU type 0x%02x only exists "
> -			"in DL\n", bctx->bvci, pdu_type);
> +		DEBUGP(DBSSGP, "BSSGP BVCI=%u PDU type 0x%02x (%s) only exists "
> +			"in DL\n", bctx->bvci, pdu_type, bssgp_pdu_str(pdu_type));

Sorry, but did you read my last feedback? There are still lots of places
where you print the 0x%02x _and_ the value_string...
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list