[MERGED] libosmocore[master]: osmo-auc-gen: Print hex values without intermittent spaces

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 1 12:10:41 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: osmo-auc-gen: Print hex values without intermittent spaces
......................................................................


osmo-auc-gen: Print hex values without intermittent spaces

When generating some authentication vectors using the osmo-auc-gen
utility, it used to print values like this:

AUTN:   f7 55 bc 47 de d0 00 00 f9 ed 4b 3f 6c 2a 97 6f

which is quite difficult to copy+paste on the terminal.  Now it
generates the following format:

Change-Id: I2805615e0c2087ca632e0658b37a9e06929620b6
AUTN:   f755bc47ded00000f9ed4b3f6c2a976f
Reviewed-on: https://gerrit.osmocom.org/164
Reviewed-by: Harald Welte <laforge at gnumonks.org>
Tested-by: Jenkins Builder
---
M utils/osmo-auc-gen.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c
index b026e28..3b3e557 100644
--- a/utils/osmo-auc-gen.c
+++ b/utils/osmo-auc-gen.c
@@ -48,18 +48,18 @@
 
 static void dump_auth_vec(struct osmo_auth_vector *vec)
 {
-	printf("RAND:\t%s\n", osmo_hexdump(vec->rand, sizeof(vec->rand)));
+	printf("RAND:\t%s\n", osmo_hexdump_nospc(vec->rand, sizeof(vec->rand)));
 
 	if (vec->auth_types & OSMO_AUTH_TYPE_UMTS) {
-		printf("AUTN:\t%s\n", osmo_hexdump(vec->autn, sizeof(vec->autn)));
-		printf("IK:\t%s\n", osmo_hexdump(vec->ik, sizeof(vec->ik)));
-		printf("CK:\t%s\n", osmo_hexdump(vec->ck, sizeof(vec->ck)));
-		printf("RES:\t%s\n", osmo_hexdump(vec->res, vec->res_len));
+		printf("AUTN:\t%s\n", osmo_hexdump_nospc(vec->autn, sizeof(vec->autn)));
+		printf("IK:\t%s\n", osmo_hexdump_nospc(vec->ik, sizeof(vec->ik)));
+		printf("CK:\t%s\n", osmo_hexdump_nospc(vec->ck, sizeof(vec->ck)));
+		printf("RES:\t%s\n", osmo_hexdump_nospc(vec->res, vec->res_len));
 	}
 
 	if (vec->auth_types & OSMO_AUTH_TYPE_GSM) {
-		printf("SRES:\t%s\n", osmo_hexdump(vec->sres, sizeof(vec->sres)));
-		printf("Kc:\t%s\n", osmo_hexdump(vec->kc, sizeof(vec->kc)));
+		printf("SRES:\t%s\n", osmo_hexdump_nospc(vec->sres, sizeof(vec->sres)));
+		printf("Kc:\t%s\n", osmo_hexdump_nospc(vec->kc, sizeof(vec->kc)));
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/164
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2805615e0c2087ca632e0658b37a9e06929620b6
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the OpenBSC mailing list