This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/160/1/include/osmocom/codec/codec.h File include/osmocom/codec/codec.h: Line 46: bool osmo_check_sid_hr(uint8_t *rtp_payload, size_t payload_len); the other functions are calld osmo_<codec>_<something>, while your new functions are osmo_<something>_<codec>, which is a minor inconsistency. But let's ignore that. https://gerrit.osmocom.org/#/c/160/1/src/codec/gsm610.c File src/codec/gsm610.c: Line 320: return false; mh, this code doesn't really look very nice, like lots of copy+paste. why not have a 'const unsigned int sid_bits[] array with the bit numbers, and a nice for-loop to iterate over sid_bits? -- To view, visit https://gerrit.osmocom.org/160 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4051e3c0d4fb9ee93d7e9e0ef4abaf9f18e227ca Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes