FIXME: TODO: do better

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Thu Jan 28 13:32:39 UTC 2016


Would anyone like to prevent this commit from reaching master? ;)

Thanks!
~Neels


commit 76af8ad075e7857983ef102f80440ee716958482
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Thu Jan 28 14:26:05 2016 +0100

    add fixme comment for todo comment :/

diff --git a/openbsc/src/libmsc/osmo_msc.c b/openbsc/src/libmsc/osmo_msc.c
index b4facff..4bea699 100644
--- a/openbsc/src/libmsc/osmo_msc.c
+++ b/openbsc/src/libmsc/osmo_msc.c
@@ -48,7 +48,7 @@ static int msc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg
  gsm0408_new_conn(conn);
  gsm0408_dispatch(conn, msg);
 
- /* TODO: do better */
+ /* TODO: do better */ /* FIXME: do the TODO comment better in the first place! */
  if (conn->silent_call)
    return BSC_API_CONN_POL_ACCEPT;
  if (conn->loc_operation || conn->sec_operation || conn->anch_operation)


-- 
- Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160128/d8d8a4e9/attachment.bin>


More information about the OpenBSC mailing list