[PATCH 2/2] Get rid of duplicated timer code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Tue Jan 26 10:12:30 UTC 2016


> On 25 Jan 2016, at 17:01, suraev at alumni.ntnu.no wrote:
> 
> 	while (!quit) {
> -		osmo_gsm_timers_check();
> -		osmo_gsm_timers_prepare();
> -		osmo_gsm_timers_update();
> +		osmo_timers_check();
> +		osmo_timers_prepare();
> +		osmo_timers_update();
> 
> 		osmo_select_main(0);

timers_check,_prepare and _update are called from osmo_select_main
already so they are not needed.

The general idea to work in frame numbers makes a lot of sense, the
question is why we are not working with it anymore.

a.) Our fn's are not monotonic and we can work in time then we do not
need this code
b.) We should do things based on the fn (e.g. the T200 issues we found
in LAPDm show that it can be a good idea).

holger




More information about the OpenBSC mailing list