[PATCH 3/3] gsm340_rx_tpdu: comment-out two unused vars

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Feb 24 19:16:07 UTC 2016


Kills two compiler warnings.
---
 openbsc/src/libmsc/gsm_04_11.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index 266cd4d..e3d261e 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -357,7 +357,7 @@ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *m
 	uint8_t *smsp = msgb_sms(msg);
 	struct gsm_sms *gsms;
 	unsigned int sms_alphabet;
-	uint8_t sms_mti, sms_mms, sms_vpf, sms_rp;
+	uint8_t sms_mti, sms_vpf;
 	uint8_t *sms_vp;
 	uint8_t da_len_bytes;
 	uint8_t address_lv[12]; /* according to 03.40 / 9.1.2.5 */
@@ -371,11 +371,14 @@ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *m
 
 	/* invert those fields where 0 means active/present */
 	sms_mti = *smsp & 0x03;
-	sms_mms = !!(*smsp & 0x04);
 	sms_vpf = (*smsp & 0x18) >> 3;
 	gsms->status_rep_req = (*smsp & 0x20);
 	gsms->ud_hdr_ind = (*smsp & 0x40);
+	/* This used to be unused code, avoid a recurring compiler warning:
+	uint8_t sms_mms, sms_rp;
+	sms_mms = !!(*smsp & 0x04);
 	sms_rp  = (*smsp & 0x80);
+	*/
 
 	smsp++;
 	gsms->msg_ref = *smsp++;
-- 
2.1.4




More information about the OpenBSC mailing list