This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgOn Wed, Feb 24, 2016 at 02:47:15PM +0100, Neels Hofmeyr wrote:
> On Wed, Feb 24, 2016 at 10:08:35AM +0100, Harald Welte wrote:
> > Hi Neels,
> >
> > On Wed, Feb 24, 2016 at 03:39:39AM +0100, Neels Hofmeyr wrote:
> > > L_NS_NODE, /*!< \brief NS node in libosmo-gb. */
> > > L_BSSGP_NODE, /*!< \brief BSSGP node in libosmo-gb. */
> > >
> > > + CTRL_NODE, /*!< \brief Control interface node. */
> > > +
> >
> > the existing nodes are pre-fixed with L_ to indicate they are part of a
> > library, as opposed to those without prefix (from the main application).
>
> AFAICT it is used only in openbsc,
not true. osmo-bts is the first counter-example.
> but still the control interface itself is part of libosmocore. That's
> why I put its vty there in the first place. libosmocore/src/ctrl/*
> -- Am I missing something?
It's fine that you add it there .but it should be called L_CTRL_NODE,
not CTRL_NODE.
> I find the name CTRL_NODE a bit too general. e.g. we also have Ctrl in
> GTP. First I had CTRLIFACE_NODE, but most other control interface code
> uses the ctrl_ prefix and that looks ugly too. Any opinions?
I don't care as long as it has an L_ prefix if it is implemented in a
library.
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)