This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Freyther holger at freyther.de
> On 02 Feb 2016, at 12:19, suraev at alumni.ntnu.no wrote:
>
>
> +unsigned _term[2][64] = {
same comment, _ is a namespace not for us. Please adjust it. Make it static const to not pollute the namespace and keep it in the rodata segment.
> +enum dec_state {
> + EXPECT_TERM, // only TERM is expected, keep parsing with the same color code
> + TOO_LONG, // that's what she said
Try to avoid comments like that. Please don't use C99 comments and have a more technical description. The rest looks fine but I have no knowledge about T4.
thanks
holger