gerrit patch verification vs. rebase upon submission

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Mon Aug 29 10:17:10 UTC 2016


> On 29 Aug 2016, at 11:41, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> 
> Hi all,

Hi!


> I've expected this before and now it has actually happened: a patch that was
> verified by jenkins caused a build failure after being merged by gerrit.
> Let's be aware of the possibility of this happening:
> 
> Commit [1] changed the rcv_rach() signature and correctly fixed all callers.
> Commit [2] added a new caller of rcv_rach(), with the correct, old arguments.
> 
> Both tested successfully on their own, and were accepted for merge. [2] was
> merged first, thus [1] no longer edited all callers as would have been
> necessary.

it happens. One option is to wait after the rebase. It should trigger a new build but is not too convenient.


holger


More information about the OpenBSC mailing list