This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Freyther holger at freyther.de> On 25 Apr 2016, at 12:51, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote: > >> > > There is, obviously, an explicit NULL on the sysmocom/iu branch, where no LLME > is applicable. > > openbsc/openbsc/src/gprs/gprs_gmm.c:2462: rc = gsm0408_rcv_gmm(mmctx, msg, NULL); > when looking at the patch I thought you would be on master. > So my suggestion above to clean up llme only when it's not NULL does still make > a lot of sense to me. > > Since I'm not familiar with GRPS code, maybe Daniel could have a quick look? > I'm having a déjà vu, didn't I write this before? > Would be nice if I could stop banging my head against your wall now ;) I would need to look at the code but if the GMM code is used on top of two different layers, then it should not look too much at the LLME? Specially as with send/receive it might not use the same LLME anyway? So yes, for your Iu branch add the NULL check, once we merge to master we need to see if there is valuable information inside the llme that we need to store somewhere else/or just log it. holger