[PATCH 2/5] Fix earfcn deletion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Wed Apr 20 15:38:55 UTC 2016


> On 20 Apr 2016, at 15:57, msuraev at sysmocom.de wrote:
> 
> From: Max <msuraev at sysmocom.de>
> 
> * fix typo in arg index
> * fix sign in error reporting
> * add vty test


> 
> +    def testSi2Q(self):
> +        self.vty.enable()
> +        self.vty.command("configure terminal")
> +        self.vty.command("network")
> +        self.vty.command("bts 0")
> +        before = self.vty.command("show running-config")
> +        self.vty.command("si2quater neighbor-list add earfcn 1911 threshold 11 2")
> +        self.vty.command("si2quater neighbor-list add earfcn 1924 threshold 11 3")
> +        self.vty.command("si2quater neighbor-list add earfcn 2111 threshold 11")
> +        self.vty.command("si2quater neighbor-list del earfcn 1911")
> +        self.vty.command("si2quater neighbor-list del earfcn 1924")
> +        self.vty.command("si2quater neighbor-list del earfcn 2111")
> +        self.assertEquals(before, self.vty.command("show running-config"))


So if both add and del are broken, your test will still pass.

* Put si2quater neighbor-list add earfcn 1911 threshold 11 2 in the default config and use show-running-config to check it is present?

* Be explicit, e.g. add 1911.. use show running-config.. and check with indexOf that it is present?

holger


More information about the OpenBSC mailing list