[PATCH] Fix earfcn deletion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

msuraev at sysmocom.de msuraev at sysmocom.de
Mon Apr 18 08:32:16 UTC 2016


From: Max <msuraev at sysmocom.de>

* fix documentation for command parameters
* fix typo in arg index
* fix sign in error reporting
---
 openbsc/src/libbsc/bsc_vty.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index 9634508..85b8394 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -2797,15 +2797,16 @@ DEFUN(cfg_bts_si2quater_neigh_del, cfg_bts_si2quater_neigh_del_cmd,
 	"SI2quater Neighbor List\n"
 	"SI2quater Neighbor List\n"
 	"Delete from SI2quater manual neighbor list\n"
-	"EARFCN of neighbor\n")
+	"EARFCN of neighbor\n"
+	"EARFCN\n")
 {
 	struct gsm_bts *bts = vty->index;
 	struct osmo_earfcn_si2q *e = &bts->si_common.si2quater_neigh_list;
-	uint16_t arfcn = atoi(argv[1]);
+	uint16_t arfcn = atoi(argv[0]);
 	int r = osmo_earfcn_del(e, arfcn);
 	if (r < 0) {
 		vty_out(vty, "Unable to delete arfcn %u: %s%s", arfcn,
-			strerror(r), VTY_NEWLINE);
+			strerror(-r), VTY_NEWLINE);
 		return CMD_WARNING;
 	}
 
-- 
2.8.1




More information about the OpenBSC mailing list