[PATCH 05/15] gtphub: add a todo comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Thu Oct 15 22:13:49 UTC 2015


diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c
index 97e52a6..577a2d0 100644
--- a/openbsc/src/gprs/gtphub.c
+++ b/openbsc/src/gprs/gtphub.c
@@ -119,6 +119,8 @@ static int gtp_relay(struct osmo_fd *from,
 	errno = 0;
 	ssize_t received = recvfrom(from->fd, buf, sizeof(buf), 0,
 				    (struct sockaddr*)from_addr, from_addr_len);
+	/* TODO use recvmsg and get a MSG_TRUNC flag to make sure the message
+	 * is not truncated. Then maybe reduce buf's size. */
 
 	if (received <= 0) {
 		if (errno != EAGAIN)
-- 
2.1.4




More information about the OpenBSC mailing list