This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Neels Hofmeyr nhofmeyr at sysmocom.deOn Mon, Oct 12, 2015 at 03:02:36PM +0200, Neels Hofmeyr wrote: > --- a/gtp/gtp.c > +++ b/gtp/gtp.c > @@ -614,6 +614,15 @@ int gtp_notification(struct gsn_t *gsn, int version, > return 0; > } > > +/* Look for a message in the response queue for the given peer and sequence > + * number seq. If found, (re-)send the response message and return 0. Otherwise > + * return nonzero. This allows catching duplicate messages. > + * A response message stays in the response queue until it times out. > + * So, for any number of identical requests within that timeout period, the > + * same packet can be resent. > + * TODO this only checks the peer and sequence number, and does not verify that > + * the GTP request is identical to the previous one for this peer and sequence > + * nr: a mere peer or seq glitch can cause leaks of previous responses. */ Actually, the repeated transfer will go to the same qmsg_t.peer that the response was originially addressed to. So fishing for other clients' responses is not likely... I can drop the todo... Any opinions on this? ~Neels -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20151012/14806115/attachment.bin>